-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: Lint against #[macro_use]
in 2018 idioms
#52275
Conversation
r? @nrc |
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
lgtm @bors: r+ |
📌 Commit 7ac345a04c86381b929343195c56839350898e1b has been approved by |
7ac345a
to
c48e5a0
Compare
@bors: r=nrc |
📌 Commit c48e5a0d948e4f276953a2fd31cd6d8b33b3efbe has been approved by |
This comment has been minimized.
This comment has been minimized.
c48e5a0
to
1b32f92
Compare
@bors: r=nrc |
📌 Commit 1b32f920655284fa5e2e8cc3b1d938adb8b93722 has been approved by |
This comment has been minimized.
This comment has been minimized.
This commit adds a lint to the compiler to warn against the `#[macro_use]` directive as part of the `rust_2018_idioms` lint. This lint is turned off by default and is only enabled when the `use_extern_macros` feature is also enabled. The lint here isn't fully fleshed out as it's just a simple warning rather than suggestions of how to actually import the macro, but hopefully it's a good base to start from! cc rust-lang#52043
1b32f92
to
0b969a9
Compare
@bors: r=nrc |
📌 Commit 0b969a9 has been approved by |
rustc: Lint against `#[macro_use]` in 2018 idioms This commit adds a lint to the compiler to warn against the `#[macro_use]` directive as part of the `rust_2018_idioms` lint. This lint is turned off by default and is only enabled when the `use_extern_macros` feature is also enabled. The lint here isn't fully fleshed out as it's just a simple warning rather than suggestions of how to actually import the macro, but hopefully it's a good base to start from! cc #52043
☀️ Test successful - status-appveyor, status-travis |
This commit adds a lint to the compiler to warn against the
#[macro_use]
directive as part of the
rust_2018_idioms
lint. This lint is turned off bydefault and is only enabled when the
use_extern_macros
feature is alsoenabled.
The lint here isn't fully fleshed out as it's just a simple warning rather than
suggestions of how to actually import the macro, but hopefully it's a good base
to start from!
cc #52043