Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the ICEing on const fn loops with an error #56065

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Replace the ICEing on const fn loops with an error #56065

merged 1 commit into from
Nov 22, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 19, 2018

fixes #56035

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2018
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 19, 2018

📌 Commit 8ee9711 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2018
@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 20, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 20, 2018

nominating for beta backport because of triviality of PR and diagnostics of newly stabilized const functions should not ICE on their release to the public.

@alexcrichton
Copy link
Member

@bors: p=1

beta-nmoinated

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 20, 2018
@bors
Copy link
Contributor

bors commented Nov 21, 2018

⌛ Testing commit 8ee9711 with merge e10ea819ba2dd05cfc5aa322b1dec66d0ccb2678...

@bors
Copy link
Contributor

bors commented Nov 21, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2018
@rust-highfive
Copy link
Collaborator

The job dist-x86_64-netbsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 21, 2018

@bors retry llvm builing just stopped in the middle without further messages

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2018
@bors
Copy link
Contributor

bors commented Nov 21, 2018

⌛ Testing commit 8ee9711 with merge 271693ee9ccb4e2f59f50a7f82c98366182f3563...

@bors
Copy link
Contributor

bors commented Nov 21, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2018
@rust-highfive
Copy link
Collaborator

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:17:13] test binary_heap::test_to_vec ... ok
[01:17:13] test btree::map::test_append_12 ... ok
[01:17:13] test btree::map::test_append_14 ... ok
[01:17:13] test btree::map::test_append_144 ... ok
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 21, 2018

@bors retry (no more output)

@alexcrichton alexcrichton mentioned this pull request Nov 21, 2018
Closed
@alexcrichton
Copy link
Member

@bors: retry

Apparently bors missed that

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2018
@alexcrichton alexcrichton added this to the Rust 2018 Release milestone Nov 21, 2018
@bors
Copy link
Contributor

bors commented Nov 21, 2018

⌛ Testing commit 8ee9711 with merge 6612100...

bors added a commit that referenced this pull request Nov 21, 2018
@bors
Auto merge of #56065 - oli-obk:min_const_fn_loop_ice, r=davidtwco
6612100 
Replace the ICEing on const fn loops with an error

fixes #56035
@bors
Copy link
Contributor

bors commented Nov 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: davidtwco
Pushing 6612100 to master...

@bors bors merged commit 8ee9711 into rust-lang:master Nov 22, 2018
@pietroalbini pietroalbini mentioned this pull request Nov 22, 2018
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 23, 2018
bors added a commit that referenced this pull request Nov 23, 2018
@bors
Auto merge of #56174 - pietroalbini:beta-rollup, r=alexcrichton
1c16fa4 
[beta] Rollup backports

* #56163: [master] Backport 1.30.1 release notes
* #56147: resolve: Fix some asserts in import validation
* #56118: Update books for Rust 2018
* #56117: resolve: Make "empty import canaries" invisible from other crates
* #56065: Replace the ICEing on const fn loops with an error
* #56143: Issue 56128 segment id ice nightly
* #56134: Fix clippy documentation links (first in #56156)

r? @ghost
@oli-obk oli-obk deleted the min_const_fn_loop_ice branch June 15, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidtwco davidtwco

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
Rust 2018 Release
Development

Successfully merging this pull request may close these issues.

const fn ICE on playground.
5 participants
@oli-obk @rust-highfive @davidtwco @bors @alexcrichton