Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update books for Rust 2018 #56118

Merged
merged 4 commits into from
Nov 21, 2018
Merged

Update books for Rust 2018 #56118

merged 4 commits into from
Nov 21, 2018

Conversation

steveklabnik
Copy link
Member

This PR:

  1. updates all of the books
    • I don't know if @gankro has further plans for the nomicon or not
  2. updates the build process because TRPL is only distributing one edition now
  3. fixes up the stdlib links

I think that this passes but it's 3:20 am and so I'm sending it in and will fix up anything i missed in the morning.

/cc @alexcrichton for the big beta backport

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2018
@alexcrichton alexcrichton added this to the Rust 2018 Release milestone Nov 21, 2018
@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Nov 21, 2018

📌 Commit 6ce68bb9767ea24a35bcd3dcc24ab893c05ea58a has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2018
@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Nov 21, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:01857879:start=1542767386853813576,finish=1542767446914347746,duration=60060534170
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/ef/cc/d8f288b5b450e59b92c460727012ee002925324bc655255a9945a45ab9ad/awscli-1.16.59-py2.py3-none-any.whl (1.4MB)
    0% |▎                               | 10kB 10.8MB/s eta 0:00:01
    1% |▌                               | 20kB 1.9MB/s eta 0:00:01
    2% |▊                               | 30kB 2.2MB/s eta 0:00:01
    2% |█                               | 40kB 2.0MB/s eta 0:00:01
---
[00:51:06] .................................................................................................... 100/5042
[00:51:09] .................................................................................................... 200/5042
[00:51:12] .............................ii............................................ii...................ii.. 300/5042
[00:51:15] ..............................................................................................iii... 400/5042
[00:51:18] .....iiiiiiii.iii............................iii...........................................i........ 500/5042
[00:51:25] .................................................................................................... 700/5042
[00:51:31] ..................................................................................i...........i..... 800/5042
[00:51:34] .................................................................................................... 900/5042
[00:51:34] .................................................................................................... 900/5042
[00:51:37] .iiiii...................iiiiii..................................................................... 1000/5042
[00:51:39] ............................................................................iiiiiiii................ 1100/5042
[00:51:44] .................................................................................................... 1300/5042
[00:51:46] .................................................................................................... 1400/5042
[00:51:49] .................................i.................................................................. 1500/5042
[00:51:51] ..i.........ii.........................................................i............................ 1600/5042
---
[00:52:12] .................................................................................................... 2200/5042
[00:52:16] .................................................................................................... 2300/5042
[00:52:20] .................................................................................................... 2400/5042
[00:52:24] .................................................................................................... 2500/5042
[00:52:27] .....................................................................................iiiiiiiii...... 2600/5042
[00:52:34] ...................................................ii............................................... 2800/5042
[00:52:37] .................................................................................................... 2900/5042
[00:52:41] .................................................................................................... 3000/5042
[00:52:44] ...............................................i.................................................... 3100/5042
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:06:47] 
[01:06:47] running 117 tests
[01:06:50] i..ii...iii..iiii.....i...i.........i..iii...........i.....i.....ii...i..i.ii..............i...ii..i 100/117
[01:06:50] i.i.....iiii.....
[01:06:50] 
[01:06:50]  finished in 3.526
[01:06:50] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:07:05] 
[01:07:05] running 118 tests
[01:07:29] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[01:07:33] ......iii.i.....ii
[01:07:33] 
[01:07:33]  finished in 28.915
[01:07:33] travis_fold:end:test_debuginfo

---
[01:36:29] travis_fold:end:stage0-linkchecker

[01:36:29] travis_time:end:stage0-linkchecker:start=1542773243168977343,finish=1542773245517772138,duration=2348794795

[01:39:12] std/index.html:10: broken link fragment `#use-to-bring-paths-into-scope` pointing to `book/ch07-02-modules-and-use-to-control-scope-and-privacy.html`

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

@bors: r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2018
@steveklabnik
Copy link
Member Author

This should be fixed, let's see what travis says, and then I'll r+

@steveklabnik
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Nov 21, 2018

📌 Commit d7b3f5c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2018
@bors
Copy link
Contributor

bors commented Nov 21, 2018

⌛ Testing commit d7b3f5c with merge 910ec6d...

bors added a commit that referenced this pull request Nov 21, 2018
Update books for Rust 2018

This PR:

1. updates all of the books
    * I don't know if @gankro has further plans for the nomicon or not
2. updates the build process because TRPL is only distributing one edition now
3. fixes up the stdlib links

I think that this passes but it's 3:20 am and so I'm sending it in and will fix up anything i missed in the morning.

/cc @alexcrichton for the big beta backport
@Gankra
Copy link
Contributor

Gankra commented Nov 21, 2018

yeah the nomicon is gonna suuuuper use all the time it has before the edition officially ships

@bors
Copy link
Contributor

bors commented Nov 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 910ec6d to master...

@bors bors merged commit d7b3f5c into rust-lang:master Nov 21, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #56118!

Tested on commit 910ec6d.
Direct link to PR: #56118

🎉 nomicon on windows: test-fail → test-pass (cc @frewsxcv @gankro, @rust-lang/infra).
🎉 nomicon on linux: test-fail → test-pass (cc @frewsxcv @gankro, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Nov 21, 2018
Tested on commit rust-lang/rust@910ec6d.
Direct link to PR: <rust-lang/rust#56118>

🎉 nomicon on windows: test-fail → test-pass (cc @frewsxcv @gankro, @rust-lang/infra).
🎉 nomicon on linux: test-fail → test-pass (cc @frewsxcv @gankro, @rust-lang/infra).
@Gankra
Copy link
Contributor

Gankra commented Nov 21, 2018

HOW

@steveklabnik
Copy link
Member Author

wait what is that

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 23, 2018
bors added a commit that referenced this pull request Nov 23, 2018
[beta] Rollup backports

* #56163: [master] Backport 1.30.1 release notes
* #56147: resolve: Fix some asserts in import validation
* #56118: Update books for Rust 2018
* #56117: resolve: Make "empty import canaries" invisible from other crates
* #56065: Replace the ICEing on const fn loops with an error
* #56143: Issue 56128 segment id ice nightly
* #56134: Fix clippy documentation links (first in #56156)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants