Remove some uses of try! #56419
Merged
Remove some uses of try! #56419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! @bors r+ rollup |
|
📌 Commit e7e9692 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 1, 2018
Remove some uses of try!
nikic
reviewed
Dec 2, 2018
| @@ -278,14 +278,14 @@ macro_rules! debug_assert_ne { | |||
| /// | |||
| /// // The previous method of quick returning Errors | |||
| /// fn write_to_file_using_try() -> Result<(), MyError> { | |||
| /// let mut file = try!(File::create("my_best_friends.txt")); | |||
| /// try!(file.write_all(b"This is a list of my best friends.")); | |||
| /// let mut file = r#try!(File::create("my_best_friends.txt")); | |||
There was a problem hiding this comment.
Is the change to the docs intended? If so, it might make sense to also explain or reference the raw literal syntax in the text above, as it may be a bit obscure for this rather prominent piece of documentation.
There was a problem hiding this comment.
This macro is deprecated (and further more try! doesn't even work on Rust 2018). Therefore it is not a prominent piece of documentation other than explaining that it is deprecated; but sure -- we can clarify the raw identifier syntax later (in a follow up PR -- which maybe @mark-i-m can fix up); the purpose r# fills here is to make code work on both editions (a good thing) so this is a strict improvement.
There was a problem hiding this comment.
Yes, the change was intended so that it works in both editions. Opened #56424
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
Remove some uses of try!
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
bors
added a commit
that referenced
this pull request
Dec 2, 2018
Rollup of 14 pull requests Successful merges: - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks) - #56305 (update miri) - #56366 (Stabilize self_in_typedefs feature) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56394 (Deal with EINTR in net timeout tests) - #56395 (Stabilize dbg!(...)) - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block) - #56402 (Improve the unstable book example for #[marker] trait) - #56412 (Update tracking issue for `extern_crate_self`) - #56416 (Remove unneeded body class selector) - #56418 (Fix failing tidy (line endings on Windows)) - #56419 (Remove some uses of try!) - #56424 (Mention raw-ident syntax) - #56432 (Update issue number of `shrink_to` methods to point the tracking issue) Failed merges: r? @ghost
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 3, 2018
Remove some uses of try!
bors
added a commit
that referenced
this pull request
Dec 3, 2018
Rollup of 13 pull requests Successful merges: - #56141 ([std] Osstr len clarity) - #56366 (Stabilize self_in_typedefs feature) - #56395 (Stabilize dbg!(...)) - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block) - #56402 (Improve the unstable book example for #[marker] trait) - #56412 (Update tracking issue for `extern_crate_self`) - #56416 (Remove unneeded body class selector) - #56418 (Fix failing tidy (line endings on Windows)) - #56419 (Remove some uses of try!) - #56432 (Update issue number of `shrink_to` methods to point the tracking issue) - #56433 (Add description about `crate` for parse_visibility's comment) - #56435 (make the C part of compiler-builtins opt-out) - #56438 (Remove not used `DotEq` token) Failed merges: r? @ghost
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 4, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 4, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 5, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Dec 5, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Dec 5, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.