New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize self_in_typedefs feature #56366

Merged
merged 3 commits into from Dec 3, 2018

Conversation

Projects
None yet
5 participants
@alexreg
Contributor

alexreg commented Nov 30, 2018

@Centril

This comment has been minimized.

Contributor

Centril commented Nov 30, 2018

This one will have to wait a bit until we're a bit into the FCP (not started yet) of that PR.

@Centril

Pending FCP, the changes look good.

@rust-highfive

This comment was marked as resolved.

Collaborator

rust-highfive commented Nov 30, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2ce391e5:start=1543550291455161332,finish=1543550292475114525,duration=1019953193
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/aa/e5/ebd5896ad5ae353d23bea05ebb8edd3d49f1471784f6afa12a9cf11710de/awscli-1.16.67-py2.py3-none-any.whl (1.4MB)
    0% |▎                               | 10kB 10.7MB/s eta 0:00:01
    1% |▌                               | 20kB 1.8MB/s eta 0:00:01
    2% |▊                               | 30kB 2.1MB/s eta 0:00:01
    2% |█                               | 40kB 1.9MB/s eta 0:00:01
---
tidy check
[00:03:34] * 568 error codes
[00:03:34] * highest error code: E0721
[00:03:34] * 239 features
[00:03:34] tidy error: The Unstable Book has a 'language feature' section 'self-in-typedefs' which doesn't correspond to an unstable language feature
[00:03:35] some tidy checks failed
[00:03:35] 
[00:03:35] 
[00:03:35] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:35] 
[00:03:35] 
[00:03:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:35] Build completed unsuccessfully in 0:01:01
[00:03:35] Build completed unsuccessfully in 0:01:01
[00:03:35] make: *** [tidy] Error 1
[00:03:35] Makefile:79: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:082b4016
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Nov 30 04:01:56 UTC 2018
---
travis_time:end:00939e28:start=1543550516924741953,finish=1543550516929328834,duration=4586881
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1f146b04
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:10f3b662
travis_time:start:10f3b662
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2bda0b80
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added the relnotes label Nov 30, 2018

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Nov 30, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2b935a50:start=1543551391581047563,finish=1543551392556846439,duration=975798876
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:44:39] ................................................................................................i... 800/5064
[00:44:43] ........i........................................................................................... 900/5064
[00:44:46] ................iiiii............................................................................... 1000/5064
[00:44:49] .................................................................................................... 1100/5064
[00:44:51] ...........................................................................F........................ 1200/5064
[00:44:55] .................................................................................................... 1400/5064
[00:44:57] .................................................................................................... 1500/5064
[00:45:00] .................i....................................................................i............. 1600/5064
[00:45:04] .................................................................................................... 1700/5064
[00:45:04] .................................................................................................... 1700/5064
[00:45:07] .................................................................................................... 1800/5064
[00:45:10] .................................................................................................... 1900/5064
[00:45:13] ..........................i......................................................................... 2000/5064
[00:45:16] .................................................................................................... 2100/5064
[00:45:20] .................................................................................................... 2200/5064
[00:45:24] .................................................................................................... 2300/5064
[00:45:27] .................................................................................................... 2400/5064
[00:45:31] ...............................................F.................................................... 2500/5064
[00:45:38] .................................................................................................... 2700/5064
[00:45:41] .................................................................................................... 2800/5064
[00:45:44] .................................................................................................... 2900/5064
[00:45:47] .................................................................................................... 3000/5064
---
[00:46:09] ......................................................................................i............. 3800/5064
[00:46:10] .................................................................................................... 3900/5064
[00:46:13] .................................................................................................... 4000/5064
[00:46:16] .................................................................................................... 4100/5064
[00:46:19] .........................................................................F.......................... 4200/5064
[00:46:22] F..............................................i.................................................... 4300/5064
[00:46:30] .................................................................................................... 4500/5064
[00:46:33] .................................................................................................... 4600/5064
[00:46:37] ............................i....................................................................... 4700/5064
[00:46:40] .................................................................................................... 4800/5064
[00:46:40] .................................................................................................... 4800/5064
[00:46:43] .................................................................................................... 4900/5064
[00:46:47] 
[00:46:47] error: 1 errors occurred comparing output.
[00:46:47] status: exit code: 1
[00:46:47] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/error-codes/E0411.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0411/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0411/auxiliary" "-A" "unused"
[00:46:47] ------------------------------------------
[00:46:47] 
[00:46:47] ------------------------------------------
[00:46:47] stderr:
[00:46:47] stderr:
[00:46:47] ------------------------------------------
[00:46:47] {"message":"cannot find type `Self` in this scope","code":{"code":"E0411","explanation":"\nThe `Self` keyword was used outside an impl, trait, or type definition.\n\nErroneous code example:\n\n```compile_fail,E0411\n<Self>::foo; // error: use of `Self` outside of an impl, trait, or type\n             // definition\n```\n\nThe `Self` keyword represents the current type, which explains why it can only\nbe used inside an impl, trait, or type definition. It gives access to the\nassociated items of a type:\n\n```\ntrait Foo {\n    type Bar;\n}\n\ntrait Baz : Foo {\n    fn bar() -> Self::Bar; // like this\n}\n```\n\nHowever, be careful when two types have a common associated type:\n\n```compile_fail\ntrait Foo {\n    type Bar;\n}\n\ntrait Foo2 {\n    type Bar;\n}\n\ntrait Baz : Foo + Foo2 {\
[00:46:47] 
[00:46:47] ---- [ui] ui/issues/issue-36638.rs stdout ----
[00:46:47] diff of stderr:
[00:46:47] 
[00:46:47] 
[00:46:47] 10 LL | trait Bar<Self> {}
[00:46:47] 12 
[00:46:47] - error: aborting due to 2 previous errors
[00:46:47] - error: aborting due to 2 previous errors
[00:46:47] + error[E0392]: parameter `Self` is never used
[00:46:47] +   --> $DIR/issue-36638.rs:13:12
[00:46:47] +    |
[00:46:47] + LL | struct Foo<Self>(Self);
[00:46:47] +    |            ^^^^ unused type parameter
[00:46:47] +    |
[00:46:47] +    = help: consider removing `Self` or using a marker such as `std::marker::PhantomData`
[00:46:47] + error: aborting due to 3 previous errors
[00:46:47] + 
[00:46:47] + For more information about this error, try `rustc --explain E0392`.
[00:46:47] 15 
[00:46:47] 15 
[00:46:47] 
[00:46:47] 
[00:46:47] The actual stderr differed from the expected stderr.
[00:46:47] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36638/issue-36638.stderr
[00:46:47] To update references, rerun the tests and pass the `--bless` flag
[00:46:47] To only update this specific test, also pass `--test-args issues/issue-36638.rs`
[00:46:47] error: 1 errors occurred comparing output.
[00:46:47] status: exit code: 1
[00:46:47] status: exit code: 1
[00:46:47] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-36638.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36638/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "continue-parse-after-error" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36638/auxiliary" "-A" "unused"
[00:46:47] ------------------------------------------
[00:46:47] 
[00:46:47] ------------------------------------------
[00:46:47] stderr:
[00:46:47] stderr:
[00:46:47] ------------------------------------------
[00:46:47] {"message":"expected identifier, found keyword `Self`","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-36638.rs","byte_start":527,"byte_end":531,"line_start":13,"line_end":13,"column_start":12,"column_end":16,"is_primary":true,"text":[{"text":"struct Foo<Self>(Self);","highlight_start":12,"highlight_end":16}],"label":"expected identifier, found keyword","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: expected identifier, found keyword `Self`\n  --> /checkout/src/test/ui/issues/issue-36638.rs:13:12\n   |\nLL | struct Foo<Self>(Self);\n   |            ^^^^ expected identifier, found keyword\n\n"}
[00:46:47] {"message":"expected identifier, found keyword `Self`","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-36638.rs","byte_start":604,"byte_end":608,"line_start":16,"line_end":16,"column_start":11,"column_end":15,"is_primary":true,"text":[{"text":"trait Bar<Self> {}","highlight_start":11,"highlight_end":15}],"label":"expected identifier, found keyword","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: expected identifier, found keyword `Self`\n  --> /checkout/src/test/ui/issues/issue-36638.rs:16:11\n   |\nLL | trait Bar<Self> {}\n   |           ^^^^ expected identifier, found keyword\n\n"}
[00:46:47] {"message":"parameter `Self` is never used","code":{"code":"E0392","explanation":"\nThis error indicates that a type or lifetime parameter has been declared\nbut not actually used. Here is an example that demonstrates the error:\n\n```compile_fail,E0392\nenum Foo<T> {\n    Bar,\n}\n```\n\nIf the type parameter was included by mistake, this error can be fixed\nby simply removing the type parameter, as shown below:\n\n```\nenum Foo {\n    Bar,\n}\n```\n\nAlternatively, if the type parameter was intentionally inserted, it must be\nused. A simple fix is shown below:\n\n```\nenum Foo<T> {\n    Bar(T),\n}\n```\n\nThis error may also commonly be found when working with unsafe code. For\nexample, when using raw pointers one may wish to specify the lifetime for\nwhich the pointed-at data is valid. An initial attempt (below) causes this\nerror:\n\n```compile_fail,E0392\nstruct Foo<'a, T> {\n    x: *const T,\n}\n```\n\nWe want to express the constraint that Foo should not outlive `'a`, because\nthe data pointed to by `T` is only valid for that lifetime. The problem is\nthat there are no actual uses of `'a`. It's possible to work around this\nby adding a PhantomData type to the struct, using it to tell the compiler\nto act as if the struct contained a borrowed reference `&'a T`:\n\n```\nuse std::marker::PhantomData;\n\nstruct Foo<'a, T: 'a> {\n    x: *const T,\n    phantom: PhantomData<&'a T>\n}\n```\n\n[PhantomData] can also be used to express information about unused type\nparameters.\n\n[PhantomData]: https://doc.rust-lang.org/std/marker/struct.PhantomData.html\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-36638.rs","byte_start":527,"byte_end":531,"line_start":13,"line_end":13,"column_start":12,"column_end":16,"is_primary":true,"text":[{"text":"struct Foo<Self>(Self);","highlight_start":12,"highlight_end":16}],"label":"unused type parameter","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"consider removing `Self` or using a marker such as `std::marker::PhantomData`","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0392]: parameter `Self` is never used\n  --> /checkout/src/test/ui/issues/issue-36638.rs:13:12\n   |\nLL | struct Foo<Self>(Self);\n   |            ^^^^ unused type parameter\n   |\n   = help: consider removing `Self` or using a marker such as `std::marker::PhantomData`\n\n"}
[00:46:47] {"message":"aborting due to 3 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 3 previous errors\n\n"}
[00:46:47] {"message":"For more information about this error, try `rustc --explain E0392`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0392`.\n"}
[00:46:47] ------------------------------------------
[00:46:47] 
[00:46:47] thread '[ui] ui/issues/issue-36638.rs' panicked at 'explicit panic', src/tools/compile--------------
[00:46:47] stderr:
[00:46:47] stderr:
[00:46:47] ------------------------------------------
[00:46:47] {"message":"cannot find type `Self` in this scope","code":{"code":"E0411","explanation":"\nThe `Self` keyword was used outside an impl, trait, or type definition.\n\nErroneous code example:\n\n```compile_fail,E0411\n<Self>::foo; // error: use of `Self` outside of an impl, trait, or type\n             // definition\n```\n\nThe `Self` keyword represents the current type, which explains why it can only\nbe used inside an impl, trait, or type definition. It gives access to the\nassociated items of a type:\n\n```\ntrait Foo {\n    type Bar;\n}\n\ntrait Baz : Foo {\n    fn bar() -> Self::Bar; // like this\n}\n```\n\nHowever, be careful when two types have a common associated type:\n\n```compile_fail\ntrait Foo {\n    type Bar;\n}\n\ntrait Foo2 {\n    type Bar;\n}\n\ntrait Baz : Foo + Foo2 {\n    fn bar() -> Self::Bar;\n    // error: ambiguous associated type `Bar` in bounds of `Self`\n}\n```\n\nThis problem can be solved by specifying from which trait we want to use the\n`Bar` type:\n\n```\ntrait Foo {\n    type Bar;\n}\n\ntrait Foo2 {\n    type Bar;\n}\n\ntrait Baz : Foo + Foo2 {\n    fn bar() -> <Self as Foo>::Bar; // ok!\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/resolve/issue-24968.rs","byte_start":477,"byte_end":481,"line_start":11,"line_end":11,"column_start":11,"column_end":15,"is_primary":true,"text":[{"text":"fn foo(_: Self) {","highlight_start":11,"highlight_end":15}],"label":"`Self` is only available in impls, traits, and type definitions","suggested_replacement":null,"suggestion_applicabiliomeTrait for Foo {} // error: trait `SomeTrait` is not in scope\n```\n\nPlease verify that the name of the trait wasn't misspelled and ensure that it\nwas imported. Example:\n\n```\n# #[cfg(for_demonstration_only)]\n// solution 1:\nuse some_file::SomeTrait;\n\n// solution 2:\ntrait SomeTrait {\n    // some functions\n}\n\nstruct Foo;\n\nimpl SomeTrait for Foo { // ok!\n    // implements functions\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/resolve/resolve-self-in-impl-2.rs","byte_start":588,"byte_end":589,"line_start":15,"line_end":15,"column_start":12,"column_end":13,"is_primary":true,"text":[{"text":"impl Self::N for S {} //~ ERROR cannot find trait `N` in `Self`","highlight_start":12,"highlight_end":13}],"label":"not found in `Self`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0405]: cannot find trait `N` in `Self`\n  --> /checkout/src/test/ui/resolve/resolve-self-in-impl-2.rs:15:12\n   |\nLL | impl Self::N for S {} //~ ERROR cannot find trait `N` in `Self`\n   |            ^ not found in `Self`\n\n"}
[00:46:47] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:46:47] {"message":"Some errors occurred: E0405, E0411.","code":null,"level":"","spans":[],"children":[],"rendered":"Some errors occurred: E0405, E0411.\n"}
[00:46:47] {"message":"For more information about an error, try `rustc --explain E0405`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about an error, try `rustc --extravis_time:end:08357667:start=1543551401538242800,finish=1543554208959353500,duration=2807421110700
travis_time:start:22e7f98c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Nov 30 05:03:28 UTC 2018
Fri, 30 Nov 2018 05:03:28 GMT
---
travis_time:end:29cfcd02:start=1543554209999886816,finish=1543554210006583458,duration=6696642
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c35e15f
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0a7dc350
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Nov 30, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0347da80:start=1543592600735758224,finish=1543592603160872561,duration=2425114337
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:47:24] .................................................................................................... 2100/5102
[00:47:28] .................................................................................................... 2200/5102
[00:47:31] .................................................................................................... 2300/5102
[00:47:35] .................................................................................................... 2400/5102
[00:47:39] ...................................................F................................................ 2500/5102
[00:47:46] .................................................................................................... 2700/5102
[00:47:50] .................................................................................................... 2800/5102
[00:47:53] .................................................................................................... 2900/5102
[00:47:56] .................................................................................................... 3000/5102
---
[00:48:52] .................................................................i.................................. 4700/5102
[00:48:55] .................................................................................................... 4800/5102
[00:48:58] .................................................................................................... 4900/5102
[00:49:01] .................................................................................................... 5000/5102
pected identifier, found keyword `Self`","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-36638.rs","byte_start":527,"byte_end":531,"line_start":13,"line_end":13,"column_start":12,"column_end":16,"is_primary":true,"text":[{"text":"struct Foo<Self>(Self);","highlight_start":12,"highlight_end":16}],"label":"expected identifier, found keyword","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: expected identifier, found keyword `Self`\n  --> /checkout/src/test/ui/issues/issue-36638.rs:13:12\n   |\nLL | struct Foo<Self>(Self);\n   |            ^^^^ expected identifier, found keyword\n\n"}
[00:49:04] {"message":"expected identifier, found keyword `Self`","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-36638.rs","byte_start":604,"byte_end":608,"line_start":16,"line_end":16,"column_start":11,"column_end":15,"is_primary":true,"text":[{"text":"trait Bar<Self> {}","highlight_start":11,"highlight_end":15}],"label":"expected identifier, found keyword","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: expected identifier, found keyword `Self`\n  --> /checkout/src/test/ui/issues/issue-36638.rs:16:11\n   |\nLL | trait Bar<Self> {}\n   |           ^^^^ expected identifier, found keyword\n\n"}
[00:49:04] {"message":"parameter `Self` is never used","code":{"code":"E0392","explanation":"\nThis error indicates that a type or lifetime parameter has been declared\nbut not actually used. Here is an example that demonstrates the error:\n\n```compile_fail,E0392\nenum Foo<T> {\n    Bar,\n}\n```\n\nIf the type parameter was included by mistake, this error can be fixed\nby simply removing the type parameter, as shown below:\n\n```\nenum Foo {\n    Bar,\n}\n```\n\nAlternatively, if the type parameter was intentionally inserted, it must be\nused. A simple fix is shown below:\n\n```\nenum Foo<T> {\n    Bar(T),\n}\n```\n\nThis error may also commonly be found when working with unsafe code. For\nexample, when using raw pointers one may wish to specify the lifetime for\nwhich the pointed-at data is valid. An initial attempt (below) causes this\nerror:\n\n```compile_fail,E0392\nstruct Foo<'a, T> {\n    x: *const T,\n}\n```\n\nWe want to express the constraint that Foo should not outlive `'a`, because\nthe data pointed to by `T` is only valid for that lifetime. The problem is\nthat there are no actual uses of `'a`. It's possible to work around this\nby adding a PhantomData type to the struct, using it to tell the compiler\nto act as if the struct contained a borrowed reference `&'a T`:\n\n```\nuse std::marker::PhantomData;\n\nstruct Foo<'a, T: 'a> {\n    x: *const T,\n    phantom: PhantomData<&'a T>\n}\n```\n\n[PhantomData] can also be used to express information about unused type\nparameters.\n\n[PhantomData]: https://doc.rust-lang.org/std/marker/struct.PhantomData.html\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-36638.rs","byte_start":527,"byte_end":531,"line_start":13,"line_end":13,"column_start":12,"column_end":16,"is_primary":true,"text":[{"text":"struct Foo<Self>(Self);","highlight_start":12,"highlight_end":16}],"label":"unused type parameter","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"consider removing `Self` or using a marker such as `std::marker::PhantomData`","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0392]: parameter `Self` is never used\n  --> /checkout/src/test/ui/issues/issue-36638.rs:13:12\n   |\nLL | struct Foo<Self>(Self);\n   |            ^^^^ unused type parameter\n   |\n   = help: consider removing `Self` or using a marker such as `std::marker::PhantomData`\n\n"}
[00:49:04] {"message":"aborting due to 3 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 3 previous errors\n\n"}
[00:49:04] {"message":"For more information about this error, try `rustc --explain E0392`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0392`.\n"}
[00:49:04] ------------------------------------------
[00:49:04] 
[00:49:04] thread '[ui] ui/issues/issue-36638.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:49:04] note: Run with `RUST_BACKTRACE=1` for a backtrace.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:stabilise-self_in_typedefs branch from 7fcd047 to e0fad58 Nov 30, 2018

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Nov 30, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1ec68044:start=1543598434283655787,finish=1543598436631300479,duration=2347644692
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:48:00] .................................................................................................... 2100/5102
[00:48:04] .................................................................................................... 2200/5102
[00:48:08] .................................................................................................... 2300/5102
[00:48:12] .................................................................................................... 2400/5102
[00:48:16] ...................................................F................................................ 2500/5102
[00:48:23] .................................................................................................... 2700/5102
[00:48:27] .................................................................................................... 2800/5102
[00:48:30] .................................................................................................... 2900/5102
[00:48:33] .................................................................................................... 3000/5102
---
[00:49:30] .................................................................i.................................. 4700/5102
[00:49:33] .................................................................................................... 4800/5102
[00:49:36] .................................................................................................... 4900/5102
[00:49:39] .................................................................................................... 5000/5102
kout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-36638.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36638/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "continue-parse-after-error" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36638/auxiliary" "-A" "unused"
[00:49:42]     Error {
[00:49:42]         line_num: 13,
[00:49:42]         kind: Some(
[00:49:42]             Error
[00:49:42]             Error
[00:49:42]         ),
[00:49:42]         msg: "13:12: 13:16: parameter `Self` is never used [E0392]"
[00:49:42] ]
[00:49:42] 
[00:49:42] thread '[ui] ui/issues/issue-36638.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1358:13
[00:49:42] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:49:42] 
[00:49:42] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:503:22
[00:49:42] 
[00:49:42] 
[00:49:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:49:42] 
[00:49:42] 
[00:49:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:49:42] Build completed unsuccessfully in 0:03:56
[00:49:42] Build completed unsuccessfully in 0:03:56
[00:49:42] make: *** [check] Error 1
[00:49:42] Makefile:58: recipe for target 'check' failed
123696 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
122844 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps
115736 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release
115352 ./src/llvm/test/CodeGen

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:stabilise-self_in_typedefs branch from e0fad58 to 8ab15c0 Nov 30, 2018

@bors

This comment was marked as resolved.

Contributor

bors commented Nov 30, 2018

☔️ The latest upstream changes (presumably #56381) made this pull request unmergeable. Please resolve the merge conflicts.

@alexreg alexreg force-pushed the alexreg:stabilise-self_in_typedefs branch from 8ab15c0 to d609fdf Nov 30, 2018

@Centril

This comment has been minimized.

Contributor

Centril commented Dec 1, 2018

@bors r+

FCP hasn't completed yet but since we close to the master=>beta deadline I'd like to avoid backports so let's land this now. The RFC was rather uncontroversial and since the PR is small we can back out in beta if FCP doesn't complete for some reason.

@bors

This comment has been minimized.

Contributor

bors commented Dec 1, 2018

📌 Commit d609fdf has been approved by Centril

@Centril

This comment has been minimized.

Contributor

Centril commented Dec 1, 2018

(Note; the tracking issue should be kept open while FCP is still in progress!)

bors added a commit that referenced this pull request Dec 1, 2018

Auto merge of #56408 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 9 pull requests

Successful merges:

 - #55010 (Add template parameter debuginfo to generic types)
 - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks)
 - #56305 (update miri)
 - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs)
 - #56394 (Deal with EINTR in net timeout tests)
 - #56395 (Stabilize dbg!(...))
 - #56402 (Improve the unstable book example for #56408 [marker] trait)
 - #56406 (Update RLS and Rustfmt)
 - #56366 (Stabilize self_in_typedefs feature)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Contributor

Centril commented Dec 1, 2018

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Dec 1, 2018

Rollup merge of rust-lang#56366 - alexreg:stabilise-self_in_typedefs,…
… r=Centril

Stabilize self_in_typedefs feature

[**Tracking Issue**](rust-lang#49303)

r? @Centril

bors added a commit that referenced this pull request Dec 2, 2018

Auto merge of #56422 - Centril:rollup, r=Centril
Rollup of 13 pull requests

Successful merges:

 - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks)
 - #56224 (Update cargo)
 - #56285 (move stage0.txt to toplevel directory)
 - #56305 (update miri)
 - #56366 (Stabilize self_in_typedefs feature)
 - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs)
 - #56394 (Deal with EINTR in net timeout tests)
 - #56395 (Stabilize dbg!(...))
 - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block)
 - #56402 (Improve the unstable book example for #[marker] trait)
 - #56416 (Remove unneeded body class selector)
 - #56418 (Fix failing tidy (line endings on Windows))
 - #56419 (Remove some uses of try!)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Dec 2, 2018

Rollup merge of rust-lang#56366 - alexreg:stabilise-self_in_typedefs,…
… r=Centril

Stabilize self_in_typedefs feature

[**Tracking Issue**](rust-lang#49303)

r? @Centril

bors added a commit that referenced this pull request Dec 2, 2018

Auto merge of #56427 - Centril:rollup, r=Centril
Rollup of 14 pull requests

Successful merges:

 - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks)
 - #56224 (Update cargo)
 - #56305 (update miri)
 - #56366 (Stabilize self_in_typedefs feature)
 - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs)
 - #56394 (Deal with EINTR in net timeout tests)
 - #56395 (Stabilize dbg!(...))
 - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block)
 - #56402 (Improve the unstable book example for #[marker] trait)
 - #56412 (Update tracking issue for `extern_crate_self`)
 - #56416 (Remove unneeded body class selector)
 - #56418 (Fix failing tidy (line endings on Windows))
 - #56419 (Remove some uses of try!)
 - #56424 (Mention raw-ident syntax)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Dec 2, 2018

Rollup merge of rust-lang#56366 - alexreg:stabilise-self_in_typedefs,…
… r=Centril

Stabilize self_in_typedefs feature

[**Tracking Issue**](rust-lang#49303)

r? @Centril

Centril added a commit to Centril/rust that referenced this pull request Dec 2, 2018

Rollup merge of rust-lang#56366 - alexreg:stabilise-self_in_typedefs,…
… r=Centril

Stabilize self_in_typedefs feature

[**Tracking Issue**](rust-lang#49303)

r? @Centril

Centril added a commit to Centril/rust that referenced this pull request Dec 2, 2018

Rollup merge of rust-lang#56366 - alexreg:stabilise-self_in_typedefs,…
… r=Centril

Stabilize self_in_typedefs feature

[**Tracking Issue**](rust-lang#49303)

r? @Centril

bors added a commit that referenced this pull request Dec 2, 2018

Auto merge of #56430 - Centril:rollup, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks)
 - #56269 (Use a `SmallVec` within `_match::Matrix`.)
 - #56305 (update miri)
 - #56358 (Enable -mergefunc-use-aliases)
 - #56366 (Stabilize self_in_typedefs feature)
 - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs)
 - #56394 (Deal with EINTR in net timeout tests)
 - #56395 (Stabilize dbg!(...))
 - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block)
 - #56402 (Improve the unstable book example for #[marker] trait)
 - #56406 (Update RLS and Rustfmt)
 - #56412 (Update tracking issue for `extern_crate_self`)
 - #56416 (Remove unneeded body class selector)
 - #56418 (Fix failing tidy (line endings on Windows))
 - #56419 (Remove some uses of try!)
 - #56424 (Mention raw-ident syntax)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Dec 2, 2018

Rollup merge of rust-lang#56366 - alexreg:stabilise-self_in_typedefs,…
… r=Centril

Stabilize self_in_typedefs feature

[**Tracking Issue**](rust-lang#49303)

r? @Centril

bors added a commit that referenced this pull request Dec 2, 2018

Auto merge of #56437 - Centril:rollup, r=Centril
Rollup of 14 pull requests

Successful merges:

 - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks)
 - #56305 (update miri)
 - #56366 (Stabilize self_in_typedefs feature)
 - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs)
 - #56394 (Deal with EINTR in net timeout tests)
 - #56395 (Stabilize dbg!(...))
 - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block)
 - #56402 (Improve the unstable book example for #[marker] trait)
 - #56412 (Update tracking issue for `extern_crate_self`)
 - #56416 (Remove unneeded body class selector)
 - #56418 (Fix failing tidy (line endings on Windows))
 - #56419 (Remove some uses of try!)
 - #56424 (Mention raw-ident syntax)
 - #56432 (Update issue number of `shrink_to` methods to point the tracking issue)

Failed merges:

r? @ghost
@pietroalbini

This comment has been minimized.

Member

pietroalbini commented Dec 2, 2018

@bors rollup-

@alexreg

This comment has been minimized.

Contributor

alexreg commented Dec 3, 2018

@pietroalbini Why did this get removed from roll-up, my I ask?

bors added a commit that referenced this pull request Dec 3, 2018

Auto merge of #56366 - alexreg:stabilise-self_in_typedefs, r=Centril
Stabilize self_in_typedefs feature

[**Tracking Issue**](#49303)

r? @Centril
@bors

This comment has been minimized.

Contributor

bors commented Dec 3, 2018

⌛️ Testing commit d609fdf with merge 7199fef...

@bors

This comment has been minimized.

Contributor

bors commented Dec 3, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Dec 3, 2018

The job x86_64-gnu-debug of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:12:23] curl: (6) Could not resolve host: static.rust-lang.org
[00:12:23] 
[00:12:23] spurious failure, trying again
[00:13:52] curl: (6) Could not resolve host: static.rust-lang.org
[00:13:52] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmpx1SQbS.sha256 https://static.rust-lang.org/dist/2018-10-30/rust-std-beta-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:13:52] Makefile:81: recipe for target 'prepare' failed
[00:13:52] make: *** [prepare] Error 1
[00:13:53] Command failed. Attempt 2/5:
[00:15:22] curl: (6) Could not resolve host: static.rust-lang.org
---
[00:19:49] curl: (6) Could not resolve host: static.rust-lang.org
[00:19:49] 
[00:19:49] spurious failure, trying again
[00:21:18] curl: (6) Could not resolve host: static.rust-lang.org
[00:21:18] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmp4wnb8c.sha256 https://static.rust-lang.org/dist/2018-10-30/rust-std-beta-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:21:18] make: *** [prepare] Error 1
[00:21:18] Makefile:81: recipe for target 'prepare' failed
[00:21:20] Command failed. Attempt 3/5:
[00:22:50] curl: (6) Could not resolve host: static.rust-lang.org
---
[00:27:17] curl: (6) Could not resolve host: static.rust-lang.org
[00:27:17] 
[00:27:17] spurious failure, trying again
[00:28:46] curl: (6) Could not resolve host: static.rust-lang.org
[00:28:46] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmp0euVYZ.sha256 https://static.rust-lang.org/dist/2018-10-30/rust-std-beta-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:28:46] make: *** [prepare] Error 1
[00:28:46] Makefile:81: recipe for target 'prepare' failed
[00:28:49] Command failed. Attempt 4/5:
[00:30:18] curl: (6) Could not resolve host: static.rust-lang.org
---
[00:34:46] curl: (6) Could not resolve host: static.rust-lang.org
[00:34:46] 
[00:34:46] spurious failure, trying again
[00:36:15] curl: (6) Could not resolve host: static.rust-lang.org
[00:36:15] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmpGuqCEl.sha256 https://static.rust-lang.org/dist/2018-10-30/rust-std-beta-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:36:15] make: *** [prepare] Error 1
[00:36:15] Makefile:81: recipe for target 'prepare' failed
[00:36:19] Command failed. Attempt 5/5:
[00:37:48] curl: (6) Could not resolve host: static.rust-lang.org
---
[00:42:15] curl: (6) Could not resolve host: static.rust-lang.org
[00:42:15] 
[00:42:15] spurious failure, trying again
[00:43:45] curl: (6) Could not resolve host: static.rust-lang.org
[00:43:45] failed to run: curl -s -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmpoVryFu.sha256 https://static.rust-lang.org/dist/2018-10-30/rust-std-beta-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:43:45] Makefile:81: recipe for target 'prepare' failed
[00:43:45] make: *** [prepare] Error 1
[00:43:45] The command has failed after 5 attempts.
travis_time:end:08db2dd8:start=1543818272790084160,finish=1543820898121292130,duration=2625331207970
---
travis_time:end:0ccdfb80:start=1543820899189282557,finish=1543820899197623496,duration=8340939
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1ee31c9a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0aef848b
travis_time:start:0aef848b
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02bf1976
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@pietroalbini

This comment has been minimized.

Member

pietroalbini commented Dec 3, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Dec 3, 2018

Rollup merge of rust-lang#56366 - alexreg:stabilise-self_in_typedefs,…
… r=Centril

Stabilize self_in_typedefs feature

[**Tracking Issue**](rust-lang#49303)

r? @Centril

bors added a commit that referenced this pull request Dec 3, 2018

Auto merge of #56451 - kennytm:rollup, r=kennytm
Rollup of 13 pull requests

Successful merges:

 - #56141 ([std] Osstr len clarity)
 - #56366 (Stabilize self_in_typedefs feature)
 - #56395 (Stabilize dbg!(...))
 - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block)
 - #56402 (Improve the unstable book example for #[marker] trait)
 - #56412 (Update tracking issue for `extern_crate_self`)
 - #56416 (Remove unneeded body class selector)
 - #56418 (Fix failing tidy (line endings on Windows))
 - #56419 (Remove some uses of try!)
 - #56432 (Update issue number of `shrink_to` methods to point the tracking issue)
 - #56433 (Add description about `crate` for parse_visibility's comment)
 - #56435 (make the C part of compiler-builtins opt-out)
 - #56438 (Remove not used `DotEq` token)

Failed merges:

r? @ghost

@bors bors merged commit d609fdf into rust-lang:master Dec 3, 2018

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment