New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak `expand_node` #57719

Merged
merged 2 commits into from Jan 19, 2019

Conversation

Projects
None yet
4 participants
@nnethercote
Copy link
Contributor

nnethercote commented Jan 18, 2019

These commits speed up the unicode_normalization benchmark a little.

nnethercote added some commits Jan 17, 2019

Inline `expand_node`.
This requires restructuring things a little so that there is only one
callsite, ensuring that inlinining doesn't cause unnecessary code bloat.

This reduces instruction counts for the `unicode_normalization`
benchmark by up to 4%.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 18, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jan 18, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 18, 2019

📌 Commit 92fd6f9 has been approved by nikomatsakis

Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019

Rollup merge of rust-lang#57719 - nnethercote:expand_node-FIDDLING, r…
…=nikomatsakis

Tweak `expand_node`

These commits speed up the `unicode_normalization` benchmark a little.

bors added a commit that referenced this pull request Jan 19, 2019

Auto merge of #57755 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #57486 (Simplify `TokenStream` some more)
 - #57502 (make trait-aliases work across crates)
 - #57598 (Add missing unpretty option help message)
 - #57649 (privacy: Account for associated existential types)
 - #57659 (Fix release manifest generation)
 - #57699 (add applicability to remaining suggestions)
 - #57719 (Tweak `expand_node`)

Failed merges:

r? @ghost

@bors bors merged commit 92fd6f9 into rust-lang:master Jan 19, 2019

@nnethercote nnethercote deleted the nnethercote:expand_node-FIDDLING branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment