Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #57912

Closed
wants to merge 23 commits into from
Closed

Rollup of 9 pull requests #57912

wants to merge 23 commits into from

Commits on Jan 17, 2019

  1. Configuration menu
    Copy the full SHA
    7b55711 View commit details
    Browse the repository at this point in the history
  2. Simplify Debug implementation of MutexGuard.

    Just transparently print the guarded data, instead of wrapping it in
    `MutexGuard { lock: Mutex { data: ... } }`.
    m-ou-se committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2e9deed View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. test that wildcard type _ is not duplicated by `type Foo<X> = (X, X…

    …);` and potentially instantiated at different types.
    pnkfelix committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b3690c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. Configuration menu
    Copy the full SHA
    c14508f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff41abc View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. un-deprecate mem::zeroed

    RalfJung committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    e7998bf View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Ignore aarch64 in simd-intrinsic-generic-reduction

    This fails on AArch64 see rust-lang#54510
    James Duley committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    9aa1ca2 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Suggest removing leading left angle brackets.

    This commit adds errors and accompanying suggestions as below:
    
    ```
    bar::<<<<<T as Foo>::Output>();
         ^^^ help: remove extra angle brackets
    ```
    davidtwco committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    22f794b View commit details
    Browse the repository at this point in the history
  2. Optimize snapshot usage.

    This commit implements a suggestion from @estebank that optimizes the
    use of snapshots.
    
    Instead of creating a snapshot for each recursion in `parse_path_segment`
    and then replacing `self` with them until the first invocation where if
    leading angle brackets are detected, `self` is not replaced and instead the
    snapshot is used to inform how parsing should continue.
    
    Now, a snapshot is created in the first invocation that acts as a backup
    of the parser state before any generic arguments are parsed (and
    therefore, before recursion starts). This backup replaces `self` if after
    all parsing of generic arguments has concluded we can determine that
    there are leading angle brackets. Parsing can then proceed from the
    backup state making use of the now known number of unmatched leading
    angle brackets to recover.
    davidtwco committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    8ab12f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. improve unused doc comment diagnostic reporting

    Report all unused attributes on a given doc comment instead of just the
    first one, and extend the span of sugared doc comments to encompass the
    whole comment.
    euclio committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    187dab9 View commit details
    Browse the repository at this point in the history
  2. expand unused doc comment diagnostic

    Report the diagnostic on macro expansions, and add a label indicating
    why the comment is unused.
    euclio committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    871e460 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Configuration menu
    Copy the full SHA
    ac4b685 View commit details
    Browse the repository at this point in the history
  2. std: Stabilize fixed-width integer atomics

    This commit stabilizes the `Atomic{I,U}{8,16,32,64}` APIs in the
    `std::sync::atomic` and `core::sync::atomic` modules. Proposed in rust-lang#56753
    and tracked in rust-lang#32976 this feature has been unstable for quite some time
    and is hopefully ready to go over the finish line now!
    
    The API is being stabilized as-is. The API of `AtomicU8` and friends
    mirrors that of `AtomicUsize`. A list of changes made here are:
    
    * A portability documentation section has been added to describe the
      current state of affairs.
    * Emulation of smaller-size atomics with larger-size atomics has been
      documented.
    * As an added bonus, `ATOMIC_*_INIT` is now scheduled for deprecation
      across the board in 1.34.0 now that `const` functions can be invoked
      in statics.
    
    Note that the 128-bit atomic types are omitted from this stabilization
    explicitly. They have far less platform support than the other atomic
    types, and will likely require further discussion about their best
    location.
    
    Closes rust-lang#32976
    Closes rust-lang#56753
    alexcrichton committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    14b36fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b659d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. Rollup merge of rust-lang#57425 - alexcrichton:stabilize-atomics, r=s…

    …fackler
    
    std: Stabilize fixed-width integer atomics
    
    This commit stabilizes the `Atomic{I,U}{8,16,32,64}` APIs in the
    `std::sync::atomic` and `core::sync::atomic` modules. Proposed in rust-lang#56753
    and tracked in rust-lang#32976 this feature has been unstable for quite some time
    and is hopefully ready to go over the finish line now!
    
    The API is being stabilized as-is. The API of `AtomicU8` and friends
    mirrors that of `AtomicUsize`. A list of changes made here are:
    
    * A portability documentation section has been added to describe the
      current state of affairs.
    * Emulation of smaller-size atomics with larger-size atomics has been
      documented.
    * As an added bonus, `ATOMIC_*_INIT` is now scheduled for deprecation
      across the board in 1.34.0 now that `const` functions can be invoked
      in statics.
    
    Note that the 128-bit atomic types are omitted from this stabilization
    explicitly. They have far less platform support than the other atomic
    types, and will likely require further discussion about their best
    location.
    
    Closes rust-lang#32976
    Closes rust-lang#56753
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    facb6ca View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#57703 - m-ou-se:mutexguard-debug, r=cramertj

    Make MutexGuard's Debug implementation more useful.
    
    Fixes rust-lang#57702.
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    64eff91 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#57729 - pnkfelix:issue-55748-pat-types-are-…

    …constraints-on-bindings-too, r=nikomatsakis
    
    extra testing of how NLL handles wildcard type `_`
    
    test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X);` and potentially instantiated at different types when used in type ascriptions in let bindings.
    
    (NLL's handling of this for the type ascription *expression form* is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by `#![feature(type_ascription)]`.)
    
    cc rust-lang#55748
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    f1d90a9 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#57764 - Xanewok:tiny-tweaks, r=nikomatsakis

    Fix some minor warnings
    
    Since apparently RLS works when initialized in the root repository (:tada:) I decided to fix some of the issues it caught.
    
    There are a lot of unused attribute warnings left on `rustc_on_unimplemented` and `rustc_layout_scalar_valid_range_start` but I imagine we can't do much about it due to 2-stage compilation?
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    729c50d View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#57825 - RalfJung:zeroed, r=nikomatsakis

    un-deprecate mem::zeroed
    
    as per the discussion around <rust-lang#53491 (comment)>
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    2c32cb7 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#57827 - parched:ignore, r=nikomatsakis

    Ignore aarch64 in simd-intrinsic-generic-reduction
    
    This fails on AArch64 see rust-lang#54510
    
    Disabling it for now until it's fixed/implemented in LLVM
    
    cc @gnzlbg
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    801adcc View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#57852 - davidtwco:issue-57819, r=estebank

    Suggest removing leading left angle brackets.
    
    Fixes rust-lang#57819.
    
    This PR adds errors and accompanying suggestions as below:
    
    ```
    bar::<<<<<T as Foo>::Output>();
         ^^^ help: remove extra angle brackets
    ```
    
    r? @estebank
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    e77959e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#57882 - euclio:unused-doc-attributes, r=est…

    …ebank
    
    overhaul unused doc comments lint
    
    This PR contains a number of improvements to the `unused_doc_comments` lint.
    
    - Extends the span to cover the entire comment when using sugared doc comments.
    - Triggers the lint for all unused doc comments on a node, instead of just the first one.
    - Triggers the lint on macro expansions, and provides a help note explaining that doc comments must be expanded by the macro.
    - Adds a label pointing at the node that cannot be documented.
    
    Furthermore, this PR fixes any instances in rustc where a macro expansion was erroneously documented.
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    20f57f3 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#57908 - petrochenkov:errepice, r=estebank

    resolve: Fix span arithmetics in the import conflict error
    
    rust-lang#56937 rebased and fixed
    
    Fixes rust-lang#56411
    Fixes rust-lang#57071
    Fixes rust-lang#57787
    
    r? @estebank
    Centril committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    e9eaebc View commit details
    Browse the repository at this point in the history