New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra testing of how NLL handles wildcard type `_` #57729

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@pnkfelix
Copy link
Member

pnkfelix commented Jan 18, 2019

test that wildcard type _ is not duplicated by type Foo<X> = (X, X); and potentially instantiated at different types when used in type ascriptions in let bindings.

(NLL's handling of this for the type ascription expression form is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by #![feature(type_ascription)].)

cc #55748

test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X…
…);` and potentially instantiated at different types.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 18, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jan 25, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 25, 2019

📌 Commit b3690c6 has been approved by nikomatsakis

Centril added a commit to Centril/rust that referenced this pull request Jan 26, 2019

Rollup merge of rust-lang#57729 - pnkfelix:issue-55748-pat-types-are-…
…constraints-on-bindings-too, r=nikomatsakis

extra testing of how NLL handles wildcard type `_`

test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X);` and potentially instantiated at different types when used in type ascriptions in let bindings.

(NLL's handling of this for the type ascription *expression form* is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by `#![feature(type_ascription)]`.)

cc rust-lang#55748

Centril added a commit to Centril/rust that referenced this pull request Jan 26, 2019

Rollup merge of rust-lang#57729 - pnkfelix:issue-55748-pat-types-are-…
…constraints-on-bindings-too, r=nikomatsakis

extra testing of how NLL handles wildcard type `_`

test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X);` and potentially instantiated at different types when used in type ascriptions in let bindings.

(NLL's handling of this for the type ascription *expression form* is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by `#![feature(type_ascription)]`.)

cc rust-lang#55748

bors added a commit that referenced this pull request Jan 26, 2019

Auto merge of #57912 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57425 (std: Stabilize fixed-width integer atomics)
 - #57703 (Make MutexGuard's Debug implementation more useful.)
 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #57764 (Fix some minor warnings)
 - #57825 (un-deprecate mem::zeroed)
 - #57827 (Ignore aarch64 in simd-intrinsic-generic-reduction)
 - #57852 (Suggest removing leading left angle brackets.)
 - #57882 (overhaul unused doc comments lint)
 - #57908 (resolve: Fix span arithmetics in the import conflict error)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 26, 2019

Failed in rollup, #57912 (comment).

@bors r-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment