New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MutexGuard's Debug implementation more useful. #57703

Merged
merged 2 commits into from Jan 26, 2019

Conversation

Projects
None yet
7 participants
@m-ou-se
Copy link
Contributor

m-ou-se commented Jan 17, 2019

Fixes #57702.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 17, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Show resolved Hide resolved src/libstd/sync/mutex.rs Outdated
Simplify Debug implementation of MutexGuard.
Just transparently print the guarded data, instead of wrapping it in
`MutexGuard { lock: Mutex { data: ... } }`.
@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Jan 17, 2019

@bors r+ rollup

@Centril Centril closed this Jan 25, 2019

@Centril Centril reopened this Jan 25, 2019

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 25, 2019

Bors is being difficult...

@bors r=cramertj rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 25, 2019

📌 Commit 2e9deed has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request Jan 26, 2019

Rollup merge of rust-lang#57703 - m-ou-se:mutexguard-debug, r=cramertj
Make MutexGuard's Debug implementation more useful.

Fixes rust-lang#57702.

Centril added a commit to Centril/rust that referenced this pull request Jan 26, 2019

Rollup merge of rust-lang#57703 - m-ou-se:mutexguard-debug, r=cramertj
Make MutexGuard's Debug implementation more useful.

Fixes rust-lang#57702.

bors added a commit that referenced this pull request Jan 26, 2019

Auto merge of #57912 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57425 (std: Stabilize fixed-width integer atomics)
 - #57703 (Make MutexGuard's Debug implementation more useful.)
 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #57764 (Fix some minor warnings)
 - #57825 (un-deprecate mem::zeroed)
 - #57827 (Ignore aarch64 in simd-intrinsic-generic-reduction)
 - #57852 (Suggest removing leading left angle brackets.)
 - #57882 (overhaul unused doc comments lint)
 - #57908 (resolve: Fix span arithmetics in the import conflict error)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 26, 2019

Rollup merge of rust-lang#57703 - m-ou-se:mutexguard-debug, r=cramertj
Make MutexGuard's Debug implementation more useful.

Fixes rust-lang#57702.

bors added a commit that referenced this pull request Jan 26, 2019

Auto merge of #57918 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #57407 (Stabilize extern_crate_self)
 - #57703 (Make MutexGuard's Debug implementation more useful.)
 - #57764 (Fix some minor warnings)
 - #57825 (un-deprecate mem::zeroed)
 - #57827 (Ignore aarch64 in simd-intrinsic-generic-reduction)
 - #57908 (resolve: Fix span arithmetics in the import conflict error)
 - #57913 (Change crate-visibility-modifier issue number in The Unstable Book)

Failed merges:

r? @ghost

@bors bors merged commit 2e9deed into rust-lang:master Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment