New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stdsimd and remove now-unused MaybeUninit::into_inner #58373

Merged
merged 6 commits into from Feb 18, 2019

Conversation

Projects
None yet
10 participants
@RalfJung
Copy link
Member

RalfJung commented Feb 11, 2019

That's a huge diff for stdsimd... Cc @gnzlbg @alexcrichton

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 11, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 11, 2019

⚠️ Warning ⚠️

  • These commits modify submodules.
@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 11, 2019

Hm, this fails to build:

error: couldn't read src/libcore/core_arch_docs.md: No such file or directory (os error 2)                                                                                                                       
 --> src/libcore/../stdsimd/crates/core_arch/src/mod.rs:8:17
  |
8 | #[doc(include = "core_arch_docs.md")]
  |                 ^^^^^^^^^^^^^^^^^^^ couldn't read file
  |
  = help: external doc paths are relative to the crate root
@gnzlbg

This comment has been minimized.

Copy link
Contributor

gnzlbg commented Feb 11, 2019

cc @QuietMisdreavus it appears that #[doc(include = "core_arch_docs.md")] does not respect #[path].

@RalfJung can you test if creating a symlink from libcore/core_arch_docs.md to stdsimd/crates/core_arch/src/core_arch_docs.md solves this issue?

Also, libstd probably needs to be compiled with --cfg feature="std_detect_file_io" --cfg feature="std_detect_dlsym_getauxval", so those two should probably be added here: https://github.com/rust-lang/rust/blob/master/src/libstd/Cargo.toml#L50

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:00bf4372:start=1549895446682520464,finish=1549895524783535846,duration=78101015382
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:03:16]    Compiling cc v1.0.28
[00:03:16]    Compiling libc v0.2.46
[00:03:16]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:03:16]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:03:17] error: couldn't read src/libcore/core_arch_docs.md: No such file or directory (os error 2)
[00:03:17]   |
[00:03:17]   |
[00:03:17] 8 | #[doc(include = "core_arch_docs.md")]
[00:03:17]   |                 ^^^^^^^^^^^^^^^^^^^ couldn't read file
[00:03:17]   |
[00:03:17]   = help: external doc paths are relative to the crate root
[00:03:18]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:03:22]    Compiling compiler_builtins v0.1.5
[00:03:22]    Compiling cmake v0.1.33
[00:03:22]    Compiling backtrace-sys v0.1.27
---
[00:03:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:03:36] expected success, got: exit code: 101
[00:03:36] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:03:36] Build completed unsuccessfully in 0:00:21
[00:03:36] make: *** [all] Error 1
[00:03:36] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:02708f85
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Feb 11 14:35:50 UTC 2019
---
travis_time:end:23fc2560:start=1549895751458688360,finish=1549895751464181466,duration=5493106
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:23853f54
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:16b390c0
travis_time:start:16b390c0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:18a9efdb
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 11, 2019

can you test if creating a symlink from libcore/core_arch_docs.md to stdsimd/crates/core_arch/src/core_arch_docs.md solves this issue?

That seems to help. But don't ask me what it'll do on Windows...

libstd probably needs to be compiled with --cfg feature="std_detect_file_io" --cfg feature="std_detect_dlsym_getauxval", so those two should probably be added

Like this? However, they should probably be documented. If you tell me which text to put there I'll do it. :P

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0cfbd85a:start=1549918893896421766,finish=1549918970418710447,duration=76522288681
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:21] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:21] tidy error: binary checked into source: /checkout/src/libcore/core_arch_docs.md
[00:03:23] some tidy checks failed
[00:03:23] 
[00:03:23] 
[00:03:23] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:23] 
[00:03:23] 
[00:03:23] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:23] Build completed unsuccessfully in 0:00:45
[00:03:23] Build completed unsuccessfully in 0:00:45
[00:03:23] Makefile:68: recipe for target 'tidy' failed
[00:03:23] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:09f9c28a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Feb 11 21:06:22 UTC 2019
---
travis_time:end:276fbfe0:start=1549919183602131603,finish=1549919183606817845,duration=4686242
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0536fdf6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c79f650
travis_time:start:0c79f650
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:27f3ae54
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@gnzlbg gnzlbg referenced this pull request Feb 11, 2019

Merged

Fix libcore build #680

@gnzlbg

This comment has been minimized.

Copy link
Contributor

gnzlbg commented Feb 11, 2019

Like this? However, they should probably be documented. If you tell me which text to put there I'll do it. :P

Yes that's exactly what I meant!

I think a comment stating:

# Enable std_detect default features:
# https://github.com/rust-lang-nursery/stdsimd/blob/master/crates/std_detect/Cargo.toml

would be enough.

That seems to help. But don't ask me what it'll do on Windows...

I don't think that will work... Maybe this PR to stdsimd fixes this here: rust-lang-nursery/stdsimd#680

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 12, 2019

Well let us see.

@gnzlbg gnzlbg referenced this pull request Feb 12, 2019

Merged

Add AVX512-IFMA intrinsics. #676

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

☔️ The latest upstream changes (presumably #58341) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung RalfJung force-pushed the RalfJung:maybe-uninit branch from ab8b25d to 9d47226 Feb 13, 2019

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 13, 2019

Seems like travis is happy?

I resolved the conflicts.

@gnzlbg

gnzlbg approved these changes Feb 13, 2019

Copy link
Contributor

gnzlbg left a comment

r? @gnzlbg LGTM.

@bors: r+

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 13, 2019

Seems like bors didn't see this, maybe because of the ":"?

@bors r=gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 13, 2019

📌 Commit 9d47226 has been approved by gnzlbg

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Feb 14, 2019

In-between-rollup-filler, @bors p=1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 14, 2019

⌛️ Testing commit 9d47226 with merge 92e9f3f...

bors added a commit that referenced this pull request Feb 14, 2019

Auto merge of #58373 - RalfJung:maybe-uninit, r=gnzlbg
update stdsimd and remove now-unused MaybeUninit::into_inner

That's a huge diff for stdsimd... Cc @gnzlbg @alexcrichton
@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 14, 2019

Seems like I somehow lost the part where into_inner gets removed.^^ But that's okay, that part is easy to submit later (and can be rollup'd).

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 14, 2019

💔 Test failed - status-appveyor

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 14, 2019

Log ends in

C:\projects\rust\build\tmp\dist\rust.wxs(144) : warning LGHT1076 : ICE61: This product should remove only older versions of itself. The Maximum version is not less than the current product. (1.34.65535 1.34.0.0)
[TIMING] Extended { stage: 2, host: "i686-pc-windows-gnu", target: "i686-pc-windows-gnu" } -- 1101.683
Build completed successfully in 3:19:57
Command exited with code 259
set PATH=%PATH%;"C:\Program Files (x86)\Windows Kits\10\Debuggers\X64"
if exist %LOCALAPPDATA%\CrashDumps for %%f in (%LOCALAPPDATA%\CrashDumps\*) do cdb -c "k;q" -G -z "%%f"

Is that just a timeout?

bors added a commit that referenced this pull request Feb 14, 2019

Auto merge of #58373 - RalfJung:maybe-uninit, r=gnzlbg
update stdsimd and remove now-unused MaybeUninit::into_inner

That's a huge diff for stdsimd... Cc @gnzlbg @alexcrichton
@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 14, 2019

Oh no, updating stdsimd broke something again. Let's not waste bors' time more...

@bors r-

@gnzlbg any idea what is going on?

[00:34:56] error[E0658]: use of unstable library feature 'stdsimd' (see issue #27731)
[00:34:56]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/crc32fast-1.1.2/src/specialized/pclmulqdq.rs:13:12
[00:34:56]    |
[00:34:56] 13 |         if is_x86_feature_detected!("pclmulqdq")
[00:34:56]    |
[00:34:56]    |
[00:34:56]    = help: add #![feature(stdsimd)] to the crate attributes to enable
@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 14, 2019

Actually, ideally you'd just take over this PR (or submit your own). All I want to do is remove MaybeUninit::into_inner, but it clearly takes a stdsimd expert to do a stdsimd update.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:25:49]    Compiling polonius-engine v0.6.2
[00:25:49] [RUSTC-TIMING] smallvec test:false 0.835
[00:25:50]    Compiling rls-span v0.4.0
[00:25:50] [RUSTC-TIMING] polonius_engine test:false 1.241
[00:25:50] error[E0658]: use of unstable library feature 'stdsimd' (see issue #27731)
[00:25:50]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/crc32fast-1.1.2/src/specialized/pclmulqdq.rs:13:12
[00:25:50]    |
[00:25:50] 13 |         if is_x86_feature_detected!("pclmulqdq")
[00:25:50]    |
[00:25:50]    |
[00:25:50]    = help: add #![feature(stdsimd)] to the crate attributes to enable
[00:25:50] 
[00:25:51] error: aborting due to previous error
[00:25:51] 
[00:25:51] For more information about this error, try `rustc --explain E0658`.
[00:25:51] For more information about this error, try `rustc --explain E0658`.
[00:25:51] [RUSTC-TIMING] crc32fast test:false 0.257
[00:25:51] error: Could not compile `crc32fast`.
[00:25:51] [RUSTC-TIMING] libc test:false 1.939
[00:25:51] [RUSTC-TIMING] crossbeam_epoch test:false 2.181
[00:25:51] [RUSTC-TIMING] rls_span test:false 1.030
[00:25:51] error: build failed
[00:25:51] error: build failed
[00:25:51] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:25:51] expected success, got: exit code: 101
[00:25:51] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:25:51] Build completed unsuccessfully in 0:22:08
[00:25:51] make: *** [all] Error 1
[00:25:51] Makefile:18: recipe for target 'all' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:008848c8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Feb 14 17:35:54 UTC 2019
---
travis_time:end:067ef0c0:start=1550165755403521669,finish=1550165755415902033,duration=12380364
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0aafa360
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:30efbd4c
travis_time:start:30efbd4c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:03f6abf5
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 14, 2019

💔 Test failed - checks-travis

@hellow554

This comment has been minimized.

Copy link
Contributor

hellow554 commented Feb 14, 2019

@RalfJung yes, thanks. Sorry that it causes additional headache. 😟

@gnzlbg

This comment has been minimized.

Copy link
Contributor

gnzlbg commented Feb 14, 2019

@RalfJung the problem is that a change in rustc to allow_internal_unstable required a change to stdsimd, which was applied, and appeared to work there, but the update of rust to that version hasnt been done yet, and it apparently fails: I've sent rust-lang-nursery/stdsimd#687 . This might fix the error, but I'm not sure, am travelling, and can't really test it properly.

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 17, 2019

All right, I updated the submodule to include that commit.

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 17, 2019

@bors r=gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 17, 2019

📌 Commit aba0d29 has been approved by gnzlbg

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Feb 17, 2019

@bors p=10

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 18, 2019

⌛️ Testing commit aba0d29 with merge d215d95...

bors added a commit that referenced this pull request Feb 18, 2019

Auto merge of #58373 - RalfJung:maybe-uninit, r=gnzlbg
update stdsimd and remove now-unused MaybeUninit::into_inner

That's a huge diff for stdsimd... Cc @gnzlbg @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: gnzlbg
Pushing d215d95 to master...

@bors bors added the merged-by-bors label Feb 18, 2019

@bors bors merged commit aba0d29 into rust-lang:master Feb 18, 2019

1 check passed

homu Test successful
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 18, 2019

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:1383b75c
$ git clone --depth=2 --branch=master https://github.com/rust-lang/rust.git rust-lang/rust
---
  fi
travis_time:end:107a5e32:start=1550468230195332216,finish=1550468230206722480,duration=11390264
travis_fold:end:before_script.3
travis_time:start:04d96fa6
$ MESSAGE_FILE=$(mktemp -t msg.XXXXXX); . src/ci/docker/x86_64-gnu-tools/repo.sh; commit_toolstate_change "$MESSAGE_FILE" "$TRAVIS_BUILD_DIR/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "$MESSAGE_FILE" "$TOOLSTATE_REPO_ACCESS_TOKEN";
Cloning into 'rust-toolstate'...
I/O error: HTTP Error 422: Unprocessable Entity
📣 Toolstate changed by <unknown PR>!
Tested on commit rust-lang/rust@d215d9591f27d0663445e65615090621153c31df.
Direct link to PR: <<unknown>>
💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Traceback (most recent call last):
  File "/home/travis/build/rust-lang/rust/src/tools/publish_toolstate.py", line 219, in <module>
    'Content-Type': 'application/json',
  File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Feb 18, 2019

Uh, what?

$ MESSAGE_FILE=$(mktemp -t msg.XXXXXX); . src/ci/docker/x86_64-gnu-tools/repo.sh; commit_toolstate_change "$MESSAGE_FILE" "$TRAVIS_BUILD_DIR/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "$MESSAGE_FILE" "$TOOLSTATE_REPO_ACCESS_TOKEN";
Cloning into 'rust-toolstate'...
I/O error: HTTP Error 422: Unprocessable Entity
📣 Toolstate changed by <unknown PR>!
Tested on commit rust-lang/rust@d215d9591f27d0663445e65615090621153c31df.
Direct link to PR: <<unknown>>
💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Traceback (most recent call last):
  File "/home/travis/build/rust-lang/rust/src/tools/publish_toolstate.py", line 219, in <module>
    'Content-Type': 'application/json',
  File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error

@rust-lang/infra @oli-obk

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 18, 2019

fix is in #58541 (comment)

@RalfJung RalfJung deleted the RalfJung:maybe-uninit branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment