Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Stabilize Ident::new_raw #59002
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
There's some discussion about stabilization in the tracking issue and it looks like one of the main questions is about the name of the API (
In light of all that I'd personally be in favor of the current
@rfcbot fcp merge
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
(Including T-Lang on this was proper as this exposes language features programmatically...)
I agree that the name is fine; I would also be alright with
I do however think that the documentation on the function is a bit underwhelming; In particular, the semantics of
@rfcbot concern tests-and-clearer-docs