Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Ident::new_raw #75084

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

Aaron1011
Copy link
Member

Tracking issue: #54723

This is a continuation of PR #59002

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2020
library/proc_macro/src/lib.rs Outdated Show resolved Hide resolved
library/proc_macro/src/lib.rs Outdated Show resolved Hide resolved
library/proc_macro/src/lib.rs Outdated Show resolved Hide resolved
src/test/ui/proc-macro/auxiliary/raw-ident.rs Outdated Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

FCP already happened in #59002, so this PR shouldn't need a new one.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2020
@jonas-schievink jonas-schievink added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 3, 2020
@jonas-schievink jonas-schievink added this to the 1.47 milestone Aug 3, 2020
@Aaron1011
Copy link
Member Author

@petrochenkov: I've addressed your comments

@petrochenkov
Copy link
Contributor

r=me with the extra word removed and commits squashed

Tracking issue: rust-lang#54723

This is a continuation of PR rust-lang#59002
@Aaron1011
Copy link
Member Author

@petrochenkov: Squashed

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2020

📌 Commit 6deda6a has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 3, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 3, 2020
…r=petrochenkov

Stabilize Ident::new_raw

Tracking issue: rust-lang#54723

This is a continuation of PR rust-lang#59002
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#74759 (add `unsigned_abs` to signed integers)
 - rust-lang#75043 (rustc_ast: `(Nested)MetaItem::check_name` -> `has_name`)
 - rust-lang#75056 (Lint path statements to suggest using drop when the type needs drop)
 - rust-lang#75081 (Fix logging for rustdoc)
 - rust-lang#75083 (Do not trigger `unused_braces` for `while let`)
 - rust-lang#75084 (Stabilize Ident::new_raw)
 - rust-lang#75103 (Disable building rust-analyzer on riscv64)
 - rust-lang#75106 (Enable docs on in the x86_64-unknown-linux-musl manifest)

Failed merges:

r? @ghost
@bors bors merged commit 622759d into rust-lang:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants