[WIP] Prerequisites from dep graph refactoring #60559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
I'm not sure what's happening with the threading here, tbh. |
|
☔ The latest upstream changes (presumably #60683) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -0,0 +1,169 @@ | |||
| use super::{Lrc, Lock}; | |||
There was a problem hiding this comment.
Can you add module level documentation here that describes what this is? In particular:
- When would I use this? What are the typical use cases?
- How do I use it? A usage example would be good.
- Do I instantiate it myself? Is there already an executor available in the context somewhere?
- What is the usage protocol? Do I need to worry about deadlocks? Resource management?
- Does it integrate with the jobserver?
- Is there anything else that users should be aware of?
| // inherent impls is considered dirty. | ||
| // | ||
| // [the plan]: https://github.com/rust-lang/rust-roadmap/issues/4 | ||
|
|
michaelwoerister
added
S-waiting-on-author
|
Triage ping @Zoxc, this is waiting for a few merge conflicts to be resolved, and there are outstanding review comments to be addressed |
Zoxc
changed the title
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 11, 2019
Prerequisites from dep graph refactoring rust-lang#2 Split out from rust-lang#60035 and overlaps with rust-lang#60559.
|
Ping from Triage: @Zoxc is there an update on this? Thanks! |
|
Ping from triage @Zoxc any updates? This is waiting for some review comments to be addressed and merge conflicts to be resolved. |
rustbot
added
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #60035
r? @eddyb