Prerequisites from dep graph refactoring #2 #61923

Zoxc · 2019-06-18T02:14:24Z

Split out from #60035 and overlaps with #60559.

rust-highfive · 2019-06-18T02:14:35Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_data_structures/sync.rs

Centril · 2019-06-18T02:27:53Z

cc @RalfJung

rust-highfive · 2019-06-18T03:22:53Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1c81285e:start=1560824301467688192,finish=1560824302229752957,duration=762064765
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:03:55] 
[01:03:55] running 9 tests
[01:03:55] iiiiiiiii
[01:03:55] 
[01:03:55]  finished in 0.146
[01:03:55] travis_fold:end:test_assembly


[01:03:55] travis_time:end:test_assembly:start=1560828147417072851,finish=1560828147563427265,duration=146354414

[01:03:55] travis_fold:start:test_incremental
travis_time:start:test_incremental
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:03:55] 
[01:03:55] running 103 tests
[01:04:09] ................................................................................F................... 100/103
[01:04:10] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:04:10] F..
[01:04:10] failures:
[01:04:10] 
[01:04:10] 
[01:04:10] ---- [incremental] incremental/rlib_cross_crate/b.rs stdout ----
[01:04:10] 
[01:04:10] error in revision `rpass3`: compilation failed!
[01:04:10] status: exit code: 101
[01:04:10] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/rlib_cross_crate/b.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass3" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/rlib_cross_crate/b/b.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/rlib_cross_crate/b/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/rlib_cross_crate/b/auxiliary"
[01:04:10] ------------------------------------------
[01:04:10] 
[01:04:10] ------------------------------------------
[01:04:10] stderr:
[01:04:10] stderr:
[01:04:10] ------------------------------------------
[01:04:10] warning: unused variable: `x`
[01:04:10]   --> /checkout/src/test/incremental/rlib_cross_crate/b.rs:25:9
[01:04:10]    |
[01:04:10] LL |     let x: a::Y = 'c';
[01:04:10]    |         ^ help: consider prefixing with an underscore: `_x`
[01:04:10]    = note: #[warn(unused_variables)] on by default
[01:04:10] 
[01:04:10] 
[01:04:10] thread 'rustc' panicked at 'DepGraph::try_mark_previous_green() - Duplicate DepNodeColor insertion for check_mod_liveness(b[317d])', src/librustc/dep_graph/graph.rs:783:9
[01:04:10] 
[01:04:10] error: internal compiler error: unexpected panic
[01:04:10] 
[01:04:10] note: the compiler unexpectedly panicked. this is a bug.
[01:04:10] note: the compiler unexpectedly panicked. this is a bug.
[01:04:10] 
[01:04:10] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:04:10] 
[01:04:10] note: rustc 1.37.0-dev running on x86_64-unknown-linux-gnu
[01:04:10] 
[01:04:10] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C rpath -C debuginfo=0
[01:04:10] 
[01:04:10] ------------------------------------------
[01:04:10] 
[01:04:10] 
[01:04:10] 
[01:04:10] ---- [incremental] incremental/type_alias_cross_crate/b.rs stdout ----
[01:04:10] 
[01:04:10] error in revision `rpass3`: compilation failed!
[01:04:10] status: exit code: 101
[01:04:10] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/type_alias_cross_crate/b.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass3" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/type_alias_cross_crate/b/b.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/type_alias_cross_crate/b/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/type_alias_cross_crate/b/auxiliary"
[01:04:10] ------------------------------------------
[01:04:10] 
[01:04:10] ------------------------------------------
[01:04:10] stderr:
[01:04:10] stderr:
[01:04:10] ------------------------------------------
[01:04:10] warning: unused variable: `x`
[01:04:10]   --> /checkout/src/test/incremental/type_alias_cross_crate/b.rs:19:9
[01:04:10]    |
[01:04:10] LL |     let x: a::Y = 'c';
[01:04:10]    |         ^ help: consider prefixing with an underscore: `_x`
[01:04:10]    = note: #[warn(unused_variables)] on by default
[01:04:10] 
[01:04:10] 
[01:04:10] thread 'rustc' panicked at 'DepGraph::try_mark_previous_green() - Duplicate DepNodeColor insertion for check_mod_liveness(b[317d])', src/librustc/dep_graph/graph.rs:783:9
[01:04:10] 
[01:04:10] error: internal compiler error: unexpected panic
[01:04:10] 
[01:04:10] note: the compiler unexpectedly panicked. this is a bug.
[01:04:10] note: the compiler unexpectedly panicked. this is a bug.
[01:04:10] 
[01:04:10] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:04:10] 
[01:04:10] note: rustc 1.37.0-dev running on x86_64-unknown-linux-gnu
[01:04:10] 
[01:04:10] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath -C debuginfo=0
[01:04:10] 
[01:04:10] ------------------------------------------
[01:04:10] 
[01:04:10] 
---
[01:04:10] test result: FAILED. 101 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
[01:04:10] 
[01:04:10] 
[01:04:10] 
[01:04:10] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/incremental" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "incremental" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:04:10] 
[01:04:10] 
[01:04:10] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:04:10] Build completed unsuccessfully in 0:59:23
---
travis_time:end:136f92c0:start=1560828165083095209,finish=1560828165087875601,duration=4780392
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:244134f2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ea01e60
travis_time:start:0ea01e60
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:068c4839
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RalfJung · 2019-06-18T20:03:33Z

@Centril anything specific you want me to look at? I am mostly unfamiliar with the code this is touching.

Centril · 2019-06-18T20:32:01Z

@RalfJung Pinged you for the AtomicCell thing :) (see #61923 (comment))

RalfJung · 2019-06-18T20:41:25Z

Ah. :) Well besides the problem around comparing Undef values in both compare_exchange and compare_and_swap, AtomicCell has two more problems that I know of:

It uses seq-locks for data that is too big for atomic accesses. This relies on the LLVM memory model, while Rust officially follows the C++ memory model. The difference is that in C++, read-write races are UB, whereas in LLVM they are well-defined but the read returns Undef. Add LLVM atomic memcpy intrinsics, expose in core/std #58599 might help here.
It relies on the validity invariant for integers to not rule out Undef. IOW, it relies on let x: u32 = mem::uninitialized() not being UB.

RalfJung · 2019-06-18T20:44:23Z

src/librustc_data_structures/sync.rs

+                old
+            }
+        }
+
        #[derive(Debug)]
        pub struct Atomic<T: Copy>(Cell<T>);


What is the difference between Atomic and AtomicCell? Neither of these types is described in the comment at the top of the file.

Oh I see, Atomic is just used here to define "fake" versions of AtomicBool and friends. Seems worth a comment that this is not actually public even though it is marked pub.
(It is not public in the sense that using it directly would lead to build failures in parallel rustc, if I understand correctly.)

(There still is no such comment that I can see.)

Added some comments here.

[WIP] Make dep node indices persistent between sessions This makes marking dep nodes green faster (and lock free in the case with no diagnostics). This change is split out from #60035. Unlike #60035 this makes loading the dep graph slower because it loads 2 copies of the dep graph, one immutable and one mutable. Based on #61845, #61779 and #61923.

Zoxc · 2019-06-22T20:22:18Z

@bors try

bors · 2019-06-22T20:22:24Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout dep-stream-prefix-2 (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self dep-stream-prefix-2 --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

Zoxc · 2019-06-22T20:27:12Z

@bors try

bors · 2019-06-22T20:27:23Z

⌛ Trying commit b76f9fe06f7e0d66f5df48b92d5fbc84e09c01b8 with merge 739ec977abef6de9ed58fcc2e0cc822138c7ceab...

bors · 2019-06-22T20:28:28Z

💔 Test failed - checks-travis

rust-highfive · 2019-06-22T20:28:29Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:0d3a6aa8
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
Cloning into 'rust-lang/rust'...
travis_time:end:0d3a6aa8:start=1561235299045578076,finish=1561235304535555566,duration=5489977490
$ cd rust-lang/rust
$ git checkout -qf 739ec977abef6de9ed58fcc2e0cc822138c7ceab
fatal: reference is not a tree: 739ec977abef6de9ed58fcc2e0cc822138c7ceab
The command "git checkout -qf 739ec977abef6de9ed58fcc2e0cc822138c7ceab" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

@eddyb

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

@eddyb

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

@eddyb

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

@eddyb

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

pnkfelix · 2019-07-10T09:22:48Z

src/librustc/dep_graph/graph.rs

@@ -1037,19 +1056,19 @@ impl CurrentDepGraph {
        fingerprint: Fingerprint
    ) -> DepNodeIndex {
        debug_assert!(!self.node_to_node_index.contains_key(&dep_node));
-        self.intern_node(dep_node, edges, fingerprint).0
+        self.intern_node(dep_node, edges, fingerprint)
    }

    fn intern_node(


can you add a comment above the fn intern_node signature, indicating what the bool in the return type represents?

The bool is removed, so no =P

src/librustc/dep_graph/graph.rs

pnkfelix · 2019-07-10T09:36:24Z

This PR seems reasonable to me. r=me once my nits and question from review are addressed.

Zoxc · 2019-07-10T15:07:31Z

@bors r=pnkfelix

bors · 2019-07-10T15:07:32Z

📌 Commit af339b1d3bc7ccb0e76d70536a2fa2ceef11a5d7 has been approved by pnkfelix

Zoxc · 2019-07-10T16:30:10Z

@bors r-

Zoxc · 2019-07-11T00:13:44Z

@bors r=pnkfelix

bors · 2019-07-11T00:13:45Z

📌 Commit 29e7bfd has been approved by pnkfelix

Zoxc · 2019-07-11T00:15:15Z

I moved the AtomicCell addition to #62577.

Prerequisites from dep graph refactoring rust-lang#2 Split out from rust-lang#60035 and overlaps with rust-lang#60559.

@ghost

Rollup of 7 pull requests Successful merges: - #61665 (core: check for pointer equality when comparing Eq slices) - #61923 (Prerequisites from dep graph refactoring #2) - #62270 (Move async-await tests from run-pass to ui) - #62425 (filedesc: don't use ioctl(FIOCLEX) on Linux) - #62476 (Continue refactoring macro expansion and resolution) - #62519 (Regression test for HRTB bug (issue 30786).) - #62557 (Fix typo in libcore/intrinsics.rs) Failed merges: r? @ghost

bors · 2019-07-11T08:13:11Z

⌛ Testing commit 29e7bfd with merge 6907005...

Add an AtomicCell abstraction Split out from rust-lang#61923.

rust-highfive assigned pnkfelix Jun 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2019

Zoxc force-pushed the dep-stream-prefix-2 branch from c55e1af to 81f89ad Compare June 18, 2019 02:15

Centril reviewed Jun 18, 2019

View reviewed changes

src/librustc_data_structures/sync.rs Outdated Show resolved Hide resolved

Zoxc force-pushed the dep-stream-prefix-2 branch from 81f89ad to 6c21ae2 Compare June 18, 2019 16:16

RalfJung reviewed Jun 18, 2019

View reviewed changes

Zoxc mentioned this pull request Jun 21, 2019

Make dep node indices persistent between sessions #62038

Closed

Zoxc force-pushed the dep-stream-prefix-2 branch from 6c21ae2 to b76f9fe Compare June 22, 2019 20:26

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2019

Zoxc mentioned this pull request Jul 1, 2019

Clean up inherent_impls #62268

Merged

Centril added a commit to Centril/rust that referenced this pull request Jul 1, 2019

Rollup merge of rust-lang#62268 - Zoxc:inherent_impls, r=eddyb

0783a2d

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62268 - Zoxc:inherent_impls, r=eddyb

510148b

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62268 - Zoxc:inherent_impls, r=eddyb

011a407

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62268 - Zoxc:inherent_impls, r=eddyb

1c667cc

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62268 - Zoxc:inherent_impls, r=eddyb

d7e42cc

Clean up inherent_impls Split out from rust-lang#61923. r? @eddyb

Zoxc force-pushed the dep-stream-prefix-2 branch from b76f9fe to dd4fa40 Compare July 5, 2019 11:04

pnkfelix reviewed Jul 10, 2019

View reviewed changes

src/librustc/dep_graph/graph.rs Outdated Show resolved Hide resolved

pnkfelix reviewed Jul 10, 2019

View reviewed changes

src/librustc/dep_graph/graph.rs Outdated Show resolved Hide resolved

Zoxc force-pushed the dep-stream-prefix-2 branch from dd4fa40 to af339b1 Compare July 10, 2019 15:05

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 10, 2019

Refactor diagnostic emission for green nodes

29e7bfd

Zoxc force-pushed the dep-stream-prefix-2 branch from af339b1 to 29e7bfd Compare July 11, 2019 00:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 11, 2019

Zoxc mentioned this pull request Jul 11, 2019

Add an AtomicCell abstraction #62577

Merged

Centril added a commit to Centril/rust that referenced this pull request Jul 11, 2019

Rollup merge of rust-lang#61923 - Zoxc:dep-stream-prefix-2, r=pnkfelix

618fc02

Prerequisites from dep graph refactoring rust-lang#2 Split out from rust-lang#60035 and overlaps with rust-lang#60559.

Centril mentioned this pull request Jul 11, 2019

Rollup of 7 pull requests #62580

Merged

bors merged commit 29e7bfd into rust-lang:master Jul 11, 2019

Zoxc deleted the dep-stream-prefix-2 branch July 11, 2019 15:44

Centril added a commit to Centril/rust that referenced this pull request Jul 13, 2019

Rollup merge of rust-lang#62577 - Zoxc:atomic-cell, r=matthewjasper

5e1891c

Add an AtomicCell abstraction Split out from rust-lang#61923.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prerequisites from dep graph refactoring #2 #61923

Prerequisites from dep graph refactoring #2 #61923

Zoxc commented Jun 18, 2019

rust-highfive commented Jun 18, 2019

Centril commented Jun 18, 2019

rust-highfive commented Jun 18, 2019

RalfJung commented Jun 18, 2019

Centril commented Jun 18, 2019

RalfJung commented Jun 18, 2019 •

edited

Loading

RalfJung Jun 18, 2019 •

edited

Loading

RalfJung Jun 18, 2019

RalfJung Jul 10, 2019

Zoxc Jul 10, 2019

Zoxc commented Jun 22, 2019

bors commented Jun 22, 2019

Zoxc commented Jun 22, 2019

bors commented Jun 22, 2019

bors commented Jun 22, 2019

rust-highfive commented Jun 22, 2019

pnkfelix Jul 10, 2019

Zoxc Jul 10, 2019

pnkfelix commented Jul 10, 2019 •

edited

Loading

Zoxc commented Jul 10, 2019

bors commented Jul 10, 2019

Zoxc commented Jul 10, 2019

Zoxc commented Jul 11, 2019

bors commented Jul 11, 2019

Zoxc commented Jul 11, 2019

bors commented Jul 11, 2019

Prerequisites from dep graph refactoring #2 #61923

Prerequisites from dep graph refactoring #2 #61923

Conversation

Zoxc commented Jun 18, 2019

rust-highfive commented Jun 18, 2019

Centril commented Jun 18, 2019

rust-highfive commented Jun 18, 2019

RalfJung commented Jun 18, 2019

Centril commented Jun 18, 2019

RalfJung commented Jun 18, 2019 • edited Loading

RalfJung Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

RalfJung Jun 18, 2019

Choose a reason for hiding this comment

RalfJung Jul 10, 2019

Choose a reason for hiding this comment

Zoxc Jul 10, 2019

Choose a reason for hiding this comment

Zoxc commented Jun 22, 2019

bors commented Jun 22, 2019

Zoxc commented Jun 22, 2019

bors commented Jun 22, 2019

bors commented Jun 22, 2019

rust-highfive commented Jun 22, 2019

pnkfelix Jul 10, 2019

Choose a reason for hiding this comment

Zoxc Jul 10, 2019

Choose a reason for hiding this comment

pnkfelix commented Jul 10, 2019 • edited Loading

Zoxc commented Jul 10, 2019

bors commented Jul 10, 2019

Zoxc commented Jul 10, 2019

Zoxc commented Jul 11, 2019

bors commented Jul 11, 2019

Zoxc commented Jul 11, 2019

bors commented Jul 11, 2019

RalfJung commented Jun 18, 2019 •

edited

Loading

RalfJung Jun 18, 2019 •

edited

Loading

pnkfelix commented Jul 10, 2019 •

edited

Loading