Rollup of 6 pull requests #61105
Merged
Rollup of 6 pull requests #61105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds notes pointing at the non-nullary variants, and uses "custom discriminant" language to be consistent with the Reference.
…ect_lifetime_defaults_map
…d_lang_items, missing_lang_items, postorder_cnums and maybe_unused_extern_crates
…avis Suggest dereferencing on assignment to mutable borrow Fix rust-lang#33570
…=estebank tweak discriminant on non-nullary enum diagnostic Adds notes pointing at the non-nullary variants, and uses "custom discriminant" language to be consistent with the Reference. Fixes rust-lang#61039. r? @estebank
fix dangling reference in Vec::append Turns out I forgot to enable Miri again for the Vec tests. And there was a dangling reference hiding in there! `get_unchecked_mut` is UB to call on an empty vector (there is no memory to get a reference to), and yet this code did it.
Box::into_unique: do the reborrow-to-raw *after* destroying the Box Currently we first "reborrow" the box to a raw pointer, and then `forget` it. When tracking raw pointers more strictly (something I am experimenting with locally in Miri), the "use" induced by passing the box to `forget` invalidates the previously created raw pointer. So adjust my hack from rust-lang#58429 to reorder the two operations.
…oop, r=estebank Fix overflowing literal lint in loops Fixes rust-lang#60459. r? @estebank
|
@bors r+ p=6 rollup=never |
|
📌 Commit 92fda92 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 92fda92 with merge e447304dfb00505ac0f2c4accb339d1a2f0eb6a9... |
|
💔 Test failed - checks-travis |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 24, 2019
Rollup of 6 pull requests Successful merges: - #59545 (Use arenas to avoid Lrc in queries #2) - #61054 (Suggest dereferencing on assignment to mutable borrow) - #61056 (tweak discriminant on non-nullary enum diagnostic) - #61082 (fix dangling reference in Vec::append) - #61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box) - #61098 (Fix overflowing literal lint in loops) Failed merges: r? @ghost
|
☀️ Test successful - checks-travis, status-appveyor |
|
📣 Toolstate changed by #61105! Tested on commit fd8e23c. 🎉 edition-guide on windows: test-fail → test-pass (cc @ehuss @Centril @steveklabnik, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 24, 2019
Tested on commit rust-lang/rust@fd8e23c. Direct link to PR: <rust-lang/rust#61105> 🎉 edition-guide on windows: test-fail → test-pass (cc @ehuss @Centril @steveklabnik, @rust-lang/infra). 🎉 edition-guide on linux: test-fail → test-pass (cc @ehuss @Centril @steveklabnik, @rust-lang/infra).
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost