Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dangling reference in Vec::append #61082

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
5 participants
@RalfJung
Copy link
Member

commented May 23, 2019

Turns out I forgot to enable Miri again for the Vec tests. And there was a dangling reference hiding in there! get_unchecked_mut is UB to call on an empty vector (there is no memory to get a reference to), and yet this code did it.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

commented May 23, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

📌 Commit f44b264 has been approved by alexcrichton

@Centril

This comment has been minimized.

Copy link
Member

commented May 23, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request May 23, 2019

Rollup merge of rust-lang#61082 - RalfJung:vec, r=alexcrichton
fix dangling reference in Vec::append

Turns out I forgot to enable Miri again for the Vec tests. And there was a dangling reference hiding in there!  `get_unchecked_mut` is UB to call on an empty vector (there is no memory to get a reference to), and yet this code did it.

bors added a commit that referenced this pull request May 23, 2019

Auto merge of #61105 - Centril:rollup-t9lemjf, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59545 (Use arenas to avoid Lrc in queries #2)
 - #61054 (Suggest dereferencing on assignment to mutable borrow)
 - #61056 (tweak discriminant on non-nullary enum diagnostic)
 - #61082 (fix dangling reference in Vec::append)
 - #61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box)
 - #61098 (Fix overflowing literal lint in loops)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 24, 2019

Auto merge of #61105 - Centril:rollup-t9lemjf, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59545 (Use arenas to avoid Lrc in queries #2)
 - #61054 (Suggest dereferencing on assignment to mutable borrow)
 - #61056 (tweak discriminant on non-nullary enum diagnostic)
 - #61082 (fix dangling reference in Vec::append)
 - #61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box)
 - #61098 (Fix overflowing literal lint in loops)

Failed merges:

r? @ghost

@bors bors merged commit f44b264 into rust-lang:master May 24, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.