Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflowing literal lint in loops #61098

Merged
merged 3 commits into from May 24, 2019

Conversation

Projects
None yet
7 participants
@varkor
Copy link
Member

commented May 23, 2019

Fixes #60459.

r? @estebank

@estebank

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Add test for for _ in 0..256u8 {} and r=me

@varkor

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

Can't believe I forgot the test itself...

@bors r=estebank

@bors

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

📌 Commit 12de24c has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request May 23, 2019

Rollup merge of rust-lang#61098 - varkor:fix-overflowing-literal-in-l…
…oop, r=estebank

Fix overflowing literal lint in loops

Fixes rust-lang#60459.

r? @estebank

bors added a commit that referenced this pull request May 23, 2019

Auto merge of #61105 - Centril:rollup-t9lemjf, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59545 (Use arenas to avoid Lrc in queries #2)
 - #61054 (Suggest dereferencing on assignment to mutable borrow)
 - #61056 (tweak discriminant on non-nullary enum diagnostic)
 - #61082 (fix dangling reference in Vec::append)
 - #61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box)
 - #61098 (Fix overflowing literal lint in loops)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 24, 2019

Auto merge of #61105 - Centril:rollup-t9lemjf, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #59545 (Use arenas to avoid Lrc in queries #2)
 - #61054 (Suggest dereferencing on assignment to mutable borrow)
 - #61056 (tweak discriminant on non-nullary enum diagnostic)
 - #61082 (fix dangling reference in Vec::append)
 - #61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box)
 - #61098 (Fix overflowing literal lint in loops)

Failed merges:

r? @ghost

@bors bors merged commit 12de24c into rust-lang:master May 24, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ehuss ehuss referenced this pull request May 28, 2019

Merged

[beta] Rollup backports #61283

@pnkfelix

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

discussed in T-compiler meeting. Accepted for backport to beta channel.

bors added a commit that referenced this pull request Jun 6, 2019

Auto merge of #61602 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 🐟 🍨 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost

bors added a commit that referenced this pull request Jun 7, 2019

Auto merge of #61602 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 🐟 🍨 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost

bors added a commit that referenced this pull request Jun 7, 2019

Auto merge of #61602 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 🐟 🍨 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.