Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn turbo 馃悷 馃崹 into an error #61189

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
7 participants
@oli-obk
Copy link
Contributor

commented May 25, 2019

Master branch part of #60989

r? @varkor

@varkor

This comment has been minimized.

Copy link
Member

commented May 25, 2019

r=me when Travis passes.

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

@bors r=varkor

@bors

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

馃搶 Commit a15df94 has been approved by varkor

Centril added a commit to Centril/rust that referenced this pull request May 26, 2019

Rollup merge of rust-lang#61189 - oli-obk:turbofish_ice, r=varkor
Turn turbo 馃悷 馃崹 into an error

Master branch part of rust-lang#60989

r? @varkor

bors added a commit that referenced this pull request May 26, 2019

Auto merge of #61201 - Centril:rollup-975knrk, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #61087 (Tweak `self` arg not as first argument of a method diagnostic)
 - #61114 (Vec: avoid creating slices to the elements)
 - #61144 (Suggest borrowing for loop head on move error)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)
 - #61173 (Auto-derive Encode and Decode implementations of DefPathTable)
 - #61184 (Add additional trace statements to the const propagator)
 - #61189 (Turn turbo 馃悷 馃崹 into an error)
 - #61193 (Add comment to explain why we change the layout for Projection)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 26, 2019

Auto merge of #61201 - Centril:rollup-975knrk, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #61087 (Tweak `self` arg not as first argument of a method diagnostic)
 - #61114 (Vec: avoid creating slices to the elements)
 - #61144 (Suggest borrowing for loop head on move error)
 - #61149 (Fix spelling in release notes)
 - #61161 (MaybeUninit doctest: remove unnecessary type ascription)
 - #61173 (Auto-derive Encode and Decode implementations of DefPathTable)
 - #61184 (Add additional trace statements to the const propagator)
 - #61189 (Turn turbo 馃悷 馃崹 into an error)
 - #61193 (Add comment to explain why we change the layout for Projection)

Failed merges:

r? @ghost

@bors bors merged commit a15df94 into rust-lang:master May 26, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Nominating for stable backport. The backport already exists in #61208 (since this PR does not apply cleanly to stable)

@oli-obk oli-obk deleted the oli-obk:turbofish_ice branch May 26, 2019

@pnkfelix

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

discussed in T-compiler meeting. accepted for backport to beta and stable channels.

bors added a commit that referenced this pull request Jun 6, 2019

Auto merge of #61602 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 馃悷 馃崹 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost

bors added a commit that referenced this pull request Jun 7, 2019

Auto merge of #61602 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 馃悷 馃崹 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost

bors added a commit that referenced this pull request Jun 7, 2019

Auto merge of #61602 - pietroalbini:beta-rollup, r=pietroalbini
[beta] Rollup backports

Rolled up:

* [beta] Permit unwinding through FFI by default #61569

Cherry-picked:

* upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802
* Fix overflowing literal lint in loops #61098
* Revert edition-guide toolstate override #61110
* Turn turbo 馃悷 馃崹 into an error #61189
* Bump hashbrown to 0.4.0 #61388
* Fix regression 61475 #61500

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Discussed on T-release meeting; declining point release for now based on sum-total of stable-accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.