Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #61307

Closed
wants to merge 12 commits into from
Closed

Rollup of 4 pull requests #61307

wants to merge 12 commits into from

Commits on May 25, 2019

  1. Do not ICE on missing access place description during mutability erro… 

    …r reporting
    @estebank
    estebank committed May 25, 2019
    Configuration menu
    Copy the full SHA
    4890ae2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. Probe for CompilerDesugaringKind::Async argument

    @estebank
    estebank committed May 26, 2019
    Configuration menu
    Copy the full SHA
    285064c View commit details
    Browse the repository at this point in the history

  2. Move tests to async-await directory

    @estebank
    estebank committed May 26, 2019
    Configuration menu
    Copy the full SHA
    025a559 View commit details
    Browse the repository at this point in the history

  3. Account for short-hand init structs when suggesting conversion

    @estebank
    estebank committed May 26, 2019
    Configuration menu
    Copy the full SHA
    24b2e20 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. librustc_errors: Move annotation collection to own impl 

    Extracted from work on rust-lang#59346. This moves the annotation collection to
the `FileWithAnnotatedLines` impl to allow re-use in a separate
EmitterWriter.
    @phansch
    phansch committed May 28, 2019
    Configuration menu
    Copy the full SHA
    96e3fb2 View commit details
    Browse the repository at this point in the history

  2. is_union returns ty to avoid computing it twice

    @spastorino
    spastorino committed May 28, 2019
    Configuration menu
    Copy the full SHA
    1b86bd7 View commit details
    Browse the repository at this point in the history

  3. Use closure to avoid self.describe_place(...).unwrap_or_else(...) rep… 

    …etition
    @spastorino
    spastorino committed May 28, 2019
    Configuration menu
    Copy the full SHA
    bb94fc0 View commit details
    Browse the repository at this point in the history

  4. review comment: tweak error wording

    @estebank
    estebank committed May 28, 2019
    Configuration menu
    Copy the full SHA
    d72f97d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Rollup merge of rust-lang#61191 - phansch:annotate_snippet_refactorin… 

    …gs1, r=estebank

librustc_errors: Move annotation collection to own impl

Extracted from work on rust-lang#59346. This moves the annotation collection to
the `FileWithAnnotatedLines` impl to allow easier re-use in a separate
EmitterWriter. Even without that new EmitterWriter present, I think it makes
sense to have this as an associated function.
    @Centril
    Centril committed May 29, 2019
    Configuration menu
    Copy the full SHA
    06afdac View commit details
    Browse the repository at this point in the history

  2. Rollup merge of rust-lang#61192 - estebank:issue-61187, r=oli-obk 

    Do not ICE on missing access place description during mutability error reporting

Fix rust-lang#61187.
    @Centril
    Centril committed May 29, 2019
    Configuration menu
    Copy the full SHA
    b397f2d View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#61217 - estebank:issue-52820, r=Centril 

    Account for short-hand init structs when suggesting conversion

Fix rust-lang#52820.
    @Centril
    Centril committed May 29, 2019
    Configuration menu
    Copy the full SHA
    5579f01 View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#61261 - spastorino:is-union-return-ty, r=ol… 

    …i-obk

is_union returns ty to avoid computing it twice

r? @oli-obk
    @Centril
    Centril committed May 29, 2019
    Configuration menu
    Copy the full SHA
    b621757 View commit details
    Browse the repository at this point in the history