Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slice const generic length display #61605

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

GuillaumeGomez
Copy link
Member

Fixes #61487.

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2019
@varkor
Copy link
Member

varkor commented Jun 6, 2019

r=me when Travis passes.

We should probably have a folder src/test/rustdoc/const-generics if we don't already, but that can be done in a separate PR.

@GuillaumeGomez
Copy link
Member Author

We actually have one. Want me to move the test inside it?

@varkor
Copy link
Member

varkor commented Jun 7, 2019

That would be good, thanks.

@GuillaumeGomez
Copy link
Member Author

Moved the test.

@varkor
Copy link
Member

varkor commented Jun 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jun 7, 2019

📌 Commit 8f37537 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 7, 2019
…y, r=varkor

Fix slice const generic length display

Fixes rust-lang#61487.

r? @varkor
bors added a commit that referenced this pull request Jun 7, 2019
Rollup of 7 pull requests

Successful merges:

 - #61332 (Remove asterisk suggestion for move errors in borrowck)
 - #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref)
 - #61586 (ci: Disable LLVM/debug assertions for asmjs builder)
 - #61599 (libcore/pin: Minor grammar corrections for module documentation)
 - #61603 (Increases heap size available during testing for SGX)
 - #61605 (Fix slice const generic length display)
 - #61618 (make the backtrace field of EvalError private)

Failed merges:

r? @ghost
@bors bors merged commit 8f37537 into rust-lang:master Jun 7, 2019
@GuillaumeGomez GuillaumeGomez deleted the const-generic-display branch June 7, 2019 19:00
@varkor varkor added the F-const_generics `#![feature(const_generics)]` label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-const_generics `#![feature(const_generics)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc generic array impl doesnt show length
4 participants