ci: Disable LLVM/debug assertions for asmjs builder #61586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shaves of 50 minutes of cycle time on Azure and will likely also save a significant chunk of time on Travis. The assertions here aren't really buying us much over other builders with assertions already enabled, so let's disable them for this builder. cc rust-lang#61185
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
LLVM assertions for asmjs (but not debug assertions) seem potentially valuable, as this target is quite different from all the others (different LLVM version, no standard codegen backend). |
|
It's true! It's largely a question of whether we have budget for all the assertions though. We sort of don't at this point in the sense that it's taking so long on Azure, and so I think we'll need to rely on finding bugs via other means. Ideally we'd run all the assertions everywhere all the time, but our CI is already quite intensive so we can't :( |
|
@bors r+ rollup |
|
📌 Commit 7d1f762 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 7, 2019
…=pietroalbini ci: Disable LLVM/debug assertions for asmjs builder This shaves of 50 minutes of cycle time on Azure and will likely also save a significant chunk of time on Travis. The assertions here aren't really buying us much over other builders with assertions already enabled, so let's disable them for this builder. cc rust-lang#61185
bors
added a commit
that referenced
this pull request
Jun 7, 2019
Rollup of 4 pull requests Successful merges: - #61332 (Remove asterisk suggestion for move errors in borrowck) - #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref) - #61586 (ci: Disable LLVM/debug assertions for asmjs builder) - #61599 (libcore/pin: Minor grammar corrections for module documentation) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 7, 2019
…=pietroalbini ci: Disable LLVM/debug assertions for asmjs builder This shaves of 50 minutes of cycle time on Azure and will likely also save a significant chunk of time on Travis. The assertions here aren't really buying us much over other builders with assertions already enabled, so let's disable them for this builder. cc rust-lang#61185
bors
added a commit
that referenced
this pull request
Jun 7, 2019
Rollup of 7 pull requests Successful merges: - #61332 (Remove asterisk suggestion for move errors in borrowck) - #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref) - #61586 (ci: Disable LLVM/debug assertions for asmjs builder) - #61599 (libcore/pin: Minor grammar corrections for module documentation) - #61603 (Increases heap size available during testing for SGX) - #61605 (Fix slice const generic length display) - #61618 (make the backtrace field of EvalError private) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shaves of 50 minutes of cycle time on Azure and will likely also
save a significant chunk of time on Travis. The assertions here aren't
really buying us much over other builders with assertions already
enabled, so let's disable them for this builder.
cc #61185