Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x.py install #61750

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Fix x.py install #61750

merged 1 commit into from
Jun 13, 2019

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Jun 11, 2019

Make sure we look for save analysis in the right place. Fixes #61703.

r? @Mark-Simulacrum
cc @petrhosek @cramertj

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2019
Make sure we look for save analysis in the right place. Fixes rust-lang#61703.
@Mark-Simulacrum
Copy link
Member

I'm not confident this is in fact the right change (i.e., maybe we should instead be uplifting save-analysis data), but since I do think it'll work let's go for it, we can always change it later if it should become necessary.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 12, 2019

📌 Commit 4f3cd3c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
Fix x.py install

Make sure we look for save analysis in the right place. Fixes rust-lang#61703.

r? @Mark-Simulacrum
cc @petrhosek @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
Fix x.py install

Make sure we look for save analysis in the right place. Fixes rust-lang#61703.

r? @Mark-Simulacrum
cc @petrhosek @cramertj
bors added a commit that referenced this pull request Jun 13, 2019
Rollup of 9 pull requests

Successful merges:

 - #60376 (Stabilize Option::xor)
 - #61398 (Stabilize copy_within)
 - #61629 (Hygienize macros in the standard library)
 - #61675 (Include frame pointer for bare metal RISC-V targets)
 - #61750 (Fix x.py install)
 - #61761 (Add an alias for x86_64-sun-solaris target tuple)
 - #61762 (rustbuild: fix libtest_stamp)
 - #61763 (ci: fix ci stats upload condition)
 - #61776 (Fix typos in error_codes)

Failed merges:

r? @ghost
@bors bors merged commit 4f3cd3c into rust-lang:master Jun 13, 2019
@tmandry tmandry deleted the fix-install branch June 13, 2019 22:49
@o01eg
Copy link
Contributor

o01eg commented Jun 16, 2019

It is related to #61435 ?

@tmandry
Copy link
Member Author

tmandry commented Jun 17, 2019

@o01eg Looking at the error log in that issue, I suspect #61703 may have been a dupe of it and this fixes both. But I don't understand what the "missing-tools" bit is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dist analysis step panics when trying to copy save-analysis
5 participants