Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Option::xor #60376

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
@lzutao
Copy link
Contributor

commented Apr 29, 2019

FCP done in #50512 (comment) .

Closes #50512 .

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@lzutao

This comment was marked as resolved.

Copy link
Contributor Author

commented Apr 29, 2019

@rustbot modify labels to +T-libs

@rustbot

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

Error: Label relnotes can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@rustbot rustbot added the T-libs label Apr 29, 2019

@jonas-schievink jonas-schievink added this to the 1.36 milestone Apr 29, 2019

@lzutao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

FCP completed but @Amanieu and @withoutboats expressed doubts so I'm going to r? @Amanieu for final approval.

@lzutao

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Are there any updates from libs team?

@lzutao

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Hi, is there any update yet?

@Centril

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Would love to see this stabilized. I do think it brings clarity and ergonomics to the "I have several incompatible options, select one of them but only if that's the only one given"-usecase. I've hit that before when working on proc macro implementations.

@taiki-e

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

@Centril

I do think it brings clarity and ergonomics to the "I have several incompatible options, select one of them but only if that's the only one given"-usecase.

If I understand correctly, Option::xor can only be used if there are two options in this use-case.

@Centril

This comment has been minimized.

Copy link
Member

commented May 18, 2019

If I understand correctly, Option::xor can only be used if there are two options in this use-case.

@taiki-e Yeah that's true; In my cases I only had two options.

@lzutao lzutao force-pushed the lzutao:stabilize-option_xor branch from c72a5d4 to da56758 May 27, 2019

@lzutao

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

@Amanieu Does the lib team have any updates?

@Centril Centril modified the milestones: 1.36, 1.37 May 27, 2019

@lzutao lzutao force-pushed the lzutao:stabilize-option_xor branch from da56758 to 1fa50b3 Jun 5, 2019

@lzutao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Spamming ping @Amanieu .

@SimonSapin

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Per FCP:

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

📌 Commit 1fa50b3 has been approved by SimonSapin

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019

bors added a commit that referenced this pull request Jun 12, 2019

Auto merge of #61783 - Centril:rollup-r5u53z7, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #60376 (Stabilize Option::xor)
 - #61398 (Stabilize copy_within)
 - #61629 (Hygienize macros in the standard library)
 - #61675 (Include frame pointer for bare metal RISC-V targets)
 - #61750 (Fix x.py install)
 - #61757 (Deprecate ONCE_INIT)
 - #61762 (rustbuild: fix libtest_stamp)
 - #61763 (ci: fix ci stats upload condition)
 - #61771 (Update cargo)
 - #61776 (Fix typos in error_codes)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019

bors added a commit that referenced this pull request Jun 13, 2019

Auto merge of #61789 - Centril:rollup-hhyvopq, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #60376 (Stabilize Option::xor)
 - #61398 (Stabilize copy_within)
 - #61629 (Hygienize macros in the standard library)
 - #61675 (Include frame pointer for bare metal RISC-V targets)
 - #61750 (Fix x.py install)
 - #61761 (Add an alias for x86_64-sun-solaris target tuple)
 - #61762 (rustbuild: fix libtest_stamp)
 - #61763 (ci: fix ci stats upload condition)
 - #61776 (Fix typos in error_codes)

Failed merges:

r? @ghost

@bors bors merged commit 1fa50b3 into rust-lang:master Jun 13, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@lzutao lzutao deleted the lzutao:stabilize-option_xor branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.