Update the rust-installer submodule
#62153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 722cfc4 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
What's the impact on compression ratio? We took pains to order files such that similar files are close to each other, to hopefully enable more compression opportunities. That might be over-engineered, but I imagine some of this will be lost if it's now splitting the stream out to separate threads. |
|
Randomly testing https://static.rust-lang.org/dist/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz the difference is: so it looks like it does increase sizes slightly, but not too much? |
|
Wow, that's less than 1% increase -- seems totally fine to me! |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 29, 2019
…ark-Simulacrum Update the `rust-installer` submodule This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 29, 2019
…ark-Simulacrum Update the `rust-installer` submodule This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 3, 2019
…ark-Simulacrum Update the `rust-installer` submodule This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
Mark-Simulacrum
force-pushed
the
parallel-compress
branch
from
722cfc4
to
f5b2541
Compare
|
@bors r+ p=1 This should improve CI times a little, so let's bump it's priority up. |
|
📌 Commit f5b2541 has been approved by |
|
⌛ Testing commit f5b2541 with merge cc358a793c40852d72913f0c70cfa2417887ec56... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
…ark-Simulacrum Update the `rust-installer` submodule This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
|
@bors retry rolled up. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
…ark-Simulacrum Update the `rust-installer` submodule This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
|
@bors retry rolled up. |
|
⌛ Testing commit f5b2541 with merge 44173d97041969fa3607ed277cbd9923287fae0d... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
…ark-Simulacrum Update the `rust-installer` submodule This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Jul 3, 2019
Rollup of 17 pull requests Successful merges: - #62039 (Remove needless lifetimes (rustc)) - #62153 (Update the `rust-installer` submodule) - #62173 (rename InterpretCx -> InterpCx) - #62240 (wfcheck: resolve the type-vars in `AdtField` types) - #62249 (Use mem::take instead of mem::replace with default) - #62252 (Update mem::replace example to not be identical to mem::take) - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser) - #62268 (Clean up inherent_impls) - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind) - #62295 (miri realloc: do not require giving old size+align) - #62297 (refactor check_for_substitution) - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.) - #62317 (Migrate `compile-pass` annotations to `build-pass`) - #62337 (Fix bucket in CPU usage script) - #62344 (simplify Option::get_or_insert) - #62346 (enable a few more tests in Miri and update the comment for others) - #62351 (remove bogus example from drop_in_place) Failed merges: r? @ghost
|
⌛ Testing commit f5b2541 with merge ddfdb9f34d123cd02a15d6dd5e29d5a870aa4cfc... |
|
Failed in #62354 (comment), @bors r- retry |
bors
added
S-waiting-on-author
This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
alexcrichton
force-pushed
the
parallel-compress
branch
from
f5b2541
to
2fb2e00
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit 2fb2e00 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 4, 2019
Update the `rust-installer` submodule This pulls in a commit which uses parallel xz encoding which should hopefully help shave some time off the dist builders which spend an inordinate amount of time compressing this data.
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.