Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bogus example from drop_in_place #62351

Merged
merged 1 commit into from
Jul 4, 2019
Merged

remove bogus example from drop_in_place #62351

merged 1 commit into from
Jul 4, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 3, 2019

Fixes #62313

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2019
This was referenced Jul 3, 2019
Closed
Merged
@cramertj
Copy link
Member

cramertj commented Jul 3, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2019

📌 Commit 6225607 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2019
@cramertj
Copy link
Member

cramertj commented Jul 3, 2019

r? @cramertj

@rust-highfive rust-highfive assigned cramertj and unassigned shepmaster Jul 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
@Centril
Rollup merge of rust-lang#62351 - RalfJung:drop-in-place, r=cramertj
2eebc8c 
remove bogus example from drop_in_place

Fixes rust-lang#62313
@Centril Centril mentioned this pull request Jul 3, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Jul 3, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
@Centril
Rollup merge of rust-lang#62351 - RalfJung:drop-in-place, r=cramertj
667904f 
remove bogus example from drop_in_place

Fixes rust-lang#62313
@Centril Centril mentioned this pull request Jul 3, 2019
Closed
bors added a commit that referenced this pull request Jul 3, 2019
@bors
Auto merge of #62354 - Centril:rollup-04ya07k, r=Centril
430069f 
Rollup of 17 pull requests

Successful merges:

 - #62039 (Remove needless lifetimes (rustc))
 - #62153 (Update the `rust-installer` submodule)
 - #62173 (rename InterpretCx -> InterpCx)
 - #62240 (wfcheck: resolve the type-vars in `AdtField` types)
 - #62249 (Use mem::take instead of mem::replace with default)
 - #62252 (Update mem::replace example to not be identical to mem::take)
 - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser)
 - #62268 (Clean up inherent_impls)
 - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind)
 - #62295 (miri realloc: do not require giving old size+align)
 - #62297 (refactor check_for_substitution)
 - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.)
 - #62317 (Migrate `compile-pass` annotations to `build-pass`)
 - #62337 (Fix bucket in CPU usage script)
 - #62344 (simplify Option::get_or_insert)
 - #62346 (enable a few more tests in Miri and update the comment for others)
 - #62351 (remove bogus example from drop_in_place)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
@Centril
Rollup merge of rust-lang#62351 - RalfJung:drop-in-place, r=cramertj
6363a58 
remove bogus example from drop_in_place

Fixes rust-lang#62313
@Centril Centril mentioned this pull request Jul 3, 2019
Merged
bors added a commit that referenced this pull request Jul 3, 2019
@bors
Auto merge of #62355 - Centril:rollup-xnxtcgm, r=Centril
b43eb42 
Rollup of 16 pull requests

Successful merges:

 - #62039 (Remove needless lifetimes (rustc))
 - #62173 (rename InterpretCx -> InterpCx)
 - #62240 (wfcheck: resolve the type-vars in `AdtField` types)
 - #62249 (Use mem::take instead of mem::replace with default)
 - #62252 (Update mem::replace example to not be identical to mem::take)
 - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser)
 - #62268 (Clean up inherent_impls)
 - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind)
 - #62295 (miri realloc: do not require giving old size+align)
 - #62297 (refactor check_for_substitution)
 - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.)
 - #62317 (Migrate `compile-pass` annotations to `build-pass`)
 - #62337 (Fix bucket in CPU usage script)
 - #62344 (simplify Option::get_or_insert)
 - #62346 (enable a few more tests in Miri and update the comment for others)
 - #62351 (remove bogus example from drop_in_place)

Failed merges:

r? @ghost
@bors bors merged commit 6225607 into rust-lang:master Jul 4, 2019
@RalfJung RalfJung deleted the drop-in-place branch July 6, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting documentation on the alignment requirements for ptr::copy
6 participants
@RalfJung @rust-highfive @cramertj @bors @Centril @shepmaster