Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "see issue" consistent #63008

Open
wants to merge 3 commits into
base: master
from

Conversation

@eupn
Copy link
Contributor

commented Jul 26, 2019

Fixes #62976. h/t to @punitkoura for initial patterns search.

r? @varkor

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T12:39:36.9073318Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T12:39:36.9272311Z ##[command]git config gc.auto 0
2019-07-26T12:39:36.9376620Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T12:39:36.9452394Z ##[command]git config --get-all http.proxy
2019-07-26T12:39:36.9595336Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63008/merge:refs/remotes/pull/63008/merge
---
2019-07-26T12:40:11.8874211Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T12:40:11.8874395Z 
2019-07-26T12:40:11.8874783Z   git checkout -b <new-branch-name>
2019-07-26T12:40:11.8875200Z 
2019-07-26T12:40:11.8875381Z HEAD is now at 296179e14 Merge 0ba3bff8923d9bc31e8a5e917c11a2a53036ccdf into 4268e7ee22935f086b856ef0063a9e22b49aeddb
2019-07-26T12:40:11.9005455Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T12:40:11.9008397Z ==============================================================================
2019-07-26T12:40:11.9008458Z Task         : Bash
2019-07-26T12:40:11.9008527Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T13:40:52.8811476Z .................................................................................................... 200/5862
2019-07-26T13:40:57.2782500Z .................................................................................................... 300/5862
2019-07-26T13:41:01.2081619Z .................................................................................................... 400/5862
2019-07-26T13:41:05.1601215Z .................................................................................................... 500/5862
2019-07-26T13:41:09.1771683Z ........................................................................i........................... 600/5862
2019-07-26T13:41:18.4670994Z .................................................................................................... 800/5862
2019-07-26T13:41:24.3441610Z .................................................................................................... 900/5862
2019-07-26T13:41:29.5900537Z .................................................................................................... 1000/5862
2019-07-26T13:41:29.5900537Z .................................................................................................... 1000/5862
2019-07-26T13:41:35.3830533Z i...........i....................................................................................... 1100/5862
2019-07-26T13:41:39.4898762Z ..............................iiiii................................................................. 1200/5862
2019-07-26T13:41:45.8028525Z .................................................................................................... 1400/5862
2019-07-26T13:41:48.6132659Z .................................................................................................... 1500/5862
2019-07-26T13:41:52.3551086Z .................................................................................................... 1600/5862
2019-07-26T13:41:55.0718305Z .................................................................................................... 1700/5862
2019-07-26T13:41:55.0718305Z .................................................................................................... 1700/5862
2019-07-26T13:41:58.5409456Z ......................................................................i............................. 1800/5862
2019-07-26T13:42:07.2460466Z .................................................................................................... 2000/5862
2019-07-26T13:42:11.6525738Z .................................................................................................... 2100/5862
2019-07-26T13:42:15.5276616Z .................................................................................................... 2200/5862
2019-07-26T13:42:15.5276616Z .................................................................................................... 2200/5862
2019-07-26T13:42:19.5851021Z ......................................................i............................................. 2300/5862
2019-07-26T13:42:29.8702179Z .................................................................................................... 2500/5862
2019-07-26T13:42:34.2370935Z .................................................................................................... 2600/5862
2019-07-26T13:42:39.7189906Z .................................................................................................... 2700/5862
2019-07-26T13:42:43.7644672Z .................................................................................................... 2800/5862
2019-07-26T13:42:43.7644672Z .................................................................................................... 2800/5862
2019-07-26T13:42:48.4162565Z .................................................................................................... 2900/5862
2019-07-26T13:42:54.0230791Z .................................................................................................... 3000/5862
2019-07-26T13:42:58.6391164Z .................................................................................................... 3100/5862
2019-07-26T13:43:04.2037337Z .................................................................................................... 3200/5862
2019-07-26T13:43:07.9011353Z .................................................................................................... 3300/5862
2019-07-26T13:43:11.7991120Z .................................................................................................... 3400/5862
2019-07-26T13:43:17.1227526Z .................................................................................................... 3500/5862
2019-07-26T13:43:21.0488700Z .....................i.............................................................................. 3600/5862
2019-07-26T13:43:25.5116915Z .................................................................................................ii. 3700/5862
2019-07-26T13:43:29.4504289Z ..i..ii............................................................................................. 3800/5862
2019-07-26T13:43:38.5800957Z .................................................................................................... 4000/5862
2019-07-26T13:43:38.5800957Z .................................................................................................... 4000/5862
2019-07-26T13:43:42.7130538Z ................ii.................................................................................. 4100/5862
2019-07-26T13:43:44.9233757Z .....................................i.............................................................. 4200/5862
2019-07-26T13:43:47.1386553Z .................................................................................................... 4300/5862
2019-07-26T13:43:49.5626952Z ......i............................................................................................. 4400/5862
2019-07-26T13:44:12.3209228Z .................................................................................................... 4600/5862
2019-07-26T13:44:16.2092893Z .................................................................................................... 4700/5862
2019-07-26T13:44:20.0440435Z .................................................................................................... 4800/5862
2019-07-26T13:44:24.9495590Z .................................................................................................... 4900/5862
---
2019-07-26T13:44:59.4397567Z .................................................................................................... 5500/5862
2019-07-26T13:45:04.0764855Z .................................................................................................... 5600/5862
2019-07-26T13:45:07.3171654Z .................................................................................................... 5700/5862
2019-07-26T13:45:10.5369927Z .................................................................................................... 5800/5862
2019-07-26T13:45:12.8421574Z ..i...........................................................
2019-07-26T13:45:12.8423714Z 
2019-07-26T13:45:12.8494576Z  finished in 276.630
2019-07-26T13:45:12.8694863Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:45:13.1028595Z 
2019-07-26T13:45:13.1028595Z 
2019-07-26T13:45:13.1028901Z running 2907 tests
2019-07-26T13:45:29.3874342Z .................................................................................................... 100/2907
2019-07-26T13:45:45.6292850Z ..............................................................................i..................... 200/2907
2019-07-26T13:46:11.8243358Z .................................................................................................... 400/2907
2019-07-26T13:46:24.7337954Z .................................................................................................... 500/2907
2019-07-26T13:46:40.2131673Z .................................................................................................... 600/2907
2019-07-26T13:47:02.6336672Z .................................................................................................... 700/2907
2019-07-26T13:47:02.6336672Z .................................................................................................... 700/2907
2019-07-26T13:47:17.1222889Z .................................................................................................... 800/2907
2019-07-26T13:47:28.6571527Z .................................................................................................... 900/2907
2019-07-26T13:47:47.7123999Z .................................................................................................... 1000/2907
2019-07-26T13:48:02.3123114Z .................................................................................................... 1100/2907
2019-07-26T13:48:13.9207778Z .................................................................................................... 1200/2907
2019-07-26T13:48:27.0295659Z .................................................................................................... 1300/2907
2019-07-26T13:48:43.9447750Z .........ii......................................................................................... 1400/2907
2019-07-26T13:48:56.6756093Z .................................................................................................... 1500/2907
2019-07-26T13:49:09.5395683Z .............................................................i.......i.............................. 1600/2907
2019-07-26T13:49:43.2505412Z .................................................................................................... 1800/2907
2019-07-26T13:49:43.2505412Z .................................................................................................... 1800/2907
2019-07-26T13:49:58.8037547Z .............................................................................................i...... 1900/2907
2019-07-26T13:50:28.9621406Z .................................................................i.................................. 2000/2907
2019-07-26T13:51:15.1987614Z .................................................................................................... 2200/2907
2019-07-26T13:51:30.4941346Z .................................................................................................... 2300/2907
2019-07-26T13:51:30.4941346Z .................................................................................................... 2300/2907
2019-07-26T13:51:50.2659331Z ii.................................................................................................. 2400/2907
2019-07-26T13:52:47.2077881Z .................................................................................................... 2600/2907
2019-07-26T13:53:01.4123320Z .................................................................................................... 2700/2907
2019-07-26T13:53:13.4351812Z .................................................................................................... 2800/2907
2019-07-26T13:53:30.6971988Z .................................................................................................... 2900/2907
---
2019-07-26T13:54:27.0248667Z  finished in 32.488
2019-07-26T13:54:27.0424699Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:54:27.2113567Z 
2019-07-26T13:54:27.2114485Z running 146 tests
2019-07-26T13:54:30.5761902Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-26T13:54:32.5028247Z iii..............i.........iii.i......ii......
2019-07-26T13:54:32.5029841Z 
2019-07-26T13:54:32.5031145Z  finished in 5.460
2019-07-26T13:54:32.5212911Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:54:32.6884663Z 
2019-07-26T13:54:32.6884663Z 
2019-07-26T13:54:32.6884943Z running 39 tests
2019-07-26T13:54:34.8173797Z i.........i......................i.....
2019-07-26T13:54:34.8174403Z 
2019-07-26T13:54:34.8178795Z  finished in 2.296
2019-07-26T13:54:34.8407967Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:54:35.0051079Z 
2019-07-26T13:54:35.0051079Z 
2019-07-26T13:54:35.0051365Z running 9 tests
2019-07-26T13:54:35.0053395Z iiiiiiiii
2019-07-26T13:54:35.0053845Z 
2019-07-26T13:54:35.0056914Z  finished in 0.164
2019-07-26T13:54:35.0246748Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:54:35.1928905Z 
---
2019-07-26T13:54:53.8199420Z  finished in 18.795
2019-07-26T13:54:53.8385539Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:54:54.0052859Z 
2019-07-26T13:54:54.0053113Z running 122 tests
2019-07-26T13:55:18.6259822Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-26T13:55:23.4205356Z .i.i......iii.i.....ii
2019-07-26T13:55:23.4206491Z 
2019-07-26T13:55:23.4208917Z  finished in 29.582
2019-07-26T13:55:23.4213266Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:55:23.4213829Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-07-26T13:55:23.4213829Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-07-26T13:55:23.4429567Z Check compiletest suite=ui-fulldeps mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T13:55:23.6057691Z 
2019-07-26T13:55:23.6058661Z running 25 tests
2019-07-26T13:55:30.4754664Z ...F.F..................thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-26T13:55:30.4756492Z .
2019-07-26T13:55:30.4759378Z failures:
2019-07-26T13:55:30.4759753Z 
2019-07-26T13:55:30.4760383Z ---- [ui] ui-fulldeps/hash-stable-is-unstable.rs stdout ----
2019-07-26T13:55:30.4760383Z ---- [ui] ui-fulldeps/hash-stable-is-unstable.rs stdout ----
2019-07-26T13:55:30.4760672Z diff of stderr:
2019-07-26T13:55:30.4760861Z 
2019-07-26T13:55:30.4761101Z 8 LL | extern crate rustc_data_structures;
2019-07-26T13:55:30.4761313Z 9    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4761528Z 10    |
2019-07-26T13:55:30.4762195Z -    = note: for more information, see ***/issues/27812
2019-07-26T13:55:30.4762900Z +    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4770667Z 12    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4770996Z 13 
2019-07-26T13:55:30.4771661Z 14 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4771939Z 17 LL | extern crate rustc;
2019-07-26T13:55:30.4771983Z 18    | ^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4772023Z 19    |
2019-07-26T13:55:30.4772023Z 19    |
2019-07-26T13:55:30.4772387Z -    = note: for more information, see ***/issues/27812
2019-07-26T13:55:30.4772705Z +    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4772782Z 21    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4772827Z 22 
2019-07-26T13:55:30.4773203Z 23 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4773319Z 26 LL | extern crate rustc_macros;
2019-07-26T13:55:30.4773363Z 27    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4773413Z 28    |
2019-07-26T13:55:30.4773413Z 28    |
2019-07-26T13:55:30.4773713Z -    = note: for more information, see ***/issues/27812
2019-07-26T13:55:30.4774014Z +    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4774092Z 30    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4774137Z 31 
2019-07-26T13:55:30.4774510Z 32 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4774615Z 35 LL | use rustc_macros::HashStable;
2019-07-26T13:55:30.4774661Z 36    |     ^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4774702Z 37    |
2019-07-26T13:55:30.4774702Z 37    |
2019-07-26T13:55:30.4774996Z -    = note: for more information, see ***/issues/27812
2019-07-26T13:55:30.4775306Z +    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4775522Z 39    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4775574Z 40 
2019-07-26T13:55:30.4775977Z 41 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4776083Z 44 LL | #[derive(HashStable)]
2019-07-26T13:55:30.4776125Z 45    |          ^^^^^^^^^^
2019-07-26T13:55:30.4776184Z 46    |
2019-07-26T13:55:30.4776184Z 46    |
2019-07-26T13:55:30.4776466Z -    = note: for more information, see ***/issues/27812
2019-07-26T13:55:30.4777459Z +    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4777546Z 48    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4777648Z 50 error: aborting due to 6 previous errors
2019-07-26T13:55:30.4777697Z 
2019-07-26T13:55:30.4777724Z 
2019-07-26T13:55:30.4777777Z The actual stderr differed from the expected stderr.
2019-07-26T13:55:30.4777777Z The actual stderr differed from the expected stderr.
2019-07-26T13:55:30.4778123Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/hash-stable-is-unstable/hash-stable-is-unstable.stderr
2019-07-26T13:55:30.4778394Z To update references, rerun the tests and pass the `--bless` flag
2019-07-26T13:55:30.4778655Z To only update this specific test, also pass `--test-args hash-stable-is-unstable.rs`
2019-07-26T13:55:30.4778753Z error: 1 errors occurred comparing output.
2019-07-26T13:55:30.4778798Z status: exit code: 1
2019-07-26T13:55:30.4778798Z status: exit code: 1
2019-07-26T13:55:30.4779558Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/hash-stable-is-unstable.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/hash-stable-is-unstable" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/hash-stable-is-unstable/auxiliary" "-A" "unused"
2019-07-26T13:55:30.4780048Z ------------------------------------------
2019-07-26T13:55:30.4780101Z 
2019-07-26T13:55:30.4780324Z ------------------------------------------
2019-07-26T13:55:30.4780369Z stderr:
2019-07-26T13:55:30.4780369Z stderr:
2019-07-26T13:55:30.4780580Z ------------------------------------------
2019-07-26T13:55:30.4780651Z error[E0601]: `main` function not found in crate `hash_stable_is_unstable`
2019-07-26T13:55:30.4780698Z    |
2019-07-26T13:55:30.4780980Z    = note: consider adding a `main` function to `/checkout/src/test/ui-fulldeps/hash-stable-is-unstable.rs`
2019-07-26T13:55:30.4781038Z 
2019-07-26T13:55:30.4781411Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4781920Z    |
2019-07-26T13:55:30.4781962Z LL | extern crate rustc_data_structures;
2019-07-26T13:55:30.4782024Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4782064Z    |
2019-07-26T13:55:30.4782064Z    |
2019-07-26T13:55:30.4782359Z    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4782432Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4782465Z 
2019-07-26T13:55:30.4782833Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4783400Z    |
2019-07-26T13:55:30.4783442Z LL | extern crate rustc;
2019-07-26T13:55:30.4783485Z    | ^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4783543Z    |
2019-07-26T13:55:30.4783543Z    |
2019-07-26T13:55:30.4783925Z    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4784014Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4784048Z 
2019-07-26T13:55:30.4784449Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4784775Z    |
2019-07-26T13:55:30.4784817Z LL | extern crate rustc_macros;
2019-07-26T13:55:30.4784862Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4784921Z    |
2019-07-26T13:55:30.4784921Z    |
2019-07-26T13:55:30.4785221Z    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4785307Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4785339Z 
2019-07-26T13:55:30.4785727Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4786053Z    |
2019-07-26T13:55:30.4786097Z LL | use rustc_macros::HashStable;
2019-07-26T13:55:30.4786143Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-26T13:55:30.4786206Z    |
2019-07-26T13:55:30.4786206Z    |
2019-07-26T13:55:30.4786500Z    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4786559Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4786809Z 
2019-07-26T13:55:30.4787231Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-26T13:55:30.4787713Z    |
2019-07-26T13:55:30.4787755Z LL | #[derive(HashStable)]
2019-07-26T13:55:30.4787801Z    |          ^^^^^^^^^^
2019-07-26T13:55:30.4787860Z    |
2019-07-26T13:55:30.4787860Z    |
2019-07-26T13:55:30.4788169Z    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-26T13:55:30.4788227Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-26T13:55:30.4788320Z error: aborting due to 6 previous errors
2019-07-26T13:55:30.4788349Z 
2019-07-26T13:55:30.4788393Z Some errors have detailed explanations: E0601, E0658.
2019-07-26T13:55:30.4788669Z For more information about an error, try `rustc --explain E0601`.
2019-07-26T13:55:30.4788669Z For more information about an error, try `rustc --explain E0601`.
2019-07-26T13:55:30.4788703Z 
2019-07-26T13:55:30.4788921Z ------------------------------------------
2019-07-26T13:55:30.4788963Z 
2019-07-26T13:55:30.4789005Z 
2019-07-26T13:55:30.4789229Z ---- [ui] ui-fulldeps/gated-plugin.rs stdout ----
2019-07-26T13:55:30.4789277Z diff of stderr:
2019-07-26T13:55:30.4789314Z 
2019-07-26T13:55:30.4789374Z 4 LL | #![plugin(attr_plugin_test)]
2019-07-26T13:55:30.4789462Z 6    |
2019-07-26T13:55:30.4789462Z 6    |
2019-07-26T13:55:30.4789765Z -    = note: for more information, see ***/issues/29597
2019-07-26T13:55:30.4790078Z +    = note: for more information, see issue #29597 <***/issues/29597>
2019-07-26T13:55:30.4790136Z 8    = help: add `#![feature(plugin)]` to the crate attributes to enable
2019-07-26T13:55:30.4790242Z 10 error: aborting due to previous error
2019-07-26T13:55:30.4790271Z 
2019-07-26T13:55:30.4790296Z 
2019-07-26T13:55:30.4790360Z The actual stderr differed from the expected stderr.
2019-07-26T13:55:30.4790360Z The actual stderr differed from the expected stderr.
2019-07-26T13:55:30.4790711Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/gated-plugin.stderr
2019-07-26T13:55:30.4790970Z To update references, rerun the tests and pass the `--bless` flag
2019-07-26T13:55:30.4791375Z To only update this specific test, also pass `--test-args gated-plugin.rs`
2019-07-26T13:55:30.4791469Z error: 1 errors occurred comparing output.
2019-07-26T13:55:30.4791536Z status: exit code: 1
2019-07-26T13:55:30.4791536Z status: exit code: 1
2019-07-26T13:55:30.4792465Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/gated-plugin.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary" "-A" "unused"
2019-07-26T13:55:30.4792799Z ------------------------------------------
2019-07-26T13:55:30.4792831Z 
2019-07-26T13:55:30.4793040Z ------------------------------------------
2019-07-26T13:55:30.4793103Z stderr:
2019-07-26T13:55:30.4793103Z stderr:
2019-07-26T13:55:30.4793317Z ------------------------------------------
2019-07-26T13:55:30.4793369Z error[E0658]: compiler plugins are experimental and possibly buggy
2019-07-26T13:55:30.4793614Z   --> /checkout/src/test/ui-fulldeps/gated-plugin.rs:3:1
2019-07-26T13:55:30.4793661Z    |
2019-07-26T13:55:30.4793702Z LL | #![plugin(attr_plugin_test)]
2019-07-26T13:55:30.4793803Z    |
2019-07-26T13:55:30.4793803Z    |
2019-07-26T13:55:30.4794099Z    = note: for more information, see issue #29597 <***/issues/29597>
2019-07-26T13:55:30.4794172Z    = help: add `#![feature(plugin)]` to the crate attributes to enable
2019-07-26T13:55:30.4794244Z error: aborting due to previous error
2019-07-26T13:55:30.4794273Z 
2019-07-26T13:55:30.4794536Z For more information about this error, try `rustc --explain E0658`.
2019-07-26T13:55:30.4794661Z 
---
2019-07-26T13:55:30.4795774Z test result: FAILED. 23 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
2019-07-26T13:55:30.4795811Z 
2019-07-26T13:55:30.4795856Z 
2019-07-26T13:55:30.4795880Z 
2019-07-26T13:55:30.4797820Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-26T13:55:30.4798303Z 
2019-07-26T13:55:30.4798331Z 
2019-07-26T13:55:30.4800673Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-26T13:55:30.4800892Z Build completed unsuccessfully in 1:08:45
2019-07-26T13:55:30.4800892Z Build completed unsuccessfully in 1:08:45
2019-07-26T13:55:31.1889495Z ##[error]Bash exited with code '1'.
2019-07-26T13:55:31.1925234Z ##[section]Starting: Checkout
2019-07-26T13:55:31.1927811Z ==============================================================================
2019-07-26T13:55:31.1927885Z Task         : Get sources
2019-07-26T13:55:31.1927937Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T16:12:49.2943166Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T16:12:49.3178535Z ##[command]git config gc.auto 0
2019-07-26T16:12:49.3278010Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T16:12:49.3340826Z ##[command]git config --get-all http.proxy
2019-07-26T16:12:50.3372281Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63008/merge:refs/remotes/pull/63008/merge
---
2019-07-26T16:13:23.1511699Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T16:13:23.1511729Z 
2019-07-26T16:13:23.1511931Z   git checkout -b <new-branch-name>
2019-07-26T16:13:23.1511961Z 
2019-07-26T16:13:23.1512031Z HEAD is now at 7bd43f4a5 Merge ae8e6d86cd28e80ad56d70b84640046faaba0ba1 into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T16:13:23.1654585Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T16:13:23.1657339Z ==============================================================================
2019-07-26T16:13:23.1657401Z Task         : Bash
2019-07-26T16:13:23.1657450Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T17:13:07.5983194Z .................................................................................................... 200/5862
2019-07-26T17:13:11.7586031Z .................................................................................................... 300/5862
2019-07-26T17:13:15.4286323Z .................................................................................................... 400/5862
2019-07-26T17:13:19.1545682Z .................................................................................................... 500/5862
2019-07-26T17:13:22.9190731Z ........................................................................i........................... 600/5862
2019-07-26T17:13:31.8466480Z .................................................................................................... 800/5862
2019-07-26T17:13:37.4105691Z .................................................................................................... 900/5862
2019-07-26T17:13:42.3401570Z .................................................................................................... 1000/5862
2019-07-26T17:13:42.3401570Z .................................................................................................... 1000/5862
2019-07-26T17:13:47.7616591Z i...........i....................................................................................... 1100/5862
2019-07-26T17:13:51.6035284Z ..............................iiiii................................................................. 1200/5862
2019-07-26T17:13:57.5659553Z .................................................................................................... 1400/5862
2019-07-26T17:14:00.2165851Z .................................................................................................... 1500/5862
2019-07-26T17:14:03.9048253Z .................................................................................................... 1600/5862
2019-07-26T17:14:06.5200145Z .................................................................................................... 1700/5862
2019-07-26T17:14:06.5200145Z .................................................................................................... 1700/5862
2019-07-26T17:14:09.9314751Z ......................................................................i............................. 1800/5862
2019-07-26T17:14:18.4129138Z .................................................................................................... 2000/5862
2019-07-26T17:14:22.6993990Z .................................................................................................... 2100/5862
2019-07-26T17:14:26.3577734Z .................................................................................................... 2200/5862
2019-07-26T17:14:26.3577734Z .................................................................................................... 2200/5862
2019-07-26T17:14:30.2128482Z ......................................................i............................................. 2300/5862
2019-07-26T17:14:39.8537271Z .................................................................................................... 2500/5862
2019-07-26T17:14:43.9151847Z .................................................................................................... 2600/5862
2019-07-26T17:14:49.0635800Z .................................................................................................... 2700/5862
2019-07-26T17:14:52.8138440Z .................................................................................................... 2800/5862
2019-07-26T17:14:52.8138440Z .................................................................................................... 2800/5862
2019-07-26T17:14:57.1214816Z .................................................................................................... 2900/5862
2019-07-26T17:15:02.3545963Z .................................................................................................... 3000/5862
2019-07-26T17:15:06.6152181Z .................................................................................................... 3100/5862
2019-07-26T17:15:11.7527267Z .................................................................................................... 3200/5862
2019-07-26T17:15:15.1772005Z .................................................................................................... 3300/5862
2019-07-26T17:15:18.7232795Z .................................................................................................... 3400/5862
2019-07-26T17:15:23.7248724Z .................................................................................................... 3500/5862
2019-07-26T17:15:27.4019264Z .....................i.............................................................................. 3600/5862
2019-07-26T17:15:31.5096315Z .................................................................................................ii. 3700/5862
2019-07-26T17:15:35.0860045Z ..i..ii............................................................................................. 3800/5862
2019-07-26T17:15:43.3671183Z .................................................................................................... 4000/5862
2019-07-26T17:15:43.3671183Z .................................................................................................... 4000/5862
2019-07-26T17:15:47.1543215Z ................ii.................................................................................. 4100/5862
2019-07-26T17:15:49.1464861Z .....................................i.............................................................. 4200/5862
2019-07-26T17:15:51.2712732Z .................................................................................................... 4300/5862
2019-07-26T17:15:53.5657828Z ......i............................................................................................. 4400/5862
2019-07-26T17:16:15.1084529Z .................................................................................................... 4600/5862
2019-07-26T17:16:18.7662289Z .................................................................................................... 4700/5862
2019-07-26T17:16:22.2663027Z .................................................................................................... 4800/5862
2019-07-26T17:16:26.8429107Z .................................................................................................... 4900/5862
---
2019-07-26T17:16:58.4059765Z .................................................................................................... 5500/5862
2019-07-26T17:17:02.6524772Z .................................................................................................... 5600/5862
2019-07-26T17:17:05.6020166Z .................................................................................................... 5700/5862
2019-07-26T17:17:08.5648962Z .................................................................................................... 5800/5862
2019-07-26T17:17:10.6608416Z ..i...........................................................
2019-07-26T17:17:10.6609625Z 
2019-07-26T17:17:10.6679002Z  finished in 258.778
2019-07-26T17:17:10.6852561Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:17:10.9067720Z 
2019-07-26T17:17:10.9067720Z 
2019-07-26T17:17:10.9067887Z running 2907 tests
2019-07-26T17:17:26.1992377Z .................................................................................................... 100/2907
2019-07-26T17:17:41.5179855Z ..............................................................................i..................... 200/2907
2019-07-26T17:18:05.8788356Z .................................................................................................... 400/2907
2019-07-26T17:18:17.7160174Z .................................................................................................... 500/2907
2019-07-26T17:18:32.0728781Z .................................................................................................... 600/2907
2019-07-26T17:18:53.3474005Z .................................................................................................... 700/2907
2019-07-26T17:18:53.3474005Z .................................................................................................... 700/2907
2019-07-26T17:19:07.2019143Z .................................................................................................... 800/2907
2019-07-26T17:19:18.2494954Z .................................................................................................... 900/2907
2019-07-26T17:19:36.4149101Z .................................................................................................... 1000/2907
2019-07-26T17:19:50.5116629Z .................................................................................................... 1100/2907
2019-07-26T17:20:01.6240161Z .................................................................................................... 1200/2907
2019-07-26T17:20:13.9577917Z .................................................................................................... 1300/2907
2019-07-26T17:20:30.0149682Z .........ii......................................................................................... 1400/2907
2019-07-26T17:20:42.1805036Z .................................................................................................... 1500/2907
2019-07-26T17:20:54.4891310Z .............................................................i.......i.............................. 1600/2907
2019-07-26T17:21:26.9984729Z .................................................................................................... 1800/2907
2019-07-26T17:21:26.9984729Z .................................................................................................... 1800/2907
2019-07-26T17:21:41.9373825Z .............................................................................................i...... 1900/2907
2019-07-26T17:22:10.4770414Z .................................................................i.................................. 2000/2907
2019-07-26T17:22:55.5142126Z .................................................................................................... 2200/2907
2019-07-26T17:23:10.0146487Z .................................................................................................... 2300/2907
2019-07-26T17:23:10.0146487Z .................................................................................................... 2300/2907
2019-07-26T17:23:28.9052461Z ii.................................................................................................. 2400/2907
2019-07-26T17:24:23.0729738Z .................................................................................................... 2600/2907
2019-07-26T17:24:36.5346824Z .................................................................................................... 2700/2907
2019-07-26T17:24:47.8972874Z .................................................................................................... 2800/2907
2019-07-26T17:25:04.1976851Z .................................................................................................... 2900/2907
---
2019-07-26T17:25:57.7277981Z  finished in 30.733
2019-07-26T17:25:57.7455408Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:25:57.9062066Z 
2019-07-26T17:25:57.9062974Z running 146 tests
2019-07-26T17:26:01.1296627Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-26T17:26:02.9939419Z iii..............i.........iii.i......ii......
2019-07-26T17:26:02.9944530Z 
2019-07-26T17:26:02.9950821Z  finished in 5.249
2019-07-26T17:26:03.0136819Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:26:03.1842604Z 
2019-07-26T17:26:03.1842604Z 
2019-07-26T17:26:03.1843322Z running 39 tests
2019-07-26T17:26:05.2123432Z i.........i......................i.....
2019-07-26T17:26:05.2124710Z 
2019-07-26T17:26:05.2128095Z  finished in 2.199
2019-07-26T17:26:05.2316184Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:26:05.3904444Z 
2019-07-26T17:26:05.3904444Z 
2019-07-26T17:26:05.3904638Z running 9 tests
2019-07-26T17:26:05.3905382Z iiiiiiiii
2019-07-26T17:26:05.3905698Z 
2019-07-26T17:26:05.3905781Z  finished in 0.158
2019-07-26T17:26:05.4076870Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:26:05.5747233Z 
---
2019-07-26T17:26:23.6442809Z  finished in 18.235
2019-07-26T17:26:23.6611285Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:26:23.8259817Z 
2019-07-26T17:26:23.8260103Z running 122 tests
2019-07-26T17:26:47.2788439Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-26T17:26:51.7881593Z .i.i......iii.i.....ii
2019-07-26T17:26:51.7883995Z 
2019-07-26T17:26:51.7885509Z  finished in 28.127
2019-07-26T17:26:51.7894289Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:26:51.7894642Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-26T17:30:32.3061421Z     Finished release [optimized] target(s) in 2m 41s
2019-07-26T17:30:32.3292186Z Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T17:30:32.4903930Z 
2019-07-26T17:30:32.4904490Z running 315 tests
2019-07-26T17:31:47.6796235Z ....................................i............................................................... 100/315
2019-07-26T17:32:54.2739299Z ....................................................i............................................... 200/315
2019-07-26T17:34:07.9639524Z ...............
2019-07-26T17:34:07.9640452Z test result: ok. 313 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-07-26T17:34:07.9640831Z 
2019-07-26T17:34:07.9641892Z  finished in 215.635
---
2019-07-26T17:38:09.7537239Z 
2019-07-26T17:38:09.7637788Z 
2019-07-26T17:38:09.7638202Z running 445 tests
2019-07-26T17:38:29.1636005Z .................................................................................................... 100/445
2019-07-26T17:38:45.5347934Z ...................................................................................i................ 200/445
2019-07-26T17:39:14.5061623Z .................................................................................................... 400/445
2019-07-26T17:39:21.2148266Z .............................................
2019-07-26T17:39:21.2149310Z test result: ok. 444 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
2019-07-26T17:39:21.2149545Z 
---
2019-07-26T17:40:38.9723313Z running 961 tests
2019-07-26T17:40:38.9871578Z .................................................................................................... 100/961
2019-07-26T17:40:38.9979041Z .................................................................................................... 200/961
2019-07-26T17:40:39.0098464Z .................................................................................................... 300/961
2019-07-26T17:40:39.1079659Z ............................................................................................ii...... 400/961
2019-07-26T17:40:39.2262681Z .................................................................................................... 600/961
2019-07-26T17:40:39.2364478Z .................................................................................................... 700/961
2019-07-26T17:40:39.2516168Z .................................................................................................... 800/961
2019-07-26T17:40:39.7222288Z .................................................................................................... 900/961
2019-07-26T17:40:39.7222288Z .................................................................................................... 900/961
2019-07-26T17:40:40.8872649Z .............................................................
2019-07-26T17:40:40.8874169Z test result: ok. 959 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-07-26T17:40:40.8874982Z 
2019-07-26T17:40:40.8881664Z    Doc-tests core
2019-07-26T17:40:44.8868642Z 
2019-07-26T17:40:44.8869379Z running 2379 tests
2019-07-26T17:40:57.2078463Z ......iiiii......................................................................................... 100/2379
2019-07-26T17:41:09.2203519Z .........................................................................ii......................... 200/2379
2019-07-26T17:41:22.5980465Z ...............................................................................................i.... 300/2379
2019-07-26T17:41:37.9788463Z .................................................................................................... 400/2379
2019-07-26T17:41:48.9296025Z ..............................i..i.................iiii............................................. 500/2379
2019-07-26T17:42:11.8331594Z .................................................................................................... 700/2379
2019-07-26T17:42:23.2656452Z .................................................................................................... 800/2379
2019-07-26T17:42:34.8620120Z .................................................................................................... 900/2379
2019-07-26T17:42:46.4567987Z .................................................................................................... 1000/2379
---
2019-07-26T17:44:31.7026231Z .................................................................................................... 1900/2379
2019-07-26T17:44:45.0821613Z .................................................................................................... 2000/2379
2019-07-26T17:44:57.3433061Z .................................................................................................... 2100/2379
2019-07-26T17:45:11.8487631Z .................................................................................................... 2200/2379
2019-07-26T17:45:27.3573432Z ........................................................................................i........... 2300/2379
2019-07-26T17:45:37.0932390Z test result: ok. 2364 passed; 0 failed; 15 ignored; 0 measured; 0 filtered out
2019-07-26T17:45:37.0932614Z 
2019-07-26T17:45:37.1191497Z  finished in 375.890
2019-07-26T17:45:37.1210170Z Testing panic_abort stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-07-26T17:47:52.8018660Z 
2019-07-26T17:47:52.8019566Z running 1009 tests
2019-07-26T17:48:15.3871007Z i................................................................................................... 100/1009
2019-07-26T17:48:28.3116669Z .................................................................................................... 200/1009
2019-07-26T17:48:36.8753092Z .................iii......i......i...i......i....................................................... 300/1009
2019-07-26T17:48:41.8041152Z .................................................................................................... 400/1009
2019-07-26T17:48:48.9752888Z ................................i..i..........................................iiii.......ii......... 500/1009
2019-07-26T17:49:03.0306100Z .................................................................................................... 700/1009
2019-07-26T17:49:03.0306100Z .................................................................................................... 700/1009
2019-07-26T17:49:10.8461303Z ...................................iiii............................................................. 800/1009
2019-07-26T17:49:26.8538327Z .................................................................................................... 900/1009
2019-07-26T17:49:34.8842266Z .........................................................iiii....................................... 1000/1009
2019-07-26T17:49:35.2608885Z test result: ok. 985 passed; 0 failed; 24 ignored; 0 measured; 0 filtered out
2019-07-26T17:49:35.2608916Z 
2019-07-26T17:49:35.2810725Z  finished in 237.687
2019-07-26T17:49:35.2827888Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-07-26T18:09:13.0958785Z  finished in 31.996
2019-07-26T18:09:13.1278136Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T18:09:13.2953805Z 
2019-07-26T18:09:13.2954276Z running 199 tests
2019-07-26T18:09:48.2407566Z ....................i...ii................................................................i......... 100/199
2019-07-26T18:10:32.1697378Z ..............................iiii.......i..........iiii.iii....................................i..
2019-07-26T18:10:32.1698170Z 
2019-07-26T18:10:32.1698238Z  finished in 79.042
2019-07-26T18:10:32.1709006Z doc tests for: /checkout/src/doc/rustdoc/src/command-line-arguments.md
2019-07-26T18:10:32.1791069Z doc tests for: /checkout/src/doc/rustdoc/src/documentation-tests.md
---
2019-07-26T18:11:01.8483930Z 
2019-07-26T18:11:01.8484158Z ---- [ui] rustdoc-ui/deprecated-attrs.rs stdout ----
2019-07-26T18:11:01.8484204Z diff of stderr:
2019-07-26T18:11:01.8484234Z 
2019-07-26T18:11:01.8484293Z 1 warning: the `#![doc(no_default_passes)]` attribute is considered deprecated
2019-07-26T18:11:01.8484336Z 2    |
2019-07-26T18:11:01.8484662Z -    = warning: please see ***/issues/44136
2019-07-26T18:11:01.8484962Z +    = warning: please see issue #44136 <***/issues/44136>
2019-07-26T18:11:01.8485013Z 4    = help: you may want to use `#![doc(document_private_items)]`
2019-07-26T18:11:01.8485222Z 5 
2019-07-26T18:11:01.8485272Z 6 warning: the `#![doc(passes = "...")]` attribute is considered deprecated
2019-07-26T18:11:01.8485336Z 7    |
2019-07-26T18:11:01.8485336Z 7    |
2019-07-26T18:11:01.8485629Z -    = warning: please see ***/issues/44136
2019-07-26T18:11:01.8486041Z +    = warning: please see issue #44136 <***/issues/44136>
2019-07-26T18:11:01.8486130Z 10 
2019-07-26T18:11:01.8486914Z 
2019-07-26T18:11:01.8486940Z 
2019-07-26T18:11:01.8486990Z The actual stderr differed from the expected stderr.
2019-07-26T18:11:01.8486990Z The actual stderr differed from the expected stderr.
2019-07-26T18:11:01.8487392Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/deprecated-attrs/deprecated-attrs.stderr
2019-07-26T18:11:01.8487643Z To update references, rerun the tests and pass the `--bless` flag
2019-07-26T18:11:01.8488039Z To only update this specific test, also pass `--test-args deprecated-attrs.rs`
2019-07-26T18:11:01.8488129Z error: 1 errors occurred comparing output.
2019-07-26T18:11:01.8488175Z status: exit code: 0
2019-07-26T18:11:01.8488175Z status: exit code: 0
2019-07-26T18:11:01.8488896Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/checkout/src/test/rustdoc-ui/deprecated-attrs.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/deprecated-attrs" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/deprecated-attrs/auxiliary"
2019-07-26T18:11:01.8489236Z ------------------------------------------
2019-07-26T18:11:01.8489271Z 
2019-07-26T18:11:01.8489482Z ------------------------------------------
2019-07-26T18:11:01.8489544Z stderr:
2019-07-26T18:11:01.8489544Z stderr:
2019-07-26T18:11:01.8489942Z ------------------------------------------
2019-07-26T18:11:01.8490150Z warning: the `#![doc(no_default_passes)]` attribute is considered deprecated
2019-07-26T18:11:01.8490369Z    |
2019-07-26T18:11:01.8490625Z    = warning: please see issue #44136 <***/issues/44136>
2019-07-26T18:11:01.8490672Z    = help: you may want to use `#![doc(document_private_items)]`
2019-07-26T18:11:01.8490715Z 
2019-07-26T18:11:01.8490756Z warning: the `#![doc(passes = "...")]` attribute is considered deprecated
2019-07-26T18:11:01.8490794Z    |
2019-07-26T18:11:01.8491045Z    = warning: please see issue #44136 <***/issues/44136>
2019-07-26T18:11:01.8491105Z 
2019-07-26T18:11:01.8491288Z ------------------------------------------
2019-07-26T18:11:01.8491314Z 
2019-07-26T18:11:01.8491351Z 
---
2019-07-26T18:11:01.8492096Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-26T18:11:01.8492162Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-26T18:11:01.8492189Z 
2019-07-26T18:11:01.8492212Z 
2019-07-26T18:11:01.8494399Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc-ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-26T18:11:01.8494761Z 
2019-07-26T18:11:01.8494787Z 
2019-07-26T18:11:01.8494849Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-26T18:11:01.8494953Z Build completed unsuccessfully in 1:50:52
2019-07-26T18:11:01.8494953Z Build completed unsuccessfully in 1:50:52
2019-07-26T18:11:02.7151785Z ##[error]Bash exited with code '1'.
2019-07-26T18:11:02.7201690Z ##[section]Starting: Checkout
2019-07-26T18:11:02.7203306Z ==============================================================================
2019-07-26T18:11:02.7203357Z Task         : Get sources
2019-07-26T18:11:02.7203404Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@BO41
Copy link
Contributor

left a comment

there are some more inconsistencies that should be fixed (at least some of them):

See issue #49146 <https://github.com/rust-lang/rust/issues/49146> \
for more information.", kind),

for more information, see issue \
#57563 <https://github.com/rust-lang/rust/issues/57563>");

see issue #43162 <https://github.com/rust-lang/rust/issues/43162#issuecomment-320764675>"

please see issue #44136 <https://github.com/rust-lang/rust/issues/44136>

for more context, see issue #60210 <https://github.com/rust-lang/rust/issues/60210>

see issue #46062 <https://github.com/rust-lang/rust/issues/46062> for more details

I think, the order should be consistent, as well as the inclusion of "for more information/details"

@eupn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

@BO41

there are some more inconsistencies that should be fixed (at least some of them):

See issue #49146 <https://github.com/rust-lang/rust/issues/49146>
for more information.", kind),

for more information, see issue
#57563 <https://github.com/rust-lang/rust/issues/57563>");

see issue #43162 <https://github.com/rust-lang/rust/issues/43162#issuecomment-320764675>"

please see issue #44136 <https://github.com/rust-lang/rust/issues/44136>

for more context, see issue #60210 <https://github.com/rust-lang/rust/issues/60210>

see issue #46062 <https://github.com/rust-lang/rust/issues/46062> for more details

I think, the order should be consistent, as well as the inclusion of "for more information/details"

I should've made this consistent as well. In this PR, I was only concerned about the consistency of Github links to the issues.

@BO41

BO41 approved these changes Jul 28, 2019

@shepmaster

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned zackmdavis Jul 28, 2019

@varkor

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

I'll review this soon. However, I feel slightly uncomfortable, because @punitkoura had asked to take this issue. It would be a shame to waste this effort, though.

If @punitkoura is happy with it, perhaps we could go with this pull request, but @punitkoura can be added as a co-author for doing the initial work? Then I can direct @punitkoura to another easy starter issue.

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

☔️ The latest upstream changes (presumably #63094) made this pull request unmergeable. Please resolve the merge conflicts.

@punitkoura

This comment has been minimized.

Copy link

commented Jul 29, 2019

Hi @varkor, these changes look good to me. I was also working on the same, but then saw this PR and therefore didn't raise another PR. It'd be really nice if I could be added as a co-author though :)

@eupn eupn force-pushed the eupn:consistent-see-issue branch from cf1843a to 93666a4 Jul 29, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-29T06:50:07.7542262Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-29T06:50:07.7744975Z ##[command]git config gc.auto 0
2019-07-29T06:50:07.7812282Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-29T06:50:07.7872177Z ##[command]git config --get-all http.proxy
2019-07-29T06:50:07.8014157Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63008/merge:refs/remotes/pull/63008/merge
---
2019-07-29T06:50:41.1333511Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-29T06:50:41.1333542Z 
2019-07-29T06:50:41.1333784Z   git checkout -b <new-branch-name>
2019-07-29T06:50:41.1333814Z 
2019-07-29T06:50:41.1333862Z HEAD is now at fea0d021b Merge 93666a47cd6d45be96cb56ecfa58c9383c528759 into 8b94e9e9188b65df38a5f1ae723617dc2dfb3155
2019-07-29T06:50:41.1462832Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-29T06:50:41.1465644Z ==============================================================================
2019-07-29T06:50:41.1465722Z Task         : Bash
2019-07-29T06:50:41.1465771Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-29T07:53:21.9131427Z .................................................................................................... 1400/8804
2019-07-29T07:53:27.9882229Z .................................................................................................... 1500/8804
2019-07-29T07:53:40.6191990Z ................................................................i...............i................... 1600/8804
2019-07-29T07:53:48.4195652Z .................................................................................................... 1700/8804
2019-07-29T07:54:03.5714613Z ..................................................iiiii............................................. 1800/8804
2019-07-29T07:54:15.0471064Z .................................................................................................... 2000/8804
2019-07-29T07:54:17.6816851Z .................................................................................................... 2100/8804
2019-07-29T07:54:21.7162997Z .................................................................................................... 2200/8804
2019-07-29T07:54:28.3163754Z .................................................................................................... 2300/8804
---
2019-07-29T07:58:18.2155740Z .................................................................................................... 5200/8804
2019-07-29T07:58:29.1367787Z .................................................................................................... 5300/8804
2019-07-29T07:58:36.8959977Z ..i................................................................................................. 5400/8804
2019-07-29T07:58:42.3318897Z .................................................................................................... 5500/8804
2019-07-29T07:58:54.5743298Z ................................................................................................ii.. 5600/8804
2019-07-29T07:59:09.3897312Z .i..ii...........i.................................................................................. 5700/8804
2019-07-29T07:59:25.7620652Z .................................................................................................... 5900/8804
2019-07-29T07:59:30.6084741Z ................................................................................................i..i 6000/8804
2019-07-29T07:59:45.1412275Z i................................................................................................... 6100/8804
2019-07-29T08:00:01.7412339Z .................................................................................................... 6200/8804
---
2019-07-29T08:04:13.6429413Z 
2019-07-29T08:04:13.6429942Z ---- [ui] ui/parser/match-vec-invalid.rs stdout ----
2019-07-29T08:04:13.6430003Z diff of stderr:
2019-07-29T08:04:13.6430033Z 
2019-07-29T08:04:13.6430080Z 10 LL |         [1, tail @ .., tail @ ..] => {},
2019-07-29T08:04:13.6430228Z 12    |
2019-07-29T08:04:13.6430228Z 12    |
2019-07-29T08:04:13.6430616Z -    = note: for more information, see ***/issues/62254
2019-07-29T08:04:13.6430956Z +    = note: for more information, see issue #62254 <***/issues/62254>
2019-07-29T08:04:13.6431018Z 14    = help: add `#![feature(slice_patterns)]` to the crate attributes to enable
2019-07-29T08:04:13.6431127Z 16 error[E0658]: subslice patterns are unstable
2019-07-29T08:04:13.6431157Z 
2019-07-29T08:04:13.6431157Z 
2019-07-29T08:04:13.6431203Z 19 LL |         [1, tail @ .., tail @ ..] => {},
2019-07-29T08:04:13.6431309Z 21    |
2019-07-29T08:04:13.6431309Z 21    |
2019-07-29T08:04:13.6431593Z -    = note: for more information, see ***/issues/62254
2019-07-29T08:04:13.6431953Z +    = note: for more information, see issue #62254 <***/issues/62254>
2019-07-29T08:04:13.6432016Z 23    = help: add `#![feature(slice_patterns)]` to the crate attributes to enable
2019-07-29T08:04:13.6432082Z 24 
2019-07-29T08:04:13.6432313Z 25 error: `..` can only be used once per slice pattern
2019-07-29T08:04:13.6432479Z 
2019-07-29T08:04:13.6432672Z The actual stderr differed from the expected stderr.
2019-07-29T08:04:13.6433500Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/match-vec-invalid/match-vec-invalid.stderr
2019-07-29T08:04:13.6433500Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/match-vec-invalid/match-vec-invalid.stderr
2019-07-29T08:04:13.6434095Z To update references, rerun the tests and pass the `--bless` flag
2019-07-29T08:04:13.6434388Z To only update this specific test, also pass `--test-args parser/match-vec-invalid.rs`
2019-07-29T08:04:13.6434471Z error: 1 errors occurred comparing output.
2019-07-29T08:04:13.6434517Z status: exit code: 1
2019-07-29T08:04:13.6434517Z status: exit code: 1
2019-07-29T08:04:13.6435264Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/match-vec-invalid.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/match-vec-invalid" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/match-vec-invalid/auxiliary" "-A" "unused"
2019-07-29T08:04:13.6435599Z ------------------------------------------
2019-07-29T08:04:13.6435634Z 
2019-07-29T08:04:13.6435845Z ------------------------------------------
2019-07-29T08:04:13.6435906Z stderr:
2019-07-29T08:04:13.6435906Z stderr:
2019-07-29T08:04:13.6436697Z ------------------------------------------
2019-07-29T08:04:13.6436756Z error[E0416]: identifier `tail` is bound more than once in the same pattern
2019-07-29T08:04:13.6437073Z    |
2019-07-29T08:04:13.6437073Z    |
2019-07-29T08:04:13.6437119Z LL |         [1, tail @ .., tail @ ..] => {},
2019-07-29T08:04:13.6437188Z    |                        ^^^^ used in a pattern more than once
2019-07-29T08:04:13.6437283Z error[E0658]: subslice patterns are unstable
2019-07-29T08:04:13.6437522Z   --> /checkout/src/test/ui/parser/match-vec-invalid.rs:4:13
2019-07-29T08:04:13.6437585Z    |
2019-07-29T08:04:13.6437585Z    |
2019-07-29T08:04:13.6437630Z LL |         [1, tail @ .., tail @ ..] => {},
2019-07-29T08:04:13.6437732Z    |
2019-07-29T08:04:13.6437732Z    |
2019-07-29T08:04:13.6438045Z    = note: for more information, see issue #62254 <***/issues/62254>
2019-07-29T08:04:13.6438104Z    = help: add `#![feature(slice_patterns)]` to the crate attributes to enable
2019-07-29T08:04:13.6438196Z error[E0658]: subslice patterns are unstable
2019-07-29T08:04:13.6438442Z   --> /checkout/src/test/ui/parser/match-vec-invalid.rs:4:24
2019-07-29T08:04:13.6438504Z    |
2019-07-29T08:04:13.6438504Z    |
2019-07-29T08:04:13.6438548Z LL |         [1, tail @ .., tail @ ..] => {},
2019-07-29T08:04:13.6438638Z    |
2019-07-29T08:04:13.6438638Z    |
2019-07-29T08:04:13.6438950Z    = note: for more information, see issue #62254 <***/issues/62254>
2019-07-29T08:04:13.6439015Z    = help: add `#![feature(slice_patterns)]` to the crate attributes to enable
2019-07-29T08:04:13.6439047Z 
2019-07-29T08:04:13.6439109Z error: `..` can only be used once per slice pattern
2019-07-29T08:04:13.6439401Z    |
2019-07-29T08:04:13.6439401Z    |
2019-07-29T08:04:13.6439461Z LL |         [1, tail @ .., tail @ ..] => {},
2019-07-29T08:04:13.6439709Z    |                    --         ^^ can only be used once per slice pattern
2019-07-29T08:04:13.6439818Z    |                    previously used here
2019-07-29T08:04:13.6439849Z 
2019-07-29T08:04:13.6439892Z error[E0308]: mismatched types
2019-07-29T08:04:13.6440368Z   --> /checkout/src/test/ui/parser/match-vec-invalid.rs:13:30
2019-07-29T08:04:13.6440368Z   --> /checkout/src/test/ui/parser/match-vec-invalid.rs:13:30
2019-07-29T08:04:13.6440430Z    |
2019-07-29T08:04:13.6440604Z LL | const RECOVERY_WITNESS: () = 0; //~ ERROR mismatched types
2019-07-29T08:04:13.6440665Z    |                              ^ expected (), found integer
2019-07-29T08:04:13.6440829Z    = note: expected type `()`
2019-07-29T08:04:13.6440829Z    = note: expected type `()`
2019-07-29T08:04:13.6440874Z               found type `{integer}`
2019-07-29T08:04:13.6440963Z error: aborting due to 5 previous errors
2019-07-29T08:04:13.6440993Z 
2019-07-29T08:04:13.6441038Z Some errors have detailed explanations: E0308, E0416, E0658.
2019-07-29T08:04:13.6441341Z For more information about an error, try `rustc --explain E0308`.
2019-07-29T08:04:13.6441341Z For more information about an error, try `rustc --explain E0308`.
2019-07-29T08:04:13.6441376Z 
2019-07-29T08:04:13.6441587Z ------------------------------------------
2019-07-29T08:04:13.6441618Z 
2019-07-29T08:04:13.6441644Z 
2019-07-29T08:04:13.6441879Z ---- [ui] ui/parser/pat-lt-bracket-6.rs stdout ----
2019-07-29T08:04:13.6441928Z diff of stderr:
2019-07-29T08:04:13.6441955Z 
2019-07-29T08:04:13.6441997Z 10 LL |     let Test(&desc[..]) = x;
2019-07-29T08:04:13.6442110Z 12    |
2019-07-29T08:04:13.6442110Z 12    |
2019-07-29T08:04:13.6442419Z -    = note: for more information, see ***/issues/62254
2019-07-29T08:04:13.6442722Z +    = note: for more information, see issue #62254 <***/issues/62254>
2019-07-29T08:04:13.6442780Z 14    = help: add `#![feature(slice_patterns)]` to the crate attributes to enable
2019-07-29T08:04:13.6442886Z 16 error[E0308]: mismatched types
2019-07-29T08:04:13.6442915Z 
2019-07-29T08:04:13.6442940Z 
2019-07-29T08:04:13.6443001Z The actual stderr differed from the expected stderr.
2019-07-29T08:04:13.6443001Z The actual stderr differed from the expected stderr.
2019-07-29T08:04:13.6443586Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-lt-bracket-6/pat-lt-bracket-6.stderr
2019-07-29T08:04:13.6443843Z To update references, rerun the tests and pass the `--bless` flag
2019-07-29T08:04:13.6444124Z To only update this specific test, also pass `--test-args parser/pat-lt-bracket-6.rs`
2019-07-29T08:04:13.6444214Z error: 1 errors occurred comparing output.
2019-07-29T08:04:13.6444275Z status: exit code: 1
2019-07-29T08:04:13.6444275Z status: exit code: 1
2019-07-29T08:04:13.6444997Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/pat-lt-bracket-6.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-lt-bracket-6" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-lt-bracket-6/auxiliary" "-A" "unused"
2019-07-29T08:04:13.6445314Z ------------------------------------------
2019-07-29T08:04:13.6445347Z 
2019-07-29T08:04:13.6445558Z ------------------------------------------
2019-07-29T08:04:13.6445620Z stderr:
2019-07-29T08:04:13.6445620Z stderr:
2019-07-29T08:04:13.6445830Z ------------------------------------------
2019-07-29T08:04:13.6445889Z error: expected one of `)`, `,`, or `@`, found `[`
2019-07-29T08:04:13.6446144Z   --> /checkout/src/test/ui/parser/pat-lt-bracket-6.rs:5:19
2019-07-29T08:04:13.6446193Z    |
2019-07-29T08:04:13.6446245Z LL |     let Test(&desc[..]) = x; //~ ERROR: expected one of `)`, `,`, or `@`, found `[`
2019-07-29T08:04:13.6446316Z    |                   ^ expected one of `)`, `,`, or `@` here
2019-07-29T08:04:13.6446519Z error[E0658]: subslice patterns are unstable
2019-07-29T08:04:13.6446762Z   --> /checkout/src/test/ui/parser/pat-lt-bracket-6.rs:5:20
2019-07-29T08:04:13.6446806Z    |
2019-07-29T08:04:13.6446806Z    |
2019-07-29T08:04:13.6446853Z LL |     let Test(&desc[..]) = x; //~ ERROR: expected one of `)`, `,`, or `@`, found `[`
2019-07-29T08:04:13.6447079Z    |
2019-07-29T08:04:13.6447079Z    |
2019-07-29T08:04:13.6447381Z    = note: for more information, see issue #62254 <***/issues/62254>
2019-07-29T08:04:13.6447454Z    = help: add `#![feature(slice_patterns)]` to the crate attributes to enable
2019-07-29T08:04:13.6447649Z error[E0308]: mismatched types
2019-07-29T08:04:13.6448012Z   --> /checkout/src/test/ui/parser/pat-lt-bracket-6.rs:9:30
2019-07-29T08:04:13.6448077Z    |
2019-07-29T08:04:13.6448077Z    |
2019-07-29T08:04:13.6448124Z LL | const RECOVERY_WITNESS: () = 0; //~ ERROR mismatched types
2019-07-29T08:04:13.6448174Z    |                              ^ expected (), found integer
2019-07-29T08:04:13.6448276Z    = note: expected type `()`
2019-07-29T08:04:13.6448276Z    = note: expected type `()`
2019-07-29T08:04:13.6448321Z               found type `{integer}`
2019-07-29T08:04:13.6448410Z error: aborting due to 3 previous errors
2019-07-29T08:04:13.6448438Z 
2019-07-29T08:04:13.6448483Z Some errors have detailed explanations: E0308, E0658.
2019-07-29T08:04:13.6448742Z For more information about an error, try `rustc --explain E0308`.
2019-07-29T08:04:13.6448742Z For more information about an error, try `rustc --explain E0308`.
2019-07-29T08:04:13.6448775Z 
2019-07-29T08:04:13.6448986Z ------------------------------------------
2019-07-29T08:04:13.6449016Z 
2019-07-29T08:04:13.6449041Z 
2019-07-29T08:04:13.6449280Z ---- [ui] ui/parser/pat-tuple-5.rs stdout ----
2019-07-29T08:04:13.6449334Z diff of stderr:
2019-07-29T08:04:13.6449361Z 
2019-07-29T08:04:13.6449401Z 10 LL |         (PAT ..) => {}
2019-07-29T08:04:13.6449504Z 12    |
2019-07-29T08:04:13.6449504Z 12    |
2019-07-29T08:04:13.6449804Z -    = note: for more information, see ***/issues/37854
2019-07-29T08:04:13.6450107Z +    = note: for more information, see issue #37854 <***/issues/37854>
2019-07-29T08:04:13.6450167Z 14    = help: add `#![feature(exclusive_range_pattern)]` to the crate attributes to enable
2019-07-29T08:04:13.6450272Z 16 error[E0308]: mismatched types
2019-07-29T08:04:13.6450301Z 
2019-07-29T08:04:13.6450327Z 
2019-07-29T08:04:13.6450387Z The actual stderr differed from the expected stderr.
2019-07-29T08:04:13.6450387Z The actual stderr differed from the expected stderr.
2019-07-29T08:04:13.6450803Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-tuple-5/pat-tuple-5.stderr
2019-07-29T08:04:13.6451047Z To update references, rerun the tests and pass the `--bless` flag
2019-07-29T08:04:13.6451317Z To only update this specific test, also pass `--test-args parser/pat-tuple-5.rs`
2019-07-29T08:04:13.6451393Z error: 1 errors occurred comparing output.
2019-07-29T08:04:13.6451450Z status: exit code: 1
2019-07-29T08:04:13.6451450Z status: exit code: 1
2019-07-29T08:04:13.6452255Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/pat-tuple-5.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-tuple-5" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-tuple-5/auxiliary" "-A" "unused"
2019-07-29T08:04:13.6452569Z ------------------------------------------
2019-07-29T08:04:13.6452609Z 
2019-07-29T08:04:13.6452822Z ------------------------------------------
2019-07-29T08:04:13.6452889Z stderr:
2019-07-29T08:04:13.6452889Z stderr:
2019-07-29T08:04:13.6453330Z ------------------------------------------
2019-07-29T08:04:13.6453391Z error: `X..` range patterns are not supported
2019-07-29T08:04:13.6453694Z   --> /checkout/src/test/ui/parser/pat-tuple-5.rs:5:10
2019-07-29T08:04:13.6453742Z    |
2019-07-29T08:04:13.6453784Z LL |         (PAT ..) => {}
2019-07-29T08:04:13.6453852Z    |          ^^^^^^ help: try using the maximum value for the type: `PAT..MAX`
2019-07-29T08:04:13.6453888Z 
2019-07-29T08:04:13.6453936Z error[E0658]: exclusive range pattern syntax is experimental
2019-07-29T08:04:13.6454167Z   --> /checkout/src/test/ui/parser/pat-tuple-5.rs:5:10
2019-07-29T08:04:13.6454230Z    |
2019-07-29T08:04:13.6454273Z LL |         (PAT ..) => {}
2019-07-29T08:04:13.6454373Z    |
2019-07-29T08:04:13.6454373Z    |
2019-07-29T08:04:13.6454673Z    = note: for more information, see issue #37854 <***/issues/37854>
2019-07-29T08:04:13.6454845Z    = help: add `#![feature(exclusive_range_pattern)]` to the crate attributes to enable
2019-07-29T08:04:13.6454996Z error[E0308]: mismatched types
2019-07-29T08:04:13.6455327Z   --> /checkout/src/test/ui/parser/pat-tuple-5.rs:5:10
2019-07-29T08:04:13.6455393Z    |
2019-07-29T08:04:13.6455435Z LL |     match (0, 1) {
2019-07-29T08:04:13.6455435Z LL |     match (0, 1) {
2019-07-29T08:04:13.6455685Z    |           ------ this match expression has type `({integer}, {integer})`
2019-07-29T08:04:13.6455735Z LL |         (PAT ..) => {}
2019-07-29T08:04:13.6455799Z    |          ^^^^^^ expected tuple, found u8
2019-07-29T08:04:13.6455841Z    |
2019-07-29T08:04:13.6455885Z    = note: expected type `({integer}, {integer})`
2019-07-29T08:04:13.6455947Z               found type `u8`
2019-07-29T08:04:13.6456019Z error: aborting due to 3 previous errors
2019-07-29T08:04:13.6456048Z 
2019-07-29T08:04:13.6456108Z Some errors have detailed explanations: E0308, E0658.
2019-07-29T08:04:13.6456358Z For more information about an error, try `rustc --explain E0308`.
---
2019-07-29T08:04:13.6456989Z 
2019-07-29T08:04:13.6457030Z 10 LL |         (.. PAT) => {}
2019-07-29T08:04:13.6457073Z 11    |          ^^^^^^
2019-07-29T08:04:13.6457114Z 12    |
2019-07-29T08:04:13.6457412Z -    = note: for more information, see ***/issues/37854
2019-07-29T08:04:13.6457712Z +    = note: for more information, see issue #37854 <***/issues/37854>
2019-07-29T08:04:13.6457787Z 14    = help: add `#![feature(exclusive_range_pattern)]` to the crate attributes to enable
2019-07-29T08:04:13.6457879Z 16 error[E0308]: mismatched types
2019-07-29T08:04:13.6457924Z 
2019-07-29T08:04:13.6457949Z 
2019-07-29T08:04:13.6458002Z The actual stderr differed from the expected stderr.
2019-07-29T08:04:13.6458002Z The actual stderr differed from the expected stderr.
2019-07-29T08:04:13.6458305Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-tuple-4/pat-tuple-4.stderr
2019-07-29T08:04:13.6458567Z To update references, rerun the tests and pass the `--bless` flag
2019-07-29T08:04:13.6458850Z To only update this specific test, also pass `--test-args parser/pat-tuple-4.rs`
2019-07-29T08:04:13.6458949Z error: 1 errors occurred comparing output.
2019-07-29T08:04:13.6458997Z status: exit code: 1
2019-07-29T08:04:13.6458997Z status: exit code: 1
2019-07-29T08:04:13.6459720Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/pat-tuple-4.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-tuple-4" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/pat-tuple-4/auxiliary" "-A" "unused"
2019-07-29T08:04:13.6460069Z ------------------------------------------
2019-07-29T08:04:13.6460119Z 
2019-07-29T08:04:13.6462569Z ------------------------------------------
2019-07-29T08:04:13.6463507Z stderr:
2019-07-29T08:04:13.6463507Z stderr:
2019-07-29T08:04:13.6463843Z ------------------------------------------
2019-07-29T08:04:13.6463920Z error: `..X` range patterns are not supported
2019-07-29T08:04:13.6464159Z   --> /checkout/src/test/ui/parser/pat-tuple-4.rs:5:10
2019-07-29T08:04:13.6464272Z LL |         (.. PAT) => {}
2019-07-29T08:04:13.6464272Z LL |         (.. PAT) => {}
2019-07-29T08:04:13.6464326Z    |          ^^^^^^ help: try using the minimum value for the type: `MIN..PAT`
2019-07-29T08:04:13.6464365Z 
2019-07-29T08:04:13.6464422Z error[E0658]: exclusive range pattern syntax is experimental
2019-07-29T08:04:13.6464703Z   --> /checkout/src/test/ui/parser/pat-tuple-4.rs:5:10
2019-07-29T08:04:13.6464928Z LL |         (.. PAT) => {}
2019-07-29T08:04:13.6465060Z    |          ^^^^^^
2019-07-29T08:04:13.6465106Z    |
2019-07-29T08:04:13.6465106Z    |
2019-07-29T08:04:13.6465498Z    = note: for more information, see issue #37854 <***/issues/37854>
2019-07-29T08:04:13.6465577Z    = help: add `#![feature(exclusive_range_pattern)]` to the crate attributes to enable
2019-07-29T08:04:13.6465657Z error[E0308]: mismatched types
2019-07-29T08:04:13.6465919Z   --> /checkout/src/test/ui/parser/pat-tuple-4.rs:11:30
2019-07-29T08:04:13.6465986Z    |
2019-07-29T08:04:13.6465986Z    |
2019-07-29T08:04:13.6466034Z LL | const RECOVERY_WITNESS: () = 0; //~ ERROR mismatched types
2019-07-29T08:04:13.6466087Z    |                              ^ expected (), found integer
2019-07-29T08:04:13.6466194Z    = note: expected type `()`
2019-07-29T08:04:13.6466194Z    = note: expected type `()`
2019-07-29T08:04:13.6466284Z               found type `{integer}`
2019-07-29T08:04:13.6466377Z error: aborting due to 3 previous errors
2019-07-29T08:04:13.6466418Z 
2019-07-29T08:04:13.6466473Z Some errors have detailed explanations: E0308, E0658.
2019-07-29T08:04:13.6466761Z For more information about an error, try `rustc --explain E0308`.
---
2019-07-29T08:04:13.6470144Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:533:22
2019-07-29T08:04:13.6470243Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-29T08:04:13.6484133Z 
2019-07-29T08:04:13.6484206Z 
2019-07-29T08:04:13.6485869Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-29T08:04:13.6486137Z 
2019-07-29T08:04:13.6486165Z 
2019-07-29T08:04:13.6489390Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-29T08:04:13.6489676Z Build completed unsuccessfully in 1:06:48
2019-07-29T08:04:13.6489676Z Build completed unsuccessfully in 1:06:48
2019-07-29T08:04:14.3284154Z ##[error]Bash exited with code '1'.
2019-07-29T08:04:14.3321647Z ##[section]Starting: Checkout
2019-07-29T08:04:14.3324156Z ==============================================================================
2019-07-29T08:04:14.3324216Z Task         : Get sources
2019-07-29T08:04:14.3324441Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

It'd be nice to normalise the following strings that appear:

  • "for more context, see [...]"
  • "for more information, see [...]"
  • "See [...] for details"
  • "see [...] for more details"
  • "see [...] for more information"

I personally prefer "see [...] for more information", as it has the link early on.

Apart from that, this looks good. If you could squash the --bless/rebase/tidy commits and add @punitkoura as a co-author, I'll approve it.

Show resolved Hide resolved src/librustc/session/mod.rs Outdated
Show resolved Hide resolved src/librustdoc/core.rs Outdated
Show resolved Hide resolved src/librustdoc/config.rs Outdated
@eupn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

It'd be nice to normalise the following strings that appear:

* "for more context, see [...]"

* "for more information, see [...]"

* "See [...] for details"

* "see [...] for more details"

* "see [...] for more information"

I personally prefer "see [...] for more information", as it has the link early on.

Apart from that, this looks good. If you could squash the --bless/rebase/tidy commits and add @punitkoura as a co-author, I'll approve it.

@punitkoura don't you mind if I'll use your email pkoura@andrew.cmu.edu as Co-authored-by for commits?

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

☔️ The latest upstream changes (presumably #63124) made this pull request unmergeable. Please resolve the merge conflicts.

@eupn eupn force-pushed the eupn:consistent-see-issue branch 2 times, most recently from 45451db to f1d1ba5 Jul 30, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-30T09:50:35.3380662Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-30T09:50:35.3553822Z ##[command]git config gc.auto 0
2019-07-30T09:50:35.3626461Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-30T09:50:35.3678134Z ##[command]git config --get-all http.proxy
2019-07-30T09:50:35.3811543Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63008/merge:refs/remotes/pull/63008/merge
---
2019-07-30T09:51:09.2529702Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-30T09:51:09.2529727Z 
2019-07-30T09:51:09.2529891Z   git checkout -b <new-branch-name>
2019-07-30T09:51:09.2529914Z 
2019-07-30T09:51:09.2529952Z HEAD is now at 350964d60 Merge f1d1ba5646c9a774e049d20dad3b18c66e1ae3bc into 4eeaaa722d6ac6d24de6e4d3faefb7c44e674b37
2019-07-30T09:51:09.2667118Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-30T09:51:09.2669623Z ==============================================================================
2019-07-30T09:51:09.2669669Z Task         : Bash
2019-07-30T09:51:09.2669707Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-30T10:49:05.8072150Z .................................................................................................... 1400/8813
2019-07-30T10:49:11.1687084Z .................................................................................................... 1500/8813
2019-07-30T10:49:22.7442881Z ................................................................i...............i................... 1600/8813
2019-07-30T10:49:29.7601262Z .................................................................................................... 1700/8813
2019-07-30T10:49:43.1703845Z ..................................................iiiii............................................. 1800/8813
2019-07-30T10:49:53.4827053Z .................................................................................................... 2000/8813
2019-07-30T10:49:55.8357892Z .................................................................................................... 2100/8813
2019-07-30T10:49:59.0141445Z .................................................................................................... 2200/8813
2019-07-30T10:50:05.1032492Z .................................................................................................... 2300/8813
---
2019-07-30T10:53:41.8199509Z .................................................................................................... 5300/8813
2019-07-30T10:53:48.3887208Z ........i........................................................................................... 5400/8813
2019-07-30T10:53:53.4615810Z .................................................................................................... 5500/8813
2019-07-30T10:54:05.0971074Z .................................................................................................... 5600/8813
2019-07-30T10:54:18.0103539Z ..ii...i..ii...........i............................................................................ 5700/8813
2019-07-30T10:54:31.1785456Z .................................................................................................... 5900/8813
2019-07-30T10:54:35.4802979Z .................................................................................................... 6000/8813
2019-07-30T10:54:35.4802979Z .................................................................................................... 6000/8813
2019-07-30T10:54:48.7432821Z ..i..ii............................................................................................. 6100/8813
2019-07-30T10:55:06.0155549Z .............................................i...................................................... 6300/8813
2019-07-30T10:55:07.9962249Z .................................................................................................... 6400/8813
2019-07-30T10:55:10.3392386Z ...............i.................................................................................... 6500/8813
2019-07-30T10:55:14.4307528Z .................................................................................................... 6600/8813
---
2019-07-30T10:59:30.3293345Z  finished in 19.104
2019-07-30T10:59:30.3443806Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T10:59:30.4866468Z 
2019-07-30T10:59:30.4866900Z running 146 tests
2019-07-30T10:59:33.4667607Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-30T10:59:35.2207571Z iii..............i.........iii.i......ii......
2019-07-30T10:59:35.2208212Z 
2019-07-30T10:59:35.2209979Z  finished in 4.876
2019-07-30T10:59:35.2386688Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T10:59:35.3829060Z 
---
2019-07-30T10:59:37.2788987Z  finished in 2.040
2019-07-30T10:59:37.2948745Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T10:59:37.4298130Z 
2019-07-30T10:59:37.4298272Z running 9 tests
2019-07-30T10:59:37.4298885Z iiiiiiiii
2019-07-30T10:59:37.4299266Z 
2019-07-30T10:59:37.4303201Z  finished in 0.135
2019-07-30T10:59:37.4462661Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T10:59:37.5962034Z 
---
2019-07-30T10:59:54.7576474Z  finished in 16.865
2019-07-30T10:59:54.7576704Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T10:59:54.7576764Z 
2019-07-30T10:59:54.7576803Z running 122 tests
2019-07-30T11:00:16.0595880Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-30T11:00:20.1947657Z .i.i......iii.i.....ii
2019-07-30T11:00:20.1949154Z 
2019-07-30T11:00:20.1950518Z  finished in 25.866
2019-07-30T11:00:20.1953152Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T11:00:20.1953637Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-30T11:01:14.7159404Z 
2019-07-30T11:01:14.7159442Z 8 LL | extern crate rustc_data_structures;
2019-07-30T11:01:14.7159479Z 9    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7159513Z 10    |
2019-07-30T11:01:14.7160237Z -    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-30T11:01:14.7160540Z +    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7160612Z 12    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7160650Z 13 
2019-07-30T11:01:14.7160960Z 14 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7161054Z 17 LL | extern crate rustc;
2019-07-30T11:01:14.7161097Z 18    | ^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7161147Z 19    |
2019-07-30T11:01:14.7161147Z 19    |
2019-07-30T11:01:14.7161385Z -    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-30T11:01:14.7161642Z +    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7161690Z 21    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7161725Z 22 
2019-07-30T11:01:14.7162046Z 23 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7162118Z 26 LL | extern crate rustc_macros;
2019-07-30T11:01:14.7162173Z 27    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7162206Z 28    |
2019-07-30T11:01:14.7162206Z 28    |
2019-07-30T11:01:14.7162435Z -    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-30T11:01:14.7162690Z +    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7162743Z 30    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7162780Z 31 
2019-07-30T11:01:14.7163096Z 32 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7163166Z 35 LL | use rustc_macros::HashStable;
2019-07-30T11:01:14.7163228Z 36    |     ^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7163262Z 37    |
2019-07-30T11:01:14.7163262Z 37    |
2019-07-30T11:01:14.7163495Z -    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-30T11:01:14.7163751Z +    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7163797Z 39    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7163852Z 40 
2019-07-30T11:01:14.7164593Z 41 error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7164724Z 44 LL | #[derive(HashStable)]
2019-07-30T11:01:14.7164770Z 45    |          ^^^^^^^^^^
2019-07-30T11:01:14.7164813Z 46    |
2019-07-30T11:01:14.7164813Z 46    |
2019-07-30T11:01:14.7165142Z -    = note: for more information, see issue #27812 <***/issues/27812>
2019-07-30T11:01:14.7165615Z +    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7165687Z 48    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7165802Z 50 error: aborting due to 6 previous errors
2019-07-30T11:01:14.7165833Z 
2019-07-30T11:01:14.7165859Z 
2019-07-30T11:01:14.7165922Z The actual stderr differed from the expected stderr.
2019-07-30T11:01:14.7165922Z The actual stderr differed from the expected stderr.
2019-07-30T11:01:14.7166297Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/hash-stable-is-unstable/hash-stable-is-unstable.stderr
2019-07-30T11:01:14.7166665Z To update references, rerun the tests and pass the `--bless` flag
2019-07-30T11:01:14.7166948Z To only update this specific test, also pass `--test-args hash-stable-is-unstable.rs`
2019-07-30T11:01:14.7167031Z error: 1 errors occurred comparing output.
2019-07-30T11:01:14.7167095Z status: exit code: 1
2019-07-30T11:01:14.7167095Z status: exit code: 1
2019-07-30T11:01:14.7167953Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/hash-stable-is-unstable.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/hash-stable-is-unstable" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/hash-stable-is-unstable/auxiliary" "-A" "unused"
2019-07-30T11:01:14.7168409Z ------------------------------------------
2019-07-30T11:01:14.7168437Z 
2019-07-30T11:01:14.7168605Z ------------------------------------------
2019-07-30T11:01:14.7168660Z stderr:
2019-07-30T11:01:14.7168660Z stderr:
2019-07-30T11:01:14.7168825Z ------------------------------------------
2019-07-30T11:01:14.7168867Z error[E0601]: `main` function not found in crate `hash_stable_is_unstable`
2019-07-30T11:01:14.7168922Z    |
2019-07-30T11:01:14.7169151Z    = note: consider adding a `main` function to `/checkout/src/test/ui-fulldeps/hash-stable-is-unstable.rs`
2019-07-30T11:01:14.7169183Z 
2019-07-30T11:01:14.7169492Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7169753Z    |
2019-07-30T11:01:14.7169795Z LL | extern crate rustc_data_structures;
2019-07-30T11:01:14.7169832Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7169865Z    |
2019-07-30T11:01:14.7169865Z    |
2019-07-30T11:01:14.7170120Z    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7170166Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7170193Z 
2019-07-30T11:01:14.7170514Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7170753Z    |
2019-07-30T11:01:14.7170800Z LL | extern crate rustc;
2019-07-30T11:01:14.7170835Z    | ^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7209630Z    |
2019-07-30T11:01:14.7209630Z    |
2019-07-30T11:01:14.7210094Z    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7210160Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7210203Z 
2019-07-30T11:01:14.7210524Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7210783Z    |
2019-07-30T11:01:14.7210954Z LL | extern crate rustc_macros;
2019-07-30T11:01:14.7211001Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7211051Z    |
2019-07-30T11:01:14.7211051Z    |
2019-07-30T11:01:14.7211330Z    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7211378Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7211420Z 
2019-07-30T11:01:14.7211719Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7212084Z    |
2019-07-30T11:01:14.7212118Z LL | use rustc_macros::HashStable;
2019-07-30T11:01:14.7212154Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^
2019-07-30T11:01:14.7212202Z    |
2019-07-30T11:01:14.7212202Z    |
2019-07-30T11:01:14.7212437Z    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7212493Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7212536Z 
2019-07-30T11:01:14.7212836Z error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-30T11:01:14.7213092Z    |
2019-07-30T11:01:14.7213125Z LL | #[derive(HashStable)]
2019-07-30T11:01:14.7213167Z    |          ^^^^^^^^^^
2019-07-30T11:01:14.7213200Z    |
2019-07-30T11:01:14.7213200Z    |
2019-07-30T11:01:14.7213444Z    = note: see issue #27812 <***/issues/27812> for more information
2019-07-30T11:01:14.7213491Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-30T11:01:14.7213566Z error: aborting due to 6 previous errors
2019-07-30T11:01:14.7213589Z 
2019-07-30T11:01:14.7213623Z Some errors have detailed explanations: E0601, E0658.
2019-07-30T11:01:14.7213846Z For more information about an error, try `rustc --explain E0601`.
2019-07-30T11:01:14.7213846Z For more information about an error, try `rustc --explain E0601`.
2019-07-30T11:01:14.7213874Z 
2019-07-30T11:01:14.7214426Z ------------------------------------------
2019-07-30T11:01:14.7214466Z 
2019-07-30T11:01:14.7214492Z 
2019-07-30T11:01:14.7214769Z ---- [ui] ui-fulldeps/gated-plugin.rs stdout ----
2019-07-30T11:01:14.7214818Z diff of stderr:
2019-07-30T11:01:14.7214846Z 
2019-07-30T11:01:14.7214890Z 4 LL | #![plugin(attr_plugin_test)]
2019-07-30T11:01:14.7215008Z 6    |
2019-07-30T11:01:14.7215008Z 6    |
2019-07-30T11:01:14.7215343Z -    = note: for more information, see issue #29597 <***/issues/29597>
2019-07-30T11:01:14.7215654Z +    = note: see issue #29597 <***/issues/29597> for more information
2019-07-30T11:01:14.7215713Z 8    = help: add `#![feature(plugin)]` to the crate attributes to enable
2019-07-30T11:01:14.7215822Z 10 error: aborting due to previous error
2019-07-30T11:01:14.7215852Z 
2019-07-30T11:01:14.7215878Z 
2019-07-30T11:01:14.7215950Z The actual stderr differed from the expected stderr.
2019-07-30T11:01:14.7215950Z The actual stderr differed from the expected stderr.
2019-07-30T11:01:14.7216257Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/gated-plugin.stderr
2019-07-30T11:01:14.7216504Z To update references, rerun the tests and pass the `--bless` flag
2019-07-30T11:01:14.7216779Z To only update this specific test, also pass `--test-args gated-plugin.rs`
2019-07-30T11:01:14.7216859Z error: 1 errors occurred comparing output.
2019-07-30T11:01:14.7216914Z status: exit code: 1
2019-07-30T11:01:14.7216914Z status: exit code: 1
2019-07-30T11:01:14.7217874Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/gated-plugin.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary" "-A" "unused"
2019-07-30T11:01:14.7218183Z ------------------------------------------
2019-07-30T11:01:14.7218212Z 
2019-07-30T11:01:14.7218388Z ------------------------------------------
2019-07-30T11:01:14.7218441Z stderr:
2019-07-30T11:01:14.7218441Z stderr:
2019-07-30T11:01:14.7218615Z ------------------------------------------
2019-07-30T11:01:14.7218657Z error[E0658]: compiler plugins are experimental and possibly buggy
2019-07-30T11:01:14.7218953Z   --> /checkout/src/test/ui-fulldeps/gated-plugin.rs:3:1
2019-07-30T11:01:14.7218995Z    |
2019-07-30T11:01:14.7219030Z LL | #![plugin(attr_plugin_test)]
2019-07-30T11:01:14.7219118Z    |
2019-07-30T11:01:14.7219118Z    |
2019-07-30T11:01:14.7219362Z    = note: see issue #29597 <***/issues/29597> for more information
2019-07-30T11:01:14.7219432Z    = help: add `#![feature(plugin)]` to the crate attributes to enable
2019-07-30T11:01:14.7219493Z error: aborting due to previous error
2019-07-30T11:01:14.7219517Z 
2019-07-30T11:01:14.7219737Z For more information about this error, try `rustc --explain E0658`.
2019-07-30T11:01:14.7219766Z 
---
2019-07-30T11:01:14.7262365Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:533:22
2019-07-30T11:01:14.7262435Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-30T11:01:14.7262478Z 
2019-07-30T11:01:14.7262500Z 
2019-07-30T11:01:14.7264461Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-30T11:01:14.7264785Z 
2019-07-30T11:01:14.7264817Z 
2019-07-30T11:01:14.7264873Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-30T11:01:14.7264927Z Build completed unsuccessfully in 1:04:02
2019-07-30T11:01:14.7264927Z Build completed unsuccessfully in 1:04:02
2019-07-30T11:01:15.6431063Z ##[error]Bash exited with code '1'.
2019-07-30T11:01:15.6469614Z ##[section]Starting: Checkout
2019-07-30T11:01:15.6473047Z ==============================================================================
2019-07-30T11:01:15.6473105Z Task         : Get sources
2019-07-30T11:01:15.6473154Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eupn eupn force-pushed the eupn:consistent-see-issue branch from f1d1ba5 to 3c2da80 Jul 30, 2019

@punitkoura

This comment has been minimized.

Copy link

commented Jul 30, 2019

@eupn, yes, that email id works
Name - Punit Singh Koura
Email - pkoura@andrew.cmu.edu

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

☔️ The latest upstream changes (presumably #63148) made this pull request unmergeable. Please resolve the merge conflicts.

@eupn eupn force-pushed the eupn:consistent-see-issue branch from 3c2da80 to 955d629 Jul 31, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 31, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-31T08:35:45.9334016Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-31T08:35:45.9542264Z ##[command]git config gc.auto 0
2019-07-31T08:35:45.9608845Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-31T08:35:45.9678991Z ##[command]git config --get-all http.proxy
2019-07-31T08:35:45.9824288Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63008/merge:refs/remotes/pull/63008/merge
---
2019-07-31T08:36:21.2742319Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-31T08:36:21.2742359Z 
2019-07-31T08:36:21.2742583Z   git checkout -b <new-branch-name>
2019-07-31T08:36:21.2742610Z 
2019-07-31T08:36:21.2742673Z HEAD is now at 937722a64 Merge 955d629abe965f62fa6a44f1de8263a0758c17d7 into 4a18848e05b0957474fdb5be162502742b5eb9fd
2019-07-31T08:36:21.2915244Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-31T08:36:21.2919393Z ==============================================================================
2019-07-31T08:36:21.2919454Z Task         : Bash
2019-07-31T08:36:21.2919501Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-31T09:37:16.3889867Z .................................................................................................... 1400/8819
2019-07-31T09:37:22.4528314Z .................................................................................................... 1500/8819
2019-07-31T09:37:35.8142898Z .................................................................i...............i.................. 1600/8819
2019-07-31T09:37:43.7375942Z .................................................................................................... 1700/8819
2019-07-31T09:37:59.3907449Z ...................................................iiiii............................................ 1800/8819
2019-07-31T09:38:11.4124689Z .................................................................................................... 2000/8819
2019-07-31T09:38:14.1611316Z .................................................................................................... 2100/8819
2019-07-31T09:38:18.0769549Z .................................................................................................... 2200/8819
2019-07-31T09:38:25.0390746Z .................................................................................................... 2300/8819
---
2019-07-31T09:42:31.0361382Z .................................................................................................... 5300/8819
2019-07-31T09:42:38.8660790Z ..............i..................................................................................... 5400/8819
2019-07-31T09:42:44.6760299Z .................................................................................................... 5500/8819
2019-07-31T09:42:57.0824609Z .................................................................................................... 5600/8819
2019-07-31T09:43:10.7733745Z ........ii...i..ii...........i...................................................................... 5700/8819
2019-07-31T09:43:27.0395727Z .................................................................................................... 5900/8819
2019-07-31T09:43:32.1205050Z .................................................................................................... 6000/8819
2019-07-31T09:43:32.1205050Z .................................................................................................... 6000/8819
2019-07-31T09:43:46.2664220Z ........i..ii....................................................................................... 6100/8819
2019-07-31T09:44:05.5927054Z ...................................................i................................................ 6300/8819
2019-07-31T09:44:07.8777528Z .................................................................................................... 6400/8819
2019-07-31T09:44:10.4096232Z .....................i.............................................................................. 6500/8819
2019-07-31T09:44:15.1330429Z .................................................................................................... 6600/8819
---
2019-07-31T09:48:18.8068826Z 
2019-07-31T09:48:18.8069380Z ---- [ui] ui/async-await/await-keyword/2015-edition-error-various-positions.rs stdout ----
2019-07-31T09:48:18.8069457Z diff of stderr:
2019-07-31T09:48:18.8069487Z 
2019-07-31T09:48:18.8069539Z 73    |     ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8069588Z 74    |
2019-07-31T09:48:18.8069664Z 75    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8070086Z -    = note: for more information, see issue #49716 <***/issues/49716>
2019-07-31T09:48:18.8070614Z +    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8070693Z 77 
2019-07-31T09:48:18.8070740Z 78 error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8071044Z 79   --> $DIR/2015-edition-error-various-positions.rs:35:11
2019-07-31T09:48:18.8071105Z 
2019-07-31T09:48:18.8071152Z The actual stderr differed from the expected stderr.
2019-07-31T09:48:18.8071534Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/await-keyword/2015-edition-error-various-positions/2015-edition-error-various-positions.stderr
2019-07-31T09:48:18.8071534Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/await-keyword/2015-edition-error-various-positions/2015-edition-error-various-positions.stderr
2019-07-31T09:48:18.8071785Z To update references, rerun the tests and pass the `--bless` flag
2019-07-31T09:48:18.8072086Z To only update this specific test, also pass `--test-args async-await/await-keyword/2015-edition-error-various-positions.rs`
2019-07-31T09:48:18.8072187Z error: 1 errors occurred comparing output.
2019-07-31T09:48:18.8072232Z status: exit code: 1
2019-07-31T09:48:18.8072232Z status: exit code: 1
2019-07-31T09:48:18.8073114Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/async-await/await-keyword/2015-edition-error-various-positions.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/await-keyword/2015-edition-error-various-positions" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/await-keyword/2015-edition-error-various-positions/auxiliary" "-A" "unused"
2019-07-31T09:48:18.8073466Z ------------------------------------------
2019-07-31T09:48:18.8073500Z 
2019-07-31T09:48:18.8073714Z ------------------------------------------
2019-07-31T09:48:18.8073888Z stderr:
2019-07-31T09:48:18.8073888Z stderr:
2019-07-31T09:48:18.8074102Z ------------------------------------------
2019-07-31T09:48:18.8074281Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8075015Z    |
2019-07-31T09:48:18.8075015Z    |
2019-07-31T09:48:18.8075063Z LL |     pub mod await { //~ ERROR `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8075132Z    |             ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8075217Z note: lint level defined here
2019-07-31T09:48:18.8075473Z   --> /checkout/src/test/ui/async-await/await-keyword/2015-edition-error-various-positions.rs:3:9
2019-07-31T09:48:18.8075536Z    |
2019-07-31T09:48:18.8075536Z    |
2019-07-31T09:48:18.8075576Z LL | #![deny(keyword_idents)]
2019-07-31T09:48:18.8075618Z    |         ^^^^^^^^^^^^^^
2019-07-31T09:48:18.8075690Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8075993Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8076054Z 
2019-07-31T09:48:18.8076096Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8076427Z    |
2019-07-31T09:48:18.8076427Z    |
2019-07-31T09:48:18.8076472Z LL |         pub struct await; //~ ERROR `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8076525Z    |                    ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8076569Z    |
2019-07-31T09:48:18.8076639Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8076923Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8076973Z 
2019-07-31T09:48:18.8077014Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8077598Z    |
2019-07-31T09:48:18.8077598Z    |
2019-07-31T09:48:18.8077662Z LL | use outer_mod::await::await; //~ ERROR `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8077717Z    |                ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8077762Z    |
2019-07-31T09:48:18.8078518Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8078897Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8078932Z 
2019-07-31T09:48:18.8078995Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8079329Z    |
2019-07-31T09:48:18.8079329Z    |
2019-07-31T09:48:18.8079396Z LL | use outer_mod::await::await; //~ ERROR `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8079464Z    |                       ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8079518Z    |
2019-07-31T09:48:18.8079592Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8079894Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8079930Z 
2019-07-31T09:48:18.8079991Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8080321Z    |
2019-07-31T09:48:18.8080321Z    |
2019-07-31T09:48:18.8080381Z LL | struct Foo { await: () }
2019-07-31T09:48:18.8080433Z    |              ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8080480Z    |
2019-07-31T09:48:18.8080561Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8080999Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8081034Z 
2019-07-31T09:48:18.8081095Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8081427Z    |
2019-07-31T09:48:18.8081427Z    |
2019-07-31T09:48:18.8081487Z LL | impl Foo { fn await() {} }
2019-07-31T09:48:18.8081540Z    |               ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8081586Z    |
2019-07-31T09:48:18.8081659Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8081956Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8081991Z 
2019-07-31T09:48:18.8082052Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8082401Z    |
2019-07-31T09:48:18.8082401Z    |
2019-07-31T09:48:18.8082444Z LL | macro_rules! await {
2019-07-31T09:48:18.8082512Z    |              ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8082559Z    |
2019-07-31T09:48:18.8082614Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8082931Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8082967Z 
2019-07-31T09:48:18.8083011Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8083358Z    |
2019-07-31T09:48:18.8083358Z    |
2019-07-31T09:48:18.8083405Z LL |     await!(); //~ ERROR `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8083575Z    |     ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8083637Z    |
2019-07-31T09:48:18.8083692Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8084042Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8084078Z 
2019-07-31T09:48:18.8084124Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8084472Z    |
2019-07-31T09:48:18.8084472Z    |
2019-07-31T09:48:18.8084522Z LL |     match await { await => {} } //~ ERROR `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8084597Z    |           ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8084642Z    |
2019-07-31T09:48:18.8084697Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8085032Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8085068Z 
2019-07-31T09:48:18.8085113Z error: `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8085465Z    |
2019-07-31T09:48:18.8085465Z    |
2019-07-31T09:48:18.8085515Z LL |     match await { await => {} } //~ ERROR `await` is a keyword in the 2018 edition
2019-07-31T09:48:18.8085589Z    |                   ^^^^^ help: you can use a raw identifier to stay compatible: `r#await`
2019-07-31T09:48:18.8085635Z    |
2019-07-31T09:48:18.8085690Z    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition!
2019-07-31T09:48:18.8086005Z    = note: see issue #49716 <***/issues/49716> for more information
2019-07-31T09:48:18.8086085Z error: aborting due to 10 previous errors
2019-07-31T09:48:18.8086114Z 
2019-07-31T09:48:18.8086249Z 
2019-07-31T09:48:18.8086496Z ------------------------------------------
---
2019-07-31T09:48:18.8104340Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:533:22
2019-07-31T09:48:18.8104589Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-31T09:48:18.8120314Z 
2019-07-31T09:48:18.8120425Z 
2019-07-31T09:48:18.8122837Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-31T09:48:18.8123129Z 
2019-07-31T09:48:18.8123159Z 
2019-07-31T09:48:18.8129554Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-31T09:48:18.8129627Z Build completed unsuccessfully in 1:05:22
2019-07-31T09:48:18.8129627Z Build completed unsuccessfully in 1:05:22
2019-07-31T09:48:19.6887281Z ##[error]Bash exited with code '1'.
2019-07-31T09:48:19.6946194Z ##[section]Starting: Checkout
2019-07-31T09:48:19.6948739Z ==============================================================================
2019-07-31T09:48:19.6948800Z Task         : Get sources
2019-07-31T09:48:19.6948849Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eupn eupn force-pushed the eupn:consistent-see-issue branch from 955d629 to 7336626 Jul 31, 2019

@eupn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@varkor

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

📌 Commit 7336626 has been approved by varkor

Centril added a commit to Centril/rust that referenced this pull request Jul 31, 2019

Rollup merge of rust-lang#63008 - eupn:consistent-see-issue, r=varkor
Make "see issue" consistent

Fixes rust-lang#62976. h/t to @punitkoura for initial patterns search.

r? @varkor

bors added a commit that referenced this pull request Jul 31, 2019

Auto merge of #63176 - Centril:rollup-jtbtt4n, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #62971 (Add keywords item into the sidebar)
 - #63008 (Make "see issue" consistent)
 - #63122 (Account for `maybe_whole_expr` in range patterns)
 - #63146 (Cleanup syntax::attr)
 - #63153 (Remove redundant method with const variable resolution)
 - #63170 (cleanup StringReader fields)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Failed in #63176 (comment), @bors r-

Please --bless --compare-mode=nll to fix the issues.

@eupn eupn force-pushed the eupn:consistent-see-issue branch from 7336626 to 2ae0619 Aug 1, 2019

@eupn

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

📌 Commit 2ae0619 has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

☔️ The latest upstream changes (presumably #63180) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout consistent-see-issue (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self consistent-see-issue --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging src/test/ui/type-alias-impl-trait/issue-60371.stderr
CONFLICT (content): Merge conflict in src/test/ui/type-alias-impl-trait/issue-60371.stderr
Auto-merging src/test/ui/privacy/private-in-public-assoc-ty.stderr
Auto-merging src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr
CONFLICT (modify/delete): src/test/ui/feature-gates/feature-gate-existential-type.stderr deleted in HEAD and modified in heads/homu-tmp. Version heads/homu-tmp of src/test/ui/feature-gates/feature-gate-existential-type.stderr left in tree.
Auto-merging src/test/ui/consts/const-eval/match-test-ptr-null.stderr
Auto-merging src/test/ui/consts/const-eval/match-test-ptr-null.rs
CONFLICT (content): Merge conflict in src/test/ui/consts/const-eval/match-test-ptr-null.rs
Auto-merging src/test/ui/consts/const-eval/issue-52442.stderr
Auto-merging src/libsyntax/parse/lexer/mod.rs
Auto-merging src/libsyntax/feature_gate.rs
Auto-merging src/librustc_typeck/check/mod.rs
Automatic merge failed; fix conflicts and then commit the result.

Unify Github issue links in diagnostics
Co-authored-by: eupn <eupn@protonmail.com>
Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>

@eupn eupn force-pushed the eupn:consistent-see-issue branch from 2ae0619 to b2f9199 Aug 8, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-08T14:57:09.7998733Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-08T14:57:09.8183853Z ##[command]git config gc.auto 0
2019-08-08T14:57:09.8250106Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-08T14:57:09.8303105Z ##[command]git config --get-all http.proxy
2019-08-08T14:57:09.8437893Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63008/merge:refs/remotes/pull/63008/merge
---
2019-08-08T14:57:44.3532239Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-08T14:57:44.3533600Z 
2019-08-08T14:57:44.3535584Z   git checkout -b <new-branch-name>
2019-08-08T14:57:44.3536215Z 
2019-08-08T14:57:44.3536743Z HEAD is now at 59290648e Merge b2f919985b365c912aafdbe37dce920e25f38cd6 into 2628f579f6246df385acf9203bf2ffb6aedf5ccc
2019-08-08T14:57:44.3657989Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-08T14:57:44.3660819Z ==============================================================================
2019-08-08T14:57:44.3660880Z Task         : Bash
2019-08-08T14:57:44.3660946Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-08T15:03:43.3011301Z    Compiling serde_json v1.0.40
2019-08-08T15:03:47.5124052Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-08T15:03:55.9110832Z     Finished release [optimized] target(s) in 1m 27s
2019-08-08T15:03:55.9174980Z tidy check
2019-08-08T15:03:56.1193234Z tidy error: /checkout/src/test/ui/consts/const-eval/match-test-ptr-null.rs:6: trailing whitespace
2019-08-08T15:03:57.7467810Z some tidy checks failed
2019-08-08T15:03:57.7468336Z 
2019-08-08T15:03:57.7468336Z 
2019-08-08T15:03:57.7469585Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-08T15:03:57.7469728Z 
2019-08-08T15:03:57.7469754Z 
2019-08-08T15:03:57.7469825Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-08T15:03:57.7469878Z Build completed unsuccessfully in 0:01:30
2019-08-08T15:03:57.7469878Z Build completed unsuccessfully in 0:01:30
2019-08-08T15:03:59.0351150Z ##[error]Bash exited with code '1'.
2019-08-08T15:03:59.0383050Z ##[section]Starting: Checkout
2019-08-08T15:03:59.0384751Z ==============================================================================
2019-08-08T15:03:59.0384820Z Task         : Get sources
2019-08-08T15:03:59.0384864Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eupn and others added some commits Jul 26, 2019

Bless ui test files
Co-authored-by: eupn <eupn@protonmail.com>
Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
Apply suggestions from review by varkor
Co-Authored-By: varkor <github@varkor.com>

@eupn eupn force-pushed the eupn:consistent-see-issue branch from b2f9199 to 8307000 Aug 9, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-09T06:55:48.8790476Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-09T06:55:48.8971896Z ##[command]git config gc.auto 0
2019-08-09T06:55:48.9061969Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-09T06:55:48.9120498Z ##[command]git config --get-all http.proxy
2019-08-09T06:55:48.9279920Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63008/merge:refs/remotes/pull/63008/merge
---
2019-08-09T06:56:25.4243647Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-09T06:56:25.4243821Z 
2019-08-09T06:56:25.4244242Z   git checkout -b <new-branch-name>
2019-08-09T06:56:25.4244403Z 
2019-08-09T06:56:25.4244571Z HEAD is now at de4d95214 Merge 8307000cabb34c98ef5bbfcf93ec4b72099419c0 into 5aa3d9a7b5d3a46a7f158e8881146331a6bc9243
2019-08-09T06:56:25.4393822Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-09T06:56:25.4396518Z ==============================================================================
2019-08-09T06:56:25.4396576Z Task         : Bash
2019-08-09T06:56:25.4396621Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-09T07:58:56.9816040Z .................................................................................................... 1300/8853
2019-08-09T07:59:03.5246867Z ..........................................F......................................................... 1400/8853
2019-08-09T07:59:09.8433831Z .................................................................................................... 1500/8853
2019-08-09T07:59:20.6118015Z ....................................................................................i............... 1600/8853
2019-08-09T07:59:28.3105186Z i................................................................................................... 1700/8853
2019-08-09T07:59:35.4046536Z ......................................................................iiiii......................... 1800/8853
2019-08-09T07:59:57.4429661Z .................................................................................................... 2000/8853
2019-08-09T07:59:59.9570429Z .................................................................................................... 2100/8853
2019-08-09T08:00:02.9082913Z .................................................................................................... 2200/8853
2019-08-09T08:00:10.8335906Z .................................................................................................... 2300/8853
---
2019-08-09T08:04:00.2558651Z .................................................................................................... 5200/8853
2019-08-09T08:04:11.9145866Z ..............................................................................................i..... 5300/8853
2019-08-09T08:04:19.9196517Z .................................................................................................... 5400/8853
2019-08-09T08:04:24.7997237Z .................................................................................................... 5500/8853
2019-08-09T08:04:36.4317899Z ........................................................................................ii...i..ii.. 5600/8853
2019-08-09T08:05:00.9596698Z .................................................................................................... 5800/8853
2019-08-09T08:05:06.4558651Z .................................................................................................... 5900/8853
2019-08-09T08:05:06.4558651Z .................................................................................................... 5900/8853
2019-08-09T08:05:11.1698122Z .........................................................................................i..ii...... 6000/8853
2019-08-09T08:05:42.4151733Z .................................................................................................... 6200/8853
2019-08-09T08:05:44.5400301Z ................................i................................................................... 6300/8853
2019-08-09T08:05:46.7825191Z .................................................................................................... 6400/8853
2019-08-09T08:05:49.4950995Z ....i............................................................................................... 6500/8853
---
2019-08-09T08:09:56.7030070Z 
2019-08-09T08:09:56.7030252Z 1 error[E0658]: casting pointers to integers in constants is unstable
2019-08-09T08:09:56.7030681Z 2   --> $DIR/match-test-ptr-null.rs:6:15
2019-08-09T08:09:56.7030872Z 3    |
2019-08-09T08:09:56.7031735Z - LL |         match &1 as *const i32 as usize { 
2019-08-09T08:09:56.7032397Z + LL |         match &1 as *const i32 as usize {
2019-08-09T08:09:56.7032749Z 6    |
2019-08-09T08:09:56.7032749Z 6    |
2019-08-09T08:09:56.7033755Z 7    = note: see issue #51910 <***/issues/51910> for more information
2019-08-09T08:09:56.7034184Z 10 error[E0019]: constant contains unimplemented expression type
2019-08-09T08:09:56.7034616Z 11   --> $DIR/match-test-ptr-null.rs:6:15
2019-08-09T08:09:56.7034828Z 12    |
2019-08-09T08:09:56.7034828Z 12    |
2019-08-09T08:09:56.7035200Z - LL |         match &1 as *const i32 as usize { 
2019-08-09T08:09:56.7035389Z + LL |         match &1 as *const i32 as usize {
2019-08-09T08:09:56.7035719Z 15 
2019-08-09T08:09:56.7035882Z 16 error[E0019]: constant contains unimplemented expression type
2019-08-09T08:09:56.7036011Z 
2019-08-09T08:09:56.7036156Z 22 error[E0080]: evaluation of constant value failed
2019-08-09T08:09:56.7036156Z 22 error[E0080]: evaluation of constant value failed
2019-08-09T08:09:56.7036526Z 23   --> $DIR/match-test-ptr-null.rs:6:15
2019-08-09T08:09:56.7036724Z 24    |
2019-08-09T08:09:56.7037110Z - LL |         match &1 as *const i32 as usize { 
2019-08-09T08:09:56.7037311Z + LL |         match &1 as *const i32 as usize {
2019-08-09T08:09:56.7037747Z 26    |               ^^^^^^^^^^^^^^^^^^^^^^^^^ "pointer-to-integer cast" needs an rfc before being allowed inside constants
2019-08-09T08:09:56.7038104Z 28 error: aborting due to 4 previous errors
2019-08-09T08:09:56.7038228Z 
2019-08-09T08:09:56.7038346Z 
2019-08-09T08:09:56.7038502Z The actual stderr differed from the expected stderr.
2019-08-09T08:09:56.7038502Z The actual stderr differed from the expected stderr.
2019-08-09T08:09:56.7039147Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/match-test-ptr-null/match-test-ptr-null.stderr
2019-08-09T08:09:56.7039649Z To update references, rerun the tests and pass the `--bless` flag
2019-08-09T08:09:56.7040126Z To only update this specific test, also pass `--test-args consts/const-eval/match-test-ptr-null.rs`
2019-08-09T08:09:56.7040432Z error: 1 errors occurred comparing output.
2019-08-09T08:09:56.7040615Z status: exit code: 1
2019-08-09T08:09:56.7040615Z status: exit code: 1
2019-08-09T08:09:56.7041537Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/match-test-ptr-null.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/match-test-ptr-null" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/match-test-ptr-null/auxiliary" "-A" "unused"
2019-08-09T08:09:56.7042156Z ------------------------------------------
2019-08-09T08:09:56.7042336Z 
2019-08-09T08:09:56.7042695Z ------------------------------------------
2019-08-09T08:09:56.7042873Z stderr:
2019-08-09T08:09:56.7042873Z stderr:
2019-08-09T08:09:56.7043234Z ------------------------------------------
2019-08-09T08:09:56.7043852Z error[E0658]: casting pointers to integers in constants is unstable
2019-08-09T08:09:56.7044319Z   --> /checkout/src/test/ui/consts/const-eval/match-test-ptr-null.rs:6:15
2019-08-09T08:09:56.7044538Z    |
2019-08-09T08:09:56.7044683Z LL |         match &1 as *const i32 as usize {
2019-08-09T08:09:56.7045013Z    |
2019-08-09T08:09:56.7045013Z    |
2019-08-09T08:09:56.7045476Z    = note: see issue #51910 <***/issues/51910> for more information
2019-08-09T08:09:56.7045716Z    = help: add `#![feature(const_raw_ptr_to_usize_cast)]` to the crate attributes to enable
2019-08-09T08:09:56.7046003Z error[E0019]: constant contains unimplemented expression type
2019-08-09T08:09:56.7046430Z   --> /checkout/src/test/ui/consts/const-eval/match-test-ptr-null.rs:6:15
2019-08-09T08:09:56.7046611Z    |
2019-08-09T08:09:56.7046611Z    |
2019-08-09T08:09:56.7046752Z LL |         match &1 as *const i32 as usize {
2019-08-09T08:09:56.7047056Z 
2019-08-09T08:09:56.7047199Z error[E0019]: constant contains unimplemented expression type
2019-08-09T08:09:56.7047612Z   --> /checkout/src/test/ui/consts/const-eval/match-test-ptr-null.rs:12:13
2019-08-09T08:09:56.7047791Z    |
2019-08-09T08:09:56.7047791Z    |
2019-08-09T08:09:56.7047958Z LL |             0 => 42, //~ ERROR constant contains unimplemented expression type
2019-08-09T08:09:56.7048229Z 
2019-08-09T08:09:56.7048370Z error[E0080]: evaluation of constant value failed
2019-08-09T08:09:56.7048791Z   --> /checkout/src/test/ui/consts/const-eval/match-test-ptr-null.rs:6:15
2019-08-09T08:09:56.7048975Z    |
2019-08-09T08:09:56.7048975Z    |
2019-08-09T08:09:56.7049135Z LL |         match &1 as *const i32 as usize {
2019-08-09T08:09:56.7049575Z    |               ^^^^^^^^^^^^^^^^^^^^^^^^^ "pointer-to-integer cast" needs an rfc before being allowed inside constants
2019-08-09T08:09:56.7049908Z error: aborting due to 4 previous errors
2019-08-09T08:09:56.7050050Z 
2019-08-09T08:09:56.7050195Z Some errors have detailed explanations: E0019, E0080, E0658.
2019-08-09T08:09:56.7050602Z For more information about an error, try `rustc --explain E0019`.
---
2019-08-09T08:09:56.7069099Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-09T08:09:56.7069399Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-09T08:09:56.7088042Z 
2019-08-09T08:09:56.7088360Z 
2019-08-09T08:09:56.7090249Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-09T08:09:56.7091427Z 
2019-08-09T08:09:56.7091460Z 
2019-08-09T08:09:56.7095722Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-09T08:09:56.7095800Z Build completed unsuccessfully in 1:07:10
2019-08-09T08:09:56.7095800Z Build completed unsuccessfully in 1:07:10
2019-08-09T08:09:57.4866968Z ##[error]Bash exited with code '1'.
2019-08-09T08:09:57.4917274Z ##[section]Starting: Checkout
2019-08-09T08:09:57.4919080Z ==============================================================================
2019-08-09T08:09:57.4919136Z Task         : Get sources
2019-08-09T08:09:57.4919184Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

@bors p=1

since this is pretty conflict-prone

@varkor

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

@eupn: there have been more merge conflicts, so you'll need to rebase and force push again.

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

☔️ The latest upstream changes (presumably #63627) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.