Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added table containing the system calls used by Instant and SystemTime. #63846

Merged
merged 4 commits into from Sep 14, 2019

Conversation

@DevQps
Copy link
Contributor

commented Aug 24, 2019

Description

See #32626 for a discussion on documenting system calls used by Instant and SystemTime.

Changes

  • Added a table containing the system calls used by each platform.

EDIT: If I can format this table better (due to the large links) please let me know.
I'd also be happy to learn a quick command to generate the docs on my host machine! Currently I am using: python x.py doc --stage 0 src/libstd but that gives me some unrecognized intrinsic errors. Advice is always welcome :)

closes #32626

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 24, 2019

r? @rkruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 24, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-24T12:51:57.1221988Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-24T12:51:57.1399453Z ##[command]git config gc.auto 0
2019-08-24T12:51:57.1464076Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-24T12:51:57.1509608Z ##[command]git config --get-all http.proxy
2019-08-24T12:51:57.1641420Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63846/merge:refs/remotes/pull/63846/merge
---
2019-08-24T12:52:31.0446729Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-24T12:52:31.0447472Z 
2019-08-24T12:52:31.0448371Z   git checkout -b <new-branch-name>
2019-08-24T12:52:31.0449091Z 
2019-08-24T12:52:31.0449751Z HEAD is now at 82cb65f20 Merge 33788c252c83aeea913482b283e33ccc41bd2860 into 478464570e60523adc6d303577d1782229ca1f93
2019-08-24T12:52:31.0606853Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-24T12:52:31.0609903Z ==============================================================================
2019-08-24T12:52:31.0609968Z Task         : Bash
2019-08-24T12:52:31.0610006Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-24T12:58:46.6459252Z    Compiling serde_json v1.0.40
2019-08-24T12:58:48.4377930Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-24T12:58:59.0741505Z     Finished release [optimized] target(s) in 1m 28s
2019-08-24T12:58:59.0829511Z tidy check
2019-08-24T12:58:59.5547503Z tidy error: /checkout/src/libstd/time.rs:68: line longer than 100 chars
2019-08-24T12:58:59.5547608Z tidy error: /checkout/src/libstd/time.rs:70: line longer than 100 chars
2019-08-24T12:58:59.5547651Z tidy error: /checkout/src/libstd/time.rs:71: line longer than 100 chars
2019-08-24T12:58:59.5547721Z tidy error: /checkout/src/libstd/time.rs:72: line longer than 100 chars
2019-08-24T12:58:59.5547947Z tidy error: /checkout/src/libstd/time.rs:73: line longer than 100 chars
2019-08-24T12:58:59.5548001Z tidy error: /checkout/src/libstd/time.rs:138: line longer than 100 chars
2019-08-24T12:58:59.5548043Z tidy error: /checkout/src/libstd/time.rs:140: line longer than 100 chars
2019-08-24T12:58:59.5548101Z tidy error: /checkout/src/libstd/time.rs:141: line longer than 100 chars
2019-08-24T12:58:59.5548143Z tidy error: /checkout/src/libstd/time.rs:142: line longer than 100 chars
2019-08-24T12:58:59.5548186Z tidy error: /checkout/src/libstd/time.rs:143: line longer than 100 chars
2019-08-24T12:59:00.8841969Z some tidy checks failed
2019-08-24T12:59:00.8847740Z 
2019-08-24T12:59:00.8847740Z 
2019-08-24T12:59:00.8848727Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-24T12:59:00.8848913Z 
2019-08-24T12:59:00.8848936Z 
2019-08-24T12:59:00.8858986Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-24T12:59:00.8859294Z Build completed unsuccessfully in 0:01:31
2019-08-24T12:59:00.8859294Z Build completed unsuccessfully in 0:01:31
2019-08-24T12:59:00.8909161Z == clock drift check ==
2019-08-24T12:59:00.8925528Z   local time: Sat Aug 24 12:59:00 UTC 2019
2019-08-24T12:59:01.0022819Z   network time: Sat, 24 Aug 2019 12:59:00 GMT
2019-08-24T12:59:01.0026523Z == end clock drift check ==
2019-08-24T12:59:02.4028366Z ##[error]Bash exited with code '1'.
2019-08-24T12:59:02.4083182Z ##[section]Starting: Checkout
2019-08-24T12:59:02.4085223Z ==============================================================================
2019-08-24T12:59:02.4085292Z Task         : Get sources
2019-08-24T12:59:02.4085478Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libstd/time.rs Outdated Show resolved Hide resolved
src/libstd/time.rs Outdated Show resolved Hide resolved
@rkruppe
Copy link
Member

left a comment

Thank you for the PR! There seem to be a few mistakes in these tables, could you please correct them and also apply the out-of-line link style suggested by @lzutao to all the links in the tables?

src/libstd/time.rs Outdated Show resolved Hide resolved
src/libstd/time.rs Outdated Show resolved Hide resolved
src/libstd/time.rs Outdated Show resolved Hide resolved
src/libstd/time.rs Outdated Show resolved Hide resolved
Update src/libstd/time.rs
Co-Authored-By: lzutao <taolzu@gmail.com>
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 26, 2019

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-26T20:06:03.9325204Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-26T20:06:04.5780329Z ##[command]git config gc.auto 0
2019-08-26T20:06:04.5786748Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-26T20:06:04.5789909Z ##[command]git config --get-all http.proxy
2019-08-26T20:06:04.5795564Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63846/merge:refs/remotes/pull/63846/merge
---
2019-08-26T20:06:40.8209940Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-26T20:06:40.8209976Z 
2019-08-26T20:06:40.8210210Z   git checkout -b <new-branch-name>
2019-08-26T20:06:40.8210257Z 
2019-08-26T20:06:40.8210309Z HEAD is now at 50b31556c Merge 1478ef45287c4da0da0daf1715d00e8b06fa333b into 9fa8f140233047fb0211dbaee531a290bcfeae7e
2019-08-26T20:06:40.8369153Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-26T20:06:40.8372040Z ==============================================================================
2019-08-26T20:06:40.8372123Z Task         : Bash
2019-08-26T20:06:40.8372175Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-26T20:12:30.1991759Z     Checking hashbrown v0.5.0
2019-08-26T20:12:31.1337194Z error: expected item after doc comment
2019-08-26T20:12:31.1337971Z   --> src/libstd/time.rs:73:1
2019-08-26T20:12:31.1338331Z    |
2019-08-26T20:12:31.1338625Z 73 | /// |  Windows  | [QueryPerformanceCounter] |
2019-08-26T20:12:31.1340415Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this doc comment doesn't document anything
2019-08-26T20:12:31.1341602Z error: aborting due to previous error
2019-08-26T20:12:31.1341910Z 
2019-08-26T20:12:31.1413422Z error: Could not compile `std`.
2019-08-26T20:12:31.1413506Z 
---
2019-08-26T20:12:31.1501932Z == clock drift check ==
2019-08-26T20:12:31.1518418Z   local time: Mon Aug 26 20:12:31 UTC 2019
2019-08-26T20:12:31.3080973Z   network time: Mon, 26 Aug 2019 20:12:31 GMT
2019-08-26T20:12:31.3081239Z == end clock drift check ==
2019-08-26T20:12:39.1653666Z ##[error]Bash exited with code '1'.
2019-08-26T20:12:39.1701544Z ##[section]Starting: Checkout
2019-08-26T20:12:39.1703542Z ==============================================================================
2019-08-26T20:12:39.1703622Z Task         : Get sources
2019-08-26T20:12:39.1703674Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@DevQps

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

I have a busy week upcoming, but I hope to fix all the suggestions next week!

@ProgrammaticNajel

This comment has been minimized.

Copy link

commented Sep 6, 2019

Ping from triage. @DevQps how was your week 😃? Are there any updates on this? Thanks.

@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review

@DevQps

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

Thanks for the triage! I wanted to work on this but unfortunately something went wrong when swapping Internet subscriptions here... So I have been without since last monday but they hope to fix it next monday. So once again unfortunately!: I hope to fix it next week!

@DevQps

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

I hope these changes do the trick! Some URLs are so long that they still bypass the checks though...

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-09T20:11:55.8582486Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-09T20:11:55.8596016Z ##[command]git config gc.auto 0
2019-09-09T20:11:55.8602493Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-09T20:11:55.8608961Z ##[command]git config --get-all http.proxy
2019-09-09T20:11:55.8612549Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63846/merge:refs/remotes/pull/63846/merge
---
2019-09-09T21:14:05.7269618Z .................................................................................................... 1500/9003
2019-09-09T21:14:11.4239841Z .................................................................................................... 1600/9003
2019-09-09T21:14:23.9632213Z .....................................................i...............i.............................. 1700/9003
2019-09-09T21:14:31.7793049Z .................................................................................................... 1800/9003
2019-09-09T21:14:46.3006074Z ............................................iiiii................................................... 1900/9003
2019-09-09T21:14:56.8500486Z .................................................................................................... 2100/9003
2019-09-09T21:14:59.2676114Z .................................................................................................... 2200/9003
2019-09-09T21:15:03.0553961Z .................................................................................................... 2300/9003
2019-09-09T21:15:10.3273964Z .................................................................................................... 2400/9003
---
2019-09-09T21:18:03.9018733Z ...............................i...............i.................................................... 4700/9003
2019-09-09T21:18:15.5131802Z .................................................................................................... 4800/9003
2019-09-09T21:18:21.6141973Z .................................................................................................... 4900/9003
2019-09-09T21:18:32.1289492Z .................................................................................................... 5000/9003
2019-09-09T21:18:37.8813974Z .............ii.ii.................................................................................. 5100/9003
2019-09-09T21:18:48.4919208Z .................................................................................................... 5300/9003
2019-09-09T21:18:58.3383539Z ............................................................................i....................... 5400/9003
2019-09-09T21:19:05.8195706Z .................................................................................................... 5500/9003
2019-09-09T21:19:11.9747791Z .................................................................................................... 5600/9003
2019-09-09T21:19:11.9747791Z .................................................................................................... 5600/9003
2019-09-09T21:19:22.4301395Z .......................................................................ii..i..ii...........i........ 5700/9003
2019-09-09T21:19:46.6896048Z .................................................................................................... 5900/9003
2019-09-09T21:19:55.7870462Z .................................................................................................... 6000/9003
2019-09-09T21:19:55.7870462Z .................................................................................................... 6000/9003
2019-09-09T21:20:01.1394336Z ........................................................................i..ii....................... 6100/9003
2019-09-09T21:20:30.3001086Z .................................................................................................... 6300/9003
2019-09-09T21:20:32.2993937Z ...............................i.................................................................... 6400/9003
2019-09-09T21:20:34.3117946Z .................................................................................................... 6500/9003
2019-09-09T21:20:36.7648721Z ...i................................................................................................ 6600/9003
---
2019-09-09T21:25:09.8271685Z  finished in 19.002
2019-09-09T21:25:09.8446327Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T21:25:09.9985110Z 
2019-09-09T21:25:09.9985355Z running 150 tests
2019-09-09T21:25:13.0710434Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-09-09T21:25:14.9629842Z ..iiii..............i.........iii.i.......ii......
2019-09-09T21:25:14.9632686Z 
2019-09-09T21:25:14.9633410Z  finished in 5.118
2019-09-09T21:25:14.9820533Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T21:25:16.0398426Z 
---
2019-09-09T21:25:17.1443999Z  finished in 2.162
2019-09-09T21:25:17.1641282Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T21:25:17.3353614Z 
2019-09-09T21:25:17.3354486Z running 9 tests
2019-09-09T21:25:17.3355449Z iiiiiiiii
2019-09-09T21:25:17.3356624Z 
2019-09-09T21:25:17.3356760Z  finished in 0.171
2019-09-09T21:25:17.3546174Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T21:25:17.5221094Z 
---
2019-09-09T21:25:35.0106674Z  finished in 17.655
2019-09-09T21:25:35.0276517Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T21:25:35.1834502Z 
2019-09-09T21:25:35.1834636Z running 123 tests
2019-09-09T21:25:57.8837568Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-09T21:26:02.2398795Z i.i.i......iii.i.....ii
2019-09-09T21:26:02.2401927Z 
2019-09-09T21:26:02.2405534Z  finished in 27.212
2019-09-09T21:26:02.2410661Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T21:26:02.2412268Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-09T21:39:16.1658124Z .................................................................................................... 100/977
2019-09-09T21:39:16.1828101Z .................................................................................................... 200/977
2019-09-09T21:39:16.1948049Z .................................................................................................... 300/977
2019-09-09T21:39:16.2150627Z .................................................................................................... 400/977
2019-09-09T21:39:16.3847840Z ..ii................................................................................................ 500/977
2019-09-09T21:39:16.4111824Z .................................................................................................... 700/977
2019-09-09T21:39:16.4298147Z .................................................................................................... 800/977
2019-09-09T21:39:16.9293963Z .................................................................................................... 900/977
2019-09-09T21:39:18.0522732Z .............................................................................
2019-09-09T21:39:18.0522732Z .............................................................................
2019-09-09T21:39:18.0522864Z test result: ok. 975 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-09-09T21:39:18.0522935Z 
2019-09-09T21:39:18.0523660Z    Doc-tests core
2019-09-09T21:39:22.8669037Z 
2019-09-09T21:39:22.8670016Z running 2400 tests
2019-09-09T21:39:33.1915441Z ......iiiii......................................................................................... 100/2400
2019-09-09T21:39:43.2173375Z ...........................................................................ii....................... 200/2400
2019-09-09T21:39:54.8742487Z .................................................................................................i.. 300/2400
2019-09-09T21:40:07.2171763Z .................................................................................................... 400/2400
2019-09-09T21:40:16.7914314Z ............................................i..i.................iiii............................... 500/2400
2019-09-09T21:40:35.6124096Z .................................................................................................... 700/2400
2019-09-09T21:40:45.2731714Z .................................................................................................... 800/2400
2019-09-09T21:40:54.9977390Z .................................................................................................... 900/2400
2019-09-09T21:41:04.7554581Z .................................................................................................... 1000/2400
---
2019-09-09T21:45:49.2403817Z 
2019-09-09T21:45:49.2404472Z running 991 tests
2019-09-09T21:46:09.0235766Z i................................................................................................... 100/991
2019-09-09T21:46:19.7789400Z .................................................................................................... 200/991
2019-09-09T21:46:27.8976697Z .................iii......i......i...i......i....................................................... 300/991
2019-09-09T21:46:32.8033042Z .................................................................................................... 400/991
2019-09-09T21:46:40.1272315Z ..................................i..i.................................ii........................... 500/991
2019-09-09T21:46:53.8607198Z .................................................................................................... 700/991
2019-09-09T21:46:53.8607198Z .................................................................................................... 700/991
2019-09-09T21:47:01.4592083Z .................iiii............................................................................... 800/991
2019-09-09T21:47:15.5424978Z .................................................................................................... 900/991
2019-09-09T21:47:22.5977234Z .......................................iiii................................................
2019-09-09T21:47:22.5978145Z 
2019-09-09T21:47:22.6070432Z  finished in 231.450
2019-09-09T21:47:22.6089205Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T21:47:22.8854766Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-09-09T22:01:05.6122089Z     Checking rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
2019-09-09T22:01:05.6173638Z     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2019-09-09T22:01:05.6482082Z     Checking hashbrown v0.5.0
2019-09-09T22:01:06.4753962Z  Documenting std v0.0.0 (/checkout/src/libstd)
2019-09-09T22:01:11.6591003Z error: `[mach_absolute_time]` cannot be resolved, ignoring it...
2019-09-09T22:01:11.6592013Z   --> src/libstd/time.rs:71:20
2019-09-09T22:01:11.6592869Z    |
2019-09-09T22:01:11.6593800Z 71 | /// | Darwin    | [mach_absolute_time]                                                 |
2019-09-09T22:01:11.6595015Z    |
2019-09-09T22:01:11.6595568Z note: lint level defined here
2019-09-09T22:01:11.6596119Z   --> src/libstd/lib.rs:211:9
2019-09-09T22:01:11.6596761Z    |
2019-09-09T22:01:11.6596761Z    |
2019-09-09T22:01:11.6597261Z 211| #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
2019-09-09T22:01:11.6598308Z    = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-09-09T22:01:11.6598536Z 
2019-09-09T22:01:11.6598536Z 
2019-09-09T22:01:11.6598963Z error: `[QueryPerformanceCounter]` cannot be resolved, ignoring it...
2019-09-09T22:01:11.6599437Z   --> src/libstd/time.rs:74:20
2019-09-09T22:01:11.6599868Z    |
2019-09-09T22:01:11.6600401Z 74 | /// | Windows   | [QueryPerformanceCounter]                                            |
2019-09-09T22:01:11.6603157Z    |
2019-09-09T22:01:11.6604039Z    = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-09-09T22:01:11.6604324Z 
2019-09-09T22:01:11.6604324Z 
2019-09-09T22:01:11.6604865Z error: `[QueryPerformanceCounter]` cannot be resolved, ignoring it...
2019-09-09T22:01:11.6605441Z   --> src/libstd/time.rs:76:6
2019-09-09T22:01:11.6605941Z    |
2019-09-09T22:01:11.6607212Z 76 | /// [QueryPerformanceCounter]: https://docs.microsoft.com/en-us/windows/win32/api/profileapi/nf-profileapi-queryperformancecounter
2019-09-09T22:01:11.6608463Z    |
2019-09-09T22:01:11.6608987Z    = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-09-09T22:01:11.6609479Z 
2019-09-09T22:01:11.6609479Z 
2019-09-09T22:01:11.6609961Z error: `[mach_absolute_time]` cannot be resolved, ignoring it...
2019-09-09T22:01:11.6610424Z   --> src/libstd/time.rs:81:6
2019-09-09T22:01:11.6610843Z    |
2019-09-09T22:01:11.6611424Z 81 | /// [mach_absolute_time]: https://developer.apple.com/library/archive/documentation/Darwin/Conceptual/KernelProgramming/services/services.html
2019-09-09T22:01:11.6615179Z    |
2019-09-09T22:01:11.6616721Z    = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-09-09T22:01:11.6617721Z 
2019-09-09T22:01:11.9880887Z error: aborting due to 4 previous errors
2019-09-09T22:01:11.9880887Z error: aborting due to 4 previous errors
2019-09-09T22:01:11.9882223Z 
2019-09-09T22:01:12.0293661Z error: Could not document `std`.
2019-09-09T22:01:12.0308372Z 
2019-09-09T22:01:12.0308725Z Caused by:
2019-09-09T22:01:12.0314910Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-name std src/libstd/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="backtrace"' --cfg 'feature="compiler-builtins-c"' --cfg 'feature="default"' --cfg 'feature="panic_unwind"' --cfg 'feature="std_detect_dlsym_getauxval"' --cfg 'feature="std_detect_file_io"' --color always --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --resource-suffix 1.39.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-c9af94aec33c482c.rmeta --extern backtrace=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libbacktrace-c3e713a9dcf4c5a7.rmeta --extern cfg_if=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcfg_if-fc053e0be91a93ad.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-e105c0b9266fe10f.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-db383e97964fb507.rmeta --extern hashbrown=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libhashbrown-b7c68b781374d024.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-ac0ff1b98d1f840a.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-88255ed6a45420e4.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-5b224b27d04f22d6.rmeta --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-5eed2f40fc7685e2.rmeta --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-614393d2bb72c85a.rmeta --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-b1a836ada7f22c5f.rmeta --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-e09a8fac343911cf.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-8234d9206d0add37.rmeta` (exit code: 1)
2019-09-09T22:01:12.0319625Z 
2019-09-09T22:01:12.0319625Z 
2019-09-09T22:01:12.0320655Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-Z" "unstable-options" "-p" "std" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--resource-suffix" "1.39.0" "--index-page" "/checkout/src/doc/index.md"
2019-09-09T22:01:12.0321013Z 
2019-09-09T22:01:12.0321123Z 
2019-09-09T22:01:12.0327316Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-09T22:01:12.0327557Z Build completed unsuccessfully in 1:41:40
2019-09-09T22:01:12.0327557Z Build completed unsuccessfully in 1:41:40
2019-09-09T22:01:12.0386211Z == clock drift check ==
2019-09-09T22:01:12.0400724Z   local time: Mon Sep  9 22:01:12 UTC 2019
2019-09-09T22:01:12.3237356Z   network time: Mon, 09 Sep 2019 22:01:12 GMT
2019-09-09T22:01:12.3243617Z == end clock drift check ==
2019-09-09T22:01:17.0715724Z ##[error]Bash exited with code '1'.
2019-09-09T22:01:17.0757262Z ##[section]Starting: Checkout
2019-09-09T22:01:17.0761224Z ==============================================================================
2019-09-09T22:01:17.0761282Z Task         : Get sources
2019-09-09T22:01:17.0761326Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libstd/time.rs Outdated Show resolved Hide resolved
Update src/libstd/time.rs
Co-Authored-By: Robin Kruppe <robin.kruppe@gmail.com>
@rkruppe

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Great, CI is green now. Thanks again for working on this :)

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

📌 Commit b3b6713 has been approved by rkruppe

@DevQps

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

No probs! I tried my best! I wish I had more time to work on things like this :)

Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
Rollup merge of rust-lang#63846 - DevQps:32626-document-time-system-c…
…alls, r=rkruppe

Added table containing the system calls used by Instant and SystemTime.

# Description
See rust-lang#32626 for a discussion on documenting system calls used by Instant and SystemTime.

## Changes
- Added a table containing the system calls used by each platform.

EDIT: If I can format this table better (due to the large links) please let me know.
I'd also be happy to learn a quick command to generate the docs on my host machine! Currently I am using: `python x.py doc --stage 0 src/libstd` but that gives me some `unrecognized intrinsic` errors. Advice is always welcome :)

closes rust-lang#32626
bors added a commit that referenced this pull request Sep 14, 2019
Auto merge of #64452 - Centril:rollup-z101tu8, r=Centril
Rollup of 17 pull requests

Successful merges:

 - #63846 (Added table containing the system calls used by Instant and SystemTime.)
 - #64116 (Fix minor typo in docs.)
 - #64290 (Provide a span if main function is not present in crate)
 - #64302 (Shrink `ObligationCauseCode`)
 - #64372 (use randSecure and randABytes)
 - #64374 (Box `DiagnosticBuilder`.)
 - #64375 (Fast path for vec.clear/truncate )
 - #64378 (Fix inconsistent link formatting.)
 - #64384 (Trim rustc-workspace-hack)
 - #64393 ( declare EnvKey before use to fix build error)
 - #64420 (Inline `mark_neighbours_as_waiting_from`.)
 - #64422 (Remove raw string literal quotes from error index descriptions)
 - #64423 (Add self to .mailmap)
 - #64425 (typo fix)
 - #64431 (fn ptr is structural match)
 - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.)
 - #64439 (fix #64430, confusing `owned_box` error message in no_std build)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
Rollup merge of rust-lang#63846 - DevQps:32626-document-time-system-c…
…alls, r=rkruppe

Added table containing the system calls used by Instant and SystemTime.

# Description
See rust-lang#32626 for a discussion on documenting system calls used by Instant and SystemTime.

## Changes
- Added a table containing the system calls used by each platform.

EDIT: If I can format this table better (due to the large links) please let me know.
I'd also be happy to learn a quick command to generate the docs on my host machine! Currently I am using: `python x.py doc --stage 0 src/libstd` but that gives me some `unrecognized intrinsic` errors. Advice is always welcome :)

closes rust-lang#32626
bors added a commit that referenced this pull request Sep 14, 2019
Auto merge of #64456 - Centril:rollup-ytqdwaq, r=Centril
Rollup of 17 pull requests

Successful merges:

 - #63846 (Added table containing the system calls used by Instant and SystemTime.)
 - #64116 (Fix minor typo in docs.)
 - #64203 (A few cosmetic improvements to code & comments in liballoc and libcore)
 - #64302 (Shrink `ObligationCauseCode`)
 - #64372 (use randSecure and randABytes)
 - #64374 (Box `DiagnosticBuilder`.)
 - #64375 (Fast path for vec.clear/truncate )
 - #64378 (Fix inconsistent link formatting.)
 - #64384 (Trim rustc-workspace-hack)
 - #64393 ( declare EnvKey before use to fix build error)
 - #64420 (Inline `mark_neighbours_as_waiting_from`.)
 - #64422 (Remove raw string literal quotes from error index descriptions)
 - #64423 (Add self to .mailmap)
 - #64425 (typo fix)
 - #64431 (fn ptr is structural match)
 - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.)
 - #64439 (fix #64430, confusing `owned_box` error message in no_std build)

Failed merges:

r? @ghost

@bors bors merged commit b3b6713 into rust-lang:master Sep 14, 2019

4 checks passed

pr Build #20190913.18 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.