Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #64430, confusing owned_box error message in no_std build #64439

Merged
merged 3 commits into from
Sep 14, 2019
Merged

fix #64430, confusing owned_box error message in no_std build #64439

merged 3 commits into from
Sep 14, 2019

Conversation

12101111
Copy link
Contributor

@12101111 12101111 commented Sep 13, 2019 •
edited by Centril
Loading

Fixes #64430

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @zackmdavis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2019
Centril
Centril reviewed Sep 13, 2019
View reviewed changes
src/librustc_typeck/check/expr.rs
try_alt_rcvr(&mut err, arc_rcvr_t);
let rc_rcvr_t = self.tcx.mk_lang_item(rcvr_t, lang_items::Rc);
try_alt_rcvr(&mut err, rc_rcvr_t);
try_alt_rcvr(&mut err, rcvr_t, lang_items::OwnedBoxLangItem);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 -- this bug fix turned out to make the code cleaner 🎉

@Centril
Copy link
Contributor

Centril commented Sep 13, 2019

r? @Centril

Can you please also include a regression test that fail with the "no method named..." error rather than the "requires XX lang_item"? Ideally, the test should cover Box, Rc, and Arc.

@rust-highfive rust-highfive assigned Centril and unassigned zackmdavis Sep 13, 2019
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2019
@Centril
Copy link
Contributor

Centril commented Sep 13, 2019

Thanks! r=me when green.

@12101111
Copy link
Contributor Author

r= @Centril

@Centril
Copy link
Contributor

Centril commented Sep 13, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 13, 2019

📌 Commit e484f21 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge of rust-lang#64439 - 12101111:fix-owned-box, r=Centril
b5e2477 
fix rust-lang#64430, confusing `owned_box` error message in no_std build

Fixes rust-lang#64430
@Centril Centril mentioned this pull request Sep 14, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge of rust-lang#64439 - 12101111:fix-owned-box, r=Centril
a5826ab 
fix rust-lang#64430, confusing `owned_box` error message in no_std build

Fixes rust-lang#64430
@Centril Centril mentioned this pull request Sep 14, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge of rust-lang#64439 - 12101111:fix-owned-box, r=Centril
1c7959b 
fix rust-lang#64430, confusing `owned_box` error message in no_std build

Fixes rust-lang#64430
@Centril Centril mentioned this pull request Sep 14, 2019
Merged
bors added a commit that referenced this pull request Sep 14, 2019
@bors
Auto merge of #64456 - Centril:rollup-ytqdwaq, r=Centril
ca3766e 
Rollup of 17 pull requests

Successful merges:

 - #63846 (Added table containing the system calls used by Instant and SystemTime.)
 - #64116 (Fix minor typo in docs.)
 - #64203 (A few cosmetic improvements to code & comments in liballoc and libcore)
 - #64302 (Shrink `ObligationCauseCode`)
 - #64372 (use randSecure and randABytes)
 - #64374 (Box `DiagnosticBuilder`.)
 - #64375 (Fast path for vec.clear/truncate )
 - #64378 (Fix inconsistent link formatting.)
 - #64384 (Trim rustc-workspace-hack)
 - #64393 ( declare EnvKey before use to fix build error)
 - #64420 (Inline `mark_neighbours_as_waiting_from`.)
 - #64422 (Remove raw string literal quotes from error index descriptions)
 - #64423 (Add self to .mailmap)
 - #64425 (typo fix)
 - #64431 (fn ptr is structural match)
 - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.)
 - #64439 (fix #64430, confusing `owned_box` error message in no_std build)

Failed merges:

r? @ghost
@bors bors merged commit e484f21 into rust-lang:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing owned_box error message since nightly-2019-09-04
5 participants
@12101111 @rust-highfive @Centril @bors @zackmdavis