Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in docs. #64116

Merged
merged 3 commits into from
Sep 14, 2019
Merged

Fix minor typo in docs. #64116

merged 3 commits into from
Sep 14, 2019

Conversation

goddessfreya
Copy link
Contributor

@goddessfreya goddessfreya commented Sep 3, 2019

This comment is prolly refering to the comment in const_eval_raw_provider, not itself.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2019
Value was renamed to Operand in rust-lang@ad2de8b
ScalarPair to Slice in rust-lang@fe50b4e

Not familiar enough with rustc's source to know if the comment is even still applicable.
@goddessfreya
Copy link
Contributor Author

Value was renamed to Operand in ad2de8b
ScalarPair to Slice in fe50b4e

Not familiar enough with rustc's source to know if the comment is even still applicable.

@cramertj
Copy link
Member

cramertj commented Sep 3, 2019

r? @RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned cramertj Sep 3, 2019
@RalfJung
Copy link
Member

RalfJung commented Sep 5, 2019

Sorry, I'm on vacation. But for this way I'd suggest r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned RalfJung Sep 5, 2019
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019
@JohnCSimon
Copy link
Member

Ping from triage:

@zegentzy can you please address the comments from @oli-obk ?

Thanks.

@goddessfreya
Copy link
Contributor Author

Apologies, I forgot about it. Thanks for the ping.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 14, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 14, 2019

📌 Commit 094af97 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
Fix minor typo in docs.

This comment is prolly refering to the comment in [const_eval_raw_provider](https://github.com/rust-lang/rust/pull/64116/files#diff-e0b58bb6712edaa8595ad7237542c958R616), not itself.
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
Fix minor typo in docs.

This comment is prolly refering to the comment in [const_eval_raw_provider](https://github.com/rust-lang/rust/pull/64116/files#diff-e0b58bb6712edaa8595ad7237542c958R616), not itself.
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
Fix minor typo in docs.

This comment is prolly refering to the comment in [const_eval_raw_provider](https://github.com/rust-lang/rust/pull/64116/files#diff-e0b58bb6712edaa8595ad7237542c958R616), not itself.
bors added a commit that referenced this pull request Sep 14, 2019
Rollup of 17 pull requests

Successful merges:

 - #63846 (Added table containing the system calls used by Instant and SystemTime.)
 - #64116 (Fix minor typo in docs.)
 - #64203 (A few cosmetic improvements to code & comments in liballoc and libcore)
 - #64302 (Shrink `ObligationCauseCode`)
 - #64372 (use randSecure and randABytes)
 - #64374 (Box `DiagnosticBuilder`.)
 - #64375 (Fast path for vec.clear/truncate )
 - #64378 (Fix inconsistent link formatting.)
 - #64384 (Trim rustc-workspace-hack)
 - #64393 ( declare EnvKey before use to fix build error)
 - #64420 (Inline `mark_neighbours_as_waiting_from`.)
 - #64422 (Remove raw string literal quotes from error index descriptions)
 - #64423 (Add self to .mailmap)
 - #64425 (typo fix)
 - #64431 (fn ptr is structural match)
 - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.)
 - #64439 (fix #64430, confusing `owned_box` error message in no_std build)

Failed merges:

r? @ghost
@bors bors merged commit 094af97 into rust-lang:master Sep 14, 2019
@goddessfreya goddessfreya deleted the patch-1 branch September 14, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants