Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #66485

Merged
merged 29 commits into from
Nov 17, 2019
Merged

Rollup of 11 pull requests #66485

merged 29 commits into from
Nov 17, 2019

Commits on Nov 14, 2019

  1. Centralize panic macro documentation

    czipperz authored and jplatte committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    6fc18a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Configuration menu
    Copy the full SHA
    91aadf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. Configuration menu
    Copy the full SHA
    8444e16 View commit details
    Browse the repository at this point in the history
  2. add missing 'static lifetime in docs

    The example refers to a static lifetime parameter that can be elided.
    This parameter is not included, meaning lifetime elision is not shown.
    mulimoen committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    e85f40c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52d7246 View commit details
    Browse the repository at this point in the history
  4. avoid linking errors

    RalfJung committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    e8ff465 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd63c59 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8575743 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    266f547 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    00bc449 View commit details
    Browse the repository at this point in the history
  9. parse: Support parsing optional literals

    Revert weird renaming of the former `LitError::report`
    petrochenkov committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    b85a3da View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a699f17 View commit details
    Browse the repository at this point in the history
  11. Improve documentation of Vec::split_off(...)

    The previous ordering of the sentences kept switching between the return
    value and the value of `self` after execution, making it hard to follow.
    
    Additionally, as rendered in the browser, the period in "`Self`. `self`"
    was difficult to make out as being a sentence separator and not one code
    block.
    mqudsi committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    8c7530a View commit details
    Browse the repository at this point in the history
  12. Revise the text of vec::split_off() per review in rust-lang#65739

    Remove the incorrect usage of "copy" as the trait is not called.
    mqudsi committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    a36c3f6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3407c49 View commit details
    Browse the repository at this point in the history
  14. Address review comments

    petrochenkov committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    11580ce View commit details
    Browse the repository at this point in the history
  15. Add some more tests

    petrochenkov committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    28aec1b View commit details
    Browse the repository at this point in the history
  16. Add test for issue 63116

    Alexendoo committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    cfe94b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. Rollup merge of rust-lang#65739 - mqudsi:vec_split_off_docs, r=dtolnay

    Improve documentation of `Vec::split_off(...)`
    
    The previous ordering of the sentences kept switching between the return
    value and the value of `self` after execution, making it hard to follow.
    
    Additionally, as rendered in the browser, the period in "`Self`. `self`"
    was difficult to make out as being a sentence separator and not one code
    block.
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    d8f2526 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#66271 - petrochenkov:abism, r=Centril

    syntax: Keep string literals in ABIs and `asm!` more precisely
    
    As a result we don't lose spans when `extern` functions or blocks are passed to proc macros, and also escape all string literals consistently.
    Continuation of rust-lang#60679, which did a similar thing with all literals besides those in ABIs and `asm!`.
    
    TODO: Add tests.
    
    Fixes rust-lang#60493
    Fixes rust-lang#64561
    r? @Centril
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    b83d50d View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#66344 - petrochenkov:noregattr, r=matthewja…

    …sper
    
    rustc_plugin: Remove `Registry::register_attribute`
    
    Legacy plugins cannot register inert attributes anymore.
    
    The preferred replacement is to use `register_tool` ([tracking issue](rust-lang#66079)).
    ```rust
    #![register_tool(servo)]
    
    #[servo::must_root]
    struct S;
    ```
    
    The more direct replacement is `register_attribute` ([tracking issue](rust-lang#66080))
    ```rust
    #![register_attr(must_root)]
    
    #[must_root]
    struct S;
    ```
    , but it requires registering each attribute individually rather than registering the tool once, and is more likely to be removed rather than stabilized.
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    54998d1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#66381 - Centril:66340, r=petrochenkov

    find_deprecation: deprecation attr may be ill-formed meta.
    
    Fixes rust-lang#66340.
    
    r? @petrochenkov
    cc @pnkfelix
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    842612f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#66395 - jplatte:centralize-panic-docs, r=Dy…

    …lan-DPC
    
    Centralize panic macro documentation
    
    This is just the main commit from rust-lang#61511 (which got closed because the author didn't reply) cherry-picked on the current master. Building `core` and `std` on this branch in stage 1 succeeded, which I thinks means the issues from the previous PR should be gone (but let's see what CI says).
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    05482d0 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#66456 - Centril:driver-codes, r=Mark-Simula…

    …crum
    
    Move `DIAGNOSTICS` usage to `rustc_driver`
    
    Remove `rustc_interface`'s dependency on `rustc_error_codes` and centralize all usages of `DIAGNOSTICS` in `rustc_driver`. Once we remove all references to `rustc_error_codes` in all other crates but `rustc_driver`, this should allow for incremental recompilation of the compiler to be smoother when tweaking error codes. This works towards rust-lang#66210 (comment).
    
    (May include traces of minor drive-by cleanup.)
    
    r? @Mark-Simulacrum
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    6e6c46c View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#66465 - mulimoen:fix_lifetime_elision_not_s…

    …hown, r=rkruppe
    
    add missing 'static lifetime in docs
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    404081f View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#66466 - RalfJung:seh, r=oli-obk

    miri panic_unwind: fix hack for SEH platforms
    
    The old hack didn't work as we ended up duplicating the `eh_personality` lang item...
    
    I have no idea if rustc cares that `eh_catch_typeinfo` has a certain shape, but better safe than sorry. I cannot test this locally.
    
    r? @oli-obk Cc @Aaron1011
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    937195b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#66469 - CosineP:fix/field-lint, r=petrochenkov

    Use "field is never read" instead of "field is never used"
    
    this is my first PR here so please let me know if i am doing it wrong
    closes rust-lang#64465
    i will be referencing this with a book PR that updates the same language
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    c0fccf5 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#66471 - Alexendoo:test-issue-63116, r=Centril

    Add test for issue 63116
    
    Closes rust-lang#63116
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    750dd03 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#66477 - ALSchwalm:clarify-transmute-copy, r…

    …=Centril
    
    Clarify transmute_copy documentation example
    
    Currently the documentation for `transmute_copy` implies that the function accepts a slice due to the variable name chosen in the example. This is misleading as `foo_slice` is actually an array and `transmute_copy` cannot take an unsized type anyway.
    
    This PR just clarifies things by renaming the variable used in the example.
    JohnTitor committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    f65cb87 View commit details
    Browse the repository at this point in the history