Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate HIR on an arena 2/4 -- Expr & Pat #66936

Merged
merged 7 commits into from Dec 27, 2019
Merged

Conversation

@cjgillot
Copy link
Contributor

cjgillot commented Dec 1, 2019

This is the second PR in the series started by #66931

This time, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-preamble...hirene-expr

@davidtwco

This comment has been minimized.

Copy link
Member

davidtwco commented Dec 1, 2019

r? @eddyb
cc @Zoxc

@rust-highfive rust-highfive assigned eddyb and unassigned davidtwco Dec 1, 2019
@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Dec 1, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-01T17:43:24.6648700Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-01T17:43:24.6831192Z ##[command]git config gc.auto 0
2019-12-01T17:43:24.6900658Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-01T17:43:24.6949477Z ##[command]git config --get-all http.proxy
2019-12-01T17:43:24.7074094Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66936/merge:refs/remotes/pull/66936/merge
---
2019-12-01T17:48:28.1541685Z    Compiling serde_json v1.0.40
2019-12-01T17:48:29.4938081Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-01T17:48:38.0405541Z     Finished release [optimized] target(s) in 1m 08s
2019-12-01T17:48:38.0486442Z tidy check
2019-12-01T17:48:38.5129187Z tidy error: /checkout/src/librustc_passes/dead.rs:130: line longer than 100 chars
2019-12-01T17:48:38.5624269Z tidy error: /checkout/src/librustc_mir/build/mod.rs:547: line longer than 100 chars
2019-12-01T17:48:38.5886670Z tidy error: /checkout/src/librustc_mir/hair/pattern/check_match.rs:129: line longer than 100 chars
2019-12-01T17:48:38.5886765Z tidy error: /checkout/src/librustc_mir/hair/pattern/check_match.rs:330: line longer than 100 chars
2019-12-01T17:48:38.6422534Z tidy error: /checkout/src/librustc/traits/error_reporting.rs:1265: line longer than 100 chars
2019-12-01T17:48:38.6638564Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:23: line longer than 100 chars
2019-12-01T17:48:38.6638805Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:118: line longer than 100 chars
2019-12-01T17:48:38.6638894Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:125: line longer than 100 chars
2019-12-01T17:48:38.6638937Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:127: line longer than 100 chars
2019-12-01T17:48:38.6638998Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:146: line longer than 100 chars
2019-12-01T17:48:38.6639043Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:156: line longer than 100 chars
2019-12-01T17:48:38.6639085Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:161: line longer than 100 chars
2019-12-01T17:48:38.6639148Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:466: line longer than 100 chars
2019-12-01T17:48:38.6639190Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:501: line longer than 100 chars
2019-12-01T17:48:38.6639241Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:603: line longer than 100 chars
2019-12-01T17:48:38.6639307Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:1246: line longer than 100 chars
2019-12-01T17:48:38.6639351Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:1284: line longer than 100 chars
2019-12-01T17:48:38.6639396Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:1304: line longer than 100 chars
2019-12-01T17:48:38.6639458Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:1390: line longer than 100 chars
2019-12-01T17:48:38.6639500Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:1415: line longer than 100 chars
2019-12-01T17:48:38.6639544Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:1434: line longer than 100 chars
2019-12-01T17:48:38.6639603Z tidy error: /checkout/src/librustc/hir/lowering/expr.rs:1479: line longer than 100 chars
2019-12-01T17:48:38.6647305Z tidy error: /checkout/src/librustc/hir/lowering/item.rs:1041: line longer than 100 chars
2019-12-01T17:48:38.6702539Z tidy error: /checkout/src/librustc/hir/lowering.rs:2135: line longer than 100 chars
2019-12-01T17:48:38.6707097Z tidy error: /checkout/src/librustc/hir/lowering.rs:2929: line longer than 100 chars
2019-12-01T17:48:38.8046628Z tidy error: /checkout/src/librustc_typeck/check/expr.rs:130: line longer than 100 chars
2019-12-01T17:48:38.8057112Z tidy error: /checkout/src/librustc_typeck/check/_match.rs:193: line longer than 100 chars
2019-12-01T17:48:38.8131649Z tidy error: /checkout/src/librustc_typeck/check/regionck.rs:1016: line longer than 100 chars
2019-12-01T17:48:38.8147765Z tidy error: /checkout/src/librustc_typeck/check/demand.rs:139: line longer than 100 chars
2019-12-01T17:48:38.8156112Z tidy error: /checkout/src/librustc_typeck/check/pat.rs:33: line longer than 100 chars
2019-12-01T17:48:38.8156486Z tidy error: /checkout/src/librustc_typeck/check/pat.rs:117: line longer than 100 chars
2019-12-01T17:48:38.8228189Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:4280: line longer than 100 chars
2019-12-01T17:48:38.8234674Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:5011: line longer than 100 chars
2019-12-01T17:48:38.8299773Z tidy error: /checkout/src/librustc_typeck/mem_categorization.rs:565: line longer than 100 chars
2019-12-01T17:48:38.8300104Z tidy error: /checkout/src/librustc_typeck/mem_categorization.rs:572: line longer than 100 chars
2019-12-01T17:48:40.0767416Z Found 486 error codes
2019-12-01T17:48:40.0767585Z Found 0 error codes with no tests
2019-12-01T17:48:40.0767622Z Done!
2019-12-01T17:48:40.0767678Z some tidy checks failed
2019-12-01T17:48:40.0767678Z some tidy checks failed
2019-12-01T17:48:40.0770695Z 
2019-12-01T17:48:40.0770958Z 
2019-12-01T17:48:40.0771889Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-01T17:48:40.0775277Z 
2019-12-01T17:48:40.0775299Z 
2019-12-01T17:48:40.0775462Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-01T17:48:40.0775513Z Build completed unsuccessfully in 0:01:11
2019-12-01T17:48:40.0775513Z Build completed unsuccessfully in 0:01:11
2019-12-01T17:48:40.0816397Z == clock drift check ==
2019-12-01T17:48:40.0842952Z   local time: Sun Dec  1 17:48:40 UTC 2019
2019-12-01T17:48:40.3592297Z   network time: Sun, 01 Dec 2019 17:48:40 GMT
2019-12-01T17:48:40.3593244Z == end clock drift check ==
2019-12-01T17:48:41.7573712Z 
2019-12-01T17:48:41.7627825Z ##[error]Bash exited with code '1'.
2019-12-01T17:48:41.7649755Z ##[section]Starting: Checkout
2019-12-01T17:48:41.7651201Z ==============================================================================
2019-12-01T17:48:41.7651243Z Task         : Get sources
2019-12-01T17:48:41.7651279Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Dec 1, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-01T21:59:42.4907890Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-01T21:59:42.5095167Z ##[command]git config gc.auto 0
2019-12-01T21:59:42.5164552Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-01T21:59:42.5218571Z ##[command]git config --get-all http.proxy
2019-12-01T21:59:42.5357626Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66936/merge:refs/remotes/pull/66936/merge
---
2019-12-01T22:26:45.8779019Z fatal runtime error: stack overflow
2019-12-01T22:26:46.1910746Z error: could not compile `core`.
2019-12-01T22:26:46.1914508Z 
2019-12-01T22:26:46.1914641Z Caused by:
2019-12-01T22:26:46.1922034Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --edition=2018 --crate-name core src/libcore/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C codegen-units=1 -C debuginfo=0 -C metadata=8dab76f6898d904f -C extra-filename=-8dab76f6898d904f --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps -Zexternal-macro-backtrace '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Wrust_2018_idioms -Wunused_lifetimes -Dwarnings -Cprefer-dynamic -Zbinary-dep-depinfo` (signal: 6, SIGABRT: process abort signal)
2019-12-01T22:26:47.5996194Z error: build failed
2019-12-01T22:26:47.6020038Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--message-format" "json-render-diagnostics"
2019-12-01T22:26:47.6020382Z expected success, got: exit code: 101
2019-12-01T22:26:47.6028860Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-01T22:26:47.6028860Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-01T22:26:47.6029249Z Build completed unsuccessfully in 0:21:09
2019-12-01T22:26:47.6082768Z == clock drift check ==
2019-12-01T22:26:47.6101030Z   local time: Sun Dec  1 22:26:47 UTC 2019
2019-12-01T22:26:47.8913491Z   network time: Sun, 01 Dec 2019 22:26:47 GMT
2019-12-01T22:26:47.8916626Z == end clock drift check ==
2019-12-01T22:26:48.6695824Z 
2019-12-01T22:26:48.6783844Z ##[error]Bash exited with code '1'.
2019-12-01T22:26:48.6838521Z ##[section]Starting: Checkout
2019-12-01T22:26:48.6840667Z ==============================================================================
2019-12-01T22:26:48.6840731Z Task         : Get sources
2019-12-01T22:26:48.6840780Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 2, 2019

☔️ The latest upstream changes (presumably #66944) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-expr branch from f4d04ea to 884d8b8 Dec 2, 2019
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 2, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-02T19:49:52.0883694Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-02T19:49:52.1073113Z ##[command]git config gc.auto 0
2019-12-02T19:49:52.1134435Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-02T19:49:52.1198558Z ##[command]git config --get-all http.proxy
2019-12-02T19:49:52.1323834Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66936/merge:refs/remotes/pull/66936/merge
---
2019-12-02T20:15:55.0260053Z fatal runtime error: stack overflow
2019-12-02T20:15:55.3125594Z error: could not compile `core`.
2019-12-02T20:15:55.3125719Z 
2019-12-02T20:15:55.3125762Z Caused by:
2019-12-02T20:15:55.3136067Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --edition=2018 --crate-name core src/libcore/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C codegen-units=1 -C debuginfo=0 -C metadata=8dab76f6898d904f -C extra-filename=-8dab76f6898d904f --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps -Zexternal-macro-backtrace '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Wrust_2018_idioms -Wunused_lifetimes -Dwarnings -Cprefer-dynamic -Zbinary-dep-depinfo` (signal: 6, SIGABRT: process abort signal)
2019-12-02T20:15:56.9123561Z error: build failed
2019-12-02T20:15:56.9140676Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--message-format" "json-render-diagnostics"
2019-12-02T20:15:56.9140809Z expected success, got: exit code: 101
2019-12-02T20:15:56.9153845Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-02T20:15:56.9153845Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-02T20:15:56.9153943Z Build completed unsuccessfully in 0:20:35
2019-12-02T20:15:56.9202769Z == clock drift check ==
2019-12-02T20:15:56.9218274Z   local time: Mon Dec  2 20:15:56 UTC 2019
2019-12-02T20:15:57.1877585Z   network time: Mon, 02 Dec 2019 20:15:57 GMT
2019-12-02T20:15:57.1881821Z == end clock drift check ==
2019-12-02T20:15:57.8993319Z 
2019-12-02T20:15:57.9091492Z ##[error]Bash exited with code '1'.
2019-12-02T20:15:57.9126620Z ##[section]Starting: Checkout
2019-12-02T20:15:57.9128281Z ==============================================================================
2019-12-02T20:15:57.9128330Z Task         : Get sources
2019-12-02T20:15:57.9128372Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cjgillot

This comment has been minimized.

Copy link
Contributor Author

cjgillot commented Dec 3, 2019

I seem to be constructing some sort of infinite loop in the HIR graph. The stack overflow happens when hashing everything. The loop consists of a ExprKind::Call(ExprKind::Path(QPath::TypeRelative(...)), &[ExprKind::Binary(..., loop, ...)).

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 3, 2019

☔️ The latest upstream changes (presumably #66982) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 6, 2019

☔️ The latest upstream changes (presumably #67060) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-expr branch from 95a3930 to 61a4f1c Dec 9, 2019
bors added a commit that referenced this pull request Dec 9, 2019
Allocate HIR on an arena 4/4

This is the fourth and last PR in the series started by #66931, #66936 and #66942.

The last commits should compile on their own.
The difference with the previous PR is given by cjgillot/rust@hirene-ty...hirene

A few more cleanups may be necessary, please tell me.

r? @eddyb like the other
cc @Zoxc
@cjgillot cjgillot force-pushed the cjgillot:hirene-expr branch from 61a4f1c to f1b7350 Dec 11, 2019
bors added a commit that referenced this pull request Dec 11, 2019
Allocate HIR on an arena 4/4

This is the fourth and last PR in the series started by #66931, #66936 and #66942.

The last commits should compile on their own.
The difference with the previous PR is given by cjgillot/rust@hirene-ty...hirene

A few more cleanups may be necessary, please tell me.

r? @eddyb like the other
cc @Zoxc
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 14, 2019

☔️ The latest upstream changes (presumably #65951) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-expr branch from f1b7350 to f23c50b Dec 14, 2019
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 16, 2019

☔️ The latest upstream changes (presumably #67356) made this pull request unmergeable. Please resolve the merge conflicts.

src/librustc/hir/mod.rs Outdated Show resolved Hide resolved
@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Dec 22, 2019

Did you ensure that the Fewer calls to arena.alloc commit didn't result in allocations which wouldn't get used?

And did you resolve the infinite loop?

@cjgillot cjgillot force-pushed the cjgillot:hirene-expr branch 2 times, most recently from 84526d2 to 3c5f298 Dec 22, 2019
@cjgillot

This comment has been minimized.

Copy link
Contributor Author

cjgillot commented Dec 22, 2019

Rebased.

Did you ensure that the Fewer calls to arena.alloc commit didn't result in allocations which wouldn't get used?

I did as much as I could. There are no unused allocation of HIR nodes, because of typing. However, typing does not guarantee against unused allocation of a pointer.

And did you resolve the infinite loop?

Yes. It was in the arena allocation code. Bug #67001

@@ -2931,16 +2938,20 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
}
}

hir::PatKind::Slice(before.into(), slice, after.into())
hir::PatKind::Slice(

This comment has been minimized.

Copy link
@Centril

Centril Dec 22, 2019

Member

We can probably elide the intermediate allocations here by converting the code above into more functional style code, but we can leave this for another time.

src/librustc/hir/mod.rs Outdated Show resolved Hide resolved
@cjgillot cjgillot force-pushed the cjgillot:hirene-expr branch from c1cabd2 to fb100e5 Dec 26, 2019
@cjgillot

This comment has been minimized.

Copy link
Contributor Author

cjgillot commented Dec 26, 2019

Rebased.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 27, 2019

@bors r=Zoxc p=5

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2019

📌 Commit fb100e5 has been approved by Zoxc

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2019

⌛️ Testing commit fb100e5 with merge a04c789...

bors added a commit that referenced this pull request Dec 27, 2019
Allocate HIR on an arena 2/4 -- Expr & Pat

This is the second PR in the series started by #66931

This time, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-preamble...hirene-expr
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 27, 2019

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing a04c789 to master...

@bors bors added the merged-by-bors label Dec 27, 2019
@bors bors merged commit fb100e5 into rust-lang:master Dec 27, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20191226.62 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Dec 27, 2019
JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Dec 27, 2019
bors added a commit to rust-lang/rust-clippy that referenced this pull request Dec 27, 2019
Rustup to rust-lang/rust#66936

changelog: none
@cjgillot cjgillot deleted the cjgillot:hirene-expr branch Dec 27, 2019
bors added a commit that referenced this pull request Dec 27, 2019
Allocate HIR on an arena 3/4 -- Ty

This is the third PR in the series started by #66931 and #66936

Once again, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty
bors added a commit that referenced this pull request Dec 29, 2019
Allocate HIR on an arena 3/4 -- Ty

This is the third PR in the series started by #66931 and #66936

Once again, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty
bors added a commit that referenced this pull request Dec 29, 2019
Allocate HIR on an arena 3/4 -- Ty

This is the third PR in the series started by #66931 and #66936

Once again, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty
bors added a commit that referenced this pull request Dec 31, 2019
Allocate HIR on an arena 4/4

This is the fourth and last PR in the series started by #66931, #66936 and #66942.

The last commits should compile on their own.
The difference with the previous PR is given by cjgillot/rust@hirene-ty...hirene

A few more cleanups may be necessary, please tell me.

r? @eddyb like the other
cc @Zoxc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.