Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non clean impls items #67178

Merged
merged 9 commits into from
Dec 11, 2019
Merged

Conversation

GuillaumeGomez
Copy link
Member

This is another (and should be the last for the clean module) rustdoc cleanup.

I tried to follow the same commit pattern as the last one to make the review as easy as possible.

r? @kinnison

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-09T17:08:38.2168664Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-09T17:08:38.2182446Z ##[command]git config gc.auto 0
2019-12-09T17:08:38.2187783Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-09T17:08:38.2191739Z ##[command]git config --get-all http.proxy
2019-12-09T17:08:38.2196939Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67178/merge:refs/remotes/pull/67178/merge
---
2019-12-09T17:14:36.6984230Z    Compiling serde_json v1.0.40
2019-12-09T17:14:38.4397286Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-09T17:14:49.2968381Z     Finished release [optimized] target(s) in 1m 27s
2019-12-09T17:14:49.3078959Z tidy check
2019-12-09T17:14:50.3250774Z tidy error: /checkout/src/librustdoc/clean/mod.rs: ignoring file length unnecessarily
2019-12-09T17:14:52.0903370Z some tidy checks failed
2019-12-09T17:14:52.0904935Z Found 485 error codes
2019-12-09T17:14:52.0905363Z Found 0 error codes with no tests
2019-12-09T17:14:52.0905553Z Done!
2019-12-09T17:14:52.0905553Z Done!
2019-12-09T17:14:52.0905687Z 
2019-12-09T17:14:52.0905814Z 
2019-12-09T17:14:52.0906831Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-09T17:14:52.0907247Z 
2019-12-09T17:14:52.0907379Z 
2019-12-09T17:14:52.0915595Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-09T17:14:52.0915691Z Build completed unsuccessfully in 0:01:31
2019-12-09T17:14:52.0915691Z Build completed unsuccessfully in 0:01:31
2019-12-09T17:14:52.0968142Z == clock drift check ==
2019-12-09T17:14:52.0979072Z   local time: Mon Dec  9 17:14:52 UTC 2019
2019-12-09T17:14:52.3917766Z   network time: Mon, 09 Dec 2019 17:14:52 GMT
2019-12-09T17:14:52.3917925Z == end clock drift check ==
2019-12-09T17:14:53.7084612Z 
2019-12-09T17:14:53.7186971Z ##[error]Bash exited with code '1'.
2019-12-09T17:14:53.7214346Z ##[section]Starting: Checkout
2019-12-09T17:14:53.7215944Z ==============================================================================
2019-12-09T17:14:53.7215996Z Task         : Get sources
2019-12-09T17:14:53.7216056Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually this looks sane, Thank you for making it easy review.

You did end up shunting a couple of functions around a bit, but I'm okay with that, it was easy enough to confirm.

You have a tidy error to fix before I can approve fully.

@kinnison kinnison added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 10, 2019
@GuillaumeGomez
Copy link
Member Author

Fixed tidy so let's move! :D

@bors: r=kinnison

@bors
Copy link
Contributor

bors commented Dec 10, 2019

📌 Commit f0babc8 has been approved by kinnison

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 10, 2019
…, r=kinnison

Move non clean impls items

This is another (and should be the last for the `clean` module) rustdoc cleanup.

I tried to follow the same commit pattern as the last one to make the review as easy as possible.

r? @kinnison
bors added a commit that referenced this pull request Dec 11, 2019
Rollup of 9 pull requests

Successful merges:

 - #66377 (Update RELEASES.md for 1.40.0)
 - #67134 (Ensure that we get a hard error on generic ZST constants if their bod…)
 - #67152 (Sort auto trait and blanket implementations display)
 - #67154 (Fix typos in src/libcore/alloc.rs docs)
 - #67168 (corrected comment in E0478)
 - #67178 (Move non clean impls items)
 - #67180 (doc: Use .copied() instead of .cloned() in Vec example)
 - #67181 (Update hashmap doc)
 - #67193 (In which we start tracking polonius in `-Z self-profile`)

Failed merges:

r? @ghost
@bors bors merged commit f0babc8 into rust-lang:master Dec 11, 2019
@GuillaumeGomez GuillaumeGomez deleted the move-non-clean-impls branch December 11, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants