Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #67828

Merged
merged 28 commits into from
Jan 3, 2020
Merged

Rollup of 10 pull requests #67828

merged 28 commits into from
Jan 3, 2020

Commits on Dec 27, 2019

  1. Configuration menu
    Copy the full SHA
    b817a68 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98d8326 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2019

  1. Suggest adding a lifetime constraint when opaque type is responsible …

    …for "does not live long enough" error
    ohadravid committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    d4fbb55 View commit details
    Browse the repository at this point in the history
  2. Less-than is asymmetric, not antisymmetric

    This has bothered me for a while. It's such a small nit, but...
    taralx committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    d935a26 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2019

  1. Configuration menu
    Copy the full SHA
    1a4f6b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0970f3d View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2020

  1. Configuration menu
    Copy the full SHA
    4f63985 View commit details
    Browse the repository at this point in the history
  2. Added test

    LeSeulArtichaut committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    f474c00 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Ensure that we process projections during MIR inlining

    Fixes rust-lang#67710
    
    Previously, we were not calling `super_place`, which resulted in us
    failing to update any local references that occur in
    ProjectionElem::Index. This caused the post-inlining MIR to contain a
    reference to a local ID from the inlined callee, leading to an ICE
    due to a type mismatch.
    Aaron1011 committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    e8e53b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd8f072 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b7c404 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6f57bad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d202b59 View commit details
    Browse the repository at this point in the history
  6. Move test

    Co-authored-by: Centril <twingoow@gmail.com>
    LeSeulArtichaut and Centril committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    3182805 View commit details
    Browse the repository at this point in the history
  7. Enhance test

    Co-authored-by: Centril <twingoow@gmail.com>
    LeSeulArtichaut and Centril committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    dc19b48 View commit details
    Browse the repository at this point in the history
  8. Reformulate test description

    Co-authored-by: Centril <twingoow@gmail.com>
    LeSeulArtichaut and Centril committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    5cc9f6b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8341a9a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. Minor: change take() docs grammar to match other docs

    Eg. mem::replace()
    petertodd committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    4a48818 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#67450 - michaelwoerister:bootstrap-import-l…

    …imit, r=Mark-Simulacrum
    
    Allow for setting a ThinLTO import limit during bootstrap
    
    The benchmarks in rust-lang#66625 have shown that a lower ThinLTO import limit can be a net win for bootstrap times. This PR:
    - exposes the setting to `config.toml`,
    - defaults to a lower limit if `incremental = true` in `config.toml`, and
    - sets a lower limit for `x86_64-gnu-llvm-7` CI image in order to make the jobs complete more quickly (which remains to be tested).
    
    This setting will affect how the compiler and it's tools are compiled. It will not affect the settings the compiler uses when compiling user code.
    
    r? @pietroalbini
    cc @rust-lang/infra
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    7c404ce View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#67595 - ohadravid:impl-trait-does-not-live-…

    …long-enough, r=estebank
    
    Suggest adding a lifetime constraint for opaque type
    
    Fixes rust-lang#67577, where code like this:
    
    ```
    struct List {
      data: Vec<String>,
    }
    impl List {
      fn started_with<'a>(&'a self, prefix: &'a str) -> impl Iterator<Item=&'a str> {
        self.data.iter().filter(|s| s.starts_with(prefix)).map(|s| s.as_ref())
      }
    }
    ```
    
    will show this error:
    ```
       Compiling playground v0.0.1 (/playground)
    error[E0597]: `prefix` does not live long enough
     --> src/lib.rs:6:47
      |
    5 |   fn started_with<'a>(&'a self, prefix: &'a str) -> impl Iterator<Item=&'a str> {
      |                   -- lifetime `'a` defined here     --------------------------- opaque type requires that `prefix` is borrowed for `'a`
    ...
    ```
    
    but without suggesting the lovely `help: you can add a constraint..`.
    
    r? @estebank
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    76c1454 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#67636 - semarie:bootstrap-rustfmt, r=Mark-S…

    …imulacrum
    
    allow rustfmt key in [build] section
    
    Permit using `rustfmt` in `config.toml`. It will allow to not download `rustfmt` binary, which is not possible for at least some tiers-3 platforms.
    
    Fixes: rust-lang#67624
    
    r? @Mark-Simulacrum
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    9dd2c9e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#67736 - taralx:patch-1, r=sfackler

    Less-than is asymmetric, not antisymmetric
    
    This has bothered me for a while. It's such a small nit, but...
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    ed80f49 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#67762 - lzutao:systemtime-links, r=joshtrip…

    …lett
    
    Add missing links for insecure_time
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    aefc3cd View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#67783 - LeSeulArtichaut:pattern-ref-warning…

    …, r=Centril
    
    Warn for bindings named same as variants when matching against a borrow
    
    Fixes rust-lang#67776
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    7affcd5 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#67796 - Aaron1011:fix/mir-inline-proj, r=we…

    …sleywiser
    
    Ensure that we process projections during MIR inlining
    
    Fixes rust-lang#67710
    
    Previously, we were not calling `super_place`, which resulted in us
    failing to update any local references that occur in
    ProjectionElem::Index. This caused the post-inlining MIR to contain a
    reference to a local ID from the inlined callee, leading to an ICE
    due to a type mismatch.
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    09c7a9b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#67807 - lzutao:toilet-closure, r=Centril

    Use drop instead of the toilet closure `|_| ()`
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    b0649c0 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#67816 - GuillaumeGomez:clean-up-err-codes, …

    …r=Dylan-DPC
    
    Clean up err codes
    
    r? @Dylan-DPC
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    39a68a1 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#67825 - petertodd:2020-mem-take-grammar, r=…

    …steveklabnik
    
    Minor: change take() docs grammar to match other docs
    
    Eg. mem::replace()
    JohnTitor committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    14c96ce View commit details
    Browse the repository at this point in the history