Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run button positionning in case of scrolling #68553

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 26, 2020

Fixes #68337.

r? @kinnison

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2020
@kinnison
Copy link
Contributor

Change looks okay, and I can confirm it fixes the issue as raised.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2020

📌 Commit 85079f8 has been approved by kinnison

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 29, 2020
…l-pos, r=kinnison

Fix run button positionning in case of scrolling

Fixes rust-lang#68337.

r? @kinnison
bors added a commit that referenced this pull request Jan 29, 2020
Rollup of 8 pull requests

Successful merges:

 - #68289 (Don't ICE on path-collision in dep-graph)
 - #68378 (Add BTreeMap::remove_entry)
 - #68553 (Fix run button positionning in case of scrolling)
 - #68556 (rustdoc: Fix re-exporting primitive types)
 - #68582 (Add E0727 long explanation)
 - #68592 (fix: typo in vec.rs)
 - #68619 (Fix a few spelling mistakes)
 - #68620 (Update links to WASI docs in time.rs module)

Failed merges:

r? @ghost
@bors bors merged commit 85079f8 into rust-lang:master Jan 29, 2020
@GuillaumeGomez GuillaumeGomez deleted the fix-run-button-scroll-pos branch January 29, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: run-button is scrolled together with code example
4 participants