Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl From<[T; N]> for Vec<T> #68692

Merged
merged 9 commits into from Mar 29, 2020
Merged

impl From<[T; N]> for Vec<T> #68692

merged 9 commits into from Mar 29, 2020

Conversation

@jyn514
Copy link
Member

jyn514 commented Jan 31, 2020

Closes #67963

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 31, 2020

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

src/liballoc/vec.rs Outdated Show resolved Hide resolved
@Centril Centril added this to the 1.43 milestone Jan 31, 2020
@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 31, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-31T05:33:05.5613622Z ========================== Starting Command Output ===========================
2020-01-31T05:33:05.5649950Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/caa15de8-3254-40da-9e32-e71026172abc.sh
2020-01-31T05:33:05.5650002Z 
2020-01-31T05:33:05.5652817Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-31T05:33:05.5659175Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T05:33:05.5661662Z Task         : Get sources
2020-01-31T05:33:05.5661965Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-31T05:33:05.5661999Z Version      : 1.0.0
2020-01-31T05:33:05.5662032Z Author       : Microsoft
---
2020-01-31T05:33:06.5380090Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-31T05:33:06.5390313Z ##[command]git config gc.auto 0
2020-01-31T05:33:06.5392586Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-31T05:33:06.5395688Z ##[command]git config --get-all http.proxy
2020-01-31T05:33:06.5401859Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68692/merge:refs/remotes/pull/68692/merge
---
2020-01-31T06:34:40.6470405Z .................................................................................................... 1700/9558
2020-01-31T06:34:45.7660253Z .................................................................................................... 1800/9558
2020-01-31T06:34:59.1694743Z .........................i.......................................................................... 1900/9558
2020-01-31T06:35:06.5642846Z .................................................................................................... 2000/9558
2020-01-31T06:35:22.0334896Z ...............iiiii................................................................................ 2100/9558
2020-01-31T06:35:32.3977131Z .................................................................................................... 2300/9558
2020-01-31T06:35:34.9298560Z .................................................................................................... 2400/9558
2020-01-31T06:35:40.2602977Z .................................................................................................... 2500/9558
2020-01-31T06:36:02.3755132Z .................................................................................................... 2600/9558
---
2020-01-31T06:38:43.8394132Z .................................................................................................... 4800/9558
2020-01-31T06:38:49.0954502Z ..........................................................i...............i......................... 4900/9558
2020-01-31T06:38:57.3210763Z .................................................................................................... 5000/9558
2020-01-31T06:39:05.7908763Z .................................................................................................... 5100/9558
2020-01-31T06:39:11.6061089Z .i.................................................................................................. 5200/9558
2020-01-31T06:39:22.9996576Z ..........................................................................ii.ii........i...i........ 5300/9558
2020-01-31T06:39:31.9953330Z ............i....................................................................................... 5500/9558
2020-01-31T06:39:42.5689899Z .................................................................................................... 5600/9558
2020-01-31T06:39:49.1775139Z .............................................................i...................................... 5700/9558
2020-01-31T06:39:56.6711570Z .................................................................................................... 5800/9558
2020-01-31T06:39:56.6711570Z .................................................................................................... 5800/9558
2020-01-31T06:40:05.1056965Z .................................................................................................... 5900/9558
2020-01-31T06:40:14.5401474Z ....................................................ii...i..ii...........i.......................... 6000/9558
2020-01-31T06:40:37.5634259Z .................................................................................................... 6200/9558
2020-01-31T06:40:45.5746968Z .................................................................................................... 6300/9558
2020-01-31T06:40:45.5746968Z .................................................................................................... 6300/9558
2020-01-31T06:40:55.1435531Z ................................................................................i..ii............... 6400/9558
2020-01-31T06:41:24.1196279Z .................................................................................................... 6600/9558
2020-01-31T06:41:29.7784276Z ........................................................i........................................... 6700/9558
2020-01-31T06:41:32.0606980Z .................................................................................................... 6800/9558
2020-01-31T06:41:34.4821111Z .......................................................i............................................ 6900/9558
---
2020-01-31T06:43:21.3503282Z .................................................................................................... 7600/9558
2020-01-31T06:43:27.0416542Z .................................................................................................... 7700/9558
2020-01-31T06:43:34.1640383Z .................................................................................................... 7800/9558
2020-01-31T06:43:45.2823416Z .................................................................................................... 7900/9558
2020-01-31T06:43:51.6691363Z ...........iiiiiii.i................................................................................ 8000/9558
2020-01-31T06:44:06.8549267Z .................................................................................................... 8200/9558
2020-01-31T06:44:17.9376756Z .................................................................................................... 8300/9558
2020-01-31T06:44:31.5969882Z .................................................................................................... 8400/9558
2020-01-31T06:44:38.6282096Z .................................................................................................... 8500/9558
---
2020-01-31T06:47:07.6205857Z  finished in 7.681
2020-01-31T06:47:07.6398039Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T06:47:07.8423345Z 
2020-01-31T06:47:07.8424341Z running 169 tests
2020-01-31T06:47:11.0206078Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-31T06:47:13.3543888Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-31T06:47:13.3544454Z 
2020-01-31T06:47:13.3550075Z  finished in 5.715
2020-01-31T06:47:13.3756165Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T06:47:13.5501275Z 
---
2020-01-31T06:47:15.7043970Z  finished in 2.329
2020-01-31T06:47:15.7238427Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T06:47:15.8928611Z 
2020-01-31T06:47:15.8928857Z running 9 tests
2020-01-31T06:47:15.8929696Z iiiiiiiii
2020-01-31T06:47:15.8930487Z 
2020-01-31T06:47:15.8933614Z  finished in 0.169
2020-01-31T06:47:16.7434256Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T06:47:16.7434343Z 
---
2020-01-31T06:47:36.9590140Z  finished in 21.045
2020-01-31T06:47:36.9830749Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T06:47:37.8596293Z 
2020-01-31T06:47:37.8596596Z running 116 tests
2020-01-31T06:47:52.0494944Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-31T06:47:54.0599479Z ....iiii.....ii.
2020-01-31T06:47:54.0603799Z 
2020-01-31T06:47:54.0608273Z  finished in 17.078
2020-01-31T06:47:54.0616945Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T06:47:54.0617366Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-31T06:59:14.3783090Z    Compiling alloc v0.0.0 (/checkout/src/liballoc)
2020-01-31T06:59:17.0262861Z error[E0308]: mismatched types
2020-01-31T06:59:17.0265356Z     --> src/liballoc/vec.rs:2396:9
2020-01-31T06:59:17.0267453Z      |
2020-01-31T06:59:17.0269147Z 2395 |     fn from(arr: [T; N]) -> Vec<T> {
2020-01-31T06:59:17.0270092Z      |                             ------ expected `vec::Vec<T>` because of return type
2020-01-31T06:59:17.0270906Z 2396 |         <[T]>::into_vec(box arr)
2020-01-31T06:59:17.0271508Z      |         ^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `vec::Vec`, found struct `std::vec::Vec`
2020-01-31T06:59:17.0272541Z      = note: expected struct `vec::Vec<T>`
2020-01-31T06:59:17.0273398Z                 found struct `std::vec::Vec<T>`
2020-01-31T06:59:17.0273647Z 
2020-01-31T06:59:17.0737931Z error: aborting due to previous error
---
2020-01-31T07:00:05.7133556Z   local time: Fri Jan 31 07:00:05 UTC 2020
2020-01-31T07:00:06.0062036Z   network time: Fri, 31 Jan 2020 07:00:06 GMT
2020-01-31T07:00:06.0063474Z == end clock drift check ==
2020-01-31T07:00:06.3696049Z 
2020-01-31T07:00:06.3807926Z ##[error]Bash exited with code '1'.
2020-01-31T07:00:06.3823188Z ##[section]Finishing: Run build
2020-01-31T07:00:06.3847043Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T07:00:06.3871676Z Task         : Get sources
2020-01-31T07:00:06.3871724Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-31T07:00:06.3871782Z Version      : 1.0.0
2020-01-31T07:00:06.3871825Z Author       : Microsoft
2020-01-31T07:00:06.3871825Z Author       : Microsoft
2020-01-31T07:00:06.3872049Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-31T07:00:06.3872111Z ==============================================================================
2020-01-31T07:00:06.8513643Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-31T07:00:06.8559400Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T07:00:06.8677004Z Cleaning up task key
2020-01-31T07:00:06.8677713Z Start cleaning up orphan processes.
2020-01-31T07:00:06.8794063Z Terminate orphan process: pid (4791) (python)
2020-01-31T07:00:06.9089981Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/liballoc/vec.rs Outdated Show resolved Hide resolved
@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 31, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-31T16:47:13.2283828Z ========================== Starting Command Output ===========================
2020-01-31T16:47:13.2285521Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/8494ac8b-c2de-4661-ab10-4764e233a11e.sh
2020-01-31T16:47:13.2285563Z 
2020-01-31T16:47:13.2288786Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-31T16:47:13.2295616Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T16:47:13.2297247Z Task         : Get sources
2020-01-31T16:47:13.2297292Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-31T16:47:13.2297323Z Version      : 1.0.0
2020-01-31T16:47:13.2297355Z Author       : Microsoft
---
2020-01-31T16:47:14.3565966Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-31T16:47:14.3707271Z ##[command]git config gc.auto 0
2020-01-31T16:47:14.3798408Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-31T16:47:14.3855920Z ##[command]git config --get-all http.proxy
2020-01-31T16:47:14.4006395Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68692/merge:refs/remotes/pull/68692/merge
---
2020-01-31T17:45:48.6895951Z .................................................................................................... 1700/9559
2020-01-31T17:45:53.6497826Z .................................................................................................... 1800/9559
2020-01-31T17:46:06.4700966Z .........................i.......................................................................... 1900/9559
2020-01-31T17:46:13.5974634Z .................................................................................................... 2000/9559
2020-01-31T17:46:28.8792940Z ...............iiiii................................................................................ 2100/9559
2020-01-31T17:46:39.1586341Z .................................................................................................... 2300/9559
2020-01-31T17:46:41.6018929Z .................................................................................................... 2400/9559
2020-01-31T17:46:46.7339329Z .................................................................................................... 2500/9559
2020-01-31T17:47:08.5064680Z .................................................................................................... 2600/9559
---
2020-01-31T17:49:47.1039331Z .................................................................................................... 4800/9559
2020-01-31T17:49:52.3004759Z ..........................................................i...............i......................... 4900/9559
2020-01-31T17:50:00.3243941Z .................................................................................................... 5000/9559
2020-01-31T17:50:08.4201517Z .................................................................................................... 5100/9559
2020-01-31T17:50:13.3735583Z .i.................................................................................................. 5200/9559
2020-01-31T17:50:24.6377701Z ..........................................................................ii.ii........i...i........ 5300/9559
2020-01-31T17:50:33.5199608Z ............i....................................................................................... 5500/9559
2020-01-31T17:50:43.8331599Z .................................................................................................... 5600/9559
2020-01-31T17:50:50.2928316Z .............................................................i...................................... 5700/9559
2020-01-31T17:50:57.6439659Z .................................................................................................... 5800/9559
2020-01-31T17:50:57.6439659Z .................................................................................................... 5800/9559
2020-01-31T17:51:05.8640614Z .................................................................................................... 5900/9559
2020-01-31T17:51:15.1456552Z ....................................................ii...i..ii...........i.......................... 6000/9559
2020-01-31T17:51:37.5272499Z .................................................................................................... 6200/9559
2020-01-31T17:51:45.2500072Z .................................................................................................... 6300/9559
2020-01-31T17:51:45.2500072Z .................................................................................................... 6300/9559
2020-01-31T17:51:53.5943226Z ................................................................................i..ii............... 6400/9559
2020-01-31T17:52:21.2384368Z .................................................................................................... 6600/9559
2020-01-31T17:52:26.9210346Z ........................................................i........................................... 6700/9559
2020-01-31T17:52:29.1152249Z .................................................................................................... 6800/9559
2020-01-31T17:52:31.4222298Z ........................................................i........................................... 6900/9559
---
2020-01-31T17:54:16.3607311Z .................................................................................................... 7600/9559
2020-01-31T17:54:21.8063566Z .................................................................................................... 7700/9559
2020-01-31T17:54:28.7183430Z .................................................................................................... 7800/9559
2020-01-31T17:54:39.7110149Z .................................................................................................... 7900/9559
2020-01-31T17:54:46.0561258Z ............iiiiiii.i............................................................................... 8000/9559
2020-01-31T17:55:00.9035793Z .................................................................................................... 8200/9559
2020-01-31T17:55:11.9162722Z .................................................................................................... 8300/9559
2020-01-31T17:55:25.7104227Z .................................................................................................... 8400/9559
2020-01-31T17:55:32.6473821Z .................................................................................................... 8500/9559
---
2020-01-31T17:57:31.5426133Z 
2020-01-31T17:57:31.5426186Z + error[E0277]: arrays only have std trait implementations for lengths 0..=32
2020-01-31T17:57:31.5426495Z +   --> $DIR/alloc-types-no-impls-length-33.rs:6:29
2020-01-31T17:57:31.5426548Z +    |
2020-01-31T17:57:31.5426595Z + LL |     let v: Vec<_> = [0; 33].into();
2020-01-31T17:57:31.5426674Z +    |                             ^^^^ the trait `std::array::LengthAtMost32` is not implemented for `[{integer}; 33]`
2020-01-31T17:57:31.5426727Z +    |
2020-01-31T17:57:31.5426787Z +    = note: required because of the requirements on the impl of `std::convert::From<[{integer}; 33]>` for `std::vec::Vec<{integer}>`
2020-01-31T17:57:31.5426873Z +    = note: required because of the requirements on the impl of `std::convert::Into<std::vec::Vec<{integer}>>` for `[{integer}; 33]`
2020-01-31T17:57:31.5426936Z + 
2020-01-31T17:57:31.5427000Z 1 error[E0277]: the trait bound `std::boxed::Box<[i32; 33]>: std::convert::From<std::boxed::Box<[i32]>>` is not satisfied
2020-01-31T17:57:31.5427686Z +   --> $DIR/alloc-types-no-impls-length-33.rs:12:23
2020-01-31T17:57:31.5427731Z 3    |
2020-01-31T17:57:31.5427731Z 3    |
2020-01-31T17:57:31.5427792Z 4 LL |     let boxed_array = <Box<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5427854Z 5    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::boxed::Box<[i32]>>` is not implemented for `std::boxed::Box<[i32; 33]>`
2020-01-31T17:57:31.5427894Z 
2020-01-31T17:57:31.5427966Z 14    = note: required because of the requirements on the impl of `std::convert::TryFrom<std::boxed::Box<[i32]>>` for `std::boxed::Box<[i32; 33]>`
2020-01-31T17:57:31.5428016Z 15 
2020-01-31T17:57:31.5428073Z 16 error[E0277]: the trait bound `std::boxed::Box<[i32; 33]>: std::convert::TryFrom<std::boxed::Box<[i32]>>` is not satisfied
2020-01-31T17:57:31.5428575Z +   --> $DIR/alloc-types-no-impls-length-33.rs:12:23
2020-01-31T17:57:31.5428621Z 18    |
2020-01-31T17:57:31.5428621Z 18    |
2020-01-31T17:57:31.5428683Z 19 LL |     let boxed_array = <Box<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5428743Z 20    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::TryFrom<std::boxed::Box<[i32]>>` is not implemented for `std::boxed::Box<[i32; 33]>`
2020-01-31T17:57:31.5428781Z 
2020-01-31T17:57:31.5428847Z 23              <std::boxed::Box<[T; _]> as std::convert::TryFrom<std::boxed::Box<[T]>>>
2020-01-31T17:57:31.5428891Z 24 
2020-01-31T17:57:31.5428942Z 25 error[E0277]: the trait bound `std::rc::Rc<[i32; 33]>: std::convert::From<std::rc::Rc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5429412Z +   --> $DIR/alloc-types-no-impls-length-33.rs:19:23
2020-01-31T17:57:31.5429639Z 27    |
2020-01-31T17:57:31.5429639Z 27    |
2020-01-31T17:57:31.5429794Z 28 LL |     let boxed_array = <Rc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5429859Z 29    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::rc::Rc<[i32]>>` is not implemented for `std::rc::Rc<[i32; 33]>`
2020-01-31T17:57:31.5429896Z 
2020-01-31T17:57:31.5429951Z 38    = note: required because of the requirements on the impl of `std::convert::TryFrom<std::rc::Rc<[i32]>>` for `std::rc::Rc<[i32; 33]>`
2020-01-31T17:57:31.5430014Z 39 
2020-01-31T17:57:31.5430064Z 40 error[E0277]: the trait bound `std::rc::Rc<[i32; 33]>: std::convert::TryFrom<std::rc::Rc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5430576Z +   --> $DIR/alloc-types-no-impls-length-33.rs:19:23
2020-01-31T17:57:31.5430620Z 42    |
2020-01-31T17:57:31.5430620Z 42    |
2020-01-31T17:57:31.5430665Z 43 LL |     let boxed_array = <Rc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5430756Z 44    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::TryFrom<std::rc::Rc<[i32]>>` is not implemented for `std::rc::Rc<[i32; 33]>`
2020-01-31T17:57:31.5430793Z 
2020-01-31T17:57:31.5430839Z 47              <std::rc::Rc<[T; _]> as std::convert::TryFrom<std::rc::Rc<[T]>>>
2020-01-31T17:57:31.5430898Z 48 
2020-01-31T17:57:31.5430949Z 49 error[E0277]: the trait bound `std::sync::Arc<[i32; 33]>: std::convert::From<std::sync::Arc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5431418Z +   --> $DIR/alloc-types-no-impls-length-33.rs:26:23
2020-01-31T17:57:31.5431463Z 51    |
2020-01-31T17:57:31.5431463Z 51    |
2020-01-31T17:57:31.5431508Z 52 LL |     let boxed_array = <Arc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5431582Z 53    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::sync::Arc<[i32]>>` is not implemented for `std::sync::Arc<[i32; 33]>`
2020-01-31T17:57:31.5431627Z 
2020-01-31T17:57:31.5431686Z 62    = note: required because of the requirements on the impl of `std::convert::TryFrom<std::sync::Arc<[i32]>>` for `std::sync::Arc<[i32; 33]>`
2020-01-31T17:57:31.5431735Z 63 
2020-01-31T17:57:31.5431802Z 64 error[E0277]: the trait bound `std::sync::Arc<[i32; 33]>: std::convert::TryFrom<std::sync::Arc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5432256Z +   --> $DIR/alloc-types-no-impls-length-33.rs:26:23
2020-01-31T17:57:31.5432317Z 66    |
2020-01-31T17:57:31.5432317Z 66    |
2020-01-31T17:57:31.5432362Z 67 LL |     let boxed_array = <Arc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5432421Z 68    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::TryFrom<std::sync::Arc<[i32]>>` is not implemented for `std::sync::Arc<[i32; 33]>`
2020-01-31T17:57:31.5432521Z 70    = help: the following implementations were found:
2020-01-31T17:57:31.5432521Z 70    = help: the following implementations were found:
2020-01-31T17:57:31.5432580Z 71              <std::sync::Arc<[T; _]> as std::convert::TryFrom<std::sync::Arc<[T]>>>
2020-01-31T17:57:31.5432866Z - error: aborting due to 6 previous errors
2020-01-31T17:57:31.5432915Z + error: aborting due to 7 previous errors
2020-01-31T17:57:31.5432972Z 74 
2020-01-31T17:57:31.5433215Z 75 For more information about this error, try `rustc --explain E0277`.
2020-01-31T17:57:31.5433215Z 75 For more information about this error, try `rustc --explain E0277`.
2020-01-31T17:57:31.5433261Z 76 
2020-01-31T17:57:31.5433286Z 
2020-01-31T17:57:31.5433311Z 
2020-01-31T17:57:31.5433369Z The actual stderr differed from the expected stderr.
2020-01-31T17:57:31.5433718Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/array-impls/alloc-types-no-impls-length-33/alloc-types-no-impls-length-33.stderr
2020-01-31T17:57:31.5434443Z To update references, rerun the tests and pass the `--bless` flag
2020-01-31T17:57:31.5434773Z To only update this specific test, also pass `--test-args const-generics/array-impls/alloc-types-no-impls-length-33.rs`
2020-01-31T17:57:31.5434975Z error: 1 errors occurred comparing output.
2020-01-31T17:57:31.5435097Z status: exit code: 1
2020-01-31T17:57:31.5435097Z status: exit code: 1
2020-01-31T17:57:31.5436055Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/const-generics/array-impls/alloc-types-no-impls-length-33.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/array-impls/alloc-types-no-impls-length-33" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/array-impls/alloc-types-no-impls-length-33/auxiliary" "-A" "unused"
2020-01-31T17:57:31.5436405Z ------------------------------------------
2020-01-31T17:57:31.5436450Z 
2020-01-31T17:57:31.5436695Z ------------------------------------------
2020-01-31T17:57:31.5436742Z stderr:
2020-01-31T17:57:31.5436742Z stderr:
2020-01-31T17:57:31.5436971Z ------------------------------------------
2020-01-31T17:57:31.5437044Z error[E0277]: arrays only have std trait implementations for lengths 0..=32
2020-01-31T17:57:31.5437331Z   --> /checkout/src/test/ui/const-generics/array-impls/alloc-types-no-impls-length-33.rs:6:29
2020-01-31T17:57:31.5437386Z    |
2020-01-31T17:57:31.5437448Z LL |     let v: Vec<_> = [0; 33].into();
2020-01-31T17:57:31.5437506Z    |                             ^^^^ the trait `std::array::LengthAtMost32` is not implemented for `[{integer}; 33]`
2020-01-31T17:57:31.5437558Z    |
2020-01-31T17:57:31.5437633Z    = note: required because of the requirements on the impl of `std::convert::From<[{integer}; 33]>` for `std::vec::Vec<{integer}>`
2020-01-31T17:57:31.5437698Z    = note: required because of the requirements on the impl of `std::convert::Into<std::vec::Vec<{integer}>>` for `[{integer}; 33]`
2020-01-31T17:57:31.5437744Z 
2020-01-31T17:57:31.5437820Z error[E0277]: the trait bound `std::boxed::Box<[i32; 33]>: std::convert::From<std::boxed::Box<[i32]>>` is not satisfied
2020-01-31T17:57:31.5438389Z    |
2020-01-31T17:57:31.5438389Z    |
2020-01-31T17:57:31.5438433Z LL |     let boxed_array = <Box<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5438492Z    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::boxed::Box<[i32]>>` is not implemented for `std::boxed::Box<[i32; 33]>`
2020-01-31T17:57:31.5438603Z    = help: the following implementations were found:
2020-01-31T17:57:31.5438603Z    = help: the following implementations were found:
2020-01-31T17:57:31.5438859Z              <std::boxed::Box<(dyn std::error::Error + 'a)> as std::convert::From<E>>
2020-01-31T17:57:31.5439136Z              <std::boxed::Box<(dyn std::error::Error + 'static)> as std::convert::From<&str>>
2020-01-31T17:57:31.5439416Z              <std::boxed::Box<(dyn std::error::Error + 'static)> as std::convert::From<std::borrow::Cow<'a, str>>>
2020-01-31T17:57:31.5439710Z              <std::boxed::Box<(dyn std::error::Error + 'static)> as std::convert::From<std::string::String>>
2020-01-31T17:57:31.5439779Z            and 16 others
2020-01-31T17:57:31.5439834Z    = note: required because of the requirements on the impl of `std::convert::Into<std::boxed::Box<[i32; 33]>>` for `std::boxed::Box<[i32]>`
2020-01-31T17:57:31.5439913Z    = note: required because of the requirements on the impl of `std::convert::TryFrom<std::boxed::Box<[i32]>>` for `std::boxed::Box<[i32; 33]>`
2020-01-31T17:57:31.5439949Z 
2020-01-31T17:57:31.5440000Z error[E0277]: the trait bound `std::boxed::Box<[i32; 33]>: std::convert::TryFrom<std::boxed::Box<[i32]>>` is not satisfied
2020-01-31T17:57:31.5440334Z    |
2020-01-31T17:57:31.5440334Z    |
2020-01-31T17:57:31.5440379Z LL |     let boxed_array = <Box<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5440584Z    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::TryFrom<std::boxed::Box<[i32]>>` is not implemented for `std::boxed::Box<[i32; 33]>`
2020-01-31T17:57:31.5440696Z    = help: the following implementations were found:
2020-01-31T17:57:31.5440696Z    = help: the following implementations were found:
2020-01-31T17:57:31.5440746Z              <std::boxed::Box<[T; _]> as std::convert::TryFrom<std::boxed::Box<[T]>>>
2020-01-31T17:57:31.5440793Z 
2020-01-31T17:57:31.5440842Z error[E0277]: the trait bound `std::rc::Rc<[i32; 33]>: std::convert::From<std::rc::Rc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5441356Z    |
2020-01-31T17:57:31.5441356Z    |
2020-01-31T17:57:31.5441399Z LL |     let boxed_array = <Rc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5441456Z    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::rc::Rc<[i32]>>` is not implemented for `std::rc::Rc<[i32; 33]>`
2020-01-31T17:57:31.5441574Z    = help: the following implementations were found:
2020-01-31T17:57:31.5441574Z    = help: the following implementations were found:
2020-01-31T17:57:31.5441619Z              <std::rc::Rc<T> as std::convert::From<T>>
2020-01-31T17:57:31.5441681Z              <std::rc::Rc<T> as std::convert::From<std::boxed::Box<T>>>
2020-01-31T17:57:31.5441727Z              <std::rc::Rc<[T]> as std::convert::From<&[T]>>
2020-01-31T17:57:31.5441774Z              <std::rc::Rc<[T]> as std::convert::From<std::vec::Vec<T>>>
2020-01-31T17:57:31.5441832Z            and 8 others
2020-01-31T17:57:31.5441883Z    = note: required because of the requirements on the impl of `std::convert::Into<std::rc::Rc<[i32; 33]>>` for `std::rc::Rc<[i32]>`
2020-01-31T17:57:31.5441943Z    = note: required because of the requirements on the impl of `std::convert::TryFrom<std::rc::Rc<[i32]>>` for `std::rc::Rc<[i32; 33]>`
2020-01-31T17:57:31.5441977Z 
2020-01-31T17:57:31.5442041Z error[E0277]: the trait bound `std::rc::Rc<[i32; 33]>: std::convert::TryFrom<std::rc::Rc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5442366Z    |
2020-01-31T17:57:31.5442366Z    |
2020-01-31T17:57:31.5442425Z LL |     let boxed_array = <Rc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5442481Z    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::TryFrom<std::rc::Rc<[i32]>>` is not implemented for `std::rc::Rc<[i32; 33]>`
2020-01-31T17:57:31.5442585Z    = help: the following implementations were found:
2020-01-31T17:57:31.5442585Z    = help: the following implementations were found:
2020-01-31T17:57:31.5442634Z              <std::rc::Rc<[T; _]> as std::convert::TryFrom<std::rc::Rc<[T]>>>
2020-01-31T17:57:31.5442663Z 
2020-01-31T17:57:31.5442726Z error[E0277]: the trait bound `std::sync::Arc<[i32; 33]>: std::convert::From<std::sync::Arc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5443763Z    |
2020-01-31T17:57:31.5443763Z    |
2020-01-31T17:57:31.5443831Z LL |     let boxed_array = <Arc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5443889Z    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<std::sync::Arc<[i32]>>` is not implemented for `std::sync::Arc<[i32; 33]>`
2020-01-31T17:57:31.5444503Z    = help: the following implementations were found:
2020-01-31T17:57:31.5444503Z    = help: the following implementations were found:
2020-01-31T17:57:31.5444554Z              <std::sync::Arc<T> as std::convert::From<T>>
2020-01-31T17:57:31.5444606Z              <std::sync::Arc<T> as std::convert::From<std::boxed::Box<T>>>
2020-01-31T17:57:31.5444674Z              <std::sync::Arc<[T]> as std::convert::From<&[T]>>
2020-01-31T17:57:31.5444727Z              <std::sync::Arc<[T]> as std::convert::From<std::vec::Vec<T>>>
2020-01-31T17:57:31.5444775Z            and 8 others
2020-01-31T17:57:31.5444849Z    = note: required because of the requirements on the impl of `std::convert::Into<std::sync::Arc<[i32; 33]>>` for `std::sync::Arc<[i32]>`
2020-01-31T17:57:31.5445092Z    = note: required because of the requirements on the impl of `std::convert::TryFrom<std::sync::Arc<[i32]>>` for `std::sync::Arc<[i32; 33]>`
2020-01-31T17:57:31.5445134Z 
2020-01-31T17:57:31.5445188Z error[E0277]: the trait bound `std::sync::Arc<[i32; 33]>: std::convert::TryFrom<std::sync::Arc<[i32]>>` is not satisfied
2020-01-31T17:57:31.5445629Z    |
2020-01-31T17:57:31.5445629Z    |
2020-01-31T17:57:31.5445676Z LL |     let boxed_array = <Arc<[i32; 33]>>::try_from(boxed_slice);
2020-01-31T17:57:31.5445756Z    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::TryFrom<std::sync::Arc<[i32]>>` is not implemented for `std::sync::Arc<[i32; 33]>`
2020-01-31T17:57:31.5445856Z    = help: the following implementations were found:
2020-01-31T17:57:31.5445856Z    = help: the following implementations were found:
2020-01-31T17:57:31.5445925Z              <std::sync::Arc<[T; _]> as std::convert::TryFrom<std::sync::Arc<[T]>>>
2020-01-31T17:57:31.5446013Z error: aborting due to 7 previous errors
2020-01-31T17:57:31.5446051Z 
2020-01-31T17:57:31.5446323Z For more information about this error, try `rustc --explain E0277`.
2020-01-31T17:57:31.5446357Z 
---
2020-01-31T17:57:31.5456269Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-01-31T17:57:31.5456370Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-01-31T17:57:31.5470752Z 
2020-01-31T17:57:31.5471262Z 
2020-01-31T17:57:31.5473115Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-31T17:57:31.5473382Z 
2020-01-31T17:57:31.5473413Z 
2020-01-31T17:57:31.5486580Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-31T17:57:31.5486656Z Build completed unsuccessfully in 1:04:44
2020-01-31T17:57:31.5486656Z Build completed unsuccessfully in 1:04:44
2020-01-31T17:57:31.5549796Z == clock drift check ==
2020-01-31T17:57:31.5574304Z   local time: Fri Jan 31 17:57:31 UTC 2020
2020-01-31T17:57:31.8523110Z   network time: Fri, 31 Jan 2020 17:57:31 GMT
2020-01-31T17:57:31.8524880Z == end clock drift check ==
2020-01-31T17:57:32.2187630Z 
2020-01-31T17:57:32.2302734Z ##[error]Bash exited with code '1'.
2020-01-31T17:57:32.2318078Z ##[section]Finishing: Run build
2020-01-31T17:57:32.2346784Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T17:57:32.2349235Z Task         : Get sources
2020-01-31T17:57:32.2349296Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-31T17:57:32.2349340Z Version      : 1.0.0
2020-01-31T17:57:32.2349379Z Author       : Microsoft
2020-01-31T17:57:32.2349379Z Author       : Microsoft
2020-01-31T17:57:32.2349441Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-31T17:57:32.2349487Z ==============================================================================
2020-01-31T17:57:32.6989508Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-31T17:57:32.7031117Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T17:57:32.7149908Z Cleaning up task key
2020-01-31T17:57:32.7150644Z Start cleaning up orphan processes.
2020-01-31T17:57:32.7294378Z Terminate orphan process: pid (3814) (python)
2020-01-31T17:57:32.7537746Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jyn514

This comment has been minimized.

Copy link
Member Author

jyn514 commented Jan 31, 2020

This is blocked on me getting stage1 to compile locally so I can mess with the test suite. It might be a couple days, I have a slow laptop and my fast computer runs alpine which doesn't work with proc-macros.

@jyn514

This comment has been minimized.

Copy link
Member Author

jyn514 commented Jan 31, 2020

Didn't take as long as I thought, only an hour 😉 This is ready for review.

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 31, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-31T19:02:10.7760646Z ========================== Starting Command Output ===========================
2020-01-31T19:02:10.7762351Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/c0e2295a-10a5-4014-a7e6-2a773ebc0232.sh
2020-01-31T19:02:10.7762412Z 
2020-01-31T19:02:10.7765987Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-31T19:02:10.7774369Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T19:02:10.7776267Z Task         : Get sources
2020-01-31T19:02:10.7776359Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-31T19:02:10.7776398Z Version      : 1.0.0
2020-01-31T19:02:10.7776436Z Author       : Microsoft
---
2020-01-31T19:02:11.7558136Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-31T19:02:11.7631296Z ##[command]git config gc.auto 0
2020-01-31T19:02:11.7633966Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-31T19:02:11.7636164Z ##[command]git config --get-all http.proxy
2020-01-31T19:02:11.7644463Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68692/merge:refs/remotes/pull/68692/merge
---
2020-01-31T20:00:55.0727625Z .................................................................................................... 1700/9559
2020-01-31T20:01:00.2398449Z .................................................................................................... 1800/9559
2020-01-31T20:01:13.5912909Z .........................i.......................................................................... 1900/9559
2020-01-31T20:01:21.1953167Z .................................................................................................... 2000/9559
2020-01-31T20:01:36.5074176Z ...............iiiii................................................................................ 2100/9559
2020-01-31T20:01:47.0260810Z .................................................................................................... 2300/9559
2020-01-31T20:01:49.6092139Z .................................................................................................... 2400/9559
2020-01-31T20:01:55.1173282Z .................................................................................................... 2500/9559
2020-01-31T20:02:17.5172335Z .................................................................................................... 2600/9559
---
2020-01-31T20:05:01.8618941Z .................................................................................................... 4800/9559
2020-01-31T20:05:07.0205686Z ..........................................................i...............i......................... 4900/9559
2020-01-31T20:05:15.3046093Z .................................................................................................... 5000/9559
2020-01-31T20:05:23.9749461Z .................................................................................................... 5100/9559
2020-01-31T20:05:29.3282819Z .i.................................................................................................. 5200/9559
2020-01-31T20:05:41.3050097Z ..........................................................................ii.ii........i...i........ 5300/9559
2020-01-31T20:05:50.6040149Z ............i....................................................................................... 5500/9559
2020-01-31T20:06:01.3575770Z .................................................................................................... 5600/9559
2020-01-31T20:06:08.0433270Z .............................................................i...................................... 5700/9559
2020-01-31T20:06:15.8028912Z .................................................................................................... 5800/9559
2020-01-31T20:06:15.8028912Z .................................................................................................... 5800/9559
2020-01-31T20:06:24.4184180Z .................................................................................................... 5900/9559
2020-01-31T20:06:33.6428917Z ....................................................ii...i..ii...........i.......................... 6000/9559
2020-01-31T20:06:56.5618518Z .................................................................................................... 6200/9559
2020-01-31T20:07:04.5348981Z .................................................................................................... 6300/9559
2020-01-31T20:07:04.5348981Z .................................................................................................... 6300/9559
2020-01-31T20:07:14.0245180Z ................................................................................i..ii............... 6400/9559
2020-01-31T20:07:48.4184653Z .................................................................................................... 6600/9559
2020-01-31T20:07:54.1147629Z ........................................................i........................................... 6700/9559
2020-01-31T20:07:56.3891173Z .................................................................................................... 6800/9559
2020-01-31T20:07:58.8069149Z ........................................................i........................................... 6900/9559
---
2020-01-31T20:09:45.9216750Z .................................................................................................... 7600/9559
2020-01-31T20:09:51.6261302Z .................................................................................................... 7700/9559
2020-01-31T20:09:58.7525681Z .................................................................................................... 7800/9559
2020-01-31T20:10:09.9713453Z .................................................................................................... 7900/9559
2020-01-31T20:10:17.1658475Z ............iiiiiii.i............................................................................... 8000/9559
2020-01-31T20:10:31.7348581Z .................................................................................................... 8200/9559
2020-01-31T20:10:43.0722053Z .................................................................................................... 8300/9559
2020-01-31T20:10:57.1370200Z .................................................................................................... 8400/9559
2020-01-31T20:11:04.2549196Z .................................................................................................... 8500/9559
---
2020-01-31T20:13:33.4732883Z  finished in 7.984
2020-01-31T20:13:33.4932196Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T20:13:33.7053579Z 
2020-01-31T20:13:33.7054990Z running 169 tests
2020-01-31T20:13:36.9486782Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-31T20:13:39.3170247Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-31T20:13:40.2288118Z 
2020-01-31T20:13:40.2288200Z  finished in 5.824
2020-01-31T20:13:40.2288630Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T20:13:40.2288671Z 
---
2020-01-31T20:13:41.6589020Z  finished in 2.319
2020-01-31T20:13:41.6796299Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T20:13:41.8487297Z 
2020-01-31T20:13:41.8489812Z running 9 tests
2020-01-31T20:13:41.8490795Z iiiiiiiii
2020-01-31T20:13:41.8491217Z 
2020-01-31T20:13:41.8492031Z  finished in 0.169
2020-01-31T20:13:41.8692541Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T20:13:42.0711639Z 
---
2020-01-31T20:14:03.7349472Z  finished in 21.799
2020-01-31T20:14:03.7349768Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T20:14:03.9039035Z 
2020-01-31T20:14:03.9039722Z running 116 tests
2020-01-31T20:14:18.2074492Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-31T20:14:20.2169815Z ....iiii.....ii.
2020-01-31T20:14:20.2171470Z 
2020-01-31T20:14:20.2174456Z  finished in 16.526
2020-01-31T20:14:20.2179525Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-31T20:14:20.2179893Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-31T20:25:18.5690130Z    Compiling alloc v0.0.0 (/checkout/src/liballoc)
2020-01-31T20:25:21.2480774Z error[E0308]: mismatched types
2020-01-31T20:25:21.2481479Z     --> src/liballoc/vec.rs:2399:9
2020-01-31T20:25:21.2481892Z      |
2020-01-31T20:25:21.2482209Z 2398 |     fn from(arr: [T; N]) -> Self {
2020-01-31T20:25:21.2482609Z      |                             ---- expected `vec::Vec<T>` because of return type
2020-01-31T20:25:21.2482957Z 2399 |         <[T]>::into_vec(box arr)
2020-01-31T20:25:21.2483368Z      |         ^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `vec::Vec`, found struct `std::vec::Vec`
2020-01-31T20:25:21.2483955Z      = note: expected struct `vec::Vec<T>`
2020-01-31T20:25:21.2484259Z                 found struct `std::vec::Vec<T>`
2020-01-31T20:25:21.2484317Z 
2020-01-31T20:25:21.2998152Z error: aborting due to previous error
---
2020-01-31T20:26:07.7092072Z   local time: Fri Jan 31 20:26:07 UTC 2020
2020-01-31T20:26:08.2628494Z   network time: Fri, 31 Jan 2020 20:26:08 GMT
2020-01-31T20:26:08.2633714Z == end clock drift check ==
2020-01-31T20:26:08.6711483Z 
2020-01-31T20:26:08.6824437Z ##[error]Bash exited with code '1'.
2020-01-31T20:26:08.6836059Z ##[section]Finishing: Run build
2020-01-31T20:26:08.6865129Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T20:26:08.6868025Z Task         : Get sources
2020-01-31T20:26:08.6868095Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-31T20:26:08.6868147Z Version      : 1.0.0
2020-01-31T20:26:08.6868194Z Author       : Microsoft
2020-01-31T20:26:08.6868194Z Author       : Microsoft
2020-01-31T20:26:08.6868266Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-31T20:26:08.6868325Z ==============================================================================
2020-01-31T20:26:09.1667116Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-31T20:26:09.1714947Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-01-31T20:26:09.1852204Z Cleaning up task key
2020-01-31T20:26:09.1853243Z Start cleaning up orphan processes.
2020-01-31T20:26:09.1991620Z Terminate orphan process: pid (3632) (python)
2020-01-31T20:26:09.2275699Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jyn514

This comment was marked as resolved.

Copy link
Member Author

jyn514 commented Jan 31, 2020

Does anyone know why this is giving an error? It's only in stage 2 I think?

2020-01-31T20:25:18.5690130Z    Compiling alloc v0.0.0 (/checkout/src/liballoc)
2020-01-31T20:25:21.2480774Z error[E0308]: mismatched types
2020-01-31T20:25:21.2481479Z     --> src/liballoc/vec.rs:2399:9
2020-01-31T20:25:21.2481892Z      |
2020-01-31T20:25:21.2482209Z 2398 |     fn from(arr: [T; N]) -> Self {
2020-01-31T20:25:21.2482609Z      |                             ---- expected `vec::Vec<T>` because of return type
2020-01-31T20:25:21.2482957Z 2399 |         <[T]>::into_vec(box arr)
2020-01-31T20:25:21.2483368Z      |         ^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `vec::Vec`, found struct `std::vec::Vec`
2020-01-31T20:25:21.2483955Z      = note: expected struct `vec::Vec<T>`
2020-01-31T20:25:21.2484259Z                 found struct `std::vec::Vec<T>`
@jyn514

This comment has been minimized.

Copy link
Member Author

jyn514 commented Feb 7, 2020

Is there anything I need to change? This has been sitting around for a little while...

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Feb 7, 2020

@withoutboats will need to take a look at this and decide whether to FCP merge it.

I think this is plausibly useful for a generic "takes impl Into<Vec<T>> type API, though mostly only because we lack impl IntoIterator<Item=T> on arrays. If we had that, it would be the "likely better" variant of this, I think, since APIs written to take iterators are much more flexible.

@jyn514

This comment has been minimized.

Copy link
Member Author

jyn514 commented Feb 7, 2020

APIs written to take iterators are much more flexible.

In this case I did need an owned buffer, not just an Iterator. impl IntoIterator for arrays would definitely be useful, it just wouldn't have solved this particular problem: #67963

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Feb 7, 2020

IntoIterator would let you collect into a vector, which in theory should be equally performant if you're starting out with a vector or array etc. Thought that may not be true today.

@jyn514

This comment has been minimized.

Copy link
Member Author

jyn514 commented Feb 24, 2020

@withoutboats do you know when you will get a chance to look at this?

@jyn514 jyn514 mentioned this pull request Mar 7, 2020
@Centril Centril modified the milestones: 1.43, 1.44 Mar 10, 2020
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Mar 10, 2020

Copy link
Member

LukasKalbertodt left a comment

Looks fine to me (apart from the two inline comments) and seems like a useful addition.

src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Show resolved Hide resolved
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 10, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-03-10T23:16:15.0738544Z ========================== Starting Command Output ===========================
2020-03-10T23:16:15.0743677Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/ba6fa79a-18ca-446f-bb7d-1b8e88e4dbeb.sh
2020-03-10T23:16:15.0744207Z 
2020-03-10T23:16:15.0749598Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-10T23:16:15.0770358Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-03-10T23:16:15.0774055Z Task         : Get sources
2020-03-10T23:16:15.0774403Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T23:16:15.0774717Z Version      : 1.0.0
2020-03-10T23:16:15.0774932Z Author       : Microsoft
---
2020-03-10T23:16:16.0619286Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-10T23:16:16.0624218Z ##[command]git config gc.auto 0
2020-03-10T23:16:16.0627657Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-10T23:16:16.0630834Z ##[command]git config --get-all http.proxy
2020-03-10T23:16:16.0637640Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68692/merge:refs/remotes/pull/68692/merge
---
2020-03-10T23:22:35.6959411Z    Compiling serde_json v1.0.40
2020-03-10T23:22:37.3355995Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2020-03-10T23:22:46.9968289Z     Finished release [optimized] target(s) in 1m 18s
2020-03-10T23:22:47.0078440Z tidy check
2020-03-10T23:22:47.9989104Z tidy error: /checkout/src/liballoc/vec.rs: too many lines (3003) (add `// ignore-tidy-filelength` to the file to suppress this error)
2020-03-10T23:22:49.6691518Z Found 489 error codes
2020-03-10T23:22:49.6691839Z Found 0 error codes with no tests
2020-03-10T23:22:49.6692061Z Done!
2020-03-10T23:22:49.6692302Z some tidy checks failed
2020-03-10T23:22:49.6692302Z some tidy checks failed
2020-03-10T23:22:49.6692466Z 
2020-03-10T23:22:49.6692579Z 
2020-03-10T23:22:49.6697696Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-03-10T23:22:49.6698601Z 
2020-03-10T23:22:49.6755551Z 
2020-03-10T23:22:49.6756002Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-03-10T23:22:49.6756418Z Build completed unsuccessfully in 0:01:30
2020-03-10T23:22:49.6756418Z Build completed unsuccessfully in 0:01:30
2020-03-10T23:22:49.6761819Z == clock drift check ==
2020-03-10T23:22:49.6771363Z   local time: Tue Mar 10 23:22:49 UTC 2020
2020-03-10T23:22:49.9651667Z   network time: Tue, 10 Mar 2020 23:22:49 GMT
2020-03-10T23:22:49.9654536Z == end clock drift check ==
2020-03-10T23:22:50.7935838Z 
2020-03-10T23:22:50.8026693Z ##[error]Bash exited with code '1'.
2020-03-10T23:22:50.8042965Z ##[section]Finishing: Run build
2020-03-10T23:22:50.8090972Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-03-10T23:22:50.8096311Z Task         : Get sources
2020-03-10T23:22:50.8096710Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T23:22:50.8097077Z Version      : 1.0.0
2020-03-10T23:22:50.8097354Z Author       : Microsoft
2020-03-10T23:22:50.8097354Z Author       : Microsoft
2020-03-10T23:22:50.8097762Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-10T23:22:50.8098231Z ==============================================================================
2020-03-10T23:22:51.1597397Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-10T23:22:51.1655185Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68692/merge to s
2020-03-10T23:22:51.1765133Z Cleaning up task key
2020-03-10T23:22:51.1766569Z Start cleaning up orphan processes.
2020-03-10T23:22:51.1975749Z Terminate orphan process: pid (4707) (python)
2020-03-10T23:22:51.2147267Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@LukasKalbertodt

This comment has been minimized.

Copy link
Member

LukasKalbertodt commented Mar 11, 2020

Apart from the tidy stuff, this looks good to me. But this is insta-stable and requires an FCP merge. Since I can't start those, reassigning:

r? @withoutboats

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Mar 18, 2020

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Mar 18, 2020

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@TimDiekmann

This comment was marked as resolved.

Copy link
Contributor

TimDiekmann commented Mar 19, 2020

Is this really supposed to be insta-stable?

@sfackler

This comment was marked as resolved.

Copy link
Member

sfackler commented Mar 19, 2020

All trait implementations are always stable.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Mar 19, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Mar 29, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Mar 29, 2020

Moving back to the technical reviewer, r? @LukasKalbertodt @bors r=LukasKalbertodt

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 29, 2020

📌 Commit 3477e67 has been approved by LukasKalbertodt

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 29, 2020

⌛️ Testing commit 3477e67 with merge 398bebc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2020
impl From<[T; N]> for Vec<T>

Closes rust-lang#67963
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Mar 29, 2020

@bors retry

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2020
Rollup of 3 pull requests

Successful merges:

 - rust-lang#68692 (impl From<[T; N]> for Vec<T>)
 - rust-lang#70101 (Add copy bound to atomic & numeric intrinsics)
 - rust-lang#70506 (BTreeMap testing: introduce symbolic constants and use height consistently)

Failed merges:

r? @ghost
@bors bors merged commit c51fcb5 into rust-lang:master Mar 29, 2020
4 of 5 checks passed
4 of 5 checks passed
homu Testing commit 3477e67a92878adae48b975915cb7a5c21026cd4 with merge 398bebc1c6366c5a7835e3b75311140c3db267cd...
Details
pr Build #20200310.81 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@jyn514 jyn514 deleted the jyn514:vec-from-array branch Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.