Rollup of 7 pull requests #68942

Dylan-DPC-zz · 2020-02-08T02:05:00Z

Successful merges:

Remove some unsound specializations #68358 (Remove some unsound specializations)
rustc_codegen_ssa: don't treat inlined variables as debuginfo arguments. #68802 (rustc_codegen_ssa: don't treat inlined variables as debuginfo arguments.)
Fix and test implementation of BTreeMap's first/last_entry, pop_first/last #68834 (Fix and test implementation of BTreeMap's first/last_entry, pop_first/last)
rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables #68881 (rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables)
Pretty-print generic params and where clauses on associated types #68913 (Pretty-print generic params and where clauses on associated types)
Don't use the word "unwrap" to describe "unwrap" methods #68918 (Don't use the word "unwrap" to describe "unwrap" methods)
Make issue references consistent #68929 (Make issue references consistent)

Failed merges:

…p_first, pop_last

…les.

It's tautological, and Rust-specific Jargon. This changes various Option/Result methods to consistently describe unwrapping behavior using the words "return", "contain", "consume". It also renames the closure argument of `Return::unwrap_or_else` to `default` to be consistent with `Option`.

Remove some unsound specializations This removes the unsound and exploitable specializations in the standard library * The `PartialEq` and `Hash` implementations for `RangeInclusive` are changed to avoid specialization. * The `PartialOrd` specialization for slices now specializes on a limited set of concrete types. * Added some tests for the soundness problems.

…ne-arg, r=nagisa rustc_codegen_ssa: don't treat inlined variables as debuginfo arguments. Fixes rust-lang#67586 by limiting `ArgumentVariable` special-casing to `VarDebugInfo` entries that are in `OUTERMOST_SOURCE_SCOPE`, i.e. the function's own argument scope. That excludes `VarDebugInfo` from inlined callees, which can also point to the caller's argument locals. This is a snippet from the optimized MIR (including inlining) of the testcase: ```rust fn foo(_1: usize) -> usize { debug bar => _1; // in scope 0 at ./example.rs:2:12: 2:15 let mut _0: usize; // return place in scope 0 at ./example.rs:2:27: 2:32 scope 1 { debug x => _1; // in scope 1 at /rustc/9ed29b6ff6aa2e048b09c27af8f62ee3040bdb37/src/libcore/convert/mod.rs:106:26: 106:27 } ``` `scope 1` is from inlining the `identity` call, and `debug x => _1;` comes from the body of `core::convert::identity`, so they are now ignored for the purposes of determining the `ArgumentVariable` debuginfo associated to `_1`.

…r=KodrAus Fix and test implementation of BTreeMap's first/last_entry, pop_first/last Properly implement and test `first_entry` & `last_entry` to fix problem report rust-lang#68829

@michaelwoerister

…agisa rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables Making this depend on the optimization level appears to have been a copy-paste mistake (other LLVM functions called in this module also take a `bool` argument, but there it means something unrelated). Also see rust-lang#8855 (comment). I don't believe we have any reason to let LLVM omit user variables from DWARF, and we were already setting this to `true` when LLVM *could* optimize them away, so this PR should have no effect anyway. r? @michaelwoerister or @nagisa cc @rkruppe @nikomatsakis

Pretty-print generic params and where clauses on associated types closes rust-lang#67509

Don't use the word "unwrap" to describe "unwrap" methods It's tautological, and "unwrap" is essentially Rust-specific jargon. I was teaching a newbie some Rust, and doing the usual hand-waving about error handling using unwrap. They asked what 'unwrap' means. I said look it up in the docs. The docs read (paraphrased) "unwrap unwraps". I was embarrassed. This changes all the Option/Result functions with unwrapping behavior to use a variation on a single description: > "Returns the contained `Some/Ok` value [or ...]." It also renames the closure of `Result::unwrap_or_else` to `default` for consistency with `Option`, and perhaps makes a few other small tweaks. Previous: rust-lang#68849

@varkor

…, r=Dylan-DPC Make issue references consistent Fixes rust-lang#62976 cc rust-lang#63008 r? @varkor because you reviewed the original pr

Dylan-DPC-zz · 2020-02-08T02:18:30Z

@bors r+ p=7 rollup=never

bors · 2020-02-08T02:18:31Z

📌 Commit a9a7da7 has been approved by Dylan-DPC

bors · 2020-02-08T02:23:55Z

⌛ Testing commit a9a7da7 with merge 423dac64efb2d57b23e6dd5198bc3784fa84a676...

rust-highfive · 2020-02-08T03:01:22Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-08T02:05:35.8309237Z ========================== Starting Command Output ===========================
2020-02-08T02:05:35.8310391Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/350e9701-d378-434c-bd83-72c4d0e74dd5.sh
2020-02-08T02:05:35.8310418Z 
2020-02-08T02:05:35.8312264Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-08T02:05:35.8364557Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68942/merge to s
2020-02-08T02:05:35.8366914Z Task         : Get sources
2020-02-08T02:05:35.8366942Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-08T02:05:35.8366967Z Version      : 1.0.0
2020-02-08T02:05:35.8366991Z Author       : Microsoft
---
2020-02-08T02:05:36.8460630Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-08T02:05:36.8541540Z ##[command]git config gc.auto 0
2020-02-08T02:05:36.8545410Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-08T02:05:36.8549214Z ##[command]git config --get-all http.proxy
2020-02-08T02:05:36.8557091Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68942/merge:refs/remotes/pull/68942/merge
---
2020-02-08T02:52:16.1917677Z .................................................................................................... 1700/9610
2020-02-08T02:52:20.0798646Z .................................................................................................... 1800/9610
2020-02-08T02:52:29.9542311Z .............................i...................................................................... 1900/9610
2020-02-08T02:52:35.5874580Z .................................................................................................... 2000/9610
2020-02-08T02:52:46.4366311Z ...................iiiii............................................................................ 2100/9610
2020-02-08T02:52:53.8158262Z .................................................................................................... 2300/9610
2020-02-08T02:52:55.5756971Z .................................................................................................... 2400/9610
2020-02-08T02:52:59.2481821Z .................................................................................................... 2500/9610
2020-02-08T02:53:15.3727116Z .................................................................................................... 2600/9610
---
2020-02-08T02:55:16.0749352Z .......................................................................i...............i............ 4900/9610
2020-02-08T02:55:22.0179893Z .................................................................................................... 5000/9610
2020-02-08T02:55:28.2440089Z .................................................................................................... 5100/9610
2020-02-08T02:55:31.8730776Z ..............i..................................................................................... 5200/9610
2020-02-08T02:55:40.6678038Z ........................................................................................ii.ii....... 5300/9610
2020-02-08T02:55:43.6446119Z .i...i.............................................................................................. 5400/9610
2020-02-08T02:55:52.7198236Z .................................................................................................... 5600/9610
2020-02-08T02:55:59.1970898Z ............................................................................i....................... 5700/9610
2020-02-08T02:56:04.9727731Z .................................................................................................... 5800/9610
2020-02-08T02:56:09.8242432Z .................................................................................................... 5900/9610
2020-02-08T02:56:09.8242432Z .................................................................................................... 5900/9610
2020-02-08T02:56:17.4537952Z ....................................................................ii...i..ii............i......... 6000/9610
2020-02-08T02:56:33.8727717Z .................................................................................................... 6200/9610
2020-02-08T02:56:39.5624199Z .................................................................................................... 6300/9610
2020-02-08T02:56:45.5616255Z ................................................................................................i..i 6400/9610
2020-02-08T02:56:58.6903251Z i................................................................................................... 6500/9610
---
2020-02-08T02:58:33.5322950Z .................................................................................................... 7600/9610
2020-02-08T02:58:37.2547814Z .................................................................................................... 7700/9610
2020-02-08T02:58:41.1394916Z .................................................................................................... 7800/9610
2020-02-08T02:58:48.2705607Z .................................................................................................... 7900/9610
2020-02-08T02:58:54.9164459Z ......................................................iiiiiii.i..................................... 8000/9610
2020-02-08T02:59:06.3238158Z .i.................................................................................................. 8200/9610
2020-02-08T02:59:10.6018578Z .................................................................................................... 8300/9610
2020-02-08T02:59:22.3667847Z .................................................................................................... 8400/9610
2020-02-08T02:59:28.8316892Z .................................................................................................... 8500/9610
---
2020-02-08T03:00:59.6945401Z 
2020-02-08T03:00:59.6946281Z ---- [ui] ui/feature-gates/feature-gate-no_sanitize.rs stdout ----
2020-02-08T03:00:59.6946516Z diff of stderr:
2020-02-08T03:00:59.6946621Z 
2020-02-08T03:00:59.6946776Z 4 LL | #[no_sanitize(address)]
2020-02-08T03:00:59.6947000Z 6    |
2020-02-08T03:00:59.6947000Z 6    |
2020-02-08T03:00:59.6947492Z -    = note: for more information, see ***/issues/39699
2020-02-08T03:00:59.6947903Z +    = note: see issue #39699 <***/issues/39699> for more information
2020-02-08T03:00:59.6948248Z 8    = help: add `#![feature(no_sanitize)]` to the crate attributes to enable
2020-02-08T03:00:59.6948493Z 10 error: aborting due to previous error
2020-02-08T03:00:59.6948592Z 
2020-02-08T03:00:59.6948685Z 
2020-02-08T03:00:59.6948797Z The actual stderr differed from the expected stderr.
2020-02-08T03:00:59.6948797Z The actual stderr differed from the expected stderr.
2020-02-08T03:00:59.6949212Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-no_sanitize/feature-gate-no_sanitize.stderr
2020-02-08T03:00:59.6949561Z To update references, rerun the tests and pass the `--bless` flag
2020-02-08T03:00:59.6949947Z To only update this specific test, also pass `--test-args feature-gates/feature-gate-no_sanitize.rs`
2020-02-08T03:00:59.6950196Z error: 1 errors occurred comparing output.
2020-02-08T03:00:59.6950320Z status: exit code: 1
2020-02-08T03:00:59.6950320Z status: exit code: 1
2020-02-08T03:00:59.6951083Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/feature-gates/feature-gate-no_sanitize.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-no_sanitize" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-no_sanitize/auxiliary" "-A" "unused"
2020-02-08T03:00:59.6951654Z ------------------------------------------
2020-02-08T03:00:59.6951783Z 
2020-02-08T03:00:59.6952063Z ------------------------------------------
2020-02-08T03:00:59.6952212Z stderr:
2020-02-08T03:00:59.6952212Z stderr:
2020-02-08T03:00:59.6952494Z ------------------------------------------
2020-02-08T03:00:59.6952667Z error[E0658]: the `#[no_sanitize]` attribute is an experimental feature
2020-02-08T03:00:59.6952996Z   --> /checkout/src/test/ui/feature-gates/feature-gate-no_sanitize.rs:1:1
2020-02-08T03:00:59.6953164Z    |
2020-02-08T03:00:59.6953283Z LL | #[no_sanitize(address)]
2020-02-08T03:00:59.6953506Z    |
2020-02-08T03:00:59.6953506Z    |
2020-02-08T03:00:59.6953892Z    = note: see issue #39699 <***/issues/39699> for more information
2020-02-08T03:00:59.6954061Z    = help: add `#![feature(no_sanitize)]` to the crate attributes to enable
2020-02-08T03:00:59.6954281Z error: aborting due to previous error
2020-02-08T03:00:59.6954401Z 
2020-02-08T03:00:59.6954709Z For more information about this error, try `rustc --explain E0658`.
2020-02-08T03:00:59.6954843Z 
---
2020-02-08T03:00:59.6964258Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-08T03:00:59.6964558Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-08T03:00:59.6973296Z 
2020-02-08T03:00:59.6973456Z 
2020-02-08T03:00:59.6975089Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-08T03:00:59.6975925Z 
2020-02-08T03:00:59.6976052Z 
2020-02-08T03:00:59.6989026Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-08T03:00:59.6989336Z Build completed unsuccessfully in 0:49:41
2020-02-08T03:00:59.6989336Z Build completed unsuccessfully in 0:49:41
2020-02-08T03:00:59.7040834Z == clock drift check ==
2020-02-08T03:00:59.7061701Z   local time: Sat Feb  8 03:00:59 UTC 2020
2020-02-08T03:01:00.2665942Z   network time: Sat, 08 Feb 2020 03:01:00 GMT
2020-02-08T03:01:00.2669524Z == end clock drift check ==
2020-02-08T03:01:00.7297641Z 
2020-02-08T03:01:00.7382258Z ##[error]Bash exited with code '1'.
2020-02-08T03:01:00.7392166Z ##[section]Finishing: Run build
2020-02-08T03:01:00.7411287Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68942/merge to s
2020-02-08T03:01:00.7412767Z Task         : Get sources
2020-02-08T03:01:00.7412819Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-08T03:01:00.7412855Z Version      : 1.0.0
2020-02-08T03:01:00.7412887Z Author       : Microsoft
2020-02-08T03:01:00.7412887Z Author       : Microsoft
2020-02-08T03:01:00.7412939Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-08T03:01:00.7412990Z ==============================================================================
2020-02-08T03:01:01.0930755Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-08T03:01:01.0967051Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68942/merge to s
2020-02-08T03:01:01.1051972Z Cleaning up task key
2020-02-08T03:01:01.1052583Z Start cleaning up orphan processes.
2020-02-08T03:01:01.1136608Z Terminate orphan process: pid (6663) (python)
2020-02-08T03:01:01.1295436Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-02-08T03:30:29Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-08T03:29:18.7598031Z 
2020-02-08T03:29:18.7598951Z ---- [ui] ui/feature-gates/feature-gate-no_sanitize.rs stdout ----
2020-02-08T03:29:18.7599332Z diff of stderr:
2020-02-08T03:29:18.7599489Z 
2020-02-08T03:29:18.7599628Z 4 LL | #[no_sanitize(address)]
2020-02-08T03:29:18.7599909Z 6    |
2020-02-08T03:29:18.7600369Z -    = note: for more information, see https://github.com/rust-lang/rust/issues/39699
2020-02-08T03:29:18.7600824Z +    = note: see issue #39699 <https://github.com/rust-lang/rust/issues/39699> for more information
2020-02-08T03:29:18.7600824Z +    = note: see issue #39699 <https://github.com/rust-lang/rust/issues/39699> for more information
2020-02-08T03:29:18.7601065Z 8    = help: add `#![feature(no_sanitize)]` to the crate attributes to enable
2020-02-08T03:29:18.7601363Z 10 error: aborting due to previous error
2020-02-08T03:29:18.7601492Z 
2020-02-08T03:29:18.7601595Z 
2020-02-08T03:29:18.7601746Z The actual stderr differed from the expected stderr.
2020-02-08T03:29:18.7601746Z The actual stderr differed from the expected stderr.
2020-02-08T03:29:18.7602194Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-no_sanitize/feature-gate-no_sanitize.stderr
2020-02-08T03:29:18.7602892Z To update references, rerun the tests and pass the `--bless` flag
2020-02-08T03:29:18.7603679Z To only update this specific test, also pass `--test-args feature-gates/feature-gate-no_sanitize.rs`
2020-02-08T03:29:18.7604192Z error: 1 errors occurred comparing output.
2020-02-08T03:29:18.7604393Z status: exit code: 1
2020-02-08T03:29:18.7604393Z status: exit code: 1
2020-02-08T03:29:18.7605447Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/feature-gates/feature-gate-no_sanitize.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-no_sanitize" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-no_sanitize/auxiliary" "-A" "unused"
2020-02-08T03:29:18.7606388Z ------------------------------------------
2020-02-08T03:29:18.7606578Z 
2020-02-08T03:29:18.7606911Z ------------------------------------------
2020-02-08T03:29:18.7607114Z stderr:
2020-02-08T03:29:18.7607114Z stderr:
2020-02-08T03:29:18.7607870Z ------------------------------------------
2020-02-08T03:29:18.7608458Z error[E0658]: the `#[no_sanitize]` attribute is an experimental feature
2020-02-08T03:29:18.7609055Z   --> /checkout/src/test/ui/feature-gates/feature-gate-no_sanitize.rs:1:1
2020-02-08T03:29:18.7609298Z    |
2020-02-08T03:29:18.7609541Z LL | #[no_sanitize(address)]
2020-02-08T03:29:18.7609920Z    |
2020-02-08T03:29:18.7610432Z    = note: see issue #39699 <https://github.com/rust-lang/rust/issues/39699> for more information
2020-02-08T03:29:18.7610432Z    = note: see issue #39699 <https://github.com/rust-lang/rust/issues/39699> for more information
2020-02-08T03:29:18.7610716Z    = help: add `#![feature(no_sanitize)]` to the crate attributes to enable
2020-02-08T03:29:18.7611045Z error: aborting due to previous error
2020-02-08T03:29:18.7611519Z 
2020-02-08T03:29:18.7612226Z For more information about this error, try `rustc --explain E0658`.
2020-02-08T03:29:18.7612392Z 
---
2020-02-08T03:29:18.7625143Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-08T03:29:18.7625504Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-08T03:29:18.7638614Z 
2020-02-08T03:29:18.7638782Z 
2020-02-08T03:29:18.7640906Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-08T03:29:18.7642124Z 
2020-02-08T03:29:18.7642239Z 
2020-02-08T03:29:18.7650537Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-08T03:29:18.7650833Z Build completed unsuccessfully in 0:58:29
2020-02-08T03:29:18.7650833Z Build completed unsuccessfully in 0:58:29
2020-02-08T03:29:18.7702297Z == clock drift check ==
2020-02-08T03:29:18.7732293Z   local time: Sat Feb  8 03:29:18 UTC 2020
2020-02-08T03:29:19.0743918Z   network time: Sat, 08 Feb 2020 03:29:19 GMT
2020-02-08T03:29:19.0744949Z == end clock drift check ==
2020-02-08T03:29:19.5637472Z 
2020-02-08T03:29:19.5718709Z ##[error]Bash exited with code '1'.
2020-02-08T03:29:19.5767873Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-08T03:29:19.5769686Z ==============================================================================
2020-02-08T03:29:19.5769759Z Task         : Get sources
2020-02-08T03:29:19.5769842Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-08T03:30:43Z

💔 Test failed - checks-azure

matthewjasper and others added 19 commits February 1, 2020 09:11

Remove some unsound specializations

a81c59f

rustc_codegen_ssa: don't treat inlined variables as debuginfo arguments.

80515f7

Fix and test implementation of BTreeMap's first_entry, last_entry, po…

fa9bfeb

…p_first, pop_last

Reorder declarations of Result::export/unwrap to match Option

c00d8aa

Reorder declarations of Result::expect_err/unwrap_err to match Option

db9b578

rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variab…

b82f6c5

…les.

Make issue references consistent

e97caf8

--bless --compare-mode=nll

2875a0c

print generic bounds on associated types

73936ab

add regression test

ab6ea2b

add hir printing

bf82582

Rollup merge of rust-lang#68834 - ssomers:btree_first_last_fix68829, …

17d7d16

…r=KodrAus Fix and test implementation of BTreeMap's first/last_entry, pop_first/last Properly implement and test `first_entry` & `last_entry` to fix problem report rust-lang#68829

Rollup merge of rust-lang#68913 - Areredify:gat_pretty, r=cramertj

2154137

Pretty-print generic params and where clauses on associated types closes rust-lang#67509

Rollup merge of rust-lang#68929 - matprec:consistent-issue-references…

a9a7da7

…, r=Dylan-DPC Make issue references consistent Fixes rust-lang#62976 cc rust-lang#63008 r? @varkor because you reviewed the original pr

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 8, 2020

Dylan-DPC-zz added the rollup A PR which is a rollup label Feb 8, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2020

Dylan-DPC-zz closed this Feb 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #68942

Rollup of 7 pull requests #68942

Dylan-DPC-zz commented Feb 8, 2020

Dylan-DPC-zz commented Feb 8, 2020

bors commented Feb 8, 2020

bors commented Feb 8, 2020

rust-highfive commented Feb 8, 2020

rust-highfive commented Feb 8, 2020

bors commented Feb 8, 2020

Rollup of 7 pull requests #68942

Rollup of 7 pull requests #68942

Conversation

Dylan-DPC-zz commented Feb 8, 2020

Dylan-DPC-zz commented Feb 8, 2020

bors commented Feb 8, 2020

bors commented Feb 8, 2020

rust-highfive commented Feb 8, 2020

rust-highfive commented Feb 8, 2020

bors commented Feb 8, 2020