Update pulldown-cmark dependency #69164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
update-pulldown-cmark
branch
from
2e32e14
to
26275db
Compare
JohnTitor
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 26275db195d27c9b0933f22910cdc1c25bc7c91e has been approved by |
bors
added
S-waiting-on-bors
euclio
reviewed
Feb 14, 2020
| @@ -65,7 +65,8 @@ warning: could not parse code block as Rust code | |||
| LL | /// code with bad syntax | |||
| | _________^ | |||
| LL | | /// \_ | |||
| | |__________^ | |||
| LL | | /// | |||
| | |_ | |||
There was a problem hiding this comment.
This is a diagnostic regression.
There was a problem hiding this comment.
I'm actually not able to understand the original behavior. The first line is supposed to be the one triggering the error so I don't understand why we had an arrow for the second as well.
There was a problem hiding this comment.
The span is intended to contain the codeblock in the markdown exactly. Here, it includes the first / of the next line of the doc comment.
There was a problem hiding this comment.
Oh I see! Great catch!
|
The span isn't correctly fulfilled. @bors: r- |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
update-pulldown-cmark
branch
from
26275db
to
d8589de
Compare
|
Ok, no more diff with the current tests. Then I guess we can continue? @bors: r=Dylan-DPC |
|
📌 Commit d8589de has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 14, 2020
…k, r=Dylan-DPC Update pulldown-cmark dependency r? @kinnison cc @ollie27 Reopening of rust-lang#65894.
bors
added a commit
that referenced
this pull request
Feb 14, 2020
Rollup of 7 pull requests Successful merges: - #68129 (Correct inference of primitive operand type behind binary operation) - #68475 (Use a `ParamEnvAnd<Predicate>` for caching in `ObligationForest`) - #68856 (typeck: clarify def_bm adjustments & add tests for or-patterns) - #69051 (simplify_try: address some of eddyb's comments) - #69128 (Fix extra subslice lowering) - #69150 (Follow-up to #68848) - #69164 (Update pulldown-cmark dependency) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @kinnison
cc @ollie27
Reopening of #65894.