Add more context to E0599 errors #69255

estebank · 2020-02-18T07:28:49Z

Point at the intermediary unfulfilled trait bounds.

Fix #52523, fix #61661, cc #36513, fix #68131, fix #64417, fix #61768, cc #57457, cc #9082, fix #57994, cc #64934, cc #65149.

rust-highfive · 2020-02-18T07:28:53Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_typeck/check/method/probe.rs

src/librustc_typeck/check/method/suggest.rs

Centril · 2020-02-18T21:40:01Z

src/test/ui/mismatched_types/issue-36053-2.rs

+// ignore-i586-unknown-linux-gnu
+// ignore-i586-unknown-linux-musl
+// ignore-i686-unknown-linux-musl


This seems unfortunate.

At least we're tracking the underlying issue now :o)

estebank · 2020-02-19T02:23:42Z

src/test/ui/associated-const/associated-const-no-item.stderr

 error[E0599]: no associated item named `ID` found for type `i32` in the current scope
  --> $DIR/associated-const-no-item.rs:5:23
   |
+LL | trait Foo {
+   | --------- `Foo` defines an item `ID`
+...
 LL | const X: i32 = <i32>::ID;
   |                       ^^ associated item not found in `i32`
   |
   = help: items from traits can only be used if the trait is implemented and in scope
-   = note: the following trait defines an item `ID`, perhaps you need to implement it:
-           candidate #1: `Foo`


TODO: we should determine whether the implementing trait is in scope. If it isn't, suggest importing it. If it is, check whether the found adt implements it directly but the bounds weren't fulfilled. If not, suggest implementing it.

src/test/ui/unique-object-noncopyable.stderr

estebank · 2020-02-20T00:03:50Z

This PR now accounts for arbitrary self types when reporting E0599, but it doesn't help when the trait definition is not crate local.

The suggestion to constrain type parameters is not as good as I would wish (it should suggest constraining the impl directly), but for newcomers it at least leads them in the right direction (they get hit with a second wave of suggestions that when applied make the code compile).

src/test/ui/associated-const/associated-const-no-item.stderr

src/test/ui/derives/derive-assoc-type-not-impl.stderr

src/test/ui/issues/issue-31173.stderr

src/test/ui/issues/issue-5153.stderr

tmandry · 2020-02-21T00:48:51Z

src/test/ui/suggestions/missing-trait-bounds-for-method-call.stderr

+   | --------- `Bar` defines an item `foo`, perhaps you need to implement it
+...
+LL |         self.foo();
+   |              ^^^ method not found in `&Foo<T>`


I think this should go before both the struct and trait above

@tmandry What do you think of this?

This looks really, really good!

My only critique is that the two notes (one on the span, one outside) are redundant.

In the new commit, this test looks like this now:

It is a very niche case, but with this we handle it well enough, I think.

Great! And I forgot to say again that I think the order of the spans ought to be reversed :)

csmoe · 2020-02-25T09:57:38Z

src/test/ui/suggestions/missing-trait-bounds-for-method-call.stderr

+   = note: the method `foo` exists but the following trait bounds were not satisfied:
+           `T: std::default::Default`
+           which is required by `Fin<T>: Bar`
+help: consider restricting the type parameter to satisfy the obligation


consider rewording obligations to requirements(or a better alternative)? as obligation isn't a common term outside the internal rustc.
ps. a google search result

What about "consider restricting the type parameter to satisfy the trait bound"?

varkor · 2020-02-27T00:35:41Z

src/librustc/traits/mod.rs

@@ -579,6 +579,20 @@ impl<'tcx, N> Vtable<'tcx, N> {
        }
    }

+    pub fn borrow_nested_obligations(&self) -> &[N] {
+        match &self {
+            VtableImpl(i) => &i.nested[..],


Huh, these are unpleasant variant names.

varkor · 2020-02-27T00:42:13Z

@bors r+

bors · 2020-02-27T00:42:15Z

📌 Commit c02e56a has been approved by varkor

Add more context to E0599 errors Point at the intermediary unfulfilled trait bounds. Fix rust-lang#52523, fix rust-lang#61661, cc rust-lang#36513, fix rust-lang#68131, fix rust-lang#64417, fix rust-lang#61768, cc rust-lang#57457, cc rust-lang#9082, fix rust-lang#57994, cc rust-lang#64934, cc rust-lang#65149.

@ghost

Rollup of 8 pull requests Successful merges: - #60826 (Implement new gdb/lldb pretty-printers) - #69255 (Add more context to E0599 errors) - #69379 (Fail on multiple declarations of `main`.) - #69430 (librustc_typeck: remove loop that never actually loops) - #69449 (Do not ping PR reviewers in toolstate breakage) - #69491 (rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages) - #69495 (don't take redundant references to operands) - #69496 (use find(x) instead of filter(x).next()) Failed merges: r? @ghost

Add more context to E0599 errors Point at the intermediary unfulfilled trait bounds. Fix rust-lang#52523, fix rust-lang#61661, cc rust-lang#36513, fix rust-lang#68131, fix rust-lang#64417, fix rust-lang#61768, cc rust-lang#57457, cc rust-lang#9082, fix rust-lang#57994, cc rust-lang#64934, cc rust-lang#65149.

JohnTitor · 2020-02-28T16:06:37Z

Failed in #69543 (comment)
@bors r-

…lity

Get around rust-lang#53081.

estebank · 2020-02-28T20:01:54Z

@bors r=varkor rollup=never

bors · 2020-02-28T20:01:56Z

📌 Commit 2fb35ad has been approved by varkor

Dylan-DPC-zz · 2020-02-29T01:12:58Z

@bors p=1

bors · 2020-02-29T03:53:01Z

⌛ Testing commit 2fb35ad with merge 55aee8d...

bors · 2020-02-29T07:27:22Z

☀️ Test successful - checks-azure
Approved by: varkor
Pushing 55aee8d to master...

jonhoo · 2020-03-03T21:33:27Z

This appears to have caused a regression:
#69629 (comment)

Follow up to rust-lang#69255, fix rust-lang#69629.

Correctly reject `TraitCandidate` in all cases Follow up to #69255, addresses #69629. When `self.select_trait_candidate(trait_ref)` returned `Err(_)`, `result` wasn't being set to `NoMatch`, causing invalid methods to be selected.

rust-highfive assigned varkor Feb 18, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2020

estebank commented Feb 18, 2020

View reviewed changes

src/librustc_typeck/check/method/probe.rs Outdated Show resolved Hide resolved

estebank force-pushed the e0599-details branch from 2a5452b to 9f63be0 Compare February 18, 2020 08:00

Centril reviewed Feb 18, 2020

View reviewed changes

src/librustc_typeck/check/method/probe.rs Outdated Show resolved Hide resolved

Centril reviewed Feb 18, 2020

View reviewed changes

estebank mentioned this pull request Feb 19, 2020

"note: method exists but trait bounds not satisfied" could be better #36513

Closed

2 tasks

estebank commented Feb 19, 2020

View reviewed changes

src/test/ui/unique-object-noncopyable.stderr Show resolved Hide resolved

estebank force-pushed the e0599-details branch from f493699 to c5c78d1 Compare February 20, 2020 00:11

tmandry reviewed Feb 21, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

estebank force-pushed the e0599-details branch from c5c78d1 to 529b891 Compare February 21, 2020 21:40

csmoe reviewed Feb 25, 2020

View reviewed changes

varkor approved these changes Feb 27, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2020

Dylan-DPC-zz mentioned this pull request Feb 27, 2020

Rollup of 8 pull requests #69521

Closed

Dylan-DPC-zz mentioned this pull request Feb 28, 2020

Rollup of 7 pull requests #69543

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 28, 2020

estebank added 11 commits February 28, 2020 11:37

Point at closure definitions

89e96e9

Mention the full path of the implementing trait

0387f0d

Tweak wording

1e7bcc7

Suggest constraining type parameters

392d853

Account for arbitrary self types in E0599

0128640

Review comments: split requirement text to multiple lines for readabi…

7c29441

…lity

keep predicate order and tweak output

c764a82

Reduce verbosity when suggesting restricting type params

a29f691

Reword message

61bc7a3

Do not suggest implementing traits if present in predicates

a9a99df

Ignore output for some platforms with diverging test output

2fb35ad

Get around rust-lang#53081.

estebank force-pushed the e0599-details branch from c02e56a to 2fb35ad Compare February 28, 2020 20:01

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 29, 2020

bors merged commit 55aee8d into rust-lang:master Feb 29, 2020

jonhoo mentioned this pull request Mar 3, 2020

Regression in rustc nightly #69629

Closed

estebank added a commit to estebank/rust that referenced this pull request Mar 4, 2020

Correctly reject TraitCandidate in all cases

8a32729

Follow up to rust-lang#69255, fix rust-lang#69629.

estebank mentioned this pull request Mar 4, 2020

Correctly reject TraitCandidate in all cases #69717

Merged

JohnTitor mentioned this pull request Mar 5, 2020

'rustc' panicked at 'called Option::unwrap() on a None value', src/librustc_typeck/check/method/suggest.rs:550:46 #69725

Closed

SNCPlay42 mentioned this pull request Aug 15, 2020

Unhelpful error message when using bad receiver type #57994

Closed

taqtiqa-mark mentioned this pull request Aug 8, 2021

Nightly (2021): trait bound error for missing use #87857

Open

estebank deleted the e0599-details branch November 9, 2023 05:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more context to E0599 errors #69255

Add more context to E0599 errors #69255

estebank commented Feb 18, 2020 •

edited

Loading

rust-highfive commented Feb 18, 2020

Centril Feb 18, 2020

estebank Feb 18, 2020

estebank Feb 19, 2020

estebank commented Feb 20, 2020

tmandry Feb 21, 2020

estebank Feb 25, 2020

tmandry Feb 25, 2020

estebank Feb 25, 2020

tmandry Feb 26, 2020

This comment has been minimized.

csmoe Feb 25, 2020 •

edited

Loading

estebank Feb 25, 2020

varkor Feb 27, 2020

varkor commented Feb 27, 2020

bors commented Feb 27, 2020

JohnTitor commented Feb 28, 2020

estebank commented Feb 28, 2020

bors commented Feb 28, 2020

Dylan-DPC-zz commented Feb 29, 2020

bors commented Feb 29, 2020

bors commented Feb 29, 2020

jonhoo commented Mar 3, 2020

Add more context to E0599 errors #69255

Add more context to E0599 errors #69255

Conversation

estebank commented Feb 18, 2020 • edited Loading

rust-highfive commented Feb 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

estebank commented Feb 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

csmoe Feb 25, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

varkor commented Feb 27, 2020

bors commented Feb 27, 2020

JohnTitor commented Feb 28, 2020

estebank commented Feb 28, 2020

bors commented Feb 28, 2020

Dylan-DPC-zz commented Feb 29, 2020

bors commented Feb 29, 2020

bors commented Feb 29, 2020

jonhoo commented Mar 3, 2020

estebank commented Feb 18, 2020 •

edited

Loading

csmoe Feb 25, 2020 •

edited

Loading