Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error message clearer about creating new module #69520

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Make error message clearer about creating new module #69520

merged 1 commit into from
Mar 16, 2020

Conversation

kornelski
Copy link
Contributor

This is a partial improvement for #69492

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2020
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-02-27T16:30:30.8869384Z ========================== Starting Command Output ===========================
2020-02-27T16:30:30.8873430Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/facc7d7a-4c9d-4351-a2b9-7322dd38115f.sh
2020-02-27T16:30:30.8874280Z 
2020-02-27T16:30:30.8879664Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-27T16:30:30.8897168Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69520/merge to s
2020-02-27T16:30:30.8900070Z Task         : Get sources
2020-02-27T16:30:30.8900300Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-27T16:30:30.8900571Z Version      : 1.0.0
2020-02-27T16:30:30.8900880Z Author       : Microsoft
---
2020-02-27T16:30:32.1732279Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-27T16:30:32.1738686Z ##[command]git config gc.auto 0
2020-02-27T16:30:32.1742020Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-27T16:30:32.1745101Z ##[command]git config --get-all http.proxy
2020-02-27T16:30:32.1752114Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69520/merge:refs/remotes/pull/69520/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cramertj
Copy link
Member

r=me with travis fixed up.

@kornelski
Copy link
Contributor Author

@cramertj it's ready

@cramertj
Copy link
Member

cramertj commented Mar 4, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2020

📌 Commit 96b3261 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
@JohnTitor
Rollup merge of rust-lang#69520 - kornelski:e69492, r=cramertj
91d521e 
Make error message clearer about creating new module

This is a partial improvement for rust-lang#69492
@JohnTitor JohnTitor mentioned this pull request Mar 5, 2020
Closed
bors added a commit that referenced this pull request Mar 5, 2020
@bors
Auto merge of #69724 - JohnTitor:rollup-vv7w65h, r=JohnTitor
f6c22f0 
Rollup of 10 pull requests

Successful merges:

 - #69520 (Make error message clearer about creating new module)
 - #69589 (ast: `Mac`/`Macro` -> `MacCall`)
 - #69614 (`delay_span_bug` when codegen cannot select obligation)
 - #69641 (Update books)
 - #69674 (Rename DefKind::Method and TraitItemKind::Method )
 - #69697 (Add explanation for E0380)
 - #69698 (Use associated constants of integer types)
 - #69705 (Toolstate: remove redundant beta-week check.)
 - #69711 (Update macros.rs: fix documentation typo.)
 - #69713 (more clippy cleanups)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Mar 5, 2020

⌛ Testing commit 96b3261 with merge 452aa16a0c003085036b35612322d8c188fe56e9...

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors
Copy link
Contributor

bors commented Mar 5, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2020
@JohnTitor
Copy link
Member

Seems spurious.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
@bors
Copy link
Contributor

bors commented Mar 5, 2020

⌛ Testing commit 96b3261 with merge 846b743f0826716f1b90bface26638ac8d3f4095...

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
@JohnTitor
Rollup merge of rust-lang#69520 - kornelski:e69492, r=cramertj
bb126e1 
Make error message clearer about creating new module

This is a partial improvement for rust-lang#69492
@JohnTitor JohnTitor mentioned this pull request Mar 5, 2020
Closed
@JohnTitor
Copy link
Member

@bors retry rolled up

@bors
Copy link
Contributor

bors commented Mar 5, 2020

⌛ Testing commit 96b3261 with merge 1e3ca884da0cdf0cab620bc98f6c85a50d776733...

@JohnTitor
Copy link
Member

Sorry for the noise...
@bors retry rolled up

@JohnTitor
Copy link
Member

Failed in #69730 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2020
@kornelski
Copy link
Contributor Author

I've rebased it on master just in case

@kornelski
Copy link
Contributor Author

Ahh, it needed message for Windows-only test that "bless" has skipped. I've fixed that.

@cramertj
Copy link
Member

cramertj commented Mar 9, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2020

📌 Commit 8de1ec9 has been approved by cramertj

@bors
Copy link
Contributor

bors commented Mar 9, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 16, 2020
Merged
bors added a commit that referenced this pull request Mar 16, 2020
@bors
Auto merge of #70040 - Dylan-DPC:rollup-id1k6lz, r=Dylan-DPC
59f4ba9 
Rollup of 7 pull requests

Successful merges:

 - #67335 (Refactor the `Qualif` trait)
 - #69122 (Backtrace Debug tweaks)
 - #69520 (Make error message clearer about creating new module)
 - #69738 (More Method -> AssocFn renaming)
 - #69867 (Add long error explanation for E0628 )
 - #69989 (resolve/hygiene: `macro_rules` are not "legacy")
 - #70036 (Make article_and_description primarily use def_kind)

Failed merges:

r? @ghost
@bors bors merged commit 1685264 into rust-lang:master Mar 16, 2020
@kornelski kornelski deleted the e69492 branch March 16, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kornelski @rust-highfive @cramertj @bors @JohnTitor