Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long error explanation for E0628 #69867

Merged

Conversation

@ayushmishra2005
Copy link
Contributor

ayushmishra2005 commented Mar 9, 2020

Add long explanation for the E0628 error code
Part of #61137

r? @GuillaumeGomez

@ayushmishra2005

This comment has been minimized.

Copy link
Contributor Author

ayushmishra2005 commented Mar 10, 2020

@ayushmishra2005

This comment has been minimized.

Copy link
Contributor Author

ayushmishra2005 commented Mar 11, 2020

@rust-highfive rust-highfive assigned Dylan-DPC and unassigned davidtwco Mar 11, 2020
src/librustc_error_codes/error_codes/E0628.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0628.md Outdated Show resolved Hide resolved
ayushmishra2005 and others added 4 commits Mar 13, 2020
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
Ayush Kumar Mishra
Ayush Kumar Mishra
@ayushmishra2005 ayushmishra2005 requested a review from Dylan-DPC Mar 13, 2020
@ayushmishra2005

This comment has been minimized.

Copy link
Contributor Author

ayushmishra2005 commented Mar 14, 2020

Hi @Dylan-DPC I have addressed all PR comments. Could you please review the changes? Thanks in advance.

@Dylan-DPC

This comment has been minimized.

Copy link
Member

Dylan-DPC commented Mar 14, 2020

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 14, 2020

📌 Commit c33c88b has been approved by Dylan-DPC

@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 14, 2020
41 of 126 tasks complete
bors added a commit that referenced this pull request Mar 16, 2020
Rollup of 7 pull requests

Successful merges:

 - #67335 (Refactor the `Qualif` trait)
 - #69122 (Backtrace Debug tweaks)
 - #69520 (Make error message clearer about creating new module)
 - #69738 (More Method -> AssocFn renaming)
 - #69867 (Add long error explanation for E0628 )
 - #69989 (resolve/hygiene: `macro_rules` are not "legacy")
 - #70036 (Make article_and_description primarily use def_kind)

Failed merges:

r? @ghost
@bors bors merged commit 8f2482b into rust-lang:master Mar 16, 2020
4 checks passed
4 checks passed
pr Build #20200313.22 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.