Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tidy check to mingw-check #69688

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Move tidy check to mingw-check #69688

merged 1 commit into from
Mar 17, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Mar 4, 2020 •
edited
Loading

Fixes #69613

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2020
@Mark-Simulacrum
Copy link
Member

I think once the fixes are made this should be able to land. Thanks for the PR!

@JohnTitor JohnTitor changed the title Move tidy check to mingw-check Run tidy check later Mar 5, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Mar 5, 2020

📌 Commit 15550f91e59ba1fb7f6fb11bf529a1d86058a6e4 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
@petrochenkov
Copy link
Contributor

Does this really address #69613?

The point of #69613 as I understand it is reporting both tidy errors and other errors after a single push to GitHub.

Here it still requires two pushes to see e.g. two errors (one substantial and one in formatting), except that now tidy runs last, which is awful because you have to wait 2 hours to see the errors (run, see and fix substantial, run, see tidy) instead of 1.1 hours (quick run, see and fix tidy, run, see substantial).

@Mark-Simulacrum
Copy link
Member

You will see tidy errors within 10-15 minutes on the mingw-check builder... except the change to the mingw-check builder was lost for some reason? @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2020
@JohnTitor JohnTitor changed the title Run tidy check later Move tidy check to mingw-check Mar 5, 2020
@JohnTitor
Copy link
Member Author

@Mark-Simulacrum Ah, I misunderstood your thought, revived the check.

@Mark-Simulacrum
Copy link
Member

I'm not sure if x.py check first strikes quite the right balance, but we can adjust ordering later too. I think the check builder latency is really low, so I'm not too worried.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2020

📌 Commit d6a17b5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 17, 2020
@Centril
Rollup merge of rust-lang#69688 - JohnTitor:move-tidy, r=Mark-Simulacrum
2b7c6a3 
Move tidy check to mingw-check

Fixes rust-lang#69613
@Centril Centril mentioned this pull request Mar 17, 2020
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 17, 2020
@Centril
Rollup merge of rust-lang#69688 - JohnTitor:move-tidy, r=Mark-Simulacrum
3e8c948 
Move tidy check to mingw-check

Fixes rust-lang#69613
@Centril Centril mentioned this pull request Mar 17, 2020
Closed
@Centril Centril mentioned this pull request Mar 17, 2020
Merged
bors added a commit that referenced this pull request Mar 17, 2020
@bors
Auto merge of #70072 - Centril:rollup-722hooh, r=Centril
660326e 
Rollup of 7 pull requests

Successful merges:

 - #68746 (Make macro metavars respect (non-)hygiene)
 - #69688 (Move tidy check to mingw-check)
 - #69735 (bootstrap: Use hash to determine if sanitizers needs to be rebuilt)
 - #69922 (implement zeroed and uninitialized with MaybeUninit)
 - #69956 (Ensure HAS_FREE_LOCAL_NAMES is set for ReFree)
 - #70061 (Cosmetic fixes in documentation)
 - #70064 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit 91426e9 into rust-lang:master Mar 17, 2020
@JohnTitor JohnTitor deleted the move-tidy branch March 17, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@tesuji tesuji tesuji left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: don't block further CI results on tidy/fmt
5 participants
@JohnTitor @Mark-Simulacrum @bors @petrochenkov @tesuji