cargotest: remove webrender #70626
Merged
cargotest: remove webrender #70626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current webrender commit occasionally fails without a reason, and the latest webrender commit is missing a dependency on our Windows builders. It's not worth installing an extra dependency for cargotest, and the spurious failure makes keeping this test not worth it.
|
Updates src/tools/cargo. cc @ehuss |
rust-highfive
added
the
S-waiting-on-review
|
IMO, r=me, but I thought we were still discussing this in infra? Not sure what we settled on. If that discussion agrees with merging this then I'm happy to merge. (Or if we have no conclusion, then I also think we should merge to fix the spurious failure). |
Centril
approved these changes
Mar 31, 2020
|
@bors r=Mark-Simulacrum Regarding the discussion, we haven't settled on a list of crates yet, so let's merge this to fix the spurious failure. |
|
📌 Commit 0110634 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#70535 (Track the finalizing node in the specialization graph) - rust-lang#70590 (Miri: make backtrace function names and spans match up) - rust-lang#70616 (rustc_target::abi: rename FieldPlacement to FieldsShape.) - rust-lang#70626 (cargotest: remove webrender) - rust-lang#70649 (clean up E0468 explanation) - rust-lang#70662 (compiletest: don't use `std::io::stdout()`, as it bypasses `set_print`.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current webrender commit occasionally fails without a reason, and the latest webrender commit is missing a dependency on our Windows builders. It's not worth installing an extra dependency for cargotest, and the spurious failure makes keeping this test not worth it.
r? @Mark-Simulacrum