Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #71189

Closed
wants to merge 14 commits into from
Closed

Rollup of 4 pull requests #71189

wants to merge 14 commits into from

Commits on Apr 14, 2020

  1. Provide better compiler output when using ? on Option in fn retur… 

    …ning `Result` and vice-versa
    Duddino committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    ce994b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. remove an impossible branch from check_consts

    @RalfJung
    RalfJung committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    c0247c8 View commit details
    Browse the repository at this point in the history

  2. remove rustfmt-induced spurious trailing comma

    @RalfJung
    RalfJung committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    49b745f View commit details
    Browse the repository at this point in the history

  3. Provide better compiler output when using ? on Option in fn retur… 

    …ning `Result` and vice-versa
    Duddino committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    fbc4168 View commit details
    Browse the repository at this point in the history

  4. Fix clippy warnings 

    clippy::{filter_next,single_char_pattern,unit_arg,identity_conversion,nonminimal_bool}
    @matthiaskrgr
    matthiaskrgr committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    139c646 View commit details
    Browse the repository at this point in the history

  5. don't clone types that are copy (clippy::clone_on_copy)

    @matthiaskrgr
    matthiaskrgr committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    3837df2 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Add test for issue-24843

    @JohnTitor
    JohnTitor committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    4154df8 View commit details
    Browse the repository at this point in the history

  2. Add test for issue-28575

    @JohnTitor
    JohnTitor committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    f0f4653 View commit details
    Browse the repository at this point in the history

  3. Add test for issue-54067

    @JohnTitor
    JohnTitor committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    2687894 View commit details
    Browse the repository at this point in the history

  4. Add test for issue-67893

    @JohnTitor
    JohnTitor committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    61ed813 View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#71141 - Duddino:master, r=estebank 

    Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa

Fixes rust-lang#71089
    @Dylan-DPC
    Dylan-DPC committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    398d332 View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#71149 - RalfJung:check-const-call, r=eddyb 

    remove an impossible branch from check_consts

All function calleess are either `FnPtr` or `FnDef`, so we can remove the alternative from check_consts and just make it ICE instead.
    @Dylan-DPC
    Dylan-DPC committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    d81e702 View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#71179 - matthiaskrgr:cl6ppy, r=Dylan-DPC 

    fix more clippy warnings
    @Dylan-DPC
    Dylan-DPC committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    eba8a1b View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#71182 - JohnTitor:regression-tests, r=Mark-… 

    …Simulacrum

Add some regression tests

Closes rust-lang#24843
Closes rust-lang#28575
Closes rust-lang#54067
Closes rust-lang#67893
Closes rust-lang#68813

I'm not sure who's the best person to ask to review since Centril is taking a break now.
    @Dylan-DPC
    Dylan-DPC committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    40df0b9 View commit details
    Browse the repository at this point in the history