Revert #71956 #73153
Merged
Revert #71956 #73153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecstatic-morse
added
the
beta-nominated
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=2 |
|
📌 Commit 452f9f93eb09d8e0ec6d06d89ce16ed034301573 has been approved by |
bors
added
S-waiting-on-bors
jonas-schievink
added
the
T-compiler
ecstatic-morse
force-pushed
the
revert-71956
branch
from
452f9f9
to
c285ab6
Compare
|
Mistake in the test case @bors r=tmandry |
|
📌 Commit c285ab6949bf7e62524f43307f76fb2290cef236 has been approved by |
|
@bors r- |
bors
added
S-waiting-on-author
ecstatic-morse
force-pushed
the
revert-71956
branch
2 times, most recently
from
3802363
to
48358e5
Compare
Co-authored-by: Aaron1011 <aa1ronham@gmail.com>
ecstatic-morse
force-pushed
the
revert-71956
branch
from
48358e5
to
b6121a5
Compare
|
@bors r=tmandry The test is now a bit more robust, and I found the right |
|
📌 Commit b6121a5 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
|
Nominating for @rust-lang/compiler. We need to backport this to beta. |
|
Discussed at today's T-compiler meeting; approved for beta backport. |
pnkfelix
added
the
beta-accepted
Mark-Simulacrum
removed
I-nominated
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2020
…-morse,Mark-Simulacrum [beta] backport This is a beta backport rollup of the following: * [beta] Revert heterogeneous SocketAddr PartialEq impls rust-lang#73318 * Fix emcc failure for wasm32. rust-lang#73213 * Revert rust-lang#71956 rust-lang#73153 * [beta] Update cargo rust-lang#73141 * Minor: off-by-one error in RELEASES.md rust-lang#72914 * normalize adt fields during structural match checking rust-lang#72897 * Revert pr 71840 rust-lang#72989 * rust-lang/cargo#8361 * e658200 from rust-lang#72901 r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #71956 since it caused unsoundness in #73137. Also adds a reduced version of #73137 to the test suite. The addition of the
MaybeInitializedLocalsdataflow analysis has not been reverted, but it is no longer used.Presumably there is a more targeted fix, but I'm worried that other bugs may be lurking. I'm not yet sure what the root cause of #73137 is.
This will need to get backported to beta.
r? @tmandry