Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #72901

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Update cargo #72901

merged 2 commits into from
Jun 5, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 2, 2020

9 commits in 9fcb8c1d20c17f51054f7aa4e08ff28d381fe096..40ebd52206e25c7a576ee42c137cc06a745a167a
2020-05-25 16:25:36 +0000 to 2020-06-01 22:35:00 +0000

@ehuss ehuss self-assigned this Jun 2, 2020
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2020
@ehuss
Copy link
Contributor Author

ehuss commented Jun 2, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 2, 2020

📌 Commit 860b381 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2020
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Jun 4, 2020

⌛ Testing commit 860b381 with merge 485518d1222161b0a0ef0bb47c2c028368b07d6d...

@bors
Copy link
Contributor

bors commented Jun 4, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2020
@ehuss
Copy link
Contributor Author

ehuss commented Jun 4, 2020

@Mark-Simulacrum do you have any objection if I enable building lld on the Windows job that tests Cargo? Cargo now has a test for some lld behavior on Windows.

AFAIK, lld builds pretty fast (about 40s on my machine) and with sccache should be even faster. I also believe it is not actually used for anything (unless use-lld is enabled, which I believe it isn't).

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

Should be fine. @bors r+

@bors
Copy link
Contributor

bors commented Jun 4, 2020

📌 Commit e658200 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2020
@bors
Copy link
Contributor

bors commented Jun 4, 2020

⌛ Testing commit e658200 with merge 219380d...

@bors
Copy link
Contributor

bors commented Jun 5, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 219380d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2020
@bors bors merged commit 219380d into rust-lang:master Jun 5, 2020
@ehuss ehuss mentioned this pull request Jun 14, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2020
…-morse,Mark-Simulacrum

[beta] backport

This is a beta backport rollup of the following:
* [beta] Revert heterogeneous SocketAddr PartialEq impls rust-lang#73318
* Fix emcc failure for wasm32. rust-lang#73213
* Revert rust-lang#71956 rust-lang#73153
* [beta] Update cargo rust-lang#73141
* Minor: off-by-one error in RELEASES.md rust-lang#72914
* normalize adt fields during structural match checking rust-lang#72897
* Revert pr 71840 rust-lang#72989
* rust-lang/cargo#8361
* e658200 from rust-lang#72901

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If rev is added to git url cargo gives no warnings and has unexpected behavior
5 participants