-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #73617
Rollup of 6 pull requests #73617
Commits on Jun 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fc60282 - Browse repository at this point
Copy the full SHA fc60282View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4896a06 - Browse repository at this point
Copy the full SHA 4896a06View commit details
Commits on Jun 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 467415d - Browse repository at this point
Copy the full SHA 467415dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a657be4 - Browse repository at this point
Copy the full SHA a657be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 726b6f4 - Browse repository at this point
Copy the full SHA 726b6f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c14d85f - Browse repository at this point
Copy the full SHA c14d85fView commit details -
Prefer accessible paths in 'use' suggestions
This fixes an issue with the following sample: mod foo { mod inaccessible { pub struct X; } pub mod avail { pub struct X; } } fn main() { X; } Instead of suggesting both `use crate::foo::inaccessible::X;` and `use crate::foo::avail::X;`, it should only suggest the latter. It is done by trimming the list of suggestions from inaccessible paths if accessible paths are present. Visibility is checked with `is_accessible_from` now instead of being hard-coded. - Some tests fixes are trivial, and others require a bit more explaining, here are my comments: src/test/ui/issues/issue-35675.stderr: Only needs to make the enum public to have the suggestion make sense. src/test/ui/issues/issue-42944.stderr: Importing the tuple struct won't help because its constructor is not visible, so the attempted constructor does not work. In that case, it's better not to suggest it. The case where the constructor is public is covered in `issue-26545.rs`.
Configuration menu - View commit details
-
Copy full SHA for fea5ab1 - Browse repository at this point
Copy the full SHA fea5ab1View commit details -
Do not send a notification for P-high stable regressions
Add comment to clarify the pattern
Configuration menu - View commit details
-
Copy full SHA for ae71e96 - Browse repository at this point
Copy the full SHA ae71e96View commit details
Commits on Jun 22, 2020
-
Rollup merge of rust-lang#71660 - sollyucko:master, r=dtolnay
impl PartialEq<Vec<B>> for &[A], &mut [A] rust-lang/rfcs#2917
Configuration menu - View commit details
-
Copy full SHA for 8da1dd0 - Browse repository at this point
Copy the full SHA 8da1dd0View commit details -
Rollup merge of rust-lang#72623 - da-x:use-suggest-public-path, r=pet…
…rochenkov Prefer accessible paths in 'use' suggestions This PR addresses issue rust-lang#26454, where `use` suggestions are made for paths that don't work. For example: ```rust mod foo { mod bar { struct X; } } fn main() { X; } // suggests `use foo::bar::X;` ```
Configuration menu - View commit details
-
Copy full SHA for fdd241f - Browse repository at this point
Copy the full SHA fdd241fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d22b80d - Browse repository at this point
Copy the full SHA d22b80dView commit details -
Rollup merge of rust-lang#73580 - RalfJung:deprecate-wrapping-offset-…
…from, r=Amanieu deprecate wrapping_offset_from As per rust-lang#41079 (comment) which seems like a consensus. r? @Amanieu
Configuration menu - View commit details
-
Copy full SHA for 35ecb26 - Browse repository at this point
Copy the full SHA 35ecb26View commit details -
Rollup merge of rust-lang#73582 - RalfJung:miri-span-bug, r=oli-obk
Miri: replace many bug! by span_bug! r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for cb85f4b - Browse repository at this point
Copy the full SHA cb85f4bView commit details -
Rollup merge of rust-lang#73585 - LeSeulArtichaut:patch-3, r=Mark-Sim…
…ulacrum Do not send a notification for P-high stable regressions This is kind of a hack to only match nightly and beta regressions, but not stable regressions. See my tests [on the playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6ff8a809162118aa2951f2ff12400067). r? @spastorino cc @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for c5e6f48 - Browse repository at this point
Copy the full SHA c5e6f48View commit details