Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #73617

Merged
merged 14 commits into from
Jun 22, 2020
Merged

Rollup of 6 pull requests #73617

merged 14 commits into from
Jun 22, 2020

Commits on Jun 20, 2020

  1. Configuration menu
    Copy the full SHA
    fc60282 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4896a06 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. Configuration menu
    Copy the full SHA
    467415d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a657be4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    726b6f4 View commit details
    Browse the repository at this point in the history
  4. Update UI tests

    GuillaumeGomez committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    c14d85f View commit details
    Browse the repository at this point in the history
  5. Prefer accessible paths in 'use' suggestions

    This fixes an issue with the following sample:
    
        mod foo {
    	mod inaccessible {
    	    pub struct X;
    	}
    	pub mod avail {
    	    pub struct X;
    	}
        }
    
        fn main() { X; }
    
    Instead of suggesting both `use crate::foo::inaccessible::X;` and `use
    crate::foo::avail::X;`, it should only suggest the latter.
    
    It is done by trimming the list of suggestions from inaccessible paths
    if accessible paths are present.
    
    Visibility is checked with `is_accessible_from` now instead of being
    hard-coded.
    
    -
    
    Some tests fixes are trivial, and others require a bit more explaining,
    here are my comments:
    
    src/test/ui/issues/issue-35675.stderr: Only needs to make the enum
    public to have the suggestion make sense.
    
    src/test/ui/issues/issue-42944.stderr: Importing the tuple struct won't
    help because its constructor is not visible, so the attempted
    constructor does not work. In that case, it's better not to suggest it.
    The case where the constructor is public is covered in `issue-26545.rs`.
    da-x committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    fea5ab1 View commit details
    Browse the repository at this point in the history
  6. Do not send a notification for P-high stable regressions

    Add comment to clarify the pattern
    LeSeulArtichaut committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    ae71e96 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Rollup merge of rust-lang#71660 - sollyucko:master, r=dtolnay

    impl PartialEq<Vec<B>> for &[A], &mut [A]
    
    rust-lang/rfcs#2917
    Dylan-DPC committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    8da1dd0 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#72623 - da-x:use-suggest-public-path, r=pet…

    …rochenkov
    
    Prefer accessible paths in 'use' suggestions
    
    This PR addresses issue rust-lang#26454, where `use` suggestions are made for paths that don't work. For example:
    
    ```rust
    mod foo {
        mod bar {
            struct X;
        }
    }
    
    fn main() { X; } // suggests `use foo::bar::X;`
    ```
    Dylan-DPC committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    fdd241f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d22b80d View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#73580 - RalfJung:deprecate-wrapping-offset-…

    …from, r=Amanieu
    
    deprecate wrapping_offset_from
    
    As per rust-lang#41079 (comment) which seems like a consensus.
    
    r? @Amanieu
    Dylan-DPC committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    35ecb26 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#73582 - RalfJung:miri-span-bug, r=oli-obk

    Miri: replace many bug! by span_bug!
    
    r? @oli-obk
    Dylan-DPC committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    cb85f4b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73585 - LeSeulArtichaut:patch-3, r=Mark-Sim…

    …ulacrum
    
    Do not send a notification for P-high stable regressions
    
    This is kind of a hack to only match nightly and beta regressions, but not stable regressions. See my tests [on the playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6ff8a809162118aa2951f2ff12400067).
    
    r? @spastorino cc @Mark-Simulacrum
    Dylan-DPC committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    c5e6f48 View commit details
    Browse the repository at this point in the history