Added docs for From<c_int> for ExitStatus

[regexident]

Partially addresses #51430

[rust-highfive]

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

[LukasKalbertodt]

Thanks for the PR!

To be honest, I don't think this particular documentation adds any valuable information. It would be better if you would mention the cost of the conversion (basically free as far as I can see), so that the doc comment has at least more information than the impl header already contains.

[regexident]

Thanks a fair point, @LukasKalbertodt!

I'd argue though that it does add something by hinting at it being a "type-safety" conversion.
Anyway, I tried improving it by adding … by wrapping it without copying.. Is that better?

_{(Technically it is "copying" in the Rust sense, but several other doc comments use "copying" to imply memcpy.)}

[LukasKalbertodt]

Yeah but this "type-safe" thing also kind of bothers me :/ And yes, "copy" is also slightly problematic. Sorry for being so picky! What do you think about this?

Converts a raw c_int into an ExitStatus. The conversion is very cheap.

[regexident]

"Very cheap" is very subjective though, isn't it? Cheap relative to what exactly?
Given that ExitStatus is a newtype the overhead should essentially be zero, no?

So how about something like… ?

Converts a raw c_int into an ExitStatus, at near-zero overhead.

[LukasKalbertodt]

Yeah, true, "very cheap" is not optimal. "near zero overhead" makes one think "overhead over what" though. Mh. I'm probably overthinking this, sorry :D
This should be handled by a professional :P

r? @GuillaumeGomez

[GuillaumeGomez]

For me it's good as is. 😆

Let's merge it then!

@bors: r+ rollup

[bors]

📌 Commit 538f157 has been approved by GuillaumeGomez