Fix RFC-1014 test #75532
Fix RFC-1014 test #75532
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Created in part to test @workingjubilee theory that there is an existing, but undetected issue on wasm32-unknown-emscripten target (although the fixed test does pass for me locally), cc @Lucretiel. |
Do you mean that this first ignore is independent of the |
|
It is consequence of the fact that flushing is driven internally rather than For example, "hello world\n" is written to the internal buffer successfully. Maybe saying that return of the error is delayed would be more accurate. |
|
Oh! OH! OHHH! That explains it! That explains why my PR breaks this test, because one of the core design goals is cleaning up the error suppressing behavior of the current |
|
Excellent synthesis! I hope this proves revealing. |
|
Might be worth changing /src/test/ui/rfcs/rfc-1014-2.rs to match. |
|
Updated rfc-1014-2.rs test case as well. |
Use two printlns when testing that writing to a closed stdout does not panic. Otherwise the test is ineffective, since the current implementation silently ignores the error during first println regardless.
Bump minor version of emsdk to 1.38.47 Release Notes: ``` v1.38.47: 10/02/2019 -------------------- - Add support for FETCH API in WASM backend. This doesn't support FETCH in the main thread (`USE_FETCH_WORKER=0` is enforced). rust-lang#9490 - Redefine errno values to be consistent with wasi. This will let us avoid needing to convert the values back and forth as we use more wasi APIs. This is an ABI change, which should not be noticeable from user code unless you use errno defines (like EAGAIN) *and* keep around binaries compiled with an older version that you link against. In that case, you should rebuild them. See rust-lang#9545. - Removed build option `-s ONLY_MY_CODE` as we now have much better solutions for that, like building to a wasm object file or using `STANDALONE_WASM` etc. (see https://github.com/emscripten-core/emscripten/wiki/WebAssembly-Standalone). - Emscripten now supports the config file (.emscripten) being placed in the emscripten directory rather that the current user's home directory. See rust-lang#9543 ``` Motivated by changes to errno values which are currently out of sync with those in libc crate which uses wasi values already. Helps with rust-lang#72808 and rust-lang#75532.
Bump minor version of emsdk to 1.38.47 Release Notes: ``` v1.38.47: 10/02/2019 -------------------- - Add support for FETCH API in WASM backend. This doesn't support FETCH in the main thread (`USE_FETCH_WORKER=0` is enforced). rust-lang#9490 - Redefine errno values to be consistent with wasi. This will let us avoid needing to convert the values back and forth as we use more wasi APIs. This is an ABI change, which should not be noticeable from user code unless you use errno defines (like EAGAIN) *and* keep around binaries compiled with an older version that you link against. In that case, you should rebuild them. See rust-lang#9545. - Removed build option `-s ONLY_MY_CODE` as we now have much better solutions for that, like building to a wasm object file or using `STANDALONE_WASM` etc. (see https://github.com/emscripten-core/emscripten/wiki/WebAssembly-Standalone). - Emscripten now supports the config file (.emscripten) being placed in the emscripten directory rather that the current user's home directory. See rust-lang#9543 ``` Motivated by changes to errno values which are currently out of sync with those in libc crate which uses wasi values already. Helps with rust-lang#72808 and rust-lang#75532.
|
The error number mismatch on the CI was fixed by #75569, and this should be working correctly now. |
|
@bors r=nikomatsakis rollup |
|
📌 Commit fa8d396 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 5 pull requests Successful merges: - rust-lang#75324 (clarify documentation of remove_dir errors) - rust-lang#75532 (Fix RFC-1014 test) - rust-lang#75664 (Update mailmap for mati865) - rust-lang#75727 (Switch to intra-doc links in `core::result`) - rust-lang#75750 (Move to intra doc links for std::thread documentation) Failed merges: r? @ghost
Use two printlns when testing that writing to a closed stdout does not
panic. Otherwise the test is ineffective, since the current implementation
silently ignores the error during first println regardless.