Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #76348

Closed
wants to merge 52 commits into from

Commits on Aug 19, 2020

  1. Configuration menu
    Copy the full SHA
    18ad5a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e5f9d7f View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Configuration menu
    Copy the full SHA
    aa40c02 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. impl Rc::new_cyclic

    mental32 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    f03d0b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. typo

    Co-authored-by: Andrew Hickman <andrew.hickman1@sky.com>
    mental32 and andrewhickman committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    42fb270 View commit details
    Browse the repository at this point in the history
  2. Link vec doc to & reference

    It is not always obvious that people could see the docs for `&`
    especially for beginners, it also helps learnability.
    pickfire committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    bb5e79c View commit details
    Browse the repository at this point in the history
  3. [WIP] Fix intra-doc links on pub re-exports

    This removes the incorrect error, but doesn't show the documentation
    anywhere.
    jyn514 committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    1b19354 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Configuration menu
    Copy the full SHA
    20a6866 View commit details
    Browse the repository at this point in the history
  2. Comment out test for generated docs until rustdoc changes its behavio…

    …r around documenting re-exports
    jyn514 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    e885f00 View commit details
    Browse the repository at this point in the history
  3. Improve tests

    Now this actually tests the links are generated correctly
    jyn514 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    d715015 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    81e85ce View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6b75e3d View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Configuration menu
    Copy the full SHA
    ec0924f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44defae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97974e3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    66b340f View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Configuration menu
    Copy the full SHA
    0f301e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Add missing link in README

    camelid committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8783c62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e29fdb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    89ae59a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d5495e2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    31a7b6e View commit details
    Browse the repository at this point in the history
  6. Remove disambiguators from link text

    Related to rust-lang#65354
    
    - Pass through the replacement text to `markdown.rs`
    - Add some tests
    - Add a state machine that actually replaces the text when parsing Markdown
    jyn514 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9815010 View commit details
    Browse the repository at this point in the history
  7. display_for -> suggestion_for

    jyn514 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9d7e797 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4df6490 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2278c72 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6e43ff5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b61eab5 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Configuration menu
    Copy the full SHA
    85146b9 View commit details
    Browse the repository at this point in the history
  2. Upgrade chalk to 0.21

    jackh726 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    e9ad819 View commit details
    Browse the repository at this point in the history
  3. More chalk work

    jackh726 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    a1c267f View commit details
    Browse the repository at this point in the history
  4. Review comments

    jackh726 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    decffcb View commit details
    Browse the repository at this point in the history
  5. Bless changed test output

    jackh726 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    fafdfaf View commit details
    Browse the repository at this point in the history
  6. Misc cleanup

    - Preserve suffixes when displaying
    - Rename test file to match `intra-link*`
    - Remove unnecessary .clone()s
    - Improve comments and naming
    - Fix more bugs and add tests
    - Escape intra-doc link example in public documentation
    jyn514 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    18c14fd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ed3950b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1ea121c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    03fd825 View commit details
    Browse the repository at this point in the history
  10. Update llvm submodule

    mati865 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    e8fc38d View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#75173 - jackh726:chalk-0.21, r=nikomatsakis

    Upgrade Chalk to 0.21
    
    Two commits here. First commit actually does the upgrade. Second commit has some changes to make more tests in compare-mode=chalk pass.
    
    The `PlaceholdersCollector` and `RegionsSubstitutor` bits are bit a hacky, but only insomuch as `ParamsSubstitutor` is. These won't be needed eventually.
    
    r? @nikomatsakis
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    30ab587 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#75200 - ssomers:btree_valmut, r=Mark-Simula…

    …crum
    
     BTreeMap: introduce marker::ValMut and reserve Mut for unique access
    
    The mutable BTreeMap iterators (apart from `DrainFilter`) are double-ended, meaning they have to rely on a front and a back handle that each represent a reference into the tree. Reserve a type category `marker::ValMut` for them, so that we guarantee that they cannot reach operations on handles with borrow type `marker::Mut`and that these operations can assume unique access to the tree.
    
    Including rust-lang#75195, benchmarks report no genuine change:
    ```
    benchcmp old new --threshold 5
     name                                 old ns/iter  new ns/iter  diff ns/iter   diff %  speedup
     btree::map::iter_100                 3,333        3,023                -310   -9.30%   x 1.10
     btree::map::range_unbounded_vs_iter  36,624       31,569             -5,055  -13.80%   x 1.16
    ```
    
    r? @Mark-Simulacrum
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    d9fe727 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#75584 - RalfJung:union-no-deref, r=matthewj…

    …asper
    
    do not apply DerefMut on union field
    
    This implements the part of [RFC 2514](https://github.com/rust-lang/rfcs/blob/master/text/2514-union-initialization-and-drop.md) about `DerefMut`. Unlike described in the RFC, we only apply this warning specifically when doing `DerefMut` of a `ManuallyDrop` field; that is really the case we are worried about here.
    
    @matthewjasper suggested I patch `convert_place_derefs_to_mutable` and `convert_place_op_to_mutable` for this, but I could not find anything to do in `convert_place_op_to_mutable` and this is sufficient to make the test pass. However, maybe there are some other cases this misses? I have no familiarity with this code.
    
    This is a breaking change *in theory*, if someone used `ManuallyDrop<T>` in a union field and relied on automatic `DerefMut`. But on stable this means `T: Copy`, so the `ManuallyDrop` is rather pointless.
    
    Cc rust-lang#55149
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    fac221a View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#75695 - JohnTitor:regression-test, r=Dylan-DPC

    Add a regression test for issue-72793
    
    Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    0d03027 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#75872 - mati865:pgo-tests, r=petrochenkov

    Enable some of profiler tests on Windows-gnu
    
    CC rust-lang#61266
    
    Because of force-push GitHub didn't let me reopen rust-lang#75184
    
    Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI.
    However we can still test the IR for the proper instrumentation so let's do it.
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    27a571f View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#75888 - GuillaumeGomez:trait-impl-assoc-con…

    …st-doc-alias, r=ollie27
    
    Add check for doc alias on assoc const in trait impl
    
    Fixes rust-lang#73721.
    
    r? @ollie27
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    094ef1a View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#75954 - ArekPiekarz:unstable_book_ffi_track…

    …ing_issues, r=steveklabnik
    
    Unstable Book: add links to tracking issues for FFI features
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    f0985d6 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ccc6444 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#76060 - pickfire:patch-12, r=jyn514

    Link vec doc to & reference
    
    It is not always obvious that people could see the docs for `&`
    especially for beginners, it also helps learnability.
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    c291172 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#76078 - jyn514:no-disambiguator, r=manishearth

    Remove disambiguators from intra doc link text
    
    Closes rust-lang#65354.
    r? @Manishearth
    
    The commits are mostly atomic, but there might be some mix between them here and there. I recommend reading 'refactor ItemLink' and 'refactor RenderedLink' on their own though, lots of churn without any logic changes.
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    4751df5 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#76082 - jyn514:top-level-links, r=ollie27,G…

    …uillaumeGomez
    
    Fix intra-doc links on pub re-exports
    
    Partial fix for rust-lang#76073 - This removes the incorrect error, but doesn't show the documentation anywhere.
    r? @GuillaumeGomez
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    5a4e265 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#76128 - poliorcetics:doc-use-arc-clone, r=K…

    …odrAus
    
    Use Arc::clone and Rc::clone in documentation
    
    This PR replaces uses of `x.clone()` by `Rc::clone(&x)` (or `Arc::clone(&x)`) to better match the documentation for those types.
    
    @rustbot modify labels: T-doc
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    3b112d8 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink

    Add missing link in README
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    2ba25e9 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#76273 - CraftSpider:master, r=matklad

    Move some Vec UI tests into alloc unit tests
    
    A bit of work towards rust-lang#76268, makes a number of the Vec UI tests that are simply running code into unit tests. Ensured that they are being run when testing liballoc locally.
    Dylan-DPC committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    70887f6 View commit details
    Browse the repository at this point in the history