Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build failure of rustfmt #78156

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Fixed build failure of rustfmt #78156

merged 2 commits into from
Oct 22, 2020

Conversation

bishtpawan
Copy link
Contributor

Fixes #78079
r? @eddyb cc @bjorn3

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2020
@bjorn3
Copy link
Member

bjorn3 commented Oct 20, 2020

I am curious why you cc'ed me.

@lcnr
Copy link
Contributor

lcnr commented Oct 20, 2020

requires ./x.py fmt.

r? @lcnr

@rust-highfive rust-highfive assigned lcnr and unassigned eddyb Oct 20, 2020
@lcnr
Copy link
Contributor

lcnr commented Oct 21, 2020

While it would be nice to get an MVCE here, I think it's fine to merge this as is.
@bishtpawan did you test if this is the only ICE when compiling rustfmt? If so, r=me

@bishtpawan
Copy link
Contributor Author

Hi @lcnr, yes I tested it with rustfmt and now everything is compiling successfully. Thanks

@lcnr
Copy link
Contributor

lcnr commented Oct 21, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 21, 2020

📌 Commit 7f58477 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#77420 (Unify const-checking structured errors for `&mut` and `&raw mut`)
 - rust-lang#77554 (Support signed integers and `char` in v0 mangling)
 - rust-lang#77976 (Mark inout asm! operands as used in liveness pass)
 - rust-lang#78009 (Haiku: explicitly set CMAKE_SYSTEM_NAME when cross-compiling)
 - rust-lang#78084 (Greatly improve display for small mobile devices screens)
 - rust-lang#78155 (Fix two small issues in compiler/rustc_lint/src/types.rs)
 - rust-lang#78156 (Fixed build failure of `rustfmt`)
 - rust-lang#78172 (Add test case for rust-lang#77062)
 - rust-lang#78188 (Add tracking issue number for pin_static_ref)
 - rust-lang#78200 (Add `ControlFlow::is_{break,continue}` methods)

Failed merges:

r? `@ghost`
@bors bors merged commit 513550c into rust-lang:master Oct 22, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustfmt no longer builds after rust-lang/rust#77306
7 participants